[ANNOUNCE] wayland-protocols

2015-11-16 Thread Jonas Ådahl
Hi, With this E-mail I'd like to officially announce the new repository for Wayland protocols and protocol development: wayland-protocols. The repository can be cloned using git clone git://anongit.freedesktop.org/wayland/wayland-protocols and be viewed using a web browser by going to http

RE: [PATCH weston] Fix runtime error caused by missing header inclusion

2015-11-16 Thread Joh, Yong-Il (Tolkien)
Hi Daniel. here it is. :-) thank you. __ Yong-iL Joh, Sr.MTS, Wind River  -Original Message- From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Monday, November 16, 2015 7:20 PM To: Joh, Yong-Il (Tolkien) Cc: wayland-devel@lists.freedesktop.org Subject: Re: [PATCH weston] Fix runt

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Peter Hutterer
On Mon, Nov 16, 2015 at 12:02:14PM +, Auke Booij wrote: > On 28 October 2015 at 05:34, Peter Hutterer wrote: > > The frame event groups separate pointer events together. The primary > > use-case > > for this at the moment is diagonal scrolling - a vertical/horizontal scroll > > event can be g

[PATCH v2 wayland 3/3] doc: generate doxygen html output from the scanner

2015-11-16 Thread Peter Hutterer
This switches the scanner to generate doxygen-compatible tags for the generated protocol headers, and hooks up the doxygen build to generate server and client-side API documentation. Each protocol is a separate doxygen @page, with each interface a @subpage. Wayland only has one protocol, wayland-p

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Peter Hutterer
Hi Daniel, Thanks for the review. I'll reply to a few select pieces, anything skipped is something I'll just fold into the next diff. On Mon, Nov 16, 2015 at 11:21:36AM +, Daniel Stone wrote: > Peter, Stephen, > > On 6 November 2015 at 04:24, Peter Hutterer wrote: > > This is the revamped

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Peter Hutterer
On Mon, Nov 16, 2015 at 12:07:12PM +, Daniel Stone wrote: > Hi Jonas, > > On 16 November 2015 at 11:59, Jonas Ådahl wrote: > > On Mon, Nov 16, 2015 at 11:21:36AM +, Daniel Stone wrote: > >> On 6 November 2015 at 04:24, Peter Hutterer > >> wrote: > >> > +More than one tablet may exis

Re: [PATCH v6 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Bryce Harrington
On Mon, Nov 16, 2015 at 10:57:24AM +1000, Peter Hutterer wrote: > The frame event groups separate pointer events together. The primary use-case > for this at the moment is diagonal scrolling - a vertical/horizontal scroll > event can be grouped together to calculate the correct motion vector. > Fra

Re: [PATCH weston v2 1/5] compositor-wayland: Change focus to a bool instead of an int

2015-11-16 Thread Bryce Harrington
On Fri, Nov 06, 2015 at 03:56:06PM -0600, Derek Foreman wrote: > Also rename focus to has_focus to be slightly less confusing. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington Pushed: remote: I: patch #64087 updated using rev 4bcc54d1a56057293d3a7a34e9592707406a6c9a remote: I: 1

Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Bryce Harrington
On Mon, Nov 16, 2015 at 02:01:20PM -0600, Derek Foreman wrote: > On 16/11/15 04:49 AM, Marek Chalupa wrote: > > On many places in the code we use wl_log + abort or wl_log + assert(0). > > Replace these with one call to wl_abort, so that we don't mix abort(), > > assert(0) and we'll save few lines >

Re: [PATCH wayland 3/3] doc: generate doxygen html output from the scanner

2015-11-16 Thread Bryce Harrington
On Fri, Nov 06, 2015 at 08:02:01AM +1000, Peter Hutterer wrote: > This switches the scanner to generate doxygen-compatible tags for the > generated protocol headers, and hooks up the doxygen build to generate server > and client-side API documentation. > > Each protocol is a separate doxygen @page

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Bill Spitzak
On Mon, Nov 16, 2015 at 11:55 AM, Carlos Garnacho wrote: > It's probably worth pointing out that his concerns are moot, there is > no blinking, or rather, has an easy solution in compositors. > > When a tool physically enters in proximity over a surface, the cursor > should be effectively invisib

Re: [PATCH v2] protocol: Define further the behavior of input on the presence of grabs

2015-11-16 Thread Daniel Stone
On Monday, 16 November 2015, Bill Spitzak wrote: > > Exit events generated by the client's own actions are a huge pain, it > forces clients to look ahead for the enter event to distinguish between the > focus moving to another surface and losing it entirely. This should be > fixed. A few ideas: >

Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Derek Foreman
On 16/11/15 04:49 AM, Marek Chalupa wrote: > On many places in the code we use wl_log + abort or wl_log + assert(0). > Replace these with one call to wl_abort, so that we don't mix abort(), > assert(0) and we'll save few lines > > Signed-off-by: Marek Chalupa Sure, I think this looks cleaner tha

Re: [PATCH wayland 2/3] doc: make the doxygen output dependent on scanner.c

2015-11-16 Thread Bryce Harrington
On Thu, Nov 05, 2015 at 02:21:02PM -0800, Bryce Harrington wrote: > On Fri, Nov 06, 2015 at 08:02:00AM +1000, Peter Hutterer wrote: > > When the scanner changes, we need to rebuild > > > > Signed-off-by: Peter Hutterer > > Reviewed-by: Bryce Harrington Thanks, pushed: remote: I: patch #63925

Re: [PATCH wayland 1/3] scanner: don't print trailing whitespaces

2015-11-16 Thread Bryce Harrington
On Thu, Nov 05, 2015 at 02:20:04PM -0800, Bryce Harrington wrote: > On Fri, Nov 06, 2015 at 08:01:59AM +1000, Peter Hutterer wrote: > > If we're printing a zero-length string, we end up printing " * " and that > > makes anything unhappy that doesn't handle trailing whitespaces. > > > > Signed-off-

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Carlos Garnacho
Hey, On Mon, Nov 16, 2015 at 8:04 PM, Daniel Stone wrote: > Bill, > > On Monday, 16 November 2015, Bill Spitzak wrote: >> >> There is a need to distinguish proximity-out from exit events. It is quite >> possible to move the stylus so that the focus enters another client without >> doing a proxim

Re: [PATCH v2] protocol: Define further the behavior of input on the presence of grabs

2015-11-16 Thread Bill Spitzak
On Thu, Nov 12, 2015 at 4:31 AM, Carlos Garnacho wrote: > The leave events in the respective device interfaces has been further > documented so those can convey the necessary info when input is being > redirected out of their currently focused surface. > > Only wl_touch is missing something seman

Re: [PATCH wayland] event-loop: remove extra header

2015-11-16 Thread Bryce Harrington
On Mon, Nov 16, 2015 at 11:53:36AM +0100, Marek Chalupa wrote: > we don't use assert() anywhere in this file, so remove #include > > Signed-off-by: Marek Chalupa Reviewed-by: Bryce Harrington Thanks, pushed: remote: I: patch #64885 updated using rev 10d5f97706f6228b607daebb90166752beb8fc77 r

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Daniel Stone
Hi, On Monday, 16 November 2015, Bill Spitzak wrote: > > Since the "frame" event groups everything together, it does not seem like > there is a need to talk about "latching". _descrete events are "latching" > in that they are in the same frame. This could remove some complexity from > your descri

Re: [PATCH wayland] add wl_abort private function

2015-11-16 Thread Bill Spitzak
This sure looks correct to me. Using assert(0) seems like it was a mistake, as it would not happen if NDEBUG was defined but it appears the code is relying on it. And since it was already doing a call to wl_log no overhead was reduced by the removal. On Mon, Nov 16, 2015 at 2:49 AM, Marek Chalup

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Daniel Stone
Bill, On Monday, 16 November 2015, Bill Spitzak wrote: > There is a need to distinguish proximity-out from exit events. It is quite > possible to move the stylus so that the focus enters another client without > doing a proximity-out. Clients are interested in distinguishing these. > This is tr

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Bill Spitzak
On Mon, Nov 16, 2015 at 4:02 AM, Auke Booij wrote: > > > We can't extend the existing wl_pointer.axis events so we introduce a new > > concept: latching events. These events (currently only axis_discrete) > > are prefixed before a wl_pointer.axis event. A client must build the full > > state of t

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Bill Spitzak
There is a need to distinguish proximity-out from exit events. It is quite possible to move the stylus so that the focus enters another client without doing a proximity-out. Clients are interested in distinguishing these. I really feel the best method is to say a "seat" has a keyboard focus and a

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Daniel Stone
Hi, On 16 November 2015 at 13:27, Carlos Garnacho wrote: > On Mon, Nov 16, 2015 at 12:21 PM, Daniel Stone wrote: >> Can we please enforce a strict bracketing of down/up occurring in >> matched pairs inside of proximity_in/out? So, the total event stream >> would be: >> - proximity_in >> -

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Carlos Garnacho
Hey :), On Mon, Nov 16, 2015 at 12:21 PM, Daniel Stone wrote: > Peter, Stephen, > > On 6 November 2015 at 04:24, Peter Hutterer wrote: >> This is the revamped version of the tablet protocol for graphics tablets >> (e.g. Wacom tablets). Too many changes from the last version (a year ago or >> so)

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Daniel Stone
Hi Jonas, On 16 November 2015 at 11:59, Jonas Ådahl wrote: > On Mon, Nov 16, 2015 at 11:21:36AM +, Daniel Stone wrote: >> On 6 November 2015 at 04:24, Peter Hutterer wrote: >> > +More than one tablet may exist, and device-specifics matter. Tablets >> > are >> > +not represented by a

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Auke Booij
On 28 October 2015 at 05:34, Peter Hutterer wrote: > The frame event groups separate pointer events together. The primary use-case > for this at the moment is diagonal scrolling - a vertical/horizontal scroll > event can be grouped together to calculate the correct motion vector. > Frame events gr

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Jonas Ådahl
On Mon, Nov 16, 2015 at 11:21:36AM +, Daniel Stone wrote: > Peter, Stephen, > > On 6 November 2015 at 04:24, Peter Hutterer wrote: > > This is the revamped version of the tablet protocol for graphics tablets > > (e.g. Wacom tablets). Too many changes from the last version (a year ago or > > s

Re: [PATCH v6 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2015-11-16 Thread Daniel Stone
On 16 November 2015 at 00:57, Peter Hutterer wrote: > The frame event groups separate pointer events together. The primary use-case > for this at the moment is diagonal scrolling - a vertical/horizontal scroll > event can be grouped together to calculate the correct motion vector. > Frame events g

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-16 Thread Daniel Stone
Peter, Stephen, On 6 November 2015 at 04:24, Peter Hutterer wrote: > This is the revamped version of the tablet protocol for graphics tablets > (e.g. Wacom tablets). Too many changes from the last version (a year ago or > so), so I won't detail them, best to look at it with fresh eyes. Thanks a

Re: Changing wl_output.transform type to unsigned?

2015-11-16 Thread Erik De Rijcke
Changing C int to C uint is ok for Java. Java only knows signed ints anyway, I therefore already map C uint to Java int, which is ok as long as no arithmetic is needed. On Mon, Nov 16, 2015 at 11:46 AM, Pekka Paalanen wrote: > On Sun, 15 Nov 2015 22:17:38 +0100 > "Nils Chr. Brause" wrote: > > >

Re: [RFC wayland] protocol: Add wl_surface.buffer_damage

2015-11-16 Thread Pekka Paalanen
On Mon, 16 Nov 2015 10:19:39 + Daniel Stone wrote: > Hi, > > On 14 November 2015 at 07:55, Jason Ekstrand wrote: > > On Nov 13, 2015 10:43 AM, "Derek Foreman" wrote: > >> Interesting problem just occurred to me... I don't think just not > >> mixing damage/buffer_damage within a commit is

[PATCH wayland] event-loop: remove extra header

2015-11-16 Thread Marek Chalupa
we don't use assert() anywhere in this file, so remove #include Signed-off-by: Marek Chalupa --- src/event-loop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index 130c7be..ea27b69 100644 --- a/src/event-loop.c +++ b/src/event-loop.c @@ -36,7 +36,6 @@

[PATCH wayland] add wl_abort private function

2015-11-16 Thread Marek Chalupa
On many places in the code we use wl_log + abort or wl_log + assert(0). Replace these with one call to wl_abort, so that we don't mix abort(), assert(0) and we'll save few lines Signed-off-by: Marek Chalupa --- src/connection.c | 22 +++--- src/wayland-client.c | 12 ---

Changing wl_output.transform type to unsigned?

2015-11-16 Thread Pekka Paalanen
On Sun, 15 Nov 2015 22:17:38 +0100 "Nils Chr. Brause" wrote: > On Sun, Nov 15, 2015 at 9:48 PM, Auke Booij wrote: > > On 9 November 2015 at 18:17, Bill Spitzak wrote: > >> I really do not see the problem with allowing it to be an int argument as > >> long as the enum value 2^31 is not used. Tho

Re: [PATCH weston] Fix runtime error caused by missing header inclusion

2015-11-16 Thread Daniel Stone
Hi Yong-Il, On 14 November 2015 at 06:16, Joh, Yong-Il (Tolkien) wrote: > when I run weston on yocto for qemux86 device, > there is an error with following. > > [08:02:07.897] launching '/usr/lib/weston/weston-ivi-shell-user-interface' > [08:02:08.201] /usr/lib/weston/weston-ivi-shell-user-inter

Re: [RFC wayland] protocol: Add wl_surface.buffer_damage

2015-11-16 Thread Daniel Stone
Hi, On 14 November 2015 at 07:55, Jason Ekstrand wrote: > On Nov 13, 2015 10:43 AM, "Derek Foreman" wrote: >> Interesting problem just occurred to me... I don't think just not >> mixing damage/buffer_damage within a commit is good enough. >> >> What if a client commits faster than the screen re

Re: [PATCH libinput 1/3] tablet: add missing event type checks for tablet events

2015-11-16 Thread Hans de Goede
Hi, On 16-11-15 00:31, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Series looks good to me, and is: Reviewed-by: Hans de Goede Regards, Hans --- src/libinput.c | 49 + 1 file changed, 49 insertions(+) diff --git a/src/libinput