Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-06 Thread Bill Spitzak
Having read this more carefully, the cursor scheme absolutely will not work. The main problem is that the client may want to choose a cursor for a tool based on the location at which it came into proximity. It cannot set this cursor until after it gets the proximity event. If this desired cursor i

Re: [RFC wayland] doc: generate doxygen html output from the scanner

2015-11-06 Thread Peter Hutterer
On 7/11/2015 01:27 , Pekka Paalanen wrote: On Thu, 29 Oct 2015 11:48:01 +1000 Peter Hutterer wrote: This switches the scanner to generate doxygen-compatible tags for the generated protocol headers, and hooks up the doxygen build to generate server and client-side API documentation. For the wa

Re: [PATCH weston 00/13] Add tablet support

2015-11-06 Thread Peter Hutterer
On 7/11/2015 09:13 , Jason Gerecke wrote: On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer wrote: This set adds support for graphics tablets to weston. It's not fully complete, there are a couple of fixmes in it but the patchset is getting a bit unwieldly. And there are some discussions on how t

Re: [PATCH weston 00/13] Add tablet support

2015-11-06 Thread Bill Spitzak
On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer wrote: > > The tablet has a separate cursor. That's a conscious decision since the > focus handling on tablets closer to an absolute touch screen than a mouse, > but unlike touch you usually want a cursor shape to indicate the precise > position. >

Re: [PATCH weston 02/13] tablet: add handling of tablet focus

2015-11-06 Thread Bill Spitzak
I don't think it should be possible for the tablet focus to be different than the pointer focus, so most of this should not be necessary. On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer wrote: > From: Stephen Chandler Paul > > Closely modelled after the pointer focus handling > > Co-authored-by

Re: [PATCH weston 05/13] tablet: handle tablet cursors in the compositor

2015-11-06 Thread Bill Spitzak
This looks like you are having the compositor maintain several cursors per seat, and switching them when different tools are used. That is wrong. The client is responsible for setting the cursor. Any cursor changes by the compositor will only lead to flashing or blinking or other incorrect renderi

Re: [PATCH libinput 6/6] tablet: rename all tool types to LIBINPUT_TOOL_TYPE_*

2015-11-06 Thread Jason Gerecke
On Thu, Nov 5, 2015 at 8:55 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer The weston patches are going to have to be modified to work with this API change, but otherwise... For the series: Reviewed-by: Jason Gerecke Jason --- Now instead of four in the eights place / you’ve got th

Re: [PATCH wayland-protocols] Add the tablet protocol

2015-11-06 Thread Jason Gerecke
On Thu, Nov 5, 2015 at 8:24 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > This is the revamped version of the tablet protocol for graphics tablets > (e.g. Wacom tablets). Too many changes from the last version (a year ago or > so), so I won't detail them, best to look at it wi

Re: [PATCH weston 00/13] Add tablet support

2015-11-06 Thread Jason Gerecke
On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer wrote: > > This set adds support for graphics tablets to weston. It's not fully > complete, there are a couple of fixmes in it but the patchset is getting a > bit unwieldly. And there are some discussions on how to do things anyway. > > Note: This nee

[PATCH weston v2 5/5] compositor-wayland: Add touch support

2015-11-06 Thread Derek Foreman
Adds support for touch devices to the wayland backend. Signed-off-by: Derek Foreman --- Changes from v1: should now properly handle both fullscreen and windowed case now should also now handle touch cancel src/compositor-wayland.c | 160 +++ 1 file ch

[PATCH weston v2 1/5] compositor-wayland: Change focus to a bool instead of an int

2015-11-06 Thread Derek Foreman
Also rename focus to has_focus to be slightly less confusing. Signed-off-by: Derek Foreman --- Changes from v1: rename focus to has_focus src/compositor-wayland.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wa

[PATCH weston v2 2/5] cairo-util: return theme location from frame_touch_down

2015-11-06 Thread Derek Foreman
I'll be using this in a follow up patch that adds touch input to weston's wayland backend. Reviewed-by: Daniel Stone Signed-off-by: Derek Foreman --- Just a re-post to keep the series together shared/cairo-util.h | 2 +- shared/frame.c | 17 + 2 files changed, 10 insertio

[PATCH weston v2 3/5] compositor-wayland: Properly release input resources when caps change

2015-11-06 Thread Derek Foreman
We should use wl_*_release when available instead of destroy, and we should update weston's internal input tracking with weston_seat_releases Signed-off-by: Derek Foreman --- Changes from v1: wl_seat version is now tracked independently for each seat instead of assuming it's the same for every se

[PATCH weston 4/5] input: Add notify_touch_cancel()

2015-11-06 Thread Derek Foreman
We already have notify_touch(), notify_touch_frame(). We need notify_touch_cancel() to implement touch in the weston wayland backend properly. Signed-off-by: Derek Foreman --- src/compositor.h | 3 +++ src/input.c | 9 + 2 files changed, 12 insertions(+) diff --git a/src/composito

Re: [RFC wayland] protocol: Add wl_surface.buffer_damage

2015-11-06 Thread Bill Spitzak
The description for wl_surface.damage should be shortened to a minimal indication that this is for back-compatibility only and that refer to the buffer_damage request. Something like "identical to buffer_damage if the buffer and surface coordinates are equal, otherwise the behaviour is undefined".

Re: [RFC wayland] protocol: Add wl_surface.buffer_damage

2015-11-06 Thread Jasper St. Pierre
To help clear things up, I think we should deprecate the wl_surface.damage request and document that the coordinates are effectively undefined -- for legacy reasons, if you see wl_surface.damage, it should be considered a damage for the entire surface. On Fri, Nov 6, 2015 at 10:55 AM, Derek Forema

[RFC wayland] protocol: Add wl_surface.buffer_damage

2015-11-06 Thread Derek Foreman
wl_surface.damage uses surface local co-ordinates. Buffer scale and buffer transforms came along, and EGL surfaces have no understanding of them. Theoretically, clients pass damage rectangles - in Y-inverted surface co-ordinates) to EGLSwapBuffersWithDamage, and the EGL implementation passed them

Re: [PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

2015-11-06 Thread Bryce Harrington
On Fri, Nov 06, 2015 at 10:24:21AM +0200, Pekka Paalanen wrote: > On Fri, 6 Nov 2015 10:51:09 +0800 > Jonas Ådahl wrote: > > > On Thu, Nov 05, 2015 at 11:46:46AM -0800, Bryce Harrington wrote: > > > On Wed, Nov 04, 2015 at 04:49:50PM +0800, Jonas Ådahl wrote: > > > > Use the fullscreen-shell prot

Re: [PATCH] doc: Use enum argument type to make links in protocol documentation

2015-11-06 Thread Auke Booij
On 6 November 2015 at 16:27, wrote: > From: Bill Spitzak This is good preparation for when we'll get cross-interface enums. Reviewed-by: Auke Booij ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailm

[PATCH] doc: Use enum argument type to make links in protocol documentation

2015-11-06 Thread spitzak
From: Bill Spitzak --- doc/publican/protocol-to-docbook.xsl | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/doc/publican/protocol-to-docbook.xsl b/doc/publican/protocol-to-docbook.xsl index fad207a..532 100644 --- a/doc/publican/protocol-to-do

[PATCH] doc: Use enum argument type to make links in protocol documentation

2015-11-06 Thread spitzak
From: Bill Spitzak Small difference in my version from the one pushed. The argument docs are produced by their own section rather than an if statement, and include the interface name along with the enum name. --- doc/publican/protocol-to-docbook.xsl | 26 +++--- 1 file change

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 14:50:26 + Auke Booij wrote: > On 24 October 2015 at 08:23, Jasper St. Pierre wrote: > > I'm struggling to understand the motivation for this patch. > > > > krh has always said that you need to think of uint and int as two > > entirely separate types -- mixing both in math

Re: [RFC wayland] doc: generate doxygen html output from the scanner

2015-11-06 Thread Pekka Paalanen
On Thu, 29 Oct 2015 11:48:01 +1000 Peter Hutterer wrote: > This switches the scanner to generate doxygen-compatible tags for the > generated protocol headers, and hooks up the doxygen build to generate server > and client-side API documentation. > > For the wayland protocol, this generates a mai

Re: [PATCH weston 00/10] weston wayland-protocols migration

2015-11-06 Thread ahmet acar
November 6 2015 2:32 AM, "Jonas Ådahl" wrote: > More or less. The question is whether it would be Ok to break builds, > and if so how "soon"? > are builds have to breaks? If build systems smarts enought(no needs for so complicated) and its behaivour known clearly both by you upstream devs a

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Nils Chr. Brause
Hi, On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote: > On 6 November 2015 at 13:03, Nils Christopher Brause > wrote: >> The enumeration wl_output.transform is clearly a bitfield. >> The definition of a bitfield is that each bit has a distinct >> meaning. This is clearly the case in the enumerat

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Auke Booij
On 24 October 2015 at 08:23, Jasper St. Pierre wrote: > I'm struggling to understand the motivation for this patch. > > krh has always said that you need to think of uint and int as two > entirely separate types -- mixing both in math will likely screw up. > You can see this in other places -- wid

Re: [PATCH v2 wayland 1/3] shm: Deprecate wl_shm_buffer_create()

2015-11-06 Thread Derek Foreman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/11/15 06:10 AM, Pekka Paalanen wrote: > On Fri, 6 Nov 2015 10:29:56 +0200 Giulio Camuffo > wrote: > >> For the whole series: Reviewed-by: Giulio Camuffo >> >> >> 2015-11-05 21:57 GMT+02:00 Derek Foreman >> : >>> From irc: it creates a wl_buf

Re: [PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Auke Booij
On 6 November 2015 at 13:03, Nils Christopher Brause wrote: > The enumeration wl_output.transform is clearly a bitfield. > The definition of a bitfield is that each bit has a distinct > meaning. This is clearly the case in the enumeration > wl_output.transform: > > - bit 0: rotate by 90 degree > -

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-11-06 Thread Pekka Paalanen
On Sat, 24 Oct 2015 00:23:05 -0700 "Jasper St. Pierre" wrote: > I'm struggling to understand the motivation for this patch. > > krh has always said that you need to think of uint and int as two > entirely separate types -- mixing both in math will likely screw up. > You can see this in other pla

[PATCH] Declare enumeration wl_output.transform as bitfield.

2015-11-06 Thread Nils Christopher Brause
The enumeration wl_output.transform is clearly a bitfield. The definition of a bitfield is that each bit has a distinct meaning. This is clearly the case in the enumeration wl_output.transform: - bit 0: rotate by 90 degree - bit 1: rotate by 180 degree - bit 2: flip around vertical axis Every oth

libinput and scrolling threshold/deadspot

2015-11-06 Thread Mads
Hi! Using xf86-input-libinput 0.15.0 and libinput 1.1.0, are there any way to tweak the size of the scrolling deadspot? That is, how many pixels of movement libinput ignores before starting a scroll event (e.g. two fingers vertical scrolling, how long you have to drag before the scrolling sta

Re: [PATCH wayland 1/3 v2] shm: Deprecate wl_shm_buffer_create()

2015-11-06 Thread Pekka Paalanen
On Fri, 16 Oct 2015 09:19:57 -0500 Derek Foreman wrote: > On 16/10/15 09:04 AM, Giulio Camuffo wrote: > > 2015-10-16 16:46 GMT+03:00 Pekka Paalanen : > >> On Sun, 4 Oct 2015 13:46:03 +0300 > >> Giulio Camuffo wrote: > >> > >>> 2015-06-26 19:34 GMT+03:00 Derek Foreman : > From irc: > i

Re: [PATCH v2 wayland 1/3] shm: Deprecate wl_shm_buffer_create()

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 10:29:56 +0200 Giulio Camuffo wrote: > For the whole series: > Reviewed-by: Giulio Camuffo > > 2015-11-05 21:57 GMT+02:00 Derek Foreman : > > From irc: > > it creates a wl_buffer object in a way that no client can ever > > access the storage. > > > > So, let's replace i

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 09:47:03 +1000 Peter Hutterer wrote: > On Thu, Nov 05, 2015 at 04:58:09PM +0200, Pekka Paalanen wrote: > > On Mon, 19 Oct 2015 11:30:47 +1000 > > Peter Hutterer wrote: > > > > > On Fri, Oct 16, 2015 at 11:42:21AM +0300, Pekka Paalanen wrote: > > > > If the original objection

Re: [PATCH weston] tests: Adding simple waycheck validation tool.

2015-11-06 Thread Pekka Paalanen
On Thu, 5 Nov 2015 12:32:02 -0500 "Jon A. Cruz" wrote: > > > On 11/05/2015 10:17 AM, Pekka Paalanen wrote: > > On Fri, 16 Oct 2015 12:23:47 -0700 > > "Jon A. Cruz" wrote: > > > >> On 10/15/2015 01:51 AM, Pekka Paalanen wrote: > >>> I think it's better to land this stuff in pieces than massage

Re: [PATCH weston 00/10] weston wayland-protocols migration

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 10:39:12 +0800 Jonas Ådahl wrote: > On Thu, Nov 05, 2015 at 12:21:21PM +0200, Pekka Paalanen wrote: > > On Wed, 4 Nov 2015 16:49:49 +0800 > > Jonas Ådahl wrote: > > > > > Hi, > > > > > > This series changes weston to depend on wayland-protocols for the > > > majority of the

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

2015-11-06 Thread Hardening
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

2015-11-06 Thread Hardening
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: [PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

2015-11-06 Thread Jonas Ådahl
On Fri, Nov 06, 2015 at 10:24:21AM +0200, Pekka Paalanen wrote: > On Fri, 6 Nov 2015 10:51:09 +0800 > Jonas Ådahl wrote: > > > On Thu, Nov 05, 2015 at 11:46:46AM -0800, Bryce Harrington wrote: > > > On Wed, Nov 04, 2015 at 04:49:50PM +0800, Jonas Ådahl wrote: > > > > Use the fullscreen-shell prot

Re: [PATCH v2 wayland 1/3] shm: Deprecate wl_shm_buffer_create()

2015-11-06 Thread Giulio Camuffo
For the whole series: Reviewed-by: Giulio Camuffo 2015-11-05 21:57 GMT+02:00 Derek Foreman : > From irc: > it creates a wl_buffer object in a way that no client can ever > access the storage. > > So, let's replace it with return NULL; and mark it with attribute > deprecated in the header. >

Re: [PATCH weston 08/10] desktop-shell: Rename protocol weston_desktop_shell

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 10:53:36 +0800 Jonas Ådahl wrote: > On Thu, Nov 05, 2015 at 04:31:37PM +0200, Pekka Paalanen wrote: > > On Wed, 4 Nov 2015 16:49:57 +0800 > > Jonas Ådahl wrote: > > > > > In the effort of going away from generic names of protocols only > > > relevant for weston, rename the w

Re: [PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

2015-11-06 Thread Pekka Paalanen
On Fri, 6 Nov 2015 10:51:09 +0800 Jonas Ådahl wrote: > On Thu, Nov 05, 2015 at 11:46:46AM -0800, Bryce Harrington wrote: > > On Wed, Nov 04, 2015 at 04:49:50PM +0800, Jonas Ådahl wrote: > > > Use the fullscreen-shell protocol XML from the wayland-protocols > > > installation, and remove the one w