Re: [PATCH wayland v3 2/4] protocol: specify enum and bitfield attributes

2015-10-26 Thread Erik De Rijcke
This is just some small FYI status feedback from the Java bindings, so it doesn't get lost/people know. from irc #wayland: 19:57 < bryce> anyone working on or interested in language bindings, would be great to get your Reviewed-by or even just Acked-by on Auke's enum patchset from today. 19:58 <

[PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-26 Thread Auke Booij
The scanner now checks whether arguments that have an associated have the right type. An argument with an enum attribute must be of type int or uint, and if the with that name has the bitfield attribute set to true, then the argument must be of type uint. Changes since v3: - Remove useless allo

Re: [PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-26 Thread Bryce Harrington
On Mon, Oct 26, 2015 at 06:37:28PM +, Auke Booij wrote: > On 26 October 2015 at 18:07, Bryce Harrington wrote: > > On Sat, Oct 24, 2015 at 12:07:49PM +0100, Auke Booij wrote: > >> The scanner now checks whether arguments that have an associated > >> have the right type. > >> An argument with

Re: [PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-26 Thread Auke Booij
On 26 October 2015 at 18:07, Bryce Harrington wrote: > On Sat, Oct 24, 2015 at 12:07:49PM +0100, Auke Booij wrote: >> The scanner now checks whether arguments that have an associated >> have the right type. >> An argument with an enum attribute must be of type int or uint, >> and if the with tha

Re: [PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-26 Thread Bryce Harrington
On Sat, Oct 24, 2015 at 12:07:49PM +0100, Auke Booij wrote: > The scanner now checks whether arguments that have an associated > have the right type. > An argument with an enum attribute must be of type int or uint, > and if the with that name has the bitfield attribute > set to true, then the ar

Re: [PATCH wayland v3 4/4] doc: output enum and bitfield attributes in the documentation

2015-10-26 Thread Bryce Harrington
On Sat, Oct 24, 2015 at 12:07:50PM +0100, Auke Booij wrote: > Signed-off-by: Auke Booij Reviewed-by: Bryce Harrington > --- > doc/publican/protocol-to-docbook.xsl | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/publican/protocol-to-docbook.xsl > b/doc/publican/protocol-t

Re: [PATCH wayland v3 2/4] protocol: specify enum and bitfield attributes

2015-10-26 Thread Bryce Harrington
On Sat, Oct 24, 2015 at 12:07:48PM +0100, Auke Booij wrote: > Signed-off-by: Auke Booij Reviewed-by: Bryce Harrington > --- > protocol/wayland.xml | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/way

Re: [PATCH wayland v3 1/4] doc: document the enum and bitfield attributes

2015-10-26 Thread Bryce Harrington
On Mon, Oct 26, 2015 at 12:16:31PM +, Auke Booij wrote: > Introduce the enum and bitfield attributes, which allow you to refer to the > enum > you are expecting in an argument, and specify which enums are to be thought of > as bitfields. > > Changes since v3: > - Fix typo ("description" -> "

Re: [PATCH] cosmetic: fix inconsistent code style with header prototypes.

2015-10-26 Thread Bryce Harrington
On Mon, Oct 26, 2015 at 02:51:19PM +0900, Jon A. Cruz wrote: > A few of the header files had function prototypes that were not > following project conventions, sometimes even in the same file. > Corrected these to follow as per wayland-os.h. > > Signed-off-by: Jon A. Cruz Pushed along with your

Re: [PATCH] cosmetic: fix incorrect whitespace.

2015-10-26 Thread Bryce Harrington
On Mon, Oct 26, 2015 at 11:49:18AM +0900, Jon A. Cruz wrote: > Fixed instances where spaces were used instead of tabs. > > Signed-off-by: Jon A. Cruz This patch conflicts with your header style cleanup patch. Looks like that one supercedes this one, so I'll drop this one from the queue. > ---

[PATCH wayland v3 1/4] doc: document the enum and bitfield attributes

2015-10-26 Thread Auke Booij
Introduce the enum and bitfield attributes, which allow you to refer to the enum you are expecting in an argument, and specify which enums are to be thought of as bitfields. Changes since v3: - Fix typo ("description" -> "descriptive") Signed-off-by: Auke Booij Reviewed-by: --- doc/publican/s

Re: [PATCH wayland v3 4/4] doc: output enum and bitfield attributes in the documentation

2015-10-26 Thread Nils Chr. Brause
Hi, On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote: > Signed-off-by: Auke Booij > --- > doc/publican/protocol-to-docbook.xsl | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/publican/protocol-to-docbook.xsl > b/doc/publican/protocol-to-docbook.xsl > index 7b45969..fad20

Re: [PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-26 Thread Nils Chr. Brause
Hi, On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote: > The scanner now checks whether arguments that have an associated > have the right type. > An argument with an enum attribute must be of type int or uint, > and if the with that name has the bitfield attribute > set to true, then the argum

Re: [PATCH wayland v3 2/4] protocol: specify enum and bitfield attributes

2015-10-26 Thread Nils Chr. Brause
Hi, On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote: > Signed-off-by: Auke Booij > --- > protocol/wayland.xml | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 59819e9..9c22d45 10

Re: [PATCH wayland v3 1/4] doc: document the enum and bitfield attributes

2015-10-26 Thread Nils Chr. Brause
Hi, On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote: > Introduce the enum and bitfield attributes, which allow you to refer to the > enum > you are expecting in an argument, and specify which enums are to be thought of > as bitfields. > > Signed-off-by: Auke Booij > --- > doc/publican/source