Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-23 Thread Giulio Camuffo
2015-10-24 1:29 GMT+03:00 Bryce Harrington : > Signed-off-by: Bryce Harrington > --- > src/compositor.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compositor.h b/src/compositor.h > index 6bb6222..4443c72 100644 > --- a/src/compositor.h > +++ b/src/composito

Re: [PATCH weston v3] data-device: Implement DnD actions

2015-10-23 Thread Bryce Harrington
On Wed, Sep 30, 2015 at 10:50:44PM +0200, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the set_actions requests on both wl_data_sourc

[PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-23 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- src/compositor.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index 6bb6222..4443c72 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -619,9 +619,9 @@ enum weston_capability { */ struct

Re: [PATCH weston 0/3] Preps for the new config system for backends (libweston)

2015-10-23 Thread Bryce Harrington
On Sat, Oct 17, 2015 at 07:24:12PM +0300, Giulio Camuffo wrote: > Hi, > these 3 patches are essentially http://patchwork.freedesktop.org/patch/57019/ > split in three, with some docs added and some functions renamed, > (hopefully) addressing Bryce's comments to that patch. > > Giulio Camuffo (3):

Re: [PATCH weston 1/3] compositor: introduce structs to handle backends configuration

2015-10-23 Thread Bryce Harrington
On Mon, Oct 19, 2015 at 05:42:53PM -0700, Bryce Harrington wrote: > On Sat, Oct 17, 2015 at 07:24:13PM +0300, Giulio Camuffo wrote: > > This commit introduces the structs weston_backend_config and > > weston_backend_output_config, to prepare for the new config > > system for the backends. > > --- >

Re: [PATCH weston] zunitc: made name of test fixture parameter explicit.

2015-10-23 Thread Bryce Harrington
On Thu, Oct 22, 2015 at 09:11:12PM -0700, Jon A. Cruz wrote: > Instead of using the implicit name 'data', changed the test > with fixture macro ZUC_TEST_F() to use an additional value > to explicitly set the name to use for test data from the > fixture. > > Signed-off-by: Jon A. Cruz Yeah, this

Re: [PATCH] doc: document the enum and bitfield attributes

2015-10-23 Thread Bryce Harrington
On Thu, Oct 22, 2015 at 05:34:38PM +0100, Auke Booij wrote: > Introduce the enum and bitfield attributes, which allow you to refer to the > enum > you are expecting in an argument, and specify which enums are to be thought of > as bitfields. > > Signed-off-by: Auke Booij Looks good. Reviewed-b

Re: [PATCH weston v2] zunitc: Clarify documentation on return behavior.

2015-10-23 Thread Bryce Harrington
On Thu, Oct 22, 2015 at 01:31:49PM -0700, Bryce Harrington wrote: > On Thu, Oct 22, 2015 at 01:25:54PM -0700, Jon A. Cruz wrote: > > * Clarify documentation on ZUC_ASSERT_* behavior in regards to return > >vs. abort() > > * Added overview section on return behavior. > > * Fixed spelling > > * R

Re: [PATCH weston 1/2] clients: try harder to discard motion after resize

2015-10-23 Thread Bryce Harrington
On Thu, Aug 27, 2015 at 09:23:33PM -0700, Bryce Harrington wrote: > On Wed, Aug 26, 2015 at 05:13:26PM -0500, Derek Foreman wrote: > > If we're going to ignore motion below and to the right when coming > > out of maximize, we should probably also ignore it above and to > > the left. > > > > Signed

Re: [PATCH weston] weston-launch: Remove unused event source

2015-10-23 Thread Bryce Harrington
On Wed, Oct 21, 2015 at 12:39:11PM -0500, Derek Foreman wrote: > vt_source is never added to an event loop in this launcher, but > it's potentially removed. > > Let's just remove the variable entirely. > > Signed-off-by: Derek Foreman Yep, nothing else appears to reference vt_source in this fil