[PATCH weston] zunitc: made name of test fixture parameter explicit.

2015-10-22 Thread Jon A. Cruz
During review of the addition of waycheck, it was pointed out that there could be problems due to ZUC_TEST_F() creating an input parameter with a hidden implicit name. This change addresses that by making the name of the passed in parameter a required third input on the ZUC_TEST_F() macro. Jon A.

[PATCH weston] zunitc: made name of test fixture parameter explicit.

2015-10-22 Thread Jon A. Cruz
Instead of using the implicit name 'data', changed the test with fixture macro ZUC_TEST_F() to use an additional value to explicitly set the name to use for test data from the fixture. Signed-off-by: Jon A. Cruz --- tests/config-parser-test.c| 42 +++

Re: [PATCH v2 0/4] Enum and bitfield XML attributes

2015-10-22 Thread Auke Booij
On 22 October 2015 at 22:51, Nils Chr. Brause wrote: > Hi, > > On Thu, Oct 22, 2015 at 10:18 PM, Bill Spitzak wrote: >> On Wed, Oct 21, 2015 at 5:22 AM, Nils Chr. Brause >> wrote: >>> >>> >>> >> - Support for cross-interface enum referencing (e.g. >>> >> wl_shm_pool::create_buffer::format to wl_

Re: [PATCH v2 0/4] Enum and bitfield XML attributes

2015-10-22 Thread Nils Chr. Brause
Hi, On Thu, Oct 22, 2015 at 10:18 PM, Bill Spitzak wrote: > On Wed, Oct 21, 2015 at 5:22 AM, Nils Chr. Brause > wrote: >> >> >> >> - Support for cross-interface enum referencing (e.g. >> >> wl_shm_pool::create_buffer::format to wl_shm::format, and >> >> wl_surface::set_buffer_transform::transfor

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

2015-10-22 Thread Nils Chr. Brause
Hi, On Thu, Oct 22, 2015 at 2:41 PM, Auke Booij wrote: > On 22 October 2015 at 02:46, Bill Spitzak wrote: >> Sorry if this is a duplicate, I am having trouble with gmail. >> >> On 10/20/2015 12:38 AM, Bryce Harrington wrote: >>> >>> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrot

Re: [PATCH weston v2] zunitc: Clarify documentation on return behavior.

2015-10-22 Thread Bryce Harrington
On Thu, Oct 22, 2015 at 01:25:54PM -0700, Jon A. Cruz wrote: > * Clarify documentation on ZUC_ASSERT_* behavior in regards to return >vs. abort() > * Added overview section on return behavior. > * Fixed spelling > * Removed outdated reference to tap function. > > Changes since v1: > > * Incor

[PATCH weston v2] zunitc: Clarify documentation on return behavior.

2015-10-22 Thread Jon A. Cruz
* Clarify documentation on ZUC_ASSERT_* behavior in regards to return vs. abort() * Added overview section on return behavior. * Fixed spelling * Removed outdated reference to tap function. Changes since v1: * Incorporated grammatical feedback. Signed-off-by: Jon A. Cruz --- tools/zunitc/do

[PATCH weston v2] zunitc documentation feedback

2015-10-22 Thread Jon A. Cruz
This patch addresses some feedback of review from unrelated changes of adding waycheck. Since that review pointed out some lack of clarity in return behavior, it seemed appropriate to address it independent of adding waycheck. Jon A. Cruz (1): zunitc: Clarify documentation on return behavior.

Re: [PATCH v2 0/4] Enum and bitfield XML attributes

2015-10-22 Thread Bill Spitzak
On Wed, Oct 21, 2015 at 5:22 AM, Nils Chr. Brause wrote: > > >> - Support for cross-interface enum referencing (e.g. > >> wl_shm_pool::create_buffer::format to wl_shm::format, and > >> wl_surface::set_buffer_transform::transform to wl_output::transform). > > > > Just to be clear on this, I think

Re: [PATCH v2 3/4] scanner: enforce correct argument type for enums

2015-10-22 Thread Bryce Harrington
On Thu, Oct 22, 2015 at 04:25:45PM +0100, Auke Booij wrote: > On 21 October 2015 at 19:13, Bryce Harrington wrote: > > On Wed, Oct 21, 2015 at 02:23:53PM +0100, Auke Booij wrote: > >> On 20 October 2015 at 08:57, Bryce Harrington > >> wrote: > >> > On Mon, Oct 19, 2015 at 11:21:25PM +0100, Auke

[PATCH] doc: document the enum and bitfield attributes

2015-10-22 Thread Auke Booij
Introduce the enum and bitfield attributes, which allow you to refer to the enum you are expecting in an argument, and specify which enums are to be thought of as bitfields. Signed-off-by: Auke Booij --- doc/publican/sources/Protocol.xml | 41 +-- 1 file chang

[PATCH] protocol: specify enum and bitfield attributes

2015-10-22 Thread Auke Booij
Signed-off-by: Auke Booij --- protocol/wayland.xml | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 59819e9..9c22d45 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -367,7 +

Re: [PATCH v2 3/4] scanner: enforce correct argument type for enums

2015-10-22 Thread Auke Booij
On 21 October 2015 at 19:13, Bryce Harrington wrote: > On Wed, Oct 21, 2015 at 02:23:53PM +0100, Auke Booij wrote: >> On 20 October 2015 at 08:57, Bryce Harrington wrote: >> > On Mon, Oct 19, 2015 at 11:21:25PM +0100, Auke Booij wrote: >> >> Signed-off-by: Auke Booij >> >> --- >> >> src/scanner

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

2015-10-22 Thread Auke Booij
On 22 October 2015 at 02:46, Bill Spitzak wrote: > Sorry if this is a duplicate, I am having trouble with gmail. > > On 10/20/2015 12:38 AM, Bryce Harrington wrote: >> >> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: >>> >>> On Mon, Oct 19, 2015 at 11:21:23PM +0100, Auke Booij