Re: [PATCH weston] zunitc: Clarify documentation on return behavior.

On Wed, Oct 21, 2015 at 04:59:28PM -0700, Jon A. Cruz wrote: > * Clarify documentation on ZUC_ASSERT_* behavior in regards to return > vs. abort() > * Added overview section on return behavior. > * Fixed spelling > * Removed outdated reference to tap function. > > Signed-off-by: Jon A. Cruz Re

Re: [PATCH] Provide damage region for screen recording on Raspberry Pi

On Thu, Oct 22, 2015 at 11:44:49AM +0900, Tomohito Esaki wrote: > From: Shinya Saito > > When trying to do sceen recording using the screenshooter, no screen data > was ever processed because the rpi-renderer never set the previous frames > damage area. > > Update the rpi-renderer to copy the ne

[PATCH] Provide damage region for screen recording on Raspberry Pi

From: Shinya Saito When trying to do sceen recording using the screenshooter, no screen data was ever processed because the rpi-renderer never set the previous frames damage area. Update the rpi-renderer to copy the necessary data. Signed-off-by: Shinya Saito Signed-off-by: Tomohito Esaki ---

Fwd: [PATCH v2 1/4] doc: document the enum and bitfield attributes

Sorry if this is a duplicate, I am having trouble with gmail. On 10/20/2015 12:38 AM, Bryce Harrington wrote: > On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: > >> On Mon, Oct 19, 2015 at 11:21:23PM +0100, Auke Booij wrote: >> >>> Introduce the enum and bitfield attributes, whi

[PATCH weston] zunitc documentation feedback

This patch addresses some feedback of review from unrelated changes of adding waycheck. Since that review pointed out some lack of clarity in return behavior, it seemed appropriate to address it independent of adding waycheck. Jon A. Cruz (1): zunitc: Clarify documentation on return behavior.

[PATCH weston] zunitc: Clarify documentation on return behavior.

* Clarify documentation on ZUC_ASSERT_* behavior in regards to return vs. abort() * Added overview section on return behavior. * Fixed spelling * Removed outdated reference to tap function. Signed-off-by: Jon A. Cruz --- tools/zunitc/doc/zunitc.dox | 80 ++

Re: [PATCH v2 2/4] protocol: specify enum and bitfield attributes

On 21 October 2015 at 18:49, Nils Chr. Brause wrote: > You are missing bitfield="true" for wl_shell_surface::resize and > wl_output::transform. Scanning the weston source code, it seems you would have been right about wl_shell_surface had it not been replaced by xdg_shell_surface. But I am happy

Re: [PATCH v2 3/3] clients: Disable popup shortcut in stacking demo

Looks like this has been NAK'd a couple of times now and the preferred solution is to fix popup initiation from keyboard, so I'm going to remove this patch from patchwork. Sorry, Derek On 06/10/15 04:48 PM, Ben Hummon wrote: > Weston does not allow popup menus initiated by keyboard. Remove the >

Re: [PATCH v2 2/3] clients: Correct drawing glitch in stacking demo

Pushed On 21/10/15 04:57 PM, Derek Foreman wrote: > On 06/10/15 04:48 PM, Ben Hummon wrote: >> Fix a graphics glitch in the stacking demo in which a transient >> window's drop shadow is visibile within the interior of the window. >> >> Signed-off-by: Ben Hummon > > Looks good to me, > > Reviewe

Re: [PATCH v2 2/3] clients: Correct drawing glitch in stacking demo

On 06/10/15 04:48 PM, Ben Hummon wrote: > Fix a graphics glitch in the stacking demo in which a transient > window's drop shadow is visibile within the interior of the window. > > Signed-off-by: Ben Hummon Looks good to me, Reviewed-by: Derek Foreman > --- > clients/stacking.c | 4 > 1

Re: [PATCH weston] build: Add -lrt for programs that use clock_gettime()

Thanks, Pushed. On 04/10/15 08:27 AM, Giulio Camuffo wrote: > 2015-06-29 22:05 GMT+03:00 Derek Foreman : >> glibc requires this prior to 2.17, and we already do it in a few other >> places. >> >> Signed-off-by: Derek Foreman > > Reviewed-by: Giulio Camuffo > >> --- >> Makefile.am | 4 ++-- >>

Re: [PATCH weston] compositor/clients: Protect CLOCK_BOOTTIME with ifdefs

Thanks for the review rebased and pushed On 04/10/15 08:23 AM, Giulio Camuffo wrote: > 2015-06-29 21:20 GMT+03:00 Derek Foreman : >> CLOCK_BOOTTIME is a relatively new* feature that may not actually be >> present everywhere (I'm looking at you wheezy). Since our use of it >> is actually only cos

Re: [PATCH wayland v3] shm: Add shm_buffer ref and shm_pool unref functions

Pushed. On 19/10/15 08:54 PM, Derek Foreman wrote: > Sometimes the compositor wants to make sure a shm pool doesn't disappear > out from under it. > > For example, in Enlightenment, rendering happens in a separate thread > while the main thread can still dispatch events. If a client is destroyed

Re: [PATCH v2 3/4] scanner: enforce correct argument type for enums

On Wed, Oct 21, 2015 at 02:23:53PM +0100, Auke Booij wrote: > On 20 October 2015 at 08:57, Bryce Harrington wrote: > > On Mon, Oct 19, 2015 at 11:21:25PM +0100, Auke Booij wrote: > >> Signed-off-by: Auke Booij > >> --- > >> src/scanner.c | 70 > >> +++

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

On Wed, Oct 21, 2015 at 02:34:48PM +0100, Auke Booij wrote: > On 21 October 2015 at 13:13, Nils Chr. Brause wrote: > > Hi, > > > > On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington > > wrote: > >> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: > >>> On Mon, Oct 19, 2015 at 11:

Re: [PATCH v2 2/4] protocol: specify enum and bitfield attributes

Hi, You are missing bitfield="true" for wl_shell_surface::resize and wl_output::transform. Cheers, Nils On Tue, Oct 20, 2015 at 12:21 AM, Auke Booij wrote: > Signed-off-by: Auke Booij > --- > protocol/wayland.xml | 34 +- > 1 file changed, 17 insertions(+), 17

[PATCH weston] weston-launch: Remove unused event source

vt_source is never added to an event loop in this launcher, but it's potentially removed. Let's just remove the variable entirely. Signed-off-by: Derek Foreman --- src/launcher-weston-launch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/launcher-weston-launch.c b/src/launcher-westo

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

Okay. Reviewed-by On Wed, Oct 21, 2015 at 3:34 PM, Auke Booij wrote: > On 21 October 2015 at 13:13, Nils Chr. Brause wrote: >> Hi, >> >> On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington >> wrote: >>> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: On Mon, Oct 19, 201

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

On 21 October 2015 at 13:13, Nils Chr. Brause wrote: > Hi, > > On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington > wrote: >> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: >>> On Mon, Oct 19, 2015 at 11:21:23PM +0100, Auke Booij wrote: >>> > Introduce the enum and bitfield att

Re: [PATCH v2 3/4] scanner: enforce correct argument type for enums

On 20 October 2015 at 08:57, Bryce Harrington wrote: > On Mon, Oct 19, 2015 at 11:21:25PM +0100, Auke Booij wrote: >> Signed-off-by: Auke Booij >> --- >> src/scanner.c | 70 >> +++ >> 1 file changed, 70 insertions(+) >> >> diff --git a/src

Re: [PATCH v2 0/4] Enum and bitfield XML attributes

Hi, On Tue, Oct 20, 2015 at 10:30 AM, Auke Booij wrote: > On 19 October 2015 at 23:21, Auke Booij wrote: >> There has been plenty of discussion regarding the introduction of new XML >> attributes. This series of patches improves on my earlier attempt to find >> common ground in this. >> >> Majo

Re: [PATCH v2 1/4] doc: document the enum and bitfield attributes

Hi, On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington wrote: > On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote: >> On Mon, Oct 19, 2015 at 11:21:23PM +0100, Auke Booij wrote: >> > Introduce the enum and bitfield attributes, which allow you to refer to >> > the enum >> > you are