Re: [PATCH] weston: release keyboard/touch/pointer objects

2015-10-09 Thread Daniel Stone
On 9 October 2015 at 20:36, Derek Foreman wrote: > On 09/10/15 11:17 AM, David FORT wrote: >> This patch adds the missing calls to release when the seat has capabilities >> changes. It also fixes a missing release of the touch object and a leak with >> old clients. >> >> Signed-off-by: David FORT

Re: [PATCH weston] shell: fix maximizing windows on a secondary output

2015-10-09 Thread Derek Foreman
On 09/10/15 11:17 AM, Marek Chalupa wrote: > commit f814c5dc9 changed get_output_work_area behaviour > which broke the code for positioning maximized window. > The x position was set to 2*output->x instead of to output->x > > fix https://bugs.freedesktop.org/show_bug.cgi?id=92357 > > Signed-off-b

[PATCH wayland] scanner: server-side also emit SINCE macros for requests

2015-10-09 Thread David FORT
Server-side we need to know the versions for destructor requests. Signed-off-by: David FORT --- src/scanner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scanner.c b/src/scanner.c index f456aa5..406ba82 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -1266,6 +1266,7 @@ emit_header(

Re: [PATCH] weston: release keyboard/touch/pointer objects

2015-10-09 Thread Derek Foreman
On 09/10/15 11:17 AM, David FORT wrote: > This patch adds the missing calls to release when the seat has capabilities > changes. It also fixes a missing release of the touch object and a leak with > old clients. > > Signed-off-by: David FORT Looks good to me. Reviewed-by: Derek Foreman > ---

Re: [PATCH weston 2/4] cairo-util: return theme location from frame_touch_down

2015-10-09 Thread Daniel Stone
On 9 October 2015 at 17:28, Derek Foreman wrote: > I'll be using this in a follow up patch that adds touch input to weston's > wayland backend. > > Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone ___ wayland-devel mailing list wayland-devel@lis

Re: [PATCH weston 3/4] compositor-wayland: Properly release input resources when caps change

2015-10-09 Thread Daniel Stone
On 9 October 2015 at 17:28, Derek Foreman wrote: > We should use wl_*_release when available instead of destroy, and we > should update weston's internal input tracking with weston_seat_releases > > Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone _

Re: [PATCH weston 1/4] compositor-wayland: Change focus to a bool instead of an int

2015-10-09 Thread Daniel Stone
Hi, On 9 October 2015 at 17:28, Derek Foreman wrote: > diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c > index 7b11ae4..dbbc1ad 100644 > --- a/src/compositor-wayland.c > +++ b/src/compositor-wayland.c > @@ -177,7 +177,7 @@ struct wayland_input { > enum weston_key_state_up

Re: [PATCH weston 4/4] compositor-wayland: Add touch support

2015-10-09 Thread Daniel Stone
Hi, On 9 October 2015 at 17:28, Derek Foreman wrote: > @@ -1617,6 +1620,137 @@ static const struct wl_keyboard_listener > keyboard_listener = { > }; > > static void > +input_handle_touch_down(void *data, struct wl_touch *wl_touch, > + uint32_t serial, uint32_t time, > +

[PATCH weston 0/4] Add touch support to the wayland backend

2015-10-09 Thread Derek Foreman
Tizen's been carrying around a patch for this, but it only works for full screen unrotated compositors. I've tried to re-write it in a more general way. Also, a little gratuitous clean-up in here too. Derek Foreman (4): compositor-wayland: Change focus to a bool instead of an int cairo-util:

[PATCH weston 2/4] cairo-util: return theme location from frame_touch_down

2015-10-09 Thread Derek Foreman
I'll be using this in a follow up patch that adds touch input to weston's wayland backend. Signed-off-by: Derek Foreman --- shared/cairo-util.h | 2 +- shared/frame.c | 17 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/shared/cairo-util.h b/shared/cairo-

[PATCH weston 1/4] compositor-wayland: Change focus to a bool instead of an int

2015-10-09 Thread Derek Foreman
Signed-off-by: Derek Foreman --- src/compositor-wayland.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 7b11ae4..dbbc1ad 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -177,7 +177

[PATCH weston 4/4] compositor-wayland: Add touch support

2015-10-09 Thread Derek Foreman
Adds support for touch devices to the wayland backend. Signed-off-by: Derek Foreman --- src/compositor-wayland.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index b25f4ea..e4fb4bd 10064

[PATCH weston 3/4] compositor-wayland: Properly release input resources when caps change

2015-10-09 Thread Derek Foreman
We should use wl_*_release when available instead of destroy, and we should update weston's internal input tracking with weston_seat_releases Signed-off-by: Derek Foreman --- src/compositor-wayland.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/composi

[PATCH] weston: release keyboard/touch/pointer objects

2015-10-09 Thread David FORT
This patch adds the missing calls to release when the seat has capabilities changes. It also fixes a missing release of the touch object and a leak with old clients. Signed-off-by: David FORT --- clients/window.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-)

[PATCH weston] shell: fix maximizing windows on a secondary output

2015-10-09 Thread Marek Chalupa
commit f814c5dc9 changed get_output_work_area behaviour which broke the code for positioning maximized window. The x position was set to 2*output->x instead of to output->x fix https://bugs.freedesktop.org/show_bug.cgi?id=92357 Signed-off-by: Marek Chalupa --- desktop-shell/shell.c | 6 ++

Re: State of Wayland protocol development

2015-10-09 Thread Mariusz Ceier
Hi, On 9 October 2015 at 15:36, Jonas Ådahl wrote: > On Fri, Oct 09, 2015 at 02:11:28PM +0100, Daniel Stone wrote: > > Hi, > > > > On 9 October 2015 at 11:15, Jonas Ådahl wrote: > > > On Fri, Oct 09, 2015 at 12:36:54PM +0300, Pekka Paalanen wrote: > > >> On Fri, 9 Oct 2015 14:41:31 +0800 > > >>

Re: [PATCH] input: add new client to resource_list instead of focus_resource_list

2015-10-09 Thread Derek Foreman
On 09/10/15 03:28 AM, Chokshi, Mitul wrote: > When new client registers touch listener, it was added to focus resource list. > At this point if another client "without" touch listener is in focus then > subsequent touch events are sent to new client with another client's resources > causing new cli

Re: State of Wayland protocol development

2015-10-09 Thread Daniel Stone
Hi, On 9 October 2015 at 14:36, Jonas Ådahl wrote: > On Fri, Oct 09, 2015 at 02:11:28PM +0100, Daniel Stone wrote: >> Excellent. One really important thing I think to have would be some >> documentation around the protocol: what are the known open issues / >> missing pieces / pitfalls? What is th

Re: State of Wayland protocol development

2015-10-09 Thread Jonas Ådahl
On Fri, Oct 09, 2015 at 02:11:28PM +0100, Daniel Stone wrote: > Hi, > > On 9 October 2015 at 11:15, Jonas Ådahl wrote: > > On Fri, Oct 09, 2015 at 12:36:54PM +0300, Pekka Paalanen wrote: > >> On Fri, 9 Oct 2015 14:41:31 +0800 > >> Jonas Ådahl wrote: > >> > I implemented one of the brought up ide

Re: State of Wayland protocol development

2015-10-09 Thread Daniel Stone
Hi, On 9 October 2015 at 11:15, Jonas Ådahl wrote: > On Fri, Oct 09, 2015 at 12:36:54PM +0300, Pekka Paalanen wrote: >> On Fri, 9 Oct 2015 14:41:31 +0800 >> Jonas Ådahl wrote: >> > I implemented one of the brought up ideas to see how it'd work. >> > More specifically, I created a repository call

Re: [PATCH wayland] scanner: Generate 'since' macros for requests as well

2015-10-09 Thread Jonas Ådahl
On Fri, Oct 09, 2015 at 01:35:32PM +0100, Daniel Stone wrote: > Hi, > > On 8 October 2015 at 08:00, Hardening wrote: > > Le 08/10/2015 05:10, Jonas Ådahl a écrit : > >> We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for > >> events in the server protocol headers. Lets do the sa

Re: State of Wayland protocol development

2015-10-09 Thread Daniel Stone
Hi, On 8 October 2015 at 21:43, Jasper St. Pierre wrote: > On Thu, Oct 8, 2015 at 12:56 PM, Daniel Stone wrote: >> The issues I had with earlier xdg-shell development mostly centred >> around your frustration with bikeshedding leading to pulling out of >> all discussion and just periodically pus

Re: [PATCH wayland] scanner: Generate 'since' macros for requests as well

2015-10-09 Thread Daniel Stone
Hi, On 8 October 2015 at 08:00, Hardening wrote: > Le 08/10/2015 05:10, Jonas Ådahl a écrit : >> We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for >> events in the server protocol headers. Lets do the same for requests in >> the client protocol headers as well. >> >> Signed-of

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-09 Thread Nils Chr. Brause
Hi, Reviewed-by: Nils Christopher Brause I ran distcheck and it worked. :) Cheers, Nils On Fri, Oct 9, 2015 at 10:01 AM, Auke Booij wrote: > Yeah, that was a pretty embarrassing mistake by me, for such a simple > patch. Thanks to Bryce for catching it. > > On 8 October 2015 at 15:05, Pekka P

Re: Enums, bitfields and wl_arrays

2015-10-09 Thread Nils Chr. Brause
Hi, On Thu, Oct 8, 2015 at 10:13 PM, Daniel Stone wrote: > Hi, > > On 5 October 2015 at 21:31, Victor Berger wrote: >> Le 2015-10-05 21:53, Nils Chr. Brause a écrit : >>> Since a language binding should support unknown values anyway, I don't >>> quite >>> see the benefit of an 'open' flag. >> >>

Re: State of Wayland protocol development

2015-10-09 Thread Jonas Ådahl
On Fri, Oct 09, 2015 at 12:36:54PM +0300, Pekka Paalanen wrote: > On Fri, 9 Oct 2015 14:41:31 +0800 > Jonas Ådahl wrote: > > > Hi again, > > > > I implemented one of the brought up ideas to see how it'd work. > > More specifically, I created a repository called "wayland-protocols"[0] > > and ada

Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

2015-10-09 Thread Jonas Ådahl
On Fri, Oct 09, 2015 at 12:50:24PM +0300, Pekka Paalanen wrote: > On Fri, 9 Oct 2015 16:42:04 +0800 > Jonas Ådahl wrote: > > > On Thu, Oct 08, 2015 at 04:29:03PM +0300, Pekka Paalanen wrote: > > > On Fri, 2 Oct 2015 17:32:59 +0800 > > > Jonas Ådahl wrote: > > > > > > > Instead of doing things

Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

2015-10-09 Thread Pekka Paalanen
On Fri, 9 Oct 2015 16:42:04 +0800 Jonas Ådahl wrote: > On Thu, Oct 08, 2015 at 04:29:03PM +0300, Pekka Paalanen wrote: > > On Fri, 2 Oct 2015 17:32:59 +0800 > > Jonas Ådahl wrote: > > > > > Instead of doing things that do the equivalent of using > > > wl_display_prepare_read() and friends, jus

Re: State of Wayland protocol development

2015-10-09 Thread Pekka Paalanen
On Fri, 9 Oct 2015 14:41:31 +0800 Jonas Ådahl wrote: > Hi again, > > I implemented one of the brought up ideas to see how it'd work. > More specifically, I created a repository called "wayland-protocols"[0] > and adapted weston[1] to use it for the fullscreen shell. I also added > pointer gestu

Re: State of Wayland protocol development

2015-10-09 Thread Pekka Paalanen
Hi all, I'm not sure how much of this was directed at me, if any, but I feel like I should state my position. On Thu, 8 Oct 2015 13:43:06 -0700 "Jasper St. Pierre" wrote: > ... snip ... > > On Thu, Oct 8, 2015 at 12:56 PM, Daniel Stone wrote: > >> This is what I believe we lost when Kristia

Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

2015-10-09 Thread Jonas Ådahl
On Thu, Oct 08, 2015 at 04:29:03PM +0300, Pekka Paalanen wrote: > On Fri, 2 Oct 2015 17:32:59 +0800 > Jonas Ådahl wrote: > > > Instead of doing things that do the equivalent of using > > wl_display_prepare_read() and friends, just use the public API. The > > only semantical difference is that we

[PATCH] input: add new client to resource_list instead of focus_resource_list

2015-10-09 Thread Chokshi, Mitul
When new client registers touch listener, it was added to focus resource list. At this point if another client "without" touch listener is in focus then subsequent touch events are sent to new client with another client's resources causing new client to stop rendering. Now new client is added to re

Re: [PATCH wayland 0/3] "enum" and "bitfield" attributes for protocol XML files

2015-10-09 Thread Auke Booij
On 5 October 2015 at 14:56, Pekka Paalanen wrote: > On Fri, 26 Jun 2015 16:02:44 +0200 > Auke Booij wrote: > >> As per last April/May's "enum" attribute discussion, these patches >> introduce two new attributes to the protocol XML files. >> The "enum" attribute is given to uments of type (u)int,

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-09 Thread Auke Booij
Yeah, that was a pretty embarrassing mistake by me, for such a simple patch. Thanks to Bryce for catching it. On 8 October 2015 at 15:05, Pekka Paalanen wrote: > On Thu, 8 Oct 2015 14:35:34 +0100 > Auke Booij wrote: > >> The wayland scanner defines the protocol. The DTD specification is not use

Re: black surface in desktop shell fullscreen mode

2015-10-09 Thread Pekka Paalanen
On Fri, 9 Oct 2015 10:04:49 +0300 Giulio Camuffo wrote: > You get a black surface because weston puts a black surface behind the > fullscreen one even if it has the right size, and it seems like it > doesn't remove the black surface when the client surface attachs a > NULL buffer. That's a weston

Re: Undefined function 'wl_egl_window_resize'

2015-10-09 Thread Pekka Paalanen
On Thu, 8 Oct 2015 17:02:05 +0200 Joaquim Duran wrote: > Hello, > > > Just curious, what Wayland display server are you going to run > > Weston with the wayland-backend on? > > I expect to run weston in an ARM based device, running on top of > hardware: fbdev, egl, cairo or anyother but no X11

Re: black surface in desktop shell fullscreen mode

2015-10-09 Thread Giulio Camuffo
2015-10-09 9:57 GMT+03:00 zou lan : > Hi Giulio > >>>qtwayland uses wl_shell unless the user explicitly enables xdg_shell, >>>and right now hide() attachs a NULL buffer. Even in the xdg_shell >>>case, so that's broken. > > Can qtwayland "hide" implement the transparent window in desktop shell > fu