Re: black surface in desktop shell fullscreen mode

2015-10-08 Thread zou lan
Hi Giulio >>qtwayland uses wl_shell unless the user explicitly enables xdg_shell, >>and right now hide() attachs a NULL buffer. Even in the xdg_shell >>case, so that's broken. Can qtwayland "hide" implement the transparent window in desktop shell fullscreen mode? I know it can work in normal mod

Re: [PATCH] weston: release keyboard/touch/pointer objects

2015-10-08 Thread Hardening
Le 08/10/2015 05:14, Jonas Ådahl a écrit : > On Tue, Oct 06, 2015 at 10:59:32AM +0200, David FORT wrote: >> This patch adds the missing calls to release when the seat has capabilities >> changes. It also fixes a missing release of the touch object. >> --- >> clients/window.c | 23 +

Re: State of Wayland protocol development

2015-10-08 Thread Jonas Ådahl
Hi again, I implemented one of the brought up ideas to see how it'd work. More specifically, I created a repository called "wayland-protocols"[0] and adapted weston[1] to use it for the fullscreen shell. I also added pointer gestures to make it obvious that its not only protocols that are impleme

Re: [PATCH] zoom: remove temporary variables

2015-10-08 Thread Bryce Harrington
On Thu, Oct 08, 2015 at 07:13:01PM +0300, Giulio Camuffo wrote: > --- > > This is a follow up to "zoom: Remove unneeded usage of wl_fixed_ts in favour > of doubles" > > src/zoom.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) Thanks, LGTM Reviewed-by: Bryce Harring

Re: State of Wayland protocol development

2015-10-08 Thread Jasper St. Pierre
... snip ... On Thu, Oct 8, 2015 at 12:56 PM, Daniel Stone wrote: > Hi, > > That's a fair (and accurate) criticism, but again I don't think that > needs one big cheese. There are quite a few people here who I think > are fairly empowered to shut down discussions that rathole into > totally unrela

Re: Enums, bitfields and wl_arrays

2015-10-08 Thread Daniel Stone
Hi, On 8 October 2015 at 21:13, Daniel Stone wrote: > On 5 October 2015 at 21:31, Victor Berger wrote: >> In this case, for a "closed" enum, the binding can decide to ignore any >> value received on the wire that is not described in the XML, as anyway, the >> client would not know what to do wit

Re: [RFC 1/2] Introduce wl_probe_visible protocol

2015-10-08 Thread Jasper St. Pierre
Mir seems to be pushing forward with their compositor-based attachment protocol, and if they've analyzed it and established that it covers most cases, I'm totally fine with us taking that. Descriptive, not prescriptive :) On Thu, Oct 8, 2015 at 1:16 PM, Daniel Stone wrote: > Hi, > > On 1 October

Re: [RFC 1/2] Introduce wl_probe_visible protocol

2015-10-08 Thread Daniel Stone
Hi, On 1 October 2015 at 07:51, Jonas Ådahl wrote: > The are a few problems with this approach, such as: > > 1) It requires an extra roundtrip to create a popup/tooltip (not that > big of a deal though, I'd say). > 2) When the parent surface has non-trivial transformations (non-90 > degree rotati

Re: Enums, bitfields and wl_arrays

2015-10-08 Thread Daniel Stone
Hi, On 5 October 2015 at 21:31, Victor Berger wrote: > Le 2015-10-05 21:53, Nils Chr. Brause a écrit : >> Since a language binding should support unknown values anyway, I don't >> quite >> see the benefit of an 'open' flag. > > It depends. In some case, it could be valid to support unknown values

Re: [PATCH wayland] server: Make serial number 0 mean invalid

2015-10-08 Thread Daniel Stone
Hi, On 8 October 2015 at 08:27, Jonas Ådahl wrote: > On Mon, Oct 05, 2015 at 12:04:49PM -0500, Derek Foreman wrote: >> There are cases in weston where it would be quite nice to have a >> sentinel value to use instead of having to have a bool for "this serial >> number is legit" too. > > Even thou

Re: [PATCH wayland 7/8] client: Remove misplaced documentation about main loop intergration

2015-10-08 Thread Daniel Stone
Hi Bill, On 5 October 2015 at 19:08, Bill Spitzak wrote: > I looked at this about a year ago, and I think both the docs and code are > suffering from multiple implementations, and this needs to be fixed. Is this a comment on the patch series, or a general musing? Much more useful than a long scr

Re: State of Wayland protocol development

2015-10-08 Thread Daniel Stone
Hi, On 8 October 2015 at 17:35, Jasper St. Pierre wrote: > My issue with this whole "we don't have a maintainer" thing is that we > don't have someone to make a decision. I have lots of patches and > ideas that I'd love to contribute (and have attempted in the past), > but usually the result is t

Re: [PATCH weston v3 3/3] Introduce wl_relative_pointer interface

2015-10-08 Thread Derek Foreman
On 07/10/15 07:41 PM, Jonas Ådahl wrote: > On Wed, Oct 07, 2015 at 01:32:35PM -0500, Derek Foreman wrote: >> On 29/07/15 01:39 AM, Jonas Ådahl wrote: >>> A wl_relative_pointer object is an extension to the wl_pointer interface >>> only used for emitting relative pointer events. It will only emit ev

Re: State of Wayland protocol development

2015-10-08 Thread Jasper St. Pierre
My issue with this whole "we don't have a maintainer" thing is that we don't have someone to make a decision. I have lots of patches and ideas that I'd love to contribute (and have attempted in the past), but usually the result is that there's some bikeshedding and discussion on the list, and then

[PATCH] zoom: remove temporary variables

2015-10-08 Thread Giulio Camuffo
--- This is a follow up to "zoom: Remove unneeded usage of wl_fixed_ts in favour of doubles" src/zoom.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/zoom.c b/src/zoom.c index edffa89..08c0693 100644 --- a/src/zoom.c +++ b/src/zoom.c @@ -68,19 +68,14

Re: Undefined function 'wl_egl_window_resize'

2015-10-08 Thread Joaquim Duran
Hello, > Just curious, what Wayland display server are you going to run Weston with > the wayland-backend on? I expect to run weston in an ARM based device, running on top of hardware: fbdev, egl, cairo or anyother but no X11 should be involved. Currently, the device has the fbdev, EGL and GLESv

Re: [PATCH wayland 6/8] client: Correct documentation regarding thread safeness

2015-10-08 Thread Jonas Ådahl
On Thu, Oct 08, 2015 at 02:25:31PM +0300, Pekka Paalanen wrote: > On Fri, 2 Oct 2015 17:32:57 +0800 > Jonas Ådahl wrote: > > > The current documentation about wl_display_dispatch() states one may not > > mix wl_display_dispatch(_queue)() with wl_display_prepare_read() and > > friends, but this i

Re: [PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-08 Thread Pekka Paalanen
On Thu, 8 Oct 2015 14:35:34 +0100 Auke Booij wrote: > The wayland scanner defines the protocol. The DTD specification is not used. > --- > Makefile.am | 4 ++-- > protocol/wayland.dtd | 29 - > 2 files changed, 2 insertions(+), 31 deletions(-) > delete mod

Re: Undefined function 'wl_egl_window_resize'

2015-10-08 Thread Pekka Paalanen
On Thu, 8 Oct 2015 13:37:40 +0200 Joaquim Duran wrote: > Hello, > > When running the weston, the message is shown: > > [13:27:56.082] Loading module '/usr/lib/weston/wayland-backend.so' > [13:27:56.132] Failed to load module: > /usr/lib/weston/wayland-backend.so: undefined symbol: > wl_egl_wind

[PATCH wayland v2] Remove protocol/wayland.dtd

2015-10-08 Thread Auke Booij
The wayland scanner defines the protocol. The DTD specification is not used. --- Makefile.am | 4 ++-- protocol/wayland.dtd | 29 - 2 files changed, 2 insertions(+), 31 deletions(-) delete mode 100644 protocol/wayland.dtd diff --git a/Makefile.am b/Makefile.

Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

2015-10-08 Thread Pekka Paalanen
On Fri, 2 Oct 2015 17:32:59 +0800 Jonas Ådahl wrote: > Instead of doing things that do the equivalent of using > wl_display_prepare_read() and friends, just use the public API. The > only semantical difference is that we will now unlock and lock the mutex > more times compared to before. > > Si

Re: Undefined function 'wl_egl_window_resize'

2015-10-08 Thread Prabhu S
The function will be provided by wayland-egl and which is from graphics drivers either mesa or the any of the supported GPU drivers. Check the Hardware Enabling for Wayland section in http://wayland.freedesktop.org/architecture.html On Thu, Oct 8, 2015 at 6:37 AM Joaquim Duran wrote: > Hello, > >

Re: [PATCH wayland 7/8] client: Remove misplaced documentation about main loop intergration

2015-10-08 Thread Pekka Paalanen
On Mon, 5 Oct 2015 10:41:37 +0800 Jonas Ådahl wrote: > On Fri, Oct 02, 2015 at 01:36:20PM -0700, Bryce Harrington wrote: > > On Fri, Oct 02, 2015 at 05:32:58PM +0800, Jonas Ådahl wrote: > > > There was documentation about how to integrate the display server file > > > descriptor in the documentat

Undefined function 'wl_egl_window_resize'

2015-10-08 Thread Joaquim Duran
Hello, When running the weston, the message is shown: [13:27:56.082] Loading module '/usr/lib/weston/wayland-backend.so' [13:27:56.132] Failed to load module: /usr/lib/weston/wayland-backend.so: undefined symbol: wl_egl_window_destroy I've configured weston with wayland backend, and not with drm

Re: [PATCH wayland 6/8] client: Correct documentation regarding thread safeness

2015-10-08 Thread Pekka Paalanen
On Fri, 2 Oct 2015 17:32:57 +0800 Jonas Ådahl wrote: > The current documentation about wl_display_dispatch() states one may not > mix wl_display_dispatch(_queue)() with wl_display_prepare_read() and > friends, but this is a misconception about how > wl_display_dispatch(_queue)() works. The fact

Re: Signed-off-by in Wayland and Weston projects

2015-10-08 Thread Bryce Harrington
On Thu, Oct 08, 2015 at 10:19:21AM +0300, Pekka Paalanen wrote: > On Thu, 8 Oct 2015 10:49:18 +0800 > Jonas Ådahl wrote: > > > On Wed, Oct 07, 2015 at 11:05:34AM -0700, Bryce Harrington wrote: > > > On Wed, Oct 07, 2015 at 11:21:38AM -0500, Derek Foreman wrote: > > > > -BEGIN PGP SIGNED MESSA

Re: black surface in desktop shell fullscreen mode

2015-10-08 Thread Giulio Camuffo
2015-10-08 9:59 GMT+03:00 Pekka Paalanen : > On Thu, 8 Oct 2015 11:12:42 +0800 > zou lan wrote: > >> >>If a client really wants to use the transparency, and does not want >> opaque black bars, it can be the client's responsibility to produce a >> buffer that can fill the screen. >> >> This is what

Re: [weston] Missing header file

2015-10-08 Thread Joaquim Duran
Hello, > please keep the mailing list in CC. Sorry. I've commented the tests that they finished with an error. Finaly, I've compiled weston. Joaquim Duran 2015-10-07 13:05 GMT+02:00 Pekka Paalanen : > On Wed, 7 Oct 2015 12:28:58 +0200 > Joaquim Duran wrote: > >> Hello, > > Hi, > > please keep

Re: Signed-off-by in Wayland and Weston projects

2015-10-08 Thread Jonas Ådahl
On Thu, Oct 08, 2015 at 10:19:21AM +0300, Pekka Paalanen wrote: > On Thu, 8 Oct 2015 10:49:18 +0800 > Jonas Ådahl wrote: > > > On Wed, Oct 07, 2015 at 11:05:34AM -0700, Bryce Harrington wrote: > > > On Wed, Oct 07, 2015 at 11:21:38AM -0500, Derek Foreman wrote: > > > > -BEGIN PGP SIGNED MESSA

Re: [PATCH wayland] server: Make serial number 0 mean invalid

2015-10-08 Thread Jonas Ådahl
On Mon, Oct 05, 2015 at 12:04:49PM -0500, Derek Foreman wrote: > On 30/09/15 03:23 PM, Jasper St. Pierre wrote: > > I don't necessarily like this. The absence of a serial can have > > radical meanings on behavior. Being able to pass 0 to mean "no serial" > > anywhere we currently rely on a serial s

Re: Signed-off-by in Wayland and Weston projects

2015-10-08 Thread Pekka Paalanen
On Thu, 8 Oct 2015 10:49:18 +0800 Jonas Ådahl wrote: > On Wed, Oct 07, 2015 at 11:05:34AM -0700, Bryce Harrington wrote: > > On Wed, Oct 07, 2015 at 11:21:38AM -0500, Derek Foreman wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA1 > > > > > > On 07/10/15 02:27 AM, Pekka Paalanen w

Re: [PATCH wayland] scanner: Generate 'since' macros for requests as well

2015-10-08 Thread Hardening
Le 08/10/2015 05:10, Jonas Ådahl a écrit : > We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for > events in the server protocol headers. Lets do the same for requests in > the client protocol headers as well. > > Signed-off-by: Jonas Ådahl > --- > src/scanner.c | 1 + > 1 file

Re: black surface in desktop shell fullscreen mode

2015-10-08 Thread Pekka Paalanen
On Thu, 8 Oct 2015 11:12:42 +0800 zou lan wrote: > >>If a client really wants to use the transparency, and does not want > opaque black bars, it can be the client's responsibility to produce a > buffer that can fill the screen. > > This is what the client wants to. The Qt app call "hide" functio