Re: [PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

> get_shell_surface(parent) may return NULL if the client passed a > unassigned wl_surface or a wl_surface with a non-shell surface role > (such as cursor role). > > https://bugs.freedesktop.org/show_bug.cgi?id=92316 > > Signed-off-by: Jonas Ådahl Tested-by: Olivier Fourdan Works for me :-)

[PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

get_shell_surface(parent) may return NULL if the client passed a unassigned wl_surface or a wl_surface with a non-shell surface role (such as cursor role). https://bugs.freedesktop.org/show_bug.cgi?id=92316 Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 5 +++-- 1 file changed, 3 insert

[PATCH v2 2/3] clients: Correct drawing glitch in stacking demo

Fix a graphics glitch in the stacking demo in which a transient window's drop shadow is visibile within the interior of the window. Signed-off-by: Ben Hummon --- clients/stacking.c | 4 1 file changed, 4 deletions(-) diff --git a/clients/stacking.c b/clients/stacking.c index ae9c332..67485

[PATCH v2 1/3] clients: Moving and rotating transient surfaces

Transient surfaces use child/parent surfaces for stacking order. This change resloves an issue in which attempting to move or rotate a toplevel transient surface can move or rotate its ancestor. Signed-off-by: Ben Hummon --- desktop-shell/shell.c | 13 + 1 file changed, 5 insertions(

[PATCH v2 3/3] clients: Disable popup shortcut in stacking demo

Weston does not allow popup menus initiated by keyboard. Remove the broken keyboard shorcut for a popup from the stacking demo. Signed-off-by: Ben Hummon --- clients/stacking.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/clients/stacking.c b/clients/stacking.c ind

Re: [PATCH 1/3] clients: Moving and rotating transient surfaces

Hmm, I landed this one but shouldn't have - we require signed-off-by for commits. Could you re-send your other two with Signed-off-by? Thanks, Derek On 06/10/15 11:48 AM, Ben Hummon wrote: > Transient surfaces use child/parent surfaces for stacking order. This > change resloves an issue in whic

Re: [PATCH 1/3] clients: Moving and rotating transient surfaces

On 06/10/15 11:48 AM, Ben Hummon wrote: > Transient surfaces use child/parent surfaces for stacking order. This > change resloves an issue in which attempting to move or rotate a > toplevel transient surface can move or rotate its ancestor. > --- This fixes an issue I introduced when trying to sto

Re: [PATCH weston 1/2] shell: update pointer focus when surface is minimized.

On 06/10/15 10:40 AM, Derek Foreman wrote: > From: Nicolas Guyomard > > Signed-off-by: Nicolas Guyomard > Signed-off-by: Derek Foreman > --- Nicolas brought it to my attention that this patch was already rejected in this thread: http://lists.freedesktop.org/archives/wayland-devel/2015-March/02

[PATCH 1/3] clients: Moving and rotating transient surfaces

Transient surfaces use child/parent surfaces for stacking order. This change resloves an issue in which attempting to move or rotate a toplevel transient surface can move or rotate its ancestor. --- The moving/rotating issue can be seen by creating transient surfaces in the weston stacking demo.

[PATCH 2/3] clients: Correct drawing glitch in stacking demo

Fix a graphics glitch in the stacking demo in which a transient window's drop shadow is visibile within the interior of the window. --- clients/stacking.c | 4 1 file changed, 4 deletions(-) diff --git a/clients/stacking.c b/clients/stacking.c index ae9c332..6748576 100644 --- a/clients/stac

[PATCH 3/3] clients: Disable popup shortcut in stacking demo

Weston does not allow popup menus initiated by keyboard. Remove the broken keyboard shorcut for a popup from the stacking demo. --- clients/stacking.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/clients/stacking.c b/clients/stacking.c index 6748576..f90243a 100644 -

[PATCH] Remove protocol/wayland.dtd

The wayland scanner defines the protocol. The DTD specification is not used. --- protocol/wayland.dtd | 29 - 1 file changed, 29 deletions(-) delete mode 100644 protocol/wayland.dtd diff --git a/protocol/wayland.dtd b/protocol/wayland.dtd deleted file mode 100644 inde

[PATCH weston 0/2] bug fixes

I'm trying to pull useful patches out of the public tizen repository. Nicolas has signed off on these two, but I'm responsible for the forward port from weston 1.7.0 to git master and can handle any required changes. (Which is why I've not put my R-b on them.) Nicolas Guyomard (2): shell: updat

[PATCH weston 2/2] input-panel: Fix show_input_panel_surface crash when no surface has focus

From: Nicolas Guyomard Signed-off-by: Nicolas Guyomard Signed-off-by: Derek Foreman --- desktop-shell/input-panel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/desktop-shell/input-panel.c b/desktop-shell/input-panel.c index 251d044..95d6287 100644 --- a/desktop-shell/input-panel.c ++

[PATCH weston 1/2] shell: update pointer focus when surface is minimized.

From: Nicolas Guyomard Signed-off-by: Nicolas Guyomard Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 3c6a3da..ee705e5 100644 --- a/desktop-shell/shell.c +++ b/d

[PATCH] weston: release keyboard/touch/pointer objects

This patch adds the missing calls to release when the seat has capabilities changes. It also fixes a missing release of the touch object. --- clients/window.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/clients/window.c b/clients/window.c index 47a7

Re: Can I enable mode switching from wayland/weston?

On 02 Oct, 2015,at 09:13 AM, Pekka Paalanen wrote: However, for special use cases like yours, there are alternatives that would work more reliably, but also require more work to implement: - fullscreen shell; This is a replacement to desktop shell, which means you cannot run desktop apps on it