Re: [PATCH] xwayland: Adjust screen size with rotation

2015-09-24 Thread Olivier Fourdan
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92076 > Signed-off-by: Olivier Fourdan > --- > hw/xwayland/xwayland-output.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > As mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=92076#c5 Tested-by: Artem Chudin

RE: [PATCH] libinput device capability modification regarding combo input devices

2015-09-24 Thread 박성진
Dear Peter, thanks. That's right. If we modify the enum with the new one, ABI break will be made. Then how about add new capabilities ? IMO, it's better to get capabilities by calling once an API than calling libinput_device_has_capability twice. Otherwise, we can enhance wayland protocol to get

Re: [PATCH] libinput device capability modification regarding combo input devices

2015-09-24 Thread Peter Hutterer
On Wed, Sep 23, 2015 at 11:29:13AM +0900, �ڼ��� wrote: > Dear all, > > as you guys know, there are some combo input devices which support both > keyboard functionality and pointer functionality. > > We can also see some of input devices supports both keyboard functionality > and touch functionali

RE: [PATCH] libinput device capability modification regarding combo input devices

2015-09-24 Thread 박성진
Dear Bill Spitzak, thanks for your opinion. : ) As we know, there are a lot of keyboards or keyboard-like devices. Some of them will be keypads or special keyboards for game or other purposes. For those kinds of keyboards, we don’t need to care and we can deal with the events in the usual ma

Re: [PATCH weston, v3] weston-terminal: Add cwd and command options

2015-09-24 Thread Derek Foreman
On 23/09/15 06:38 PM, ahmet acar wrote: > Add 'cwd' (current working directory) and 'command' (run specified > command immediately after startup) switch to weston-terminal. > Both switch are optional. > > v3: > -change command execution mechanism as 'bash -c command' (Bill Spitzak) > > Running

[PATCH] tests: Migrate screenshot code from internal test to client helpers

2015-09-24 Thread Bryce Harrington
These routines provide test cases an ability to capture screen images for rendering verification. This commit is a no-change refactoring, except for making the routines non-static. Makefile rules are also updated; most notably, this links test clients against the cairo libraries now. Signed-off-

[PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-09-24 Thread David FORT
This patch makes the seat dynamic and leak it on purpose during seat removal to prevent the ghost object case. --- src/compositor-rdp.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index c2

[PATCH weston] RDP compositor: dynamic seat v2

2015-09-24 Thread David FORT
This is the updated version patched for libweston. I had a discussion with Pekka about the seat removal announce. Previously valgrind was detecting nasty things with text-input. But some cleanups have been done since in text-input and it works like a charm now. So I feel like the seat removal anno

Re: [PATCH weston] launcher: fix typo

2015-09-24 Thread Bryce Harrington
On Thu, Sep 24, 2015 at 02:30:38PM -0500, Derek Foreman wrote: > In the launcher split up patch WESTON_LAUNCHER_SOCK was accidentally > changed to WESTON_LAUNCH_SOCK > > Signed-off-by: Derek Foreman Good find. Wonder how that snuck in here. Pushed to trunk, thanks! Bryce > --- > src/launche

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-24 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 11:05:31PM +0200, John-John Tedro wrote: > On Tue, Sep 22, 2015 at 06:18:44PM -0700, Bryce Harrington wrote: > > ivi_layout_transition_fade_layer() checks for null before making the > > call, but this also needs done in create_visibility_transition(), > > ivi_layout_transiti

Re: [PATCH weston 2/3] text: Don't track binding in struct text_backend

2015-09-24 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 10:27:42AM -0500, Derek Foreman wrote: > On 17/09/15 03:45 PM, Bryce Harrington wrote: > > On Thu, Jun 25, 2015 at 03:49:48PM -0500, Derek Foreman wrote: > >> The binding is only used for preventing launch, and we've already got the > >> pid for that. > >> > >> With multiple

Re: [PATCH] libinput device capability modification regarding combo input devices

2015-09-24 Thread Bill Spitzak
On Wed, Sep 23, 2015 at 6:52 PM, 박성진 wrote: > Dear Andreas Pokorny, thanks for your reply. J > > > > As you mentioned, we also need to distinguish between a full keyboard and > a device which has a set of few keys. > > Each key coming from the full keyboard will be sent to the focus > surface(win

[PATCH weston] launcher: fix typo

2015-09-24 Thread Derek Foreman
In the launcher split up patch WESTON_LAUNCHER_SOCK was accidentally changed to WESTON_LAUNCH_SOCK Signed-off-by: Derek Foreman --- src/launcher-weston-launch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/launcher-weston-launch.c b/src/launcher-weston-launch.c index 0

Re: [PATCH weston] launcher: fix broken distcheck

2015-09-24 Thread Bryce Harrington
On Thu, Sep 24, 2015 at 11:05:30AM -0700, Bryce Harrington wrote: > On Thu, Sep 24, 2015 at 09:26:48AM -0500, Derek Foreman wrote: > > We were missing launcher-impl.h in Makefile.am > > > > Signed-off-by: Derek Foreman > > Aha, right. > Reviewed-by: Bryce Harrington To ssh://git.freedesktop.or

Re: Enums, bitfields and wl_arrays in the .xml file

2015-09-24 Thread Bill Spitzak
On Thu, Sep 24, 2015 at 4:00 AM, Victor Berger < victor.ber...@polytechnique.org> wrote: > Hi, > > After some discussions on IRC, it appears this raises several concerns > about back-compatibility. > > The main points being: > > - if a protocol file previously did not use these extra attributes, a

Re: Enums, bitfields and wl_arrays in the .xml file

2015-09-24 Thread Nils Chr. Brause
Hi These are all very interesting points. I understand that some language bindings might break existing code, if they want to use the 'enum' and 'bitfield' attributes. But they could simply bump the major version of their bindings, in that case. In my opinion this is a low price to pay for highe

Re: [PATCH weston] launcher: fix broken distcheck

2015-09-24 Thread Bryce Harrington
On Thu, Sep 24, 2015 at 09:26:48AM -0500, Derek Foreman wrote: > We were missing launcher-impl.h in Makefile.am > > Signed-off-by: Derek Foreman Aha, right. Reviewed-by: Bryce Harrington > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.am b/Makefile.am >

Re: [PATCH weston] compositor: systemd notifications support

2015-09-24 Thread Giulio Camuffo
2015-09-24 16:20 GMT+03:00 Pekka Paalanen : > On Thu, 24 Sep 2015 15:53:53 +0300 > Giulio Camuffo wrote: > >> 2015-09-24 14:06 GMT+03:00 Egor Starkov : >> > Add systemd status and watchdog notification support. >> > Feature is not compiled by default and can be enabled by >> > "--enable-systemd-no

Re: Compile and use rpi-backend on raspberry 2 gave always black screen after weston-launch

2015-09-24 Thread Fabio Fantoni
Il 23/09/2015 16:53, Derek Foreman ha scritto: On 17/09/15 09:16 AM, Fabio Fantoni wrote: Il 17/09/2015 14:15, Pekka Paalanen ha scritto: On Thu, 17 Sep 2015 11:13:19 +0200 Fabio Fantoni wrote: Il 16/09/2015 18:00, Pekka Paalanen ha scritto: On Tue, 15 Sep 2015 17:10:09 +0200 Fabio Fantoni

[PATCH weston] launcher: fix broken distcheck

2015-09-24 Thread Derek Foreman
We were missing launcher-impl.h in Makefile.am Signed-off-by: Derek Foreman --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 94a824b..1d66cc0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -129,6 +129,7 @@ noinst_LTLIBRARIES +=

Re: [PATCH weston] compositor: systemd notifications support

2015-09-24 Thread Pekka Paalanen
On Thu, 24 Sep 2015 15:53:53 +0300 Giulio Camuffo wrote: > 2015-09-24 14:06 GMT+03:00 Egor Starkov : > > Add systemd status and watchdog notification support. > > Feature is not compiled by default and can be enabled by > > "--enable-systemd-notify" configuration flag. Watchdog > > timeout equals

Re: [PATCH weston] compositor: systemd notifications support

2015-09-24 Thread Giulio Camuffo
2015-09-24 14:06 GMT+03:00 Egor Starkov : > Add systemd status and watchdog notification support. > Feature is not compiled by default and can be enabled by > "--enable-systemd-notify" configuration flag. Watchdog > timeout equals to half of timeout defined by "WATCHDOG_USEC" > environment variable

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-24 Thread John-John Tedro
On Tue, Sep 22, 2015 at 06:18:44PM -0700, Bryce Harrington wrote: > ivi_layout_transition_fade_layer() checks for null before making the > call, but this also needs done in create_visibility_transition(), > ivi_layout_transition_move_resize_view(), and > ivi_layout_transition_move_layer(). Or alte

Re: Enums, bitfields and wl_arrays in the .xml file

2015-09-24 Thread Victor Berger
Hi, After some discussions on IRC, it appears this raises several concerns about back-compatibility. The main points being: - if a protocol file previously did not use these extra attributes, and choses to add them, depending on the language using them it can be a breaking change (as it wou

Re: Patchwork upgrade?

2015-09-24 Thread Olivier Blin
Le 24/09/2015 13:26, Damien Lespiau a écrit : On Wed, Sep 23, 2015 at 07:17:20PM +0200, Olivier Blin wrote: > Le 22/09/2015 19:27, Damien Lespiau a écrit : > >On Mon, Jul 27, 2015 at 11:01:43AM -0700, Bryce Harrington wrote: > >> On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: > > >

Re: Patchwork upgrade?

2015-09-24 Thread Damien Lespiau
On Wed, Sep 23, 2015 at 07:17:20PM +0200, Olivier Blin wrote: > Le 22/09/2015 19:27, Damien Lespiau a écrit : > >On Mon, Jul 27, 2015 at 11:01:43AM -0700, Bryce Harrington wrote: > >> On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: > > > >The other thing is more difficult. I don't hav

[PATCH weston] compositor: systemd notifications support

2015-09-24 Thread Egor Starkov
Add systemd status and watchdog notification support. Feature is not compiled by default and can be enabled by "--enable-systemd-notify" configuration flag. Watchdog timeout equals to half of timeout defined by "WATCHDOG_USEC" environment variable, which is set by "WatchdogSec=" setting in service

[PATCH weston] compositor: systemd notifications support

2015-09-24 Thread Egor Starkov
This patch implements systemd sd_notify interface, that allows weston to utilize systemd monitoring capabilities: notify about internal state and use watchdog. More info can be found here: http://www.freedesktop.org/software/systemd/man/sd_notify.html The feature is not compiled by default and ca

Re: [PATCH weston 2/3] launcher: Split out launcher implementations into three distinct ones

2015-09-24 Thread Pekka Paalanen
On Thu, 24 Sep 2015 13:51:10 +0300 Pekka Paalanen wrote: > On Wed, 23 Sep 2015 13:42:13 -0500 > Derek Foreman wrote: > > > On 23/09/15 12:46 PM, Jasper St. Pierre wrote: > > > We now have a launcher interface and distinct implementations for > > > logind, weston-launch, and direct DRM, each in

Re: [PATCH weston] compositor: remove incorrect idle timer initialization

2015-09-24 Thread Pekka Paalanen
On Wed, 23 Sep 2015 18:29:46 +0300 Egor Starkov wrote: > weston_compositor_create() should just create idle timer but > not arm it, because idle-time setting is not read at this point Hi Egor, the explanation in the cover letter is actually even better, so I merged it with this message. > Sign

Re: [PATCH weston 2/3] launcher: Split out launcher implementations into three distinct ones

2015-09-24 Thread Pekka Paalanen
On Wed, 23 Sep 2015 13:42:13 -0500 Derek Foreman wrote: > On 23/09/15 12:46 PM, Jasper St. Pierre wrote: > > We now have a launcher interface and distinct implementations for > > logind, weston-launch, and direct DRM, each in their own files. > > > > This helps up clean up the spaghetti code int