Re: [PATCH] libinput device capability modification regarding combo input devices

2015-09-22 Thread Andreas Pokorny
Hi, 2015-09-23 4:29 GMT+02:00 박성진 : > Dear all, > > as you guys know, there are some combo input devices which support both > keyboard functionality and pointer functionality. > > We can also see some of input devices supports both keyboard functionality > and touch functionality. > > > > In theo

[PATCH] libinput device capability modification regarding combo input devices

2015-09-22 Thread 박성진
Dear all, as you guys know, there are some combo input devices which support both keyboard functionality and pointer functionality. We can also see some of input devices supports both keyboard functionality and touch functionality. In theory, each input device functionality needs to be provid

Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 03:31:04AM +0200, Manuel Bachmann wrote: > Hi Bryce, and thanks a lot for the review ! > > Of course I have tested it :) ; the steps are the following : > Copy some text in weston-terminal, scroll it out (by pressing [Enter] > repeatedly e.g.), try to paste. > It does work

Re: [PATCH weston v2] xwm: flush xcb connection only when we processed some event

2015-09-22 Thread Bryce Harrington
On Wed, Aug 12, 2015 at 09:55:12AM +0200, Marek Chalupa wrote: > xwayland source is checked, so it dispatches twice on any event. > If the other turn has no events to dispatch, we flush the connection > redundantly > > v2. do not flood logs with 'unhandled event' messages > > Signed-off-by: Marek

Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Manuel Bachmann
Hi Bryce, and thanks a lot for the review ! Of course I have tested it :) ; the steps are the following : Copy some text in weston-terminal, scroll it out (by pressing [Enter] repeatedly e.g.), try to paste. It does work with the patch only. 2015-09-23 2:10 GMT+02:00 Bryce Harrington : > On Sat

Re: [PATCH weston] tests: Convert 'xalloc's to 'zalloc's

2015-09-22 Thread Bryce Harrington
On Tue, Sep 08, 2015 at 10:39:44PM -0700, Bryce Harrington wrote: > On Mon, Sep 07, 2015 at 04:46:40PM +0300, Pekka Paalanen wrote: > > On Fri, 4 Sep 2015 23:47:09 +0530 > > Seedo Eldho Paul wrote: > > > > > xalloc terminates the program abruptly if the requested amount of > > > memory couldn't

Re: [PATCH weston] clients: ungrab the correct input when menus close

2015-09-22 Thread Bryce Harrington
On Fri, Sep 11, 2015 at 02:28:15PM -0500, Derek Foreman wrote: > We need to input_ungrab() on the stored input, not the one that caused > the release - otherwise bad things can happen in multi-seat environments > when a seat that didn't open the menu closes it. > > To reproduce: > configure two s

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 05:28:32PM -0700, Bryce Harrington wrote: > On Sun, Sep 20, 2015 at 02:47:37AM +0200, John-John Tedro wrote: > > create_layout_transition does not initialize is_transition_func. > > > > This patch initializes it to NULL. > > > > Signed-off-by: John-John Tedro > > Reviewe

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 02:13:37AM +0200, John-John Tedro wrote: > On Mon, Sep 21, 2015 at 09:33:29AM -0700, Bill Spitzak wrote: > >=20 > > Maybe this should be using xzalloc, that seems to be the standard method = > in > > Weston > > Yikes. > > It looks like create_move_resize_view_transition (a

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 09:33:29AM -0700, Bill Spitzak wrote: > On Sat, Sep 19, 2015 at 5:47 PM, John-John Tedro > wrote: > > > create_layout_transition does not initialize is_transition_func. > > > > This patch initializes it to NULL. > > > > Signed-off-by: John-John Tedro > > --- > > ivi-shel

Re: [PATCH][weston] vaapi-recorder: Fix allocator sizeof operand mismatch

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 05:21:58PM -0700, Bryce Harrington wrote: > On Sun, Sep 20, 2015 at 11:12:50AM -0300, Lucas Tanure wrote: > > Result of 'calloc' is converted to a pointer of type 'unsigned int', which > > is > > incompatible with sizeof operand type 'int' > > In practice uint and int will

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-22 Thread Bryce Harrington
On Sun, Sep 20, 2015 at 02:47:37AM +0200, John-John Tedro wrote: > create_layout_transition does not initialize is_transition_func. > > This patch initializes it to NULL. > > Signed-off-by: John-John Tedro Reviewed-by: Bryce Harrington Btw, since this function sets nearly all the parameters t

Re: [PATCH][weston] vaapi-recorder: Fix allocator sizeof operand mismatch

2015-09-22 Thread Bryce Harrington
On Sun, Sep 20, 2015 at 11:12:50AM -0300, Lucas Tanure wrote: > Result of 'calloc' is converted to a pointer of type 'unsigned int', which is > incompatible with sizeof operand type 'int' In practice uint and int will result in the same size, but this is more technically correct, so yep good find.

Re: [PATCH][weston] ivi_layout_surface_add_notification: Fix potential leak of memory pointed to by 'notification'

2015-09-22 Thread Lucas Tanure
Ok. Thanks, I forgot that one. On Tue, Sep 22, 2015, 21:18 Bryce Harrington wrote: > On Tue, Sep 22, 2015 at 05:18:05PM -0700, Bryce Harrington wrote: > > On Sat, Sep 19, 2015 at 06:24:58PM -0300, Lucas Tanure wrote: > > > Signed-off-by: Lucas Tanure > > > > Reviewed-by: Bryce Harrington > > >

Re: [PATCH][weston] ivi_layout_surface_add_notification: Fix potential leak of memory pointed to by 'notification'

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 05:18:05PM -0700, Bryce Harrington wrote: > On Sat, Sep 19, 2015 at 06:24:58PM -0300, Lucas Tanure wrote: > > Signed-off-by: Lucas Tanure > > Reviewed-by: Bryce Harrington > > I notice this patch was marked as Superseded in patchwork, but I didn't > spot a patch supersed

Re: [PATCH][weston] ivi_layout_surface_add_notification: Fix potential leak of memory pointed to by 'notification'

2015-09-22 Thread Bryce Harrington
On Sat, Sep 19, 2015 at 06:24:58PM -0300, Lucas Tanure wrote: > Signed-off-by: Lucas Tanure Reviewed-by: Bryce Harrington I notice this patch was marked as Superseded in patchwork, but I didn't spot a patch superseding it. So, I've NEW'd it for application since it still appears to be pertinen

Re: [PATCH][weston] terminal: allow copy-paste when selection is scrolled out

2015-09-22 Thread Bryce Harrington
On Sat, Sep 19, 2015 at 01:51:05PM +0200, Manuel Bachmann wrote: > We could not paste text when its source went outside the > visible part of the buffer ; this is because we were > incorrectly assuming that our iterator should start at > row 0, while it could very well be negative. > > Signed-off-

Re: Patchwork upgrade?

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 06:27:49PM +0100, Damien Lespiau wrote: > On Mon, Jul 27, 2015 at 11:01:43AM -0700, Bryce Harrington wrote: > > On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: > > > Hey Bryce, > > > > > > On 17 July 2015 at 21:19, Bryce Harrington wrote: > > > > Could I both

Re: [weston] weston-terminal: Add a few nice features

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 03:24:49PM +0300, ahmet acar wrote: > Hi.This trivial patch adds 'cwd' (current working directory) > and 'command' (run specified command immediatelly after open) > features to weston-terminal.So this adds more use cases > and flexibility to our terminal. Sounds useful! I

Re: [PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

2015-09-22 Thread Lucas Tanure
On Tue, Sep 22, 2015 at 6:38 PM, Bryce Harrington wrote: > On Tue, Sep 22, 2015 at 02:36:44PM -0700, Bryce Harrington wrote: > > On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote: > > > layout_transition_register could not work and we need to free trans in > > > the calling function. >

Re: [PATCH] weston_wm: Implement _NET_ACTIVE_WINDOW

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 12:29:46AM +0200, Benoit Gschwind wrote: > --- > xwayland/window-manager.c | 21 + > xwayland/xwayland.h | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c > index f9544d8..254bd45 1

Re: [PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 02:36:44PM -0700, Bryce Harrington wrote: > On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote: > > layout_transition_register could not work and we need to free trans in > > the calling function. > > > > Signed-off-by: Lucas Tanure > > LGTM, > > Reviewed-by: B

Re: [PATCH][weston, v2] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 11:24:35AM -0300, Lucas Tanure wrote: > Free transition before return. We don't need to use layout_transition_destroy, > because transition was not registered yet. > > v2: consolidate memory leaks fixes LGTM. Reviewed-by: Bryce Harrington > Signed-off-by: Lucas Tanure

Re: [PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote: > layout_transition_register could not work and we need to free trans in > the calling function. > > Signed-off-by: Lucas Tanure LGTM, Reviewed-by: Bryce Harrington > --- > ivi-shell/ivi-layout-transition.c | 6 -- > 1 file ch

Re: [PATCH][weston 2/2] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-22 Thread Bryce Harrington
On Mon, Sep 21, 2015 at 02:10:33PM -0300, Lucas Tanure wrote: > Check if layout_transition_register worked, otherwise destroy transition > > Signed-off-by: Lucas Tanure > --- > ivi-shell/ivi-layout-transition.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ivi-shell

Re: [PATCH wayland v2] Contributing: explain Patchwork

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 09:18:30AM +0200, Olivier Fourdan wrote: > On 22 September 2015 at 08:56, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Add general guidelines for using Patchwork, as we heavily rely on it > > nowadays. > > > > v2: > > > > - mention also Xwayland and libinput p

Re: [PATCH wayland] Contributing: explain Patchwork

2015-09-22 Thread Bryce Harrington
On Tue, Sep 22, 2015 at 10:30:48AM +0300, Pekka Paalanen wrote: > On Tue, 22 Sep 2015 09:22:27 +0300 > Pekka Paalanen wrote: > > > On Mon, 21 Sep 2015 12:31:21 -0700 > > Bryce Harrington wrote: > > > > > On Mon, Sep 21, 2015 at 10:41:59AM +0300, Pekka Paalanen wrote: > > > > From: Pekka Paalane

Re: Patchwork upgrade?

2015-09-22 Thread Damien Lespiau
On Mon, Jul 27, 2015 at 11:01:43AM -0700, Bryce Harrington wrote: > On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: > > Hey Bryce, > > > > On 17 July 2015 at 21:19, Bryce Harrington wrote: > > > Could I bother you to request we update patchwork on fdo? > > > The latest version now d

Re: [PATCH weston v2] compositor: fix initializing idle timeout at startup

2015-09-22 Thread Pekka Paalanen
On Tue, 22 Sep 2015 13:50:00 +0300 Egor Starkov wrote: > Read and store idle-time setting before calling weston_compositor_create > that makes initial setting of idle timeout. > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=92030 Hi Egor, strange, I cannot reproduce this problem. > Sig

Re: [PATCH weston v2] xwm: use always a valid 'primary view' for an X window

2015-09-22 Thread Benoit Gschwind
Giulio Camuffo writes: > > The xwm gets a primary view for a X window using the get_primary_view > vfunc of the shell_interface struct. Storing it is dangerous though because > it doesn't listen for its destruction so it may end up using the old stored > view pointer after that view was freed, o

[PATCH weston v2] compositor: fix initializing idle timeout at startup

2015-09-22 Thread Egor Starkov
idle-time setting is currently read and set after weston_compositor_create is called. This causes an issue that screen never goes dark after weston started until first input event. Change is fixing that by reading idle-time setting before timer initialization. --- C

[PATCH weston v2] compositor: fix initializing idle timeout at startup

2015-09-22 Thread Egor Starkov
Read and store idle-time setting before calling weston_compositor_create that makes initial setting of idle timeout. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=92030 Signed-off-by: Egor Starkov --- src/compositor.c | 3 ++- src/compositor.h | 2 +- src/main.c | 11 --- 3

Re: [PATCH wayland] Contributing: explain Patchwork

2015-09-22 Thread Pekka Paalanen
On Tue, 22 Sep 2015 09:22:27 +0300 Pekka Paalanen wrote: > On Mon, 21 Sep 2015 12:31:21 -0700 > Bryce Harrington wrote: > > > On Mon, Sep 21, 2015 at 10:41:59AM +0300, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > +The following patch states are found in Patchwork: > > > + > >

Re: [PATCH wayland v2] Contributing: explain Patchwork

2015-09-22 Thread Olivier Fourdan
On 22 September 2015 at 08:56, Pekka Paalanen wrote: > From: Pekka Paalanen > > Add general guidelines for using Patchwork, as we heavily rely on it > nowadays. > > v2: > > - mention also Xwayland and libinput patch management > - reword "if not found in Patchwork" > - reword "Not applicable" >