Re: [PATCH weston] terminal: Don't crash when selecting non-ascii characters

2015-09-09 Thread Bryce Harrington
On Wed, Sep 02, 2015 at 04:21:54PM -0500, Derek Foreman wrote: > So it turns out if you cat /dev/urandom and drag select in the mess > you can crash weston-terminal. There may also be more legitimate > ways of doing this. > > The reason is that isalpha() and isdigit() only accept values that > fi

Re: [PATCH weston] compositor-fbdev: Remove bizarre division by sizeof

2015-09-09 Thread Bryce Harrington
On Wed, Sep 02, 2015 at 01:45:20PM -0500, Derek Foreman wrote: > Really not sure why this was even here - it worked because > we were dividing by 1. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington > --- > src/compositor-fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH weston] rpi: fix segfault at startup in rpi_flippipe_init() v2

2015-09-09 Thread John Sadler
On 08/09/15 13:31, Pekka Paalanen wrote: > From: John Sadler > > When running with the RPi backend, Weston now segfaults at startup on the > line: > > flippipe->clk_id = output->base.compositor->presentation_clock; > > in `rpi_flippipe_init()`. > > This is because `output->base.compositor` is

Re: [PATCH weston 4/4] rpi: prevent Weston segfaulting on shut-down due to NULL `backend`

2015-09-09 Thread John Sadler
On 08/09/15 14:55, Pekka Paalanen wrote: > On Sat, 5 Sep 2015 15:01:40 +0100 > John Sadler wrote: > >> When running with the RPi backend, Weston sefaults during shutdown. This is >> due to the fact that `compositor->backend` is never initialised, and there >> is no NULL check prior to calling `de

Re: [PATCH weston] Revert "compositor-drm: disable hardware cursors"

2015-09-09 Thread Pekka Paalanen
On Wed, 9 Sep 2015 10:03:34 +0300 Giulio Camuffo wrote: > 2015-09-09 9:58 GMT+03:00 Pekka Paalanen : > > On Tue, 8 Sep 2015 22:52:51 -0700 > > Bryce Harrington wrote: > > > >> On Mon, Sep 07, 2015 at 04:42:16PM +0300, Pekka Paalanen wrote: > >> > On Mon, 7 Sep 2015 15:36:35 +0200 > >> > Giulio C

Re: [PATCH] clients: Fix height typo in clamp_view()

2015-09-09 Thread Pekka Paalanen
On Tue, 8 Sep 2015 19:24:12 -0700 Bryce Harrington wrote: > We should be checking our scaled image height against the allocation > height rather than the allocation width. > > Signed-off-by: Bryce Harrington > --- > clients/image.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH weston] Revert "compositor-drm: disable hardware cursors"

2015-09-09 Thread Giulio Camuffo
2015-09-09 9:58 GMT+03:00 Pekka Paalanen : > On Tue, 8 Sep 2015 22:52:51 -0700 > Bryce Harrington wrote: > >> On Mon, Sep 07, 2015 at 04:42:16PM +0300, Pekka Paalanen wrote: >> > On Mon, 7 Sep 2015 15:36:35 +0200 >> > Giulio Camuffo wrote: >> > >> > > 2015-09-07 16:27 GMT+03:00 Pekka Paalanen : >