Re: [PATCH libinput] Note that libinput_unref() really destroys everything

2015-09-03 Thread Peter Hutterer
On Fri, Sep 04, 2015 at 08:29:07AM +0200, Andreas Pokorny wrote: > Hi, > To some degree this does not sound like a bug. At least for resources that > are not presented to the user as being ref counted. But I would have > expected that libinput_path_add_device would increase the ref count of the > l

Re: [PATCH libinput] Note that libinput_unref() really destroys everything

2015-09-03 Thread Andreas Pokorny
Hi, To some degree this does not sound like a bug. At least for resources that are not presented to the user as being ref counted. But I would have expected that libinput_path_add_device would increase the ref count of the libinput_context and similar for seats. So as long as the device is not unre

Re: [PATCH libinput] Note that libinput_unref() really destroys everything

2015-09-03 Thread Jonas Ã…dahl
On Fri, Sep 04, 2015 at 02:17:06PM +1000, Peter Hutterer wrote: > This is both a bug and required behavior. A caller may hold refcounted > references to devices, seats, or device groups but when libinput_unref() > cleans up, all these become invalid. > > It is required behavior, because the last c

[PATCH libinput] Note that libinput_unref() really destroys everything

2015-09-03 Thread Peter Hutterer
This is both a bug and required behavior. A caller may hold refcounted references to devices, seats, or device groups but when libinput_unref() cleans up, all these become invalid. It is required behavior, because the last call to libinput_unref() also calls libinput_suspend() and thus stops any e

Re: [PATCH weston] tests: Remove the redundant NULL checks

2015-09-03 Thread Seedo Eldho Paul
On Sep 4, 2015 1:48 AM, "Bryce Harrington" wrote: > > On Fri, Sep 04, 2015 at 12:17:18AM +0530, Seedo Eldho Paul wrote: > > xzalloc is guaranteed to return a non-NULL value. > > > > Signed-off-by: Seedo Eldho Paul > > --- > > tests/internal-screenshot-test.c | 13 - > > 1 file change

Re: [PATCH weston] shell: When rotating use the parent if available

2015-09-03 Thread Bryce Harrington
On Wed, Sep 02, 2015 at 11:32:05AM -0500, Derek Foreman wrote: > This prevents the rotation mouse bind from rotating pop-up menus > directly by using a shell surface's eldest parent instead. > > Signed-off-by: Derek Foreman > --- > desktop-shell/shell.c | 6 ++ > 1 file changed, 6 insertions

Re: [PATCH weston] tests: Remove the redundant NULL checks

2015-09-03 Thread Bryce Harrington
On Fri, Sep 04, 2015 at 12:17:18AM +0530, Seedo Eldho Paul wrote: > xzalloc is guaranteed to return a non-NULL value. > > Signed-off-by: Seedo Eldho Paul > --- > tests/internal-screenshot-test.c | 13 - > 1 file changed, 13 deletions(-) Good point. The error handling code will neve

[PATCH weston] tests: Remove the redundant NULL checks

2015-09-03 Thread Seedo Eldho Paul
xzalloc is guaranteed to return a non-NULL value. Signed-off-by: Seedo Eldho Paul --- tests/internal-screenshot-test.c | 13 - 1 file changed, 13 deletions(-) diff --git a/tests/internal-screenshot-test.c b/tests/internal-screenshot-test.c index e72a695..a74ae7a 100644 --- a/tests/i

[ANNOUNCE] libinput 1.0.1

2015-09-03 Thread Peter Hutterer
libinput 1.0.1 is now available. This release contains a bugfix affecting touchpads on the Lenovo x230. These devices require a custom acceleration method to make up for the buggy hardware. The change to unaccelerated scrolling in 1.0rc1 was missing these device-specific hooks and the scroll speed