Re: [PATCH weston v3 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2015-08-26 Thread Bryce Harrington
This patchset is looking reasonably ripe. If pq and/or derek give thumbs up, and you get a v4 turned around quickly (i.e. before the end of the month) with the changes mentioned in this thread, I wouldn't mind landing this for 1.9-beta. This seems relatively safe to me, as it isn't invasive into

Re: [PATCH weston v3 4/5] clients: Add pointer gesture support to weston-eventdemo

2015-08-26 Thread Bryce Harrington
On Fri, Jul 31, 2015 at 03:59:54PM +0200, Carlos Garnacho wrote: > Just print the output, as with the other events. > > Signed-off-by: Carlos Garnacho > Reviewed-by: Jonas Ådahl One minor comment, but otherwise LGTM: Reviewed-by: Bryce Harrington > --- > clients/eventdemo.c | 108 > +++

Re: [PATCH weston v4] clients: Request the wl_pointer_gesture_swipe/pinch interfaces

2015-08-26 Thread Bryce Harrington
On Wed, Aug 05, 2015 at 04:03:21PM +0200, Carlos Garnacho wrote: > This is accompanied by separate handlers for the different stages > of swipe/pinch gestures, so those can be set in demos. > > v4: Indenting fix. > v3: added null checks around pointer gesture interface destruction, > nullify a

Re: [PATCH weston v4] compositor: Implement wl_pointer_gesture_swipe/pinch interfaces

2015-08-26 Thread Bryce Harrington
On Wed, Aug 05, 2015 at 04:02:05PM +0200, Carlos Garnacho wrote: > These are obtained from the _wl_pointer_gestures global resource, > although each pointer will maintain the resources list and additional > information for the pinch/swipe gestures. The lifetime and focus > management of gesture res

Re: [PATCH weston v3 2/5] compositor: Implement wl_pointer_gesture_swipe/pinch interfaces

2015-08-26 Thread Bryce Harrington
On Fri, Jul 31, 2015 at 03:59:52PM +0200, Carlos Garnacho wrote: > These are obtained from the _wl_pointer_gestures global resource, > although each pointer will maintain the resources list and additional > information for the pinch/swipe gestures. The lifetime and focus > management of gesture res

Re: [PATCH weston v3 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2015-08-26 Thread Bryce Harrington
On Fri, Jul 31, 2015 at 03:59:51PM +0200, Carlos Garnacho wrote: > The whole feature is exposed by the wl_pointer_gestures global > resource, which can be used to obtain individual swipe/pinch > gesture interfaces for a given wl_pointer. > > The lifetime and progress of gestures is maintained by t

[PATCH weston 1/2] clients: try harder to discard motion after resize

2015-08-26 Thread Derek Foreman
If we're going to ignore motion below and to the right when coming out of maximize, we should probably also ignore it above and to the left. Signed-off-by: Derek Foreman --- clients/window.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.

[PATCH weston 2/2] clients: don't discard motion if we have a grab

2015-08-26 Thread Derek Foreman
We discard motion outside the window on the assumption it's from before some event that caused the window to shrink. However, if we have a grab it's likely that this motion is actually from dragging from the inside of the window out. This fixes a problem where drag selecting in weston terminal beh

Testing static functions in testsuite (was Re: [PATCH weston 2/3] drm: port the drm backend to the new init api)

2015-08-26 Thread Bryce Harrington
On Wed, Aug 26, 2015 at 04:35:59PM +0300, Pekka Paalanen wrote: > On Tue, 25 Aug 2015 14:24:23 -0700 > Bryce Harrington wrote: > > On Tue, Aug 25, 2015 at 09:03:36AM -0700, Jon A. Cruz wrote: > > > On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > > > > How would you suggest we arrange the source co

Re: [PATCH v3 weston] Introduce pointer locking and confinement protocol

2015-08-26 Thread Derek Foreman
On 23/08/15 10:19 PM, Jonas Ådahl wrote: > On Sat, Aug 22, 2015 at 06:49:15PM -0500, Derek Foreman wrote: >> Hi Jonas, >> >> Instead of a reasonable review, I'm going to mostly ask a bunch of noob >> questions. Feel free to disregard if you don't have time to enlighten me... > > Thanks for the in

Re: [PATCH weston] build, compositor-drm: fix output name constants another way

2015-08-26 Thread Bryce Harrington
On Wed, Aug 26, 2015 at 11:05:28AM +0100, Daniel Stone wrote: > Hi, > > On 25 August 2015 at 00:32, Bryce Harrington wrote: > > On Mon, Aug 24, 2015 at 12:32:33PM -0500, Derek Foreman wrote: > >> On 24/08/15 06:27 AM, Pekka Paalanen wrote: > >> > From: Pekka Paalanen > >> > > >> > Bumping libdrm

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-26 Thread Pekka Paalanen
Hi On Tue, 25 Aug 2015 14:24:23 -0700 Bryce Harrington wrote: > On Tue, Aug 25, 2015 at 09:03:36AM -0700, Jon A. Cruz wrote: > > On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > > > How would you suggest we arrange the source code such that we can pick > > > arbitrary functions for unit tests wi

Re: [PATCH weston] build, compositor-drm: fix output name constants another way

2015-08-26 Thread Daniel Stone
Hi, On 25 August 2015 at 00:32, Bryce Harrington wrote: > On Mon, Aug 24, 2015 at 12:32:33PM -0500, Derek Foreman wrote: >> On 24/08/15 06:27 AM, Pekka Paalanen wrote: >> > From: Pekka Paalanen >> > >> > Bumping libdrm requirement by 3 years just for output connector name >> > constants was a bi

Re: [PATCH weston v2] ivi-layout: implement surface clipping

2015-08-26 Thread Pekka Paalanen
On Mon, 24 Aug 2015 17:34:09 -0700 Bryce Harrington wrote: > On Mon, Aug 24, 2015 at 01:21:21PM +0300, Pekka Paalanen wrote: > > On Mon, 24 Aug 2015 10:24:15 +0900 > > Nobuhiko Tanibata wrote: > > > > > From: Nobuhiko Tanibata > > > > > > View clip region is set in surface-local coordinates.