Re: [PATCH weston] build: Require newer version of libdrm

2015-08-21 Thread Bryce Harrington
On Fri, Aug 21, 2015 at 11:06:02PM -0500, Derek Foreman wrote: > commit 89c49b3060a115e846ba1e7fbef94d14894244f2 changed the way we name > outputs, but it also added the new output names VIRTUAL and DSI. > > These aren't available until libdrm 2.4.59 Ubuntu 14.04 appears to have 2.4.60. Presumab

Re: [PATCH libinput] doc: fix more typos

2015-08-21 Thread Peter Hutterer
On Fri, Aug 21, 2015 at 08:42:54AM -0700, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke merged, thanks. Cheers, Peter > --- > doc/absolute-axes.dox | 2 +- > doc/faqs.dox | 2 +- > doc/gestures.dox | 2 +- > doc/palm-detection.dox | 4 ++-- > doc/reporting-bugs.dox |

[PATCH weston] build: Require newer version of libdrm

2015-08-21 Thread Derek Foreman
commit 89c49b3060a115e846ba1e7fbef94d14894244f2 changed the way we name outputs, but it also added the new output names VIRTUAL and DSI. These aren't available until libdrm 2.4.59 Signed-off-by: Derek Foreman --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c

Re: [PATCH libinput] RFC on quirk handling in libinput

2015-08-21 Thread Peter Hutterer
On 22/08/2015 06:33 , Andreas Pokorny wrote: Hi, The patch in the follow up mail describes a quirk needed to handle the touchscreen for a range of mediatek based devices. Depending on how the touch screen is wired to the soc, it always would report maximum == minimum == 0 for ABS_MT_TRACKING_ID.

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Prabhu S
Below is the case where I'm getting stuck with the actual test case. Wondering why there is no callback wl_callb...@25.done or wl_buffer@29.release The EGL implementation depends on these callback/buffer release. Also noticed if the valid buffer is attached immediately after null buffer, everything

[PATCH libinput] quirk for mtk kernels

2015-08-21 Thread Andreas Pokorny
Signed-off-by: Andreas Pokorny --- src/evdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 29303f8..1373e6f 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1886,6 +1886,16 @@ evdev_check_min_max(struct evdev_device *device, unsigned int code)

[PATCH libinput] RFC on quirk handling in libinput

2015-08-21 Thread Andreas Pokorny
Hi, The patch in the follow up mail describes a quirk needed to handle the touchscreen for a range of mediatek based devices. Depending on how the touch screen is wired to the soc, it always would report maximum == minimum == 0 for ABS_MT_TRACKING_ID. Whats the best way to handle this sort of brok

Re: wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Jasper St. Pierre
We need to fix that documentation, then, along with fixing Weston. mutter will give you an error with this event stream, since attaching a NULL buffer for an xdg_surface is invalid. This behavior is one of the reasons why I removed this ability from xdg_surface and instead made it an error -- the

wl_surface.attach with NULL wl_buffer behaviour

2015-08-21 Thread Prabhu S
Hi, Based on the wayland protocol specification for wl_surface::attach >>If wl_surface.attach is sent with a NULL wl_buffer, the following wl_surface.commit will remove the surface content. Wondering if wl_surface_attach called with wl_buffer=NULL, will there be any wl_buffer release event or fram

[PATCH libinput] doc: fix more typos

2015-08-21 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- doc/absolute-axes.dox | 2 +- doc/faqs.dox | 2 +- doc/gestures.dox | 2 +- doc/palm-detection.dox | 4 ++-- doc/reporting-bugs.dox | 2 +- doc/seats.dox | 4 ++-- doc/tapping.dox| 2 +- doc/tools.dox | 4 ++-- doc/touchp

Re: [PATCH weston 1/3] clients: Drop deadlock circumvention hack now that we don't need it

2015-08-21 Thread Jonas Ådahl
On Fri, Aug 21, 2015 at 04:09:20PM +0300, Pekka Paalanen wrote: > On Wed, 19 Aug 2015 11:15:21 -0500 > Derek Foreman wrote: > > > On 26/01/15 04:19 AM, Jonas Ådahl wrote: > > > mesa supports EGLSwapInterval 0 now, so lets remove this hack. As a > > > bonus we don't conflict with the XDG shell pro

Re: [PATCH weston v2] clients: Require EGL_MIN_SWAP_INTERVAL to be 0 for subsurfaces

2015-08-21 Thread Jonas Ådahl
On Fri, Aug 21, 2015 at 04:05:34PM +0300, Pekka Paalanen wrote: > On Tue, 27 Jan 2015 10:47:29 +0800 > Jonas Ådahl wrote: > > > Warn and fail when assert to create sub surfaces when swap interval 0 is > > not supported by the EGL platform. > > > > Programs wanting to add subsurfaces need to chec

[PATCH libinput] libinput: add orientation and size of touch point and pressure to the API

2015-08-21 Thread Andreas Pokorny
This change adds four new properties to touch events: * major: diameter of the touch ellipse along the major axis * minor: diameter perpendicular to major axis * pressure: a pressure value mapped into the range [0, 1] * orientation: the angle between major and the x axis [0, 360] Those values are

[PATCH libinput] libinput: add orientation and size of touch point and pressure to the API

2015-08-21 Thread Andreas Pokorny
This change adds four new properties to touch events: * major: diameter of the touch ellipse along the major axis * minor: diameter perpendicular to major axis * pressure: a pressure value mapped into the range [0, 1] * orientation: the angle between major and the x axis [0, 360] Those values are

Re: [PATCH weston 1/3] clients: Drop deadlock circumvention hack now that we don't need it

2015-08-21 Thread Pekka Paalanen
On Wed, 19 Aug 2015 11:15:21 -0500 Derek Foreman wrote: > On 26/01/15 04:19 AM, Jonas Ådahl wrote: > > mesa supports EGLSwapInterval 0 now, so lets remove this hack. As a > > bonus we don't conflict with the XDG shell protocol that doesn't allow > > committing a null-buffer, which was a side effe

Re: [PATCH weston v2] clients: Require EGL_MIN_SWAP_INTERVAL to be 0 for subsurfaces

2015-08-21 Thread Pekka Paalanen
On Tue, 27 Jan 2015 10:47:29 +0800 Jonas Ådahl wrote: > Warn and fail when assert to create sub surfaces when swap interval 0 is > not supported by the EGL platform. > > Programs wanting to add subsurfaces need to check whether it is > subsurfaces are supported by the display with the new > disp

Re: [PATCH weston] gl-renderer: gl_renderer_create display cleanup on error

2015-08-21 Thread Pekka Paalanen
On Fri, 21 Aug 2015 00:20:54 -0300 Dawid Gajownik wrote: > Clean up display connection via eglTerminate() in case of EGL > initialisation error. > > Signed-off-by: Dawid Gajownik > --- > src/gl-renderer.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gl-rende

Re: [PATCH weston] compositor-drm: rename outputs to follow kernel style

2015-08-21 Thread Pekka Paalanen
On Thu, 20 Aug 2015 11:05:39 -0700 Bryce Harrington wrote: > On Thu, Aug 20, 2015 at 10:04:45AM +0300, Pekka Paalanen wrote: > > On Wed, 19 Aug 2015 10:46:41 -0500 > > Derek Foreman wrote: > > > > > Excellent! > > > > > > Incidentally, this is also how Enlightenment names its outputs. > > > >

Re: [PATCH libinput 2/2] enable -Wall -Werror for CFLAGS

2015-08-21 Thread Peter Hutterer
On 21/08/2015 21:04 , Andreas Pokorny wrote: Hi, The sole purpose of Werror is to keep warnings out. But libinput already did a good job without Wall + Werror being enabled. yeah, fwiw, the general rule is that patches that introduce warnings won't get merged. On Fri, Aug 21, 2015 at 4:05

Re: [PATCH weston] compositor-drm: rename outputs to follow kernel style

2015-08-21 Thread Pekka Paalanen
On Wed, 19 Aug 2015 15:54:30 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > The problem with the old table of names is that it contains duplicates. > It is possible to end up with multiple outputs with the same name. In > that case you cannot write individual configurations for these ou

Re: [PATCH libinput 2/2] enable -Wall -Werror for CFLAGS

2015-08-21 Thread Andreas Pokorny
Hi, The sole purpose of Werror is to keep warnings out. But libinput already did a good job without Wall + Werror being enabled. On Fri, Aug 21, 2015 at 4:05 AM, Peter Hutterer wrote: > On Thu, Aug 20, 2015 at 02:32:23PM +0300, Pekka Paalanen wrote: > > On Thu, 20 Aug 2015 12:51:38 +0200 > > An

Re: [PATCH weston 0/3] ivi-shell: Bugfix for ivi_layout_screen/layer_render_order

2015-08-21 Thread Pekka Paalanen
On Thu, 20 Aug 2015 14:13:26 + "Ucan, Emre (ADITG/SW1)" wrote: > Hi all, > > First two patches are actually new versions of my previous patches, > but I wrote different commit summaries for them, because they were > too long. > > The last patch removes redundant wl_list_empty/init calls as

Re: [PATCH weston 2/3] ivi-shell: clear order.layer_list before reordering it

2015-08-21 Thread Pekka Paalanen
On Thu, 20 Aug 2015 11:52:47 -0700 Bill Spitzak wrote: > On Thu, Aug 20, 2015 at 7:13 AM, Ucan, Emre (ADITG/SW1) < > eu...@de.adit-jv.com> wrote: > > > > > Checking wl_list_empty() on a link offers no information: if it returns > > true, wl_list_remove() is safe to do. If it returns false, you s

Re: [PATCH weston] compositor-drm: rename outputs to follow kernel style

2015-08-21 Thread Pekka Paalanen
On Thu, 20 Aug 2015 11:05:39 -0700 Bryce Harrington wrote: > On Thu, Aug 20, 2015 at 10:04:45AM +0300, Pekka Paalanen wrote: > > On Wed, 19 Aug 2015 10:46:41 -0500 > > Derek Foreman wrote: > > > > > Excellent! > > > > > > Incidentally, this is also how Enlightenment names its outputs. > > > >

Re: [PATCH wayland] Revert "client: require WAYLAND_DISPLAY to be set"

2015-08-21 Thread Pekka Paalanen
On Thu, 20 Aug 2015 16:24:10 -0700 Bryce Harrington wrote: > On Thu, Aug 20, 2015 at 02:18:07PM -0400, Ray Strode wrote: > > Hi, > > > > > All of these arguments makes sense, so I guess I agree with reverting this > > > change. > > +1 > > Reviewed-by: Bryce Harrington > > > Great. pq are go