[PATCH libinput] touchpad: enable natural scrolling for edge scrolling

Instead of going straight to pointer_notify_axis, go through evdev_notify_axis() which flips the scroll direction around for us. https://bugs.freedesktop.org/show_bug.cgi?id=91597 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 20 ++-- src/evdev.c

Re: [PATCH libinput 03/16] filter: rename speed to speed_ranged where it's in the [-1, 1] range

On Mon, Aug 10, 2015 at 04:20:50PM +0800, Jonas Ådahl wrote: > On Wed, Aug 05, 2015 at 04:32:32PM +1000, Peter Hutterer wrote: > > To avoid confusion with the other speed in units/time > > > > Signed-off-by: Peter Hutterer > > --- > > src/filter-private.h | 4 ++-- > > src/filter.c | 18

Re: [PATCH libinput 05/16] filter: add two helper functions to convert between speeds

On Mon, Aug 10, 2015 at 04:21:17PM +0800, Jonas Ådahl wrote: > On Wed, Aug 05, 2015 at 04:32:34PM +1000, Peter Hutterer wrote: > > This makes it more obvious where we're using units/us and units/ms as input > > variable and what the output is. Clutters up the code, but still better than > > dealing

Re: [PATCH libinput 16/16] tools: add shell script for making the pointer acceleration graphs in the docs

On Mon, Aug 10, 2015 at 04:23:34PM +0800, Jonas Ådahl wrote: > On Wed, Aug 05, 2015 at 04:32:45PM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > tools/Makefile.am | 2 ++ > > tools/make-ptraccel-graphs.sh | 79 > > +

Re: [PATCH libinput 12/16] filter: duplicate the code for the Lenovo x230 accel method

On Mon, Aug 10, 2015 at 04:22:40PM +0800, Jonas Ådahl wrote: > On Wed, Aug 05, 2015 at 04:32:41PM +1000, Peter Hutterer wrote: > > This is "once-tested, don't touch it again" code. The quirks on the touchpad > > means we'd have to find that specific device again and re-test everything if > > we cha

Re: [PATCH weston] weston-launch: On error putenv returns a non-zero value

On Sun, Aug 09, 2015 at 12:50:40PM -0300, Dawid Gajownik wrote: > According to POSIX standard "upon successful completion, putenv() shall > return 0; otherwise, it shall return a non-zero value." Unlike in > setenv() we should not be checking only for negative values. > > Signed-off-by: Dawid Gajo

Re: [PATCH libinput] udev: use prop_value() to fetch the ID_INPUT_PROP property

Hi, On 05-08-15 03:31, Peter Hutterer wrote: This will thus work if the property is only set on a parent device, not on the device directly. https://github.com/systemd/systemd/issues/763 Signed-off-by: Peter Hutterer LGTM: Reviewed-by: Hans de Goede Regards, Hans --- udev/libinput-mo

Re: [PATCH libinput] evdev: split scroll threshold and direction lock threshold into two

Hi, On 05-08-15 03:45, Peter Hutterer wrote: The previous code used a 5mm threshold before axis events were posted. This threshold was on top of the 2mm 2fg threshold (and timeout handling) in the gesture code and effectively prevented events from being sent after a timeout, or in the 2mm-5mm ra

Re: [PATCH libinput 16/16] tools: add shell script for making the pointer acceleration graphs in the docs

On Wed, Aug 05, 2015 at 04:32:45PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > tools/Makefile.am | 2 ++ > tools/make-ptraccel-graphs.sh | 79 > +++ > 2 files changed, 81 insertions(+) > create mode 100755 tools/make-

Re: [PATCH libinput 14/16] tools: allow filter-switching in ptraccel-debug

On Wed, Aug 05, 2015 at 04:32:43PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > tools/ptraccel-debug.c | 43 --- > 1 file changed, 36 insertions(+), 7 deletions(-) > > diff --git a/tools/ptraccel-debug.c

Re: [PATCH libinput 11/16] filter: split out handling of the low-dpi accel method

On Wed, Aug 05, 2015 at 04:32:40PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 34 -- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/src/filter.c b/src/filter.c > index 68f178

Re: [PATCH libinput 13/16] filter: split trackpoint acceleration out

On Wed, Aug 05, 2015 at 04:32:42PM +1000, Peter Hutterer wrote: > This is step one to fixing trackpoint acceleration, separating it from the > other acceleration code. No functional changes yet, it still uses the low-dpi > accel method. > > https://bugs.freedesktop.org/show_bug.cgi?id=91369 > > S

Re: [PATCH libinput 12/16] filter: duplicate the code for the Lenovo x230 accel method

On Wed, Aug 05, 2015 at 04:32:41PM +1000, Peter Hutterer wrote: > This is "once-tested, don't touch it again" code. The quirks on the touchpad > means we'd have to find that specific device again and re-test everything if > we change anything elsewhere in the code. So duplicate it properly, so that

Re: [PATCH libinput 10/16] filter: split calculating the accel factor into a helper function

On Wed, Aug 05, 2015 at 04:32:39PM +1000, Peter Hutterer wrote: > No functional changes. > > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 35 +-- > 1 file changed, 25 insertions(+), 10 deletions(-) > > diff --git a/src/filter.c

Re: [PATCH libinput 09/16] filter: revamp to create device-specific filters, rather than accel functions

On Wed, Aug 05, 2015 at 04:32:38PM +1000, Peter Hutterer wrote: > The previous approach to pointer acceleration was to initialize the same > motion filter behavior but a different acceleration profile depending on the > hardware (the profile converts a speed to a multiplier for input deltas). > >

Re: [PATCH libinput 07/16] filter: drop accel->last, write-only value

On Wed, Aug 05, 2015 at 04:32:36PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/filter.c b/src/filter.c > index 4f0d8d5..29bf8e5 100644 > --- a/src/filter.c > +++ b/s

Re: [PATCH libinput 08/16] filter: move create_pointer_accelerator_filter down in the file

On Wed, Aug 05, 2015 at 04:32:37PM +1000, Peter Hutterer wrote: > No functional changes, just moving code in preparation for filter patches > > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 70 > ++-- > 1

Re: [PATCH libinput 06/16] filter: explain the acceleration function in detail

On Wed, Aug 05, 2015 at 04:32:35PM +1000, Peter Hutterer wrote: > And switch to a code-flow that's a bit more self-explanatory than the current > min/max combinations. > > Signed-off-by: Peter Hutterer Much much more easy to follow now. Most of the reviewing time of this patch was trying to re-u

Re: [PATCH libinput 05/16] filter: add two helper functions to convert between speeds

On Wed, Aug 05, 2015 at 04:32:34PM +1000, Peter Hutterer wrote: > This makes it more obvious where we're using units/us and units/ms as input > variable and what the output is. Clutters up the code, but still better than > dealing with us/ms differently per function, and still better than carrying

Re: [PATCH libinput 04/16] filter: rename speed_out to "factor" for the touchpad profiles

On Wed, Aug 05, 2015 at 04:32:33PM +1000, Peter Hutterer wrote: > The return value of a profile is a unitless factor, not a speed. > Same applies for s1/s2, these are factors, not speeds. > > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 46

Re: [PATCH libinput 03/16] filter: rename speed to speed_ranged where it's in the [-1, 1] range

On Wed, Aug 05, 2015 at 04:32:32PM +1000, Peter Hutterer wrote: > To avoid confusion with the other speed in units/time > > Signed-off-by: Peter Hutterer > --- > src/filter-private.h | 4 ++-- > src/filter.c | 18 +- > 2 files changed, 11 insertions(+), 11 deletions(-) >

Re: [PATCH libinput 02/16] filter: drop superfluous struct declaration

On Wed, Aug 05, 2015 at 04:32:31PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl > --- > src/filter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/filter.c b/src/filter.c > index b01b68a..e615deb 100644 > --- a/src/filter.c > +++ b/src/fi

Re: [PATCH libinput 01/16] Revert "filter: move the pointer acceleration profiles back to units/ms"

On Wed, Aug 05, 2015 at 04:32:30PM +1000, Peter Hutterer wrote: > This reverts commit 8a6825f1602aa9d9c4b29a83d296f55f68b316e0. > > Aside from introducing bugs, this doesn't really help with anything, it adds a > requirement to rename everything to make clear where we're using µs and where > we're