Dear all:
Could I close the lock in desktop shell? If set "locking=false" in Weston.ini,
it only close the screensaver. How to not lock the screen? Thank you.
Is it good if I modify the code shell_fade_done()?
case FADE_OUT:
- lock(shell);
+ //lock(shell);
Be
On Wed, Aug 05, 2015 at 11:28:43AM +0800, jackie.hu...@windriver.com wrote:
> From: Jackie Huang
>
> Add arg --with-libunwind for configure so it's optional to check
> libunwind, which is helpfull to make deterministic builds.
>
> Signed-off-by: Jackie Huang
merged, thanks.
Cheers,
Peter
The api, ivi_layout_layer_remove_surface, shall remove a ivi_surface
from a list of ivi_layer. In previous code, there is no trigger to
refresh order of list, removing the ivi_surface, in commit_layer_list.
To fix this bug, set a mask; IVI_NOTIFICATION_REMOVE in order to trigger
refresh list of su
This annoys me when using Valgrind.
Reviewed-by: Ryo Munakata
Thank you.
On Thu, 6 Aug 2015 12:19:51 -0500
Derek Foreman wrote:
> If we destroy all the devices before trying to remove keyboard focus
> we'll segfault because we destroyed the keyboard.
>
> Signed-off-by: Derek Foreman
> ---
On 06/08/15 07:12 PM, Dawid Gajownik wrote:
> On Wed, Aug 5, 2015 at 6:20 PM, Derek Foreman wrote:
>> Good catch!
>>
>> However, can we get the same result by making weston_output_init() call
>> wl_list_init(&output->link)?
>>
>> I think that'd be simple enough not to require a comment to explain
On Wed, Aug 5, 2015 at 6:20 PM, Derek Foreman wrote:
> Good catch!
>
> However, can we get the same result by making weston_output_init() call
> wl_list_init(&output->link)?
>
> I think that'd be simple enough not to require a comment to explain
> what's going on...
Indeed, you're right. I tested
When the output can't be completely created in the backend (for example
lack of memory), weston_compositor_add_output() is never run. In such
a case output->link is not initialized. Letter, when
weston_output_destroy() is called, application crashes on
wl_list_remove(&output->link).
This problem h
On Wed, Aug 05, 2015 at 03:24:01PM -0500, Derek Foreman wrote:
> On 05/08/15 03:05 PM, Dawid Gajownik wrote:
> > On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman
> > wrote:
> >> This looks good to me barring two tiny style nits below.
> >> That fixed,
> >> Reviewed-by: Derek Foreman
> >
> > Thanks
This all looks ok to me, and it's not too bad for stomping all over
heavily contested files.
Reviewed-by: Derek Foreman
On 06/08/15 03:12 PM, Dawid Gajownik wrote:
> - opening braces are on the same line as the if statement
> - opening braces are not on the same line as the function name
> - sp
Le 05/08/2015 22:20, Derek Foreman a écrit :
> On 05/08/15 03:21 PM, Dawid Gajownik wrote:
>> When something goes wrong during weston initialization,
>> weston_compositor_destroy() is executed. It destroys the backend and
>> then frees compositor memory. Unfortunately RDP backend is not correctly
>
- opening braces are on the same line as the if statement
- opening braces are not on the same line as the function name
- space between for/while/if and opening parenthesis
Signed-off-by: Dawid Gajownik
---
clients/eventdemo.c | 8 +++---
clients/ivi-shell-user-interface.c
As this is the oldest patch in patchwork, I figured I'd test it out and
see if we can land it. :)
On 08/01/15 10:57 AM, Jason Ekstrand wrote:
> Previously, we blindly created a mode for the output based on surface size
> and completely ignoring the output transform. This caused modesets to fail
If we destroy all the devices before trying to remove keyboard focus
we'll segfault because we destroyed the keyboard.
Signed-off-by: Derek Foreman
---
src/libinput-seat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libinput-seat.c b/src/libinput-seat.c
index e6d44b
On Fri, 29 May 2015 10:46:44 -0500
Derek Foreman wrote:
Hi all.
I sent an almost same patch to ML recently, which means this problem hasn't
been fixed.
So now:
Reviewed-by: Ryo Munakata
This patch has been forgotten for a long time.
Please push it unless anyone has issues with it.
> This pr
From: Jackie Huang
Add arg --with-libunwind for configure so it's optional to check
libunwind, which is helpfull to make deterministic builds.
Signed-off-by: Jackie Huang
---
configure.ac | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/co
Hi,
On 08/06/2015 01:49 PM, Davide Bettio wrote:
Hello,
On 2015-08-06 10:37, Marek Chalupa wrote:
the patch does not apply in the first place:
Applying: Extend WAYLAND_DISPLAY and name parameter semantics to
support absolute paths.
fatal: corrupt patch at line 15
Repository lacks necessary bl
Hello,
On 2015-08-06 10:37, Marek Chalupa wrote:
the patch does not apply in the first place:
Applying: Extend WAYLAND_DISPLAY and name parameter semantics to
support absolute paths.
fatal: corrupt patch at line 15
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back t
Extend WAYLAND_DISPLAY and name parameter semantics to
support absolute paths. For example WAYLAND_DISPLAY="/my/path/wayland-2"
or
connect_to_socket("/my/path/wayland-2").
Signed-off-by: Davide Bettio
---
doc/man/wl_display_connect.xml | 8
src/wayland-client.c | 36
+
Hi,
On 30 July 2015 at 03:33, Jonas Ådahl wrote:
> One of the principles of Wayland is that object creation never fails. If
> the object cannot be created, it should be reported as a protocol error
> and an offending client should be terminated.
>
> A current violation to this principle is the in
Hey,
Just to clarify my review of this series. I like WAYLAND_DISPLAY being
able to handle absolute paths. I'm in for adding
WAYLAND_SERVER_SOCKET_DIR, because currently it is the only way how to
customize wl_display_add_socket_auto (In the future we could add
something like wl_display_add_so
Hi,
On 07/29/2015 11:23 AM, Davide Bettio wrote:
Introduce WAYLAND_SERVER_SOCKET_DIR to change socket
directory without changing XDG_RUNTIME_DIR. This might be useful to change
socket directory in case wl_display_add_socket_auto is used. For example
this
will change the socket path for weston wi
Hi,
IMO it would be better to implement this functionality in the compositor
(command line argument or so) instead of adding new env var. Or is there
a reason it must be env var?
However, it is just my point of view, I don't want to block this patch.
Regards,
Marek
On 07/28/2015 05:51 PM, Da
Hi,
the patch does not apply in the first place:
Applying: Extend WAYLAND_DISPLAY and name parameter semantics to support
absolute paths.
fatal: corrupt patch at line 15
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Most of my comment regar
Hi,
On 31 July 2015 at 10:02, Elvis Lee wrote:
> proxy_destroy could be called twice by wl_proxy_destroy and
> wl_event_queue_release.
> Then, wl_map_remove was called twice for same object id.
>
> Signed-off-by: Elvis Lee
> ---
> src/wayland-client.c | 10 ++
> 1 file changed, 6 ins
24 matches
Mail list logo
