Re: [PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

2015-08-05 Thread Nobuhiko Tanibata
2015-08-06 02:15 に Derek Foreman さんは書きました: On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote: Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface belongs to, in order to trigger refreshing a list of surface in ivi_layout_layer. Signed-off-by: Nobuhiko Tanibata --- ivi-shell

Re: [PATCH] desktop-shell: fix bug referencing invalid surface list

2015-08-05 Thread Ryo Munakata
Hi Derek. On 08/05, Derek Foreman wrote: > On 29/07/15 01:12 PM, Ryo Munakata wrote: > > In shell_destroy_shell_surface, we remove the link of a shell_surface. > > There is a case which the link references shell_client::surface_list > > which is already free'd. > > Therefore we have to remove shel

Re: [PATCH] desktop-shell: fix bug referencing invalid surface list

2015-08-05 Thread Derek Foreman
On 29/07/15 01:12 PM, Ryo Munakata wrote: > In shell_destroy_shell_surface, we remove the link of a shell_surface. > There is a case which the link references shell_client::surface_list > which is already free'd. > Therefore we have to remove shell_client::surface_list when freeing > a shell_client

Re: [PATCH weston] compositor: fix crash when destroying incompletely created output

2015-08-05 Thread Derek Foreman
On 30/07/15 08:23 PM, Dawid Gajownik wrote: > When output can't be created in foo_backend_create_output(), > weston_output_destroy() is called without executing > weston_compositor_add_output(). In such a case output->link is not initialized > and causes application crash on wl_list_remove(&output-

Re: [PATCH weston v2] backends: don't destroy renderer and output twice

2015-08-05 Thread Derek Foreman
Looks good Reviewed-by: Derek Foreman On 30/07/15 10:02 PM, Dawid Gajownik wrote: > drm, fbdev, rpi and wayland backends are unnecessarily destroying > renderer and output before executing weston_compositor_shutdown() > > Signed-off-by: Dawid Gajownik > --- > src/compositor-drm.c | 1 - >

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 03:05 PM, Dawid Gajownik wrote: > On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman wrote: >> This looks good to me barring two tiny style nits below. >> That fixed, >> Reviewed-by: Derek Foreman > > Thanks for the information. Does Weston follow the same coding style > as Wayland [1]? T

Re: [PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 03:21 PM, Dawid Gajownik wrote: > When something goes wrong during weston initialization, > weston_compositor_destroy() is executed. It destroys the backend and > then frees compositor memory. Unfortunately RDP backend is not correctly > destroyed. It frees compositor instead of a backe

[PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend memory. This causes later a double free error. Th

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman wrote: > This looks good to me barring two tiny style nits below. > That fixed, > Reviewed-by: Derek Foreman Thanks for the information. Does Weston follow the same coding style as Wayland [1]? The mistakes that I made are also present in other files

Re: [PATCH weston v2] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 02:49 PM, Dawid Gajownik wrote: > When something goes wrong during weston initialization, > weston_compositor_destroy() is executed. It destroys the backend and > then frees compositor memory. Unfortunately RDP backend is not correctly > destroyed. It frees compositor instead of a backe

[PATCH weston v2] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend memory. This causes later a double free error. Th

[PATCH weston] desktop-shell: Make resize and move functions take a pointer instead of a seat

2015-08-05 Thread Derek Foreman
An earlier patch made surface_resize() and surface_move() take pointers instead of seats, this updates the weston_shell_interface resize and move to match. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 8 src/compositor.h | 5 +++-- xwayland/window-manager.c |

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
This looks good to me barring two tiny style nits below. That fixed, Reviewed-by: Derek Foreman CC'd David in case he has objections. On 31/07/15 06:10 PM, Dawid Gajownik wrote: > When something goes wrong during weston initialization, > weston_compositor_destroy() is executed. It destroys the b

Re: [PATCH] [RDP compositor] don't crash when the key file doesn't exist

2015-08-05 Thread Derek Foreman
On 01/08/15 05:35 PM, David FORT wrote: > This allows to close the remaining issue in > https://bugs.freedesktop.org/show_bug.cgi?id=91390 > --- > src/compositor-rdp.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/compositor-rdp.c b/src/compositor-rd

Re: [PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

2015-08-05 Thread Derek Foreman
On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote: > Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface > belongs to, in order to trigger refreshing a list of surface in > ivi_layout_layer. > > Signed-off-by: Nobuhiko Tanibata > --- > ivi-shell/ivi-layout.c | 1 + > 1 file cha

Re: [PATCH weston] screen-share: don't test keyboard/pointer pointers

2015-08-05 Thread Derek Foreman
Oops, thanks Reviewed-by: Derek Foreman On 31/07/15 09:46 PM, Dawid Gajownik wrote: > Keyboards and pointers aren't freed when devices are removed, so we > should really be testing keyboard_device_count and pointer_device_count > in most cases, not the actual pointers. Otherwise we end up with >

[PATCH weston v4] clients: Request the wl_pointer_gesture_swipe/pinch interfaces

2015-08-05 Thread Carlos Garnacho
This is accompanied by separate handlers for the different stages of swipe/pinch gestures, so those can be set in demos. v4: Indenting fix. v3: added null checks around pointer gesture interface destruction, nullify afterwards. v2: depend on standalone protocol xml. Signed-off-by: Carlos Garn

[PATCH weston v4] compositor: Implement wl_pointer_gesture_swipe/pinch interfaces

2015-08-05 Thread Carlos Garnacho
These are obtained from the _wl_pointer_gestures global resource, although each pointer will maintain the resources list and additional information for the pinch/swipe gestures. The lifetime and focus management of gesture resources is thus attached to the pointer. The translation of libinput even

Re: [PATCH weston] build: install Weston protocol XML files #89966

2015-08-05 Thread Dawid Gajownik
On Wed, Aug 5, 2015 at 6:49 AM, Pekka Paalanen wrote: > Hi, Hi. > NAK. > > By policy, we do not install protocol XML files for extensions that > are not stable, or are intended to be private to Weston. > > Weston should install only the protocol files which are both stable > and intended for use

Re: [PATCH weston] build: install Weston protocol XML files #89966

2015-08-05 Thread Pekka Paalanen
On Wed, 5 Aug 2015 00:03:50 -0300 Dawid Gajownik wrote: > Protocol XML files are required by external applications. This patch > installs necessary files and makes them discoverable via pkg-config. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=89966 > > Signed-off-by: Dawid Gajownik

[PATCH] ivi-shell: bugfix, list of surfaces on a layer are cumulated when set render order is called several time in one commitchanges.

2015-08-05 Thread Nobuhiko Tanibata
The final list of surfaces of set render order shall be applied. So link of surfaces and list of surfaces in a layer shall be initialized. And then the order of surfaces shall be restructured. Signed-off-by: Nobuhiko Tanibata --- ivi-shell/ivi-layout.c | 14 +++--- 1 file changed, 7 inse