Re: [PATCH libinput 5/5] Change to micro seconds for measuring time internally

On Tue, Jul 28, 2015 at 12:47:06PM +0800, Jonas Ådahl wrote: > In order to provide higher precision event time stamps, change the > internal time measuring from milliseconds to microseconds. > Microseconds are chosen because it is the most fine grained time stamp > we can get from evdev. > > The A

Re: [PATCH libinput 3/5] test/pointer: Don't rely on velocities in direction change test

On Tue, Jul 28, 2015 at 12:47:04PM +0800, Jonas Ådahl wrote: > We currently rely on an extra millisecond being added by the filter > code to get a velocity that are small enough to not hit the max > acceleration limit. If this arbitrary millisecond is changed (for > example by changing the internal

Re: [PATCH libinput 4/5] timer: Warn about negative timer offsets

On Tue, Jul 28, 2015 at 12:47:05PM +0800, Jonas Ådahl wrote: > Even if it may be caused by extreme stalls, warn if the timer was set to > be triggered even before 'now' when it actually is triggered, as it is > more likely a programming error. > > Part of the reason for this commit was not to conv

Re: [PATCH libinput 2/5] Always use uint64_t for internal timestamp values

On Tue, Jul 28, 2015 at 12:47:03PM +0800, Jonas Ådahl wrote: > In most places we use 64 bit unsigned integers; lets be consistent and > use it everywhere. > > Signed-off-by: Jonas Ådahl Reviewed-by: Peter Hutterer Cheers, Peter > --- > src/evdev-mt-touchpad.h | 2 +- > src/evdev.c

Re: [PATCH libinput 1/5] test: Use ck_assert_double_ for checking doubles in some places

On Tue, Jul 28, 2015 at 12:47:02PM +0800, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Reviewed-by: Peter Hutterer Cheers, Peter > --- > test/litest.c | 4 ++-- > test/pointer.c | 36 +++- > 2 files changed, 25 insertions(+), 15 deletions(-) > > diff -

Re: [PATCH libinput 2/2] Ignore test devices for libinput contexts not run from the test suite

On Tue, Jul 28, 2015 at 04:20:29PM +1000, Peter Hutterer wrote: > On Tue, Jul 28, 2015 at 12:52:45PM +0800, Jonas Ådahl wrote: > > Add a LIBINPUT_TEST_DEVICE udev parameter to test devices created by > > the test suite. When an application tries to add such a device to the > > path backend or when

Re: [PATCH libinput 2/2] Ignore test devices for libinput contexts not run from the test suite

On Tue, Jul 28, 2015 at 12:52:45PM +0800, Jonas Ådahl wrote: > Add a LIBINPUT_TEST_DEVICE udev parameter to test devices created by > the test suite. When an application tries to add such a device to the > path backend or when the udev backend discoveres such a device, it will typo, "discovers" >

[PATCH libinput 2/2] Ignore test devices for libinput contexts not run from the test suite

Add a LIBINPUT_TEST_DEVICE udev parameter to test devices created by the test suite. When an application tries to add such a device to the path backend or when the udev backend discoveres such a device, it will be ignored. Only the context when run via the test suite will actually handle these devi

[PATCH libinput 1/2] test: Make udev path variables more explicitly named

This is to make room for more types of rules files. Signed-off-by: Jonas Ådahl --- test/Makefile.am | 4 ++-- test/litest.c| 18 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 1c2852e..a9ddc85 100644 --- a/test/M

[PATCH libinput 5/5] Change to micro seconds for measuring time internally

In order to provide higher precision event time stamps, change the internal time measuring from milliseconds to microseconds. Microseconds are chosen because it is the most fine grained time stamp we can get from evdev. The API is extended with high precision getters whenever the given information

[PATCH libinput 2/5] Always use uint64_t for internal timestamp values

In most places we use 64 bit unsigned integers; lets be consistent and use it everywhere. Signed-off-by: Jonas Ådahl --- src/evdev-mt-touchpad.h | 2 +- src/evdev.c | 6 +++--- src/evdev.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/evde

[PATCH libinput 3/5] test/pointer: Don't rely on velocities in direction change test

We currently rely on an extra millisecond being added by the filter code to get a velocity that are small enough to not hit the max acceleration limit. If this arbitrary millisecond is changed (for example by changing the internal time measurment to microseconds and adding just a microsecond instea

[PATCH libinput 1/5] test: Use ck_assert_double_ for checking doubles in some places

Signed-off-by: Jonas Ådahl --- test/litest.c | 4 ++-- test/pointer.c | 36 +++- 2 files changed, 25 insertions(+), 15 deletions(-) diff --git a/test/litest.c b/test/litest.c index d7769d5..2daf23a 100644 --- a/test/litest.c +++ b/test/litest.c @@ -2223,9 +2223,

[PATCH libinput 4/5] timer: Warn about negative timer offsets

Even if it may be caused by extreme stalls, warn if the timer was set to be triggered even before 'now' when it actually is triggered, as it is more likely a programming error. Part of the reason for this commit was not to convert the unsigned int to a signed int (which abs() does). Signed-off-by

[PATCH v2 weston] zoom: Store the seat that initiated a zoom

Track the seat that initiated a zoom instead of picking the first one. Previously, if there are multiple seats then any seat can adjust the zoom level but the zoom tracks the first seat's pointer. Now the zoom will follow the pointer of the seat that initiated the zoom. Additionally, if there's

Re: [PATCH v2 weston 4/4] zoom: Store the seat that initiated a zoom

On 23/07/15 07:58 PM, Bryce Harrington wrote: > On Thu, Jul 23, 2015 at 02:55:15PM -0500, Derek Foreman wrote: >> Track the seat that initiated a seat instead of picking the first one. > > initiated a zoom? ;-) Sigh. Yes. :) >> Previously, if there are multiple seats then any seat can adjust t

Re: [PATCH v2 weston 2/4] zoom: Call weston_output_activate_zoom() appropriately

On 23/07/15 07:02 PM, Bryce Harrington wrote: > On Thu, Jul 23, 2015 at 02:55:13PM -0500, Derek Foreman wrote: >> No longer call weston_output_update_zoom() when trying to zoom out >> on an unzoomed output. >> >> Add an assert() to make sure update_zoom is never called without an >> active zoom. >>

Re: Patchwork upgrade?

On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: > Hey Bryce, > > On 17 July 2015 at 21:19, Bryce Harrington wrote: > > Could I bother you to request we update patchwork on fdo? > > The latest version now displays counts of Acked/Reviewed/Tested which > > would be quite handy in pick

Re: [PATCH v2 libinput] touchpad: disable 2fg scrolling on Synaptics semi-mt touchpads

Hi, On 27-07-15 06:45, Peter Hutterer wrote: These touchpads have a terrible resolution when two fingers are down, causing scrolling to jump around a lot. That then turns into bug reports that we can't do much about, the data is simply garbage. https://bugs.freedesktop.org/show_bug.cgi?id=91135

Re: [PATCH v2 libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP

Hi, On 27-07-15 07:10, Peter Hutterer wrote: On the 4.1 kernels synaptics pretends to have 3 slots (the serial fw only does 2). This was added to avoid cursor jumps but has since been reverted for 4.2 (kernel commit dbf3c37086, 4.1.3 is still buggy). In some cases a TRIPLETAP may be triggered wi

Re: [PATCH wayland v2 2/2] scanner: get rid of leaks

On 07/23/2015 08:50 PM, Bryce Harrington wrote: On Thu, Jul 23, 2015 at 07:39:31AM +0200, Marek Chalupa wrote: Free all the memory we have allocated during running. v2.: split creating objects and getting rid of leaks into two patches move check for NULL description into free_des

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

Hi, thanks for review. On 07/23/2015 08:41 PM, Bryce Harrington wrote: On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote: wrap creating and initializing objects (structures) into functions and use them in the code. Signed-off-by: Marek Chalupa --- src/scanner.c | 158 +++