[PATCH libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP

2015-07-23 Thread Peter Hutterer
On the 4.1 kernels synaptics pretends to have 3 slots (the serial fw only does 2). This was added to avoid cursor jumps but has since been reverted. In some cases a TRIPLETAP may be triggered without slot 2 ever activating. While there are still those kernels out there, work around this bug by ope

Re: [PATCH 0/2] Misc fixes for the RDP compositor

2015-07-23 Thread Bryce Harrington
On Tue, Jul 21, 2015 at 02:38:08PM +0300, Pekka Paalanen wrote: > On Mon, 20 Jul 2015 14:39:19 +0200 > David FORT wrote: > > > Misc things fixed in the RDP compositor: > > * bad return value in backend_init, introduced by the libweston refactoring; > > * an initialization that was done too early

Re: [PATCH][V3][weston] build: mkdir target weston.ini directories before writing

2015-07-23 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 01:45:00PM +0200, Quentin Glidic wrote: > On 2015-07-17 13:33, Ross Burton wrote: > > In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini > > to > > be written before ivi-shell/ exists. Solve this by creating the target > > directory first. > > > >

Re: [PATCH v2 weston 4/4] zoom: Store the seat that initiated a zoom

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 02:55:15PM -0500, Derek Foreman wrote: > Track the seat that initiated a seat instead of picking the first one. initiated a zoom? ;-) > Previously, if there are multiple seats then any seat can adjust the zoom > level but the zoom tracks the first seat's pointer. > > No

Re: [PATCH v2 weston 3/4] zoom: Rename zoom_area_center_from_pointer to zoom_area_center_from_point

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 02:55:14PM -0500, Derek Foreman wrote: > It doesn't do anything with a pointer, and zoom can be initiated by the > keyboard, so the name was a little confusing. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington > --- > src/zoom.c | 6 +++--- > 1 file change

[PATCH libinput] touchpad: don't check clickfinger distance for three fingers

2015-07-23 Thread Peter Hutterer
It's reasonable to expect a thumb (or the other hand's index finger) to click a button while a finger is down for movement. It's less reasonable to expect this when two fingers are interacting with the touchpad, or when two fingers click the touchpad (even on a large touchpad that's an awkward posi

Re: [PATCH v2 weston 2/4] zoom: Call weston_output_activate_zoom() appropriately

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 02:55:13PM -0500, Derek Foreman wrote: > No longer call weston_output_update_zoom() when trying to zoom out > on an unzoomed output. > > Add an assert() to make sure update_zoom is never called without an > active zoom. > > Signed-off-by: Derek Foreman A few probably dum

Re: [PATCH v2 weston 1/4] zoom: Change zoom->active to a bool

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 02:55:12PM -0500, Derek Foreman wrote: > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington > --- > src/compositor.h | 2 +- > src/zoom.c | 7 --- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/compositor.h b/src/compositor.h

Re: [PATCH wayland] build: Build libwayland-private

2015-07-23 Thread Bryce Harrington
On Fri, Jun 19, 2015 at 10:27:33AM +1000, Peter Hutterer wrote: > On Thu, Jun 18, 2015 at 05:47:22PM -0500, Derek Foreman wrote: > > This splits the bulk of libwayland-util into libwayland-private. > > > > libwayland-util (which is just wayland-util.c) is for use with the scanner. > > > > libwayl

[PATCH v2 weston 0/4] Some zoom fixes

2015-07-23 Thread Derek Foreman
Previously I sent a series that fixed some problems with zoom, but also changed zoom behaviour in potentially controversial ways (and in did it in compositor instead of shell, which is probably not great). This is a rebase of the first few mostly non-invasive patches from the series, skipping most

[PATCH v2 weston 4/4] zoom: Store the seat that initiated a zoom

2015-07-23 Thread Derek Foreman
Track the seat that initiated a seat instead of picking the first one. Previously, if there are multiple seats then any seat can adjust the zoom level but the zoom tracks the first seat's pointer. Now the zoom will follow the pointer of the seat that initiated the zoom. Additionally, if there's

[PATCH v2 weston 3/4] zoom: Rename zoom_area_center_from_pointer to zoom_area_center_from_point

2015-07-23 Thread Derek Foreman
It doesn't do anything with a pointer, and zoom can be initiated by the keyboard, so the name was a little confusing. Signed-off-by: Derek Foreman --- src/zoom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/zoom.c b/src/zoom.c index 39515d4..18fc7ca 100644 --- a/

[PATCH v2 weston 2/4] zoom: Call weston_output_activate_zoom() appropriately

2015-07-23 Thread Derek Foreman
No longer call weston_output_update_zoom() when trying to zoom out on an unzoomed output. Add an assert() to make sure update_zoom is never called without an active zoom. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 5 - src/zoom.c| 3 +++ 2 files changed, 7 insertio

[PATCH v2 weston 1/4] zoom: Change zoom->active to a bool

2015-07-23 Thread Derek Foreman
Signed-off-by: Derek Foreman --- src/compositor.h | 2 +- src/zoom.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index d0c6034..b69547f 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -147,7 +147,7 @@ struct weston_

Re: [PATCH] cms-helper/static: Add "identity" builtin cms profile (v3)

2015-07-23 Thread Bryce Harrington
On Tue, Jul 21, 2015 at 02:42:52PM +0300, Pekka Paalanen wrote: > On Mon, 20 Jul 2015 11:17:15 -0500 > Derek Foreman wrote: > > > On 18/07/15 01:10 AM, Mario Kleiner wrote: > > > Allows to force loading an identity gamma table if > > > option icc_profile= is given in weston.ini for > > > an outpu

Re: [PATCH] cms-colord: Fix crash at compositor shutdown. (v2)

2015-07-23 Thread Bryce Harrington
On Sat, Jul 18, 2015 at 08:07:11AM +0200, Mario Kleiner wrote: > cms-colord used the weston_compositor destroy signal to > trigger its final colord_module_destroy cleanup, and the > wl_output destroy signal to trigger per output cleanup. > > The problem is that the compositor destroy signal gets >

Re: [PATCH wayland v2 2/2] scanner: get rid of leaks

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 07:39:31AM +0200, Marek Chalupa wrote: > Free all the memory we have allocated during running. > > v2.: split creating objects and getting rid of leaks > into two patches > > move check for NULL description into free_description > > Signed-off-by: Marek Chalupa

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote: > wrap creating and initializing objects (structures) > into functions and use them in the code. > > Signed-off-by: Marek Chalupa > --- > src/scanner.c | 158 > ++ > 1 file cha

Re: [PATCH wayland 2/2] scanner: wrap few long lines

2015-07-23 Thread Bryce Harrington
On Thu, Jul 16, 2015 at 01:59:05PM +0200, Marek Chalupa wrote: > Wrap few long lines to the length around 80 chars > > Signed-off-by: Marek Chalupa How hard core are we about maintaining the 80-column rule? Frankly I think the original code with the logging message on one line is more readable.

Re: [PATCH wayland v2 1/2] scanner: refactor creating objects

2015-07-23 Thread Derek Foreman
These both look OK to me now... Reviewed-By: Derek Foreman On 23/07/15 12:39 AM, Marek Chalupa wrote: > wrap creating and initializing objects (structures) > into functions and use them in the code. > > Signed-off-by: Marek Chalupa > --- > src/scanner.c | 158 > ++

Re: [PATCH weston] desktop-shell: Put monitor to sleep when idle timer expires

2015-07-23 Thread Bryce Harrington
On Tue, Jul 21, 2015 at 02:31:55PM +0300, Pekka Paalanen wrote: > On Mon, 20 Jul 2015 16:28:13 -0500 > Derek Foreman wrote: > > > Removing the screensaver had the accidental side effect of disabling > > DPMS display shut down. > > > > Signed-off-by: Derek Foreman > > --- > > desktop-shell/shel

Re: [PATCH wayland-web] extras: add wldbg tool

2015-07-23 Thread Bryce Harrington
On Thu, Jul 23, 2015 at 04:52:30PM +0200, Marek Chalupa wrote: > wldbg is a tool for debugging wayland applications > > Signed-off-by: Marek Chalupa > --- > extras.html | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/extras.html b/extras.html > index 55ff35c..eba7133 100644 > ---

[PATCH weston v2 4/5] clients: Request the wl_pointer_gesture_swipe/pinch interfaces

2015-07-23 Thread Carlos Garnacho
This is accompanied by separate handlers for the different stages of swipe/pinch gestures, so those can be set in demos. Signed-off-by: Carlos Garnacho --- Makefile.am | 2 + clients/window.c | 209 ++- clients/window.h | 54 +++

[PATCH weston v2 5/5] clients: Add pointer gesture support to weston-eventdemo

2015-07-23 Thread Carlos Garnacho
Just print the output, as with the other events. Signed-off-by: Carlos Garnacho --- clients/eventdemo.c | 102 +++- 1 file changed, 101 insertions(+), 1 deletion(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index dc69fd6..1401580 1006

[PATCH weston v2 3/5] compositor: Emit wl_pointer_gesture_* events on libinput gesture events

2015-07-23 Thread Carlos Garnacho
The translation is fairly straightforward so far, it would be convenient if gestures went through the pointer grab interface, but this is not done at the moment. Signed-off-by: Carlos Garnacho --- src/compositor.h | 7 +++ src/input.c | 107 ++

[PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2015-07-23 Thread Carlos Garnacho
The whole feature is exposed by the wl_pointer_gestures global resource, which can be used to obtain individual swipe/pinch gesture interfaces for a given wl_pointer. The lifetime and progress of gestures is maintained by the separate wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interface

[PATCH weston v2 2/5] compositor: Implement wl_pointer_gesture_swipe/pinch interfaces

2015-07-23 Thread Carlos Garnacho
Each of these come with a getter on wl_pointer, which takes care of creating the resource. The focused resources list is maintained in sync with the pointer's. Signed-off-by: Carlos Garnacho --- src/compositor.c | 100 +++ src/compositor.h |

[PATCH wayland-web] extras: add wldbg tool

2015-07-23 Thread Marek Chalupa
wldbg is a tool for debugging wayland applications Signed-off-by: Marek Chalupa --- extras.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/extras.html b/extras.html index 55ff35c..eba7133 100644 --- a/extras.html +++ b/extras.html @@ -120,6 +120,12 @@ act as a middle-man Wayland s

Re: announcing wldbg

2015-07-23 Thread Marek Chalupa
On 07/23/2015 11:22 AM, Pekka Paalanen wrote: On Wed, 22 Jul 2015 16:27:46 +0200 Marek Chalupa wrote: Hi folks, It's been some time since I started developing a tool called wldbg in my free time. I'm using it while debugging applications based on wayland and I think it is in enough good sha

Re: announcing wldbg

2015-07-23 Thread Pekka Paalanen
On Wed, 22 Jul 2015 16:27:46 +0200 Marek Chalupa wrote: > Hi folks, > > It's been some time since I started developing a tool called wldbg in my > free time. I'm using it while debugging applications based on wayland > and I think it is in enough good shape to bring it out (although there > i

Re: [PATCH libinput 1/3] test: only initialize the generic rules/hwdb once

2015-07-23 Thread Hans de Goede
Hi, On 23-07-15 06:59, Peter Hutterer wrote: Installing the udev rules and reloading udevadm takes around 150ms each time. For test-pointer alone (currently 336 tests) this adds almost a minute to the runtime. The model quirks and libinput udev rules don't change, so installing them once at the

Re: [PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

2015-07-23 Thread Hans de Goede
Hi, On 23-07-15 04:31, Peter Hutterer wrote: On Wed, Jul 22, 2015 at 03:54:02PM +0200, Hans de Goede wrote: Hi, On 22-07-15 07:09, Peter Hutterer wrote: If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer --- src/evdev-mt-touch