Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

2015-07-21 Thread Peter Hutterer
On Tue, Jul 21, 2015 at 10:15:24PM +0200, Hans de Goede wrote: > Hi, > > On 07/16/2015 01:55 AM, Peter Hutterer wrote: > >On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote: > >>On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer > >> wrote: > >>>These touchpads have a terrible resolu

[PATCH libinput 10/11] touchpad: a pressure change alone needs touch processing, mark as dirty

2015-07-21 Thread Peter Hutterer
A thumb may not move, but may change pressure so we need to process accordingly. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index c06b517..0b39bf6 100644 --- a/src/evdev-mt-touc

[PATCH libinput 06/11] touchpad: scale thumb pressure threshold with the resolution

2015-07-21 Thread Peter Hutterer
On touchpads with a higher resolution we also see higher pressure values. Scale accordingly, but use the T440s as reference and don't go below that device's threshold. A false positive is worse than a false negative when it comes to thumb detection. https://bugs.freedesktop.org/show_bug.cgi?id=913

[PATCH libinput 09/11] test: fix default axis value assignment

2015-07-21 Thread Peter Hutterer
Was assigned to -1 if no custom axes were provided. Signed-off-by: Peter Hutterer --- test/litest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/litest.c b/test/litest.c index db93bbe..5ab95f1 100644 --- a/test/litest.c +++ b/test/litest.c @@ -1223,6 +1223,9 @@

[PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

2015-07-21 Thread Peter Hutterer
If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 16 src/evdev-mt-touchpad.h | 1 + test/touchpad.c | 31 --- 3 files changed, 45 insertions(+), 3

[PATCH libinput 07/11] touchpad: only try thumb detection in the lowest 15/8mm

2015-07-21 Thread Peter Hutterer
That's the most likely area it will be resting in, if it's sitting anywhere above that it's likely part of an interaction. A thumb in the lowest 15mm needs to trigger the pressure threshold before it's labelled a thumb. A thumb in the lowest 8mm is considered a thumb if it remains there for 300ms.

[PATCH libinput 05/11] touchpad: use the top-most touch for fake finger positions

2015-07-21 Thread Peter Hutterer
The average human hand has four fingers but only one thumb, i.e. the chance of a fake finger being close to the top-most touch is higher than to whatever the first touch was (which may be a thumb at the bottom of the touchpad). So search for the top-most real touch and copy its position into the fa

[PATCH libinput 04/11] touchpad: ignore thumbs when counting clickfingers

2015-07-21 Thread Peter Hutterer
We may have four fingers on the touchpad - three real ones + a thumb. Count it as three-finger click then. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 3 +++ test/touchpad.c | 39 ++- 2 files changed, 41 insertions(+),

[PATCH libinput 08/11] test: only run 3-slot test for touchpads with three slots

2015-07-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/touchpad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/touchpad.c b/test/touchpad.c index 329eeb3..875bc58 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -456,6 +456,7 @@ START_TEST(touchpad_4fg_clickfinger_btntool_3slots) struct

[PATCH libinput 03/11] touchpad: 4-finger clickfingers are middle button clicks

2015-07-21 Thread Peter Hutterer
If a thumb is resting with a three-finger click, that must be a middle-click. And the odd case where we have a real four-finger click doesn't need worrying about. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH libinput 02/11] touchpad: only enable thumb detection on clickpads

2015-07-21 Thread Peter Hutterer
The use-case we have thumb detection for is to let a user rest a thumb on the touchpad before clicking. On a touchpad with physical buttons, the thumb won't be resting on the touchpad. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 3 +++ test/touchpad.c | 16 --

[PATCH libinput 01/11] touchpad: skip thumb detection for touchpads smaller than 50mm

2015-07-21 Thread Peter Hutterer
Gets a bit cramped if you're trying to rest the thumb on a touchpad that small. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 8 test/touchpad.c | 10 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-

Re: [PATCH libinput 4/4] touchpad: reset the motion history during/after a slots->nfake crossover

2015-07-21 Thread Benjamin Tissoires
On Tue, Jul 21, 2015 at 1:51 AM, Peter Hutterer wrote: > Whenever we cross from N slots to at least one fake finger, reset the motion > history and skip the next event too. Especially on serial Synaptics touchpads, > the first touch update after a two-slot → TRIPLETAP is garbage, as is the one > f

Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

2015-07-21 Thread Hans de Goede
Hi, On 07/16/2015 01:55 AM, Peter Hutterer wrote: On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote: On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer wrote: These touchpads have a terrible resolution when two fingers are down, causing scrolling to jump around a lot. That then

LibreOffice now works natively on wayland

2015-07-21 Thread darxus
The bug was just closed, after three years: https://bugs.documentfoundation.org/show_bug.cgi?id=48903 I think this is a pretty big step. http://caolanm.blogspot.com/2015/07/libreoffice-on-wayland.html ___ wayland-devel mailing list wayland-devel@lists.fr

Re: [PATCH] cms-helper/static: Add "identity" builtin cms profile (v3)

2015-07-21 Thread Pekka Paalanen
On Mon, 20 Jul 2015 11:17:15 -0500 Derek Foreman wrote: > On 18/07/15 01:10 AM, Mario Kleiner wrote: > > Allows to force loading an identity gamma table if > > option icc_profile= is given in weston.ini for > > an output, ie., icc_profile= is specified to an > > empty assignment. > > > > Some sp

Re: [PATCH 0/2] Misc fixes for the RDP compositor

2015-07-21 Thread Pekka Paalanen
On Mon, 20 Jul 2015 14:39:19 +0200 David FORT wrote: > Misc things fixed in the RDP compositor: > * bad return value in backend_init, introduced by the libweston refactoring; > * an initialization that was done too early and was crashing when using RDP4 > security > > David FORT (2): > [rdp co

Re: [PATCH weston] desktop-shell: Put monitor to sleep when idle timer expires

2015-07-21 Thread Pekka Paalanen
On Mon, 20 Jul 2015 16:28:13 -0500 Derek Foreman wrote: > Removing the screensaver had the accidental side effect of disabling > DPMS display shut down. > > Signed-off-by: Derek Foreman > --- > desktop-shell/shell.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/desktop-shell/shel

[PATCH libinput 2/2] touchpad: reduce unpin threshold to 1.5mm

2015-07-21 Thread Peter Hutterer
3mm is too large, it makes the touchpad feel sluggish. We already take fuzz into account through the hysteresis and the real issue we have with the pointer moving on a click is _before_ the BTN_LEFT event comes in, not after. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 4 ++-- t

[PATCH libinput 1/2] touchpad: reduce 2fg scroll threshold to 2mm

2015-07-21 Thread Peter Hutterer
3mm is too large, especially on fine-grained scroll motions. Since we already use the hysteresis to defuzz the current touchpad point, having a slower threshold here should not cause any adverse motions. This affects the pinch gestures too and needs a minor test adjustment. The atmel hover device'