Re: [PATCH 03/10] cms-helper/static: Add "identity" builtin cms profile (v2)

2015-07-17 Thread Mario Kleiner
On 07/02/2015 01:57 PM, Pekka Paalanen wrote: On Thu, 02 Jul 2015 09:36:47 +0200 Mario Kleiner wrote: On 06/29/2015 06:09 PM, Derek Foreman wrote: On 28/06/15 10:17 PM, Mario Kleiner wrote: On 06/26/2015 08:29 PM, Derek Foreman wrote: On 21/06/15 02:25 PM, Mario Kleiner wrote: Allows to

[PATCH] cms-helper/static: Add "identity" builtin cms profile (v3)

2015-07-17 Thread Mario Kleiner
Allows to force loading an identity gamma table if option icc_profile= is given in weston.ini for an output, ie., icc_profile= is specified to an empty assignment. Some special display output devices, e.g., for neuro-science applications, and special display testing hardware need a guaranteed perf

[PATCH] cms-colord: Fix crash at compositor shutdown. (v2)

2015-07-17 Thread Mario Kleiner
cms-colord used the weston_compositor destroy signal to trigger its final colord_module_destroy cleanup, and the wl_output destroy signal to trigger per output cleanup. The problem is that the compositor destroy signal gets emitted before the output destroy signals at compositor shutdown, colord_m

Re: [PATCH weston] exposay: Fix logic inversion when ending keyboard grabs

2015-07-17 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 08:58:02PM -0500, Derek Foreman wrote: > I flipped a ! in cee82d62865ab5b239935f102c2e1f7868e0fa65 > and the exposay keyboard grab became permanent. > > Signed-off-by: Derek Foreman Thanks for catching that! Pushed to git. > --- > desktop-shell/exposay.c | 2 +- > 1 fi

Re: Report: Patches that no longer apply

2015-07-17 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 03:19:20PM -0700, Bryce Harrington wrote: > Hi Derek, > > Here's a list of your patches in patchwork, and whether they still apply > or not. (This just sequentially applied all your patches, so > potentially the conflict could be between one of your newer patches and > one

[PATCH weston] exposay: Fix logic inversion when ending keyboard grabs

2015-07-17 Thread Derek Foreman
I flipped a ! in cee82d62865ab5b239935f102c2e1f7868e0fa65 and the exposay keyboard grab became permanent. Signed-off-by: Derek Foreman --- desktop-shell/exposay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-shell/exposay.c b/desktop-shell/exposay.c index 3fa585a..

Report: Patches that no longer apply

2015-07-17 Thread Bryce Harrington
Hi Derek, Here's a list of your patches in patchwork, and whether they still apply or not. (This just sequentially applied all your patches, so potentially the conflict could be between one of your newer patches and one of your older ones.) Bryce 47258 Applying: desktop-shell: add output co-o

Re: [PATCH 10/10] cms-colord: Fix crash at compositor shutdown.

2015-07-17 Thread Derek Foreman
On 21/06/15 02:25 PM, Mario Kleiner wrote: > cms-colord used the weston_compositor destroy signal to > trigger its final colord_module_destroy cleanup, and the > wl_output destroy signal to trigger per output cleanup. > > The problem is that the compositor destroy signal gets > emitted before the

Re: [PATCH weston] logind-util: Use %u for unsigned int in snprintf

2015-07-17 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 03:25:55PM -0500, Derek Foreman wrote: > Looks fine to me. > > Reviewed-By: Derek Foreman Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/weston 27135af..c683623 master -> master > On 19/06/15 06:28 PM, Bryce Harrington wrote: > > Addresses this warning fo

Re: [PATCH weston] logind-util: Use %u for unsigned int in snprintf

2015-07-17 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 03:06:44PM +0300, Pekka Paalanen wrote: > On Wed, 1 Jul 2015 12:29:00 +0200 > Marek Chalupa wrote: > > > sizeof operator returns size_t, which need not to be unsigned int, but can > > be long (long) unsigned int. > > So here the correct fix should be either to use %zu (sin

[PATCH wayland] shm: Add wl_shm_buffer get/put functions

2015-07-17 Thread Derek Foreman
Sometimes the compositor wants to make sure a shm pool doesn't disappear out from under it. For example, in Enlightenment, rendering happens in a separate thread while the main thread can still dispatch events. If a client is destroyed during rendering, all its resources are cleaned up and its sh

Re: [PATCH wayland] shm: add getters for the fd and offset

2015-07-17 Thread Derek Foreman
On 01/07/15 03:25 AM, Giulio Camuffo wrote: > This allows to share the buffer data by mmapping the fd again. Does it really? If the client's closed its mapping then it's gone, isn't it? Also, if we might need it later it would be better not unmapping in the first place. I think I've got a patch

Re: [PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

2015-07-17 Thread Derek Foreman
On 16/07/15 06:59 AM, Marek Chalupa wrote: > Create functions for structures allocation (instead of inlining it into > the code) and free the objects after we don't use them anymore. > > Signed-off-by: Marek Chalupa I think this is quite nice, but I'd like to see the leak fixes in a second patch

Re: [PATCH wayland 2/2] scanner: wrap few long lines

2015-07-17 Thread Derek Foreman
Reviewed-By: Derek Foreman On 16/07/15 06:59 AM, Marek Chalupa wrote: > Wrap few long lines to the length around 80 chars > > Signed-off-by: Marek Chalupa > --- > src/scanner.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/src/scanner.c b/src/scanne

Re: [PATCH] compositor: destroy modifier_binding_list

2015-07-17 Thread Bryce Harrington
On Fri, Jul 17, 2015 at 03:33:50PM -0500, Derek Foreman wrote: > Reviewed-By: Derek Foreman Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/weston 179c186..27135af master -> master > On 16/07/15 11:07 PM, Ryo Munakata wrote: > > Signed-off-by: Ryo Munakata > > --- > > src/composi

Re: [PATCH] compositor: destroy modifier_binding_list

2015-07-17 Thread Derek Foreman
Reviewed-By: Derek Foreman On 16/07/15 11:07 PM, Ryo Munakata wrote: > Signed-off-by: Ryo Munakata > --- > src/compositor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compositor.c b/src/compositor.c > index 4e88375..ec2be7d 100644 > --- a/src/compositor.c > +++ b/src/composit

Re: [PATCH weston] logind-util: Use %u for unsigned int in snprintf

2015-07-17 Thread Derek Foreman
Looks fine to me. Reviewed-By: Derek Foreman On 19/06/15 06:28 PM, Bryce Harrington wrote: > Addresses this warning found by Denis Denisov: > > [src/logind-util.c:702]: (warning) %d in format string (no. 1) > requires 'int' but the argument type is 'unsigned int'. > > Signed-off-by: Bryce

Patchwork upgrade?

2015-07-17 Thread Bryce Harrington
Daniel, Could I bother you to request we update patchwork on fdo? The latest version now displays counts of Acked/Reviewed/Tested which would be quite handy in picking out patches to land as we start heading towards the next alpha. http://patchwork.ozlabs.org/project/patchwork/list/ Bryce _

Re: [PATCH][V3][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Jon A. Cruz
On 07/17/2015 04:33 AM, Ross Burton wrote: > In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to > be written before ivi-shell/ exists. Solve this by creating the target > directory first. > > Signed-off-by: Ross Burton > --- > Makefile.am | 4 ++-- > 1 file changed,

Re: [PATCH weston] logind-util: Use %u for unsigned int in snprintf

2015-07-17 Thread Pekka Paalanen
On Wed, 1 Jul 2015 12:29:00 +0200 Marek Chalupa wrote: > sizeof operator returns size_t, which need not to be unsigned int, but can > be long (long) unsigned int. > So here the correct fix should be either to use %zu (since C99) or cast it > to unsigned long and use %lu < SardemFF7> Why has siz

Re: [PATCH][V3][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Quentin Glidic
On 2015-07-17 13:33, Ross Burton wrote: > In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to > be written before ivi-shell/ exists. Solve this by creating the target > directory first. > > Signed-off-by: Ross Burton > --- > Makefile.am | 4 ++-- > 1 file changed, 2 i

Re: [PATCH][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Quentin Glidic
On 2015-07-16 22:22, Ross Burton wrote: > In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to > be written before ivi-shell/ exists. Solve this by creating the target > directory first. > > Signed-off-by: Ross Burton > --- > Makefile.am | 2 ++ > 1 file changed, 2 ins

[PATCH][V3][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Ross Burton
In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to be written before ivi-shell/ exists. Solve this by creating the target directory first. Signed-off-by: Ross Burton --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b

Re: [PATCH][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Burton, Ross
On 17 July 2015 at 12:31, Ross Burton wrote: > + $(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(AM_V_GEN)$(SED) \ > Argh. V3 incoming. Ross ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/w

Re: [PATCH][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Burton, Ross
On 17 July 2015 at 12:35, Quentin Glidic wrote: > You should have only one $(AM_V_GEN) per rule. Otherwise output will be: > > GEN ivi-shell/weston.ini > GEN ivi-shell/weston.ini > > It may look like a bug to the user. > > You should do it that way: > > $(AM_V_GEN)$(MKDIR_P) $(dir $@); $(SED)

[PATCH][weston] build: mkdir target weston.ini directories before writing

2015-07-17 Thread Ross Burton
In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to be written before ivi-shell/ exists. Solve this by creating the target directory first. Signed-off-by: Ross Burton --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b

Re: [PATCH] build: always build wayland-scanner

2015-07-17 Thread Daniel Stone
Hi, On 17 July 2015 at 11:55, Burton, Ross wrote: > Bump. Lots of mails but no concrete acceptance or rejection. Rationale is solid to me. Applied, bikeshedded naming (with Ross's OK), tested, pushed. Cheers, Daniel > Ross > > On 1 July 2015 at 22:51, Ross Burton wrote: >> >> The previous id

Re: [PATCH] build: always build wayland-scanner

2015-07-17 Thread Burton, Ross
Bump. Lots of mails but no concrete acceptance or rejection. Ross On 1 July 2015 at 22:51, Ross Burton wrote: > The previous idiom for building a cross-compiled Wayland is to build once > for > the build host (with --enable-scanner --disable-libraries) to get a > wayland-scanner binary that ca

Re: [PATCH weston v7 0/3] Refactored simple unit/integration test framework and corresponding test program.

2015-07-17 Thread Pekka Paalanen
On Wed, 15 Jul 2015 19:22:40 -0700 "Jon A. Cruz" wrote: > Here is yet another re-worked version of the patch adding unit testing > framework and corresponding separation. This drops the higher-level waycheck > program and focuses on the first two steps of adding zunitc and converting > the config

Re: [PATCH weston v6 4/4] Adding doxygen setup and info for the testing framework.

2015-07-17 Thread Pekka Paalanen
On Wed, 15 Jul 2015 19:29:37 -0700 "Jon A. Cruz" wrote: > On 07/07/2015 05:35 AM, Pekka Paalanen wrote: > > On Thu, 2 Jul 2015 23:36:47 -0700 > > "Jon A. Cruz" wrote: > > > >> Signed-off-by: Jon A. Cruz > >> --- > >> .gitignore | 2 + > >> Makefile.am

Re: [PATCH weston v6 2/4] Enables output in the JUnit XML format.

2015-07-17 Thread Pekka Paalanen
On Wed, 15 Jul 2015 17:21:16 -0700 "Jon A. Cruz" wrote: > On 07/07/2015 04:49 AM, Pekka Paalanen wrote: > > On Thu, 2 Jul 2015 23:36:45 -0700 > > "Jon A. Cruz" wrote: > > > >> Adds basic support for optionally outputting in the XML format > >> commonly used by JUnit compatible tools. > >> > >>

Re: [PATCH 08/10] compositor: Respect repaint-window when restarting repaint loop.

2015-07-17 Thread Mario Kleiner
On 07/06/2015 03:41 PM, Pekka Paalanen wrote: On Sun, 21 Jun 2015 21:25:15 +0200 Mario Kleiner wrote: If a stopped repaint loop gets restarted due to posting of new damage, and this restart of the repaint loop happens late in the video refresh cycle, ie. already inside the repaint-window and t

Re: [PATCH weston v3 0/5] Fast repaint loop start on DRM

2015-07-17 Thread Pekka Paalanen
On Thu, 16 Jul 2015 19:42:24 +0200 Mario Kleiner wrote: > > > On 07/16/2015 01:30 PM, Pekka Paalanen wrote: > > On Tue, 7 Jul 2015 12:53:09 +0300 > > Pekka Paalanen wrote: > > > >> From: Pekka Paalanen > >> > >> Hi, > >> > >> as promised in > >> http://lists.freedesktop.org/archives/wayland-

Re: [PATCH weston] README: introduce libweston

2015-07-17 Thread Pekka Paalanen
On Thu, 16 Jul 2015 18:56:20 -0700 Bryce Harrington wrote: > On Thu, Jul 16, 2015 at 11:55:03AM +0300, Pekka Paalanen wrote: > > A quick fix would be to have a runtime switch in toytoolkit to ask for > > cairo-egl, and default to cairo-image. This way we'd limit the > > cairo-egl impact to just