[PATCH] compositor: destroy modifier_binding_list

Signed-off-by: Ryo Munakata --- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index 4e88375..ec2be7d 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4558,6 +4558,7 @@ weston_compositor_shutdown(struct weston_compositor *ec)

RE: weston-desktop-shell

Hi pekka >Odd. You definitely should be getting first a black screen which then fades to >the desktop once weston-desktop-shell signals ready, because you have >startup-animation=fade. Yes. I don't notice it before. There is a black screen flashed across before display Weston-desktop-shell. B

Re: [PATCH][weston] build: don't duplicate rule for weston.desktop

On Thu, Jul 16, 2015 at 08:56:32PM +0100, Ross Burton wrote: > dist_wayland_session_DATA will distribute and install src/weston.desktop, so > the > definition of wayland_session_DATA which also installs src/weston.desktop will > result in the file being installed twice and (rarely) cause install t

Re: [PATCH weston] shell: Switch middle and right mouse bindings

On Fri, Jun 26, 2015 at 01:57:44PM +1000, Peter Hutterer wrote: > On Thu, Jun 25, 2015 at 04:03:30PM -0500, Derek Foreman wrote: > > Currently rotate is on the right mouse button and resize is on the middle. > > > > As fantastic as rotating windows is, it's probably nicer to have resize on > > the

Re: [PATCH v2 weston] log: Open log file CLOEXEC so child processes don't get the fd

On Mon, Jun 08, 2015 at 11:37:31AM -0500, Derek Foreman wrote: > Reviewed-by: Pekka Paalanen > Signed-off-by: Derek Foreman Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/weston 4a8a3a1..6bc33d6 master -> master > --- > > Nested the os_fd_set_cloexec() call so calling weston_log

Re: [PATCH weston 00/17] Don't allow direct use of seat->device pointers

On Wed, Jul 15, 2015 at 01:00:31PM -0500, Derek Foreman wrote: > "v7" of my "Don't allow direct use of seat->device pointers" stuff. > > Those pointers are funny in that they only exist after a device has been > plugged in, and they don't ever go away. We're supposed to check if > the associated

Re: [PATCH weston] README: introduce libweston

On Thu, Jul 16, 2015 at 11:55:03AM +0300, Pekka Paalanen wrote: > On Wed, 15 Jul 2015 09:52:38 -0700 > Bryce Harrington wrote: > > > On Wed, Jul 15, 2015 at 01:03:24PM +0100, Daniel Stone wrote: > > > Hi, > > > > > > On 14 July 2015 at 11:07, Pekka Paalanen wrote: > > > > From: Pekka Paalanen

Re: Wayland Relative Pointer API Progress

On Wed, Jul 15, 2015 at 5:09 AM, Daniel Stone wrote: > On 29 June 2015 at 20:22, Bill Spitzak wrote: > > On Sun, Jun 28, 2015 at 7:32 AM, x414e54 wrote: > >> Clients do not draw the mouse cursor, either the GPU (using hardware > >> overlays) or the WM does. > > > > Yes, I want to allow clients

Re: [PATCH wayland] protocol: Add pointer gestures (swipe/pinch) protocol

On Thu, Jul 16, 2015 at 08:17:44PM +0200, Carlos Garnacho wrote: > Hey Jonas :), > > On Thu, Jul 16, 2015 at 3:15 AM, Jonas Ådahl wrote: > > On Wed, Jul 15, 2015 at 08:02:10PM +0200, Carlos Garnacho wrote: > >> The lifetime and progress of gestures is maintained by the separate > >> wl_pointer_ge

Re: [PATCH][weston] build: don't duplicate rule for weston.desktop

Looks good to me, Reviewed-By: Derek Foreman On 16/07/15 02:56 PM, Ross Burton wrote: > dist_wayland_session_DATA will distribute and install src/weston.desktop, so > the > definition of wayland_session_DATA which also installs src/weston.desktop will > result in the file being installed twice

[PATCH][weston] build: mkdir target weston.ini directories before writing

In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini to be written before ivi-shell/ exists. Solve this by creating the target directory first. Signed-off-by: Ross Burton --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index

[PATCH][weston] build: don't duplicate rule for weston.desktop

dist_wayland_session_DATA will distribute and install src/weston.desktop, so the definition of wayland_session_DATA which also installs src/weston.desktop will result in the file being installed twice and (rarely) cause install to fail. Spotted and fix by Roy Li . Signed-off-by: Ross Burton ---

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

On 16/07/15 03:02 AM, Hardening wrote: > Le 01/07/2015 12:52, Marek Chalupa a écrit : >> >> >> On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > > wrote: >> >> >> >> On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman >> mailto:der...@osg.samsung.com>> wrote: >> >>

Re: [PATCH wayland] protocol: Add pointer gestures (swipe/pinch) protocol

Hey Jonas :), On Thu, Jul 16, 2015 at 3:15 AM, Jonas Ådahl wrote: > On Wed, Jul 15, 2015 at 08:02:10PM +0200, Carlos Garnacho wrote: >> The lifetime and progress of gestures is maintained by the separate >> wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces, >> each of these has beg

Re: [PATCH wayland] protocol: Add pointer gestures (swipe/pinch) protocol

Hey, Keen eye on those :), my last proofreading wasn't as successful. I've just sent a new patch that contains Pekka's suggestions, fixes for your comments and your r-b. Cheers, Carlos On Thu, Jul 16, 2015 at 2:13 AM, Peter Hutterer wrote: > On Wed, Jul 15, 2015 at 08:02:10PM +0200, Carlos Ga

[PATCH wayland v2] protocol: Add pointer gestures (swipe/pinch) protocol

The lifetime and progress of gestures is maintained by the separate wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces, each of these has begin/update(optional)/end phases, as transmitted by their events. The gesture interfaces can be obtained from the wl_pointer, and must be interpr

Re: [PATCH wayland] protocol: define further the behavior of input on the presence of grabs

If the client still has key focus, then it should get the key release. That sounds like a compositor bug to me. On Thu, Jul 16, 2015 at 10:28 AM, Arnaud Vrac wrote: > On Wed, Jun 10, 2015 at 5:20 PM, Jasper St. Pierre > wrote: > >> On Wed, Jun 10, 2015 at 4:50 AM, Carlos Garnacho >> wrote: >> >

Re: [PATCH weston v3 0/5] Fast repaint loop start on DRM

On 07/16/2015 01:30 PM, Pekka Paalanen wrote: On Tue, 7 Jul 2015 12:53:09 +0300 Pekka Paalanen wrote: From: Pekka Paalanen Hi, as promised in http://lists.freedesktop.org/archives/wayland-devel/2015-July/023192.html here are the patches. The above-mentioned email contains an analysis of

Re: [PATCH wayland] protocol: define further the behavior of input on the presence of grabs

On Wed, Jun 10, 2015 at 5:20 PM, Jasper St. Pierre wrote: > On Wed, Jun 10, 2015 at 4:50 AM, Carlos Garnacho > wrote: > > On mar, 2015-06-09 at 11:03 -0700, Jasper St. Pierre wrote: > >> What is the value of clients having this information? > > > > The same there is in having wl_touch.cancelled.

Re: [PATCH v2 weston 00/16] Atomic modesetting support

Hi, On 11 July 2015 at 02:05, Bryce Harrington wrote: > On Fri, Jun 26, 2015 at 02:16:55PM -0500, Derek Foreman wrote: >> On 22/06/15 11:25 AM, Daniel Stone wrote: >> > Hi, >> > Thanks to everyone who reviewed the previous series. This new series >> > cleans up the previous patches, introduces a

Re: [PATCH v2 weston 04/16] compositor-drm: Record current DPMS level

Hi, On 11 July 2015 at 01:58, Bryce Harrington wrote: > On Mon, Jun 22, 2015 at 05:25:09PM +0100, Daniel Stone wrote: >> + ret = drmModeConnectorSetProperty(c->drm.fd, output->connector_id, >> + output->dpms_prop->prop_id, level); >> + if (ret) { > >

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

On Thu, Jul 16, 2015 at 3:37 AM, Peter Hutterer wrote: > On Thu, Jul 16, 2015 at 03:23:20PM +0800, Jonas Ådahl wrote: >> On Thu, Jul 16, 2015 at 03:37:30PM +0900, x414e54 wrote: >> > On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer >> > wrote: >> > > On Wed, Jul 15, 2015 at 08:23:09AM +0900, x414

Re: weston-desktop-shell

On Thu, 16 Jul 2015 11:06:38 + Nancy Zou wrote: > Hi pekka > > >>Btw. even the 3 seconds sounds awfully long. What platform is this > >>and which backend/renderer? > Fbdev backend, gl renderer Ah, the unholy combination. > >>Did you pass some --with-cairo= option to Weston's configure? > -

[PATCH wayland 1/2] scanner: refactor creating objects and get rid of leaks

Create functions for structures allocation (instead of inlining it into the code) and free the objects after we don't use them anymore. Signed-off-by: Marek Chalupa --- src/scanner.c | 266 +- 1 file changed, 209 insertions(+), 57 deletions

[PATCH wayland 2/2] scanner: wrap few long lines

Wrap few long lines to the length around 80 chars Signed-off-by: Marek Chalupa --- src/scanner.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index c652612..ac511f1 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -597,7 +597

Re: [PATCH weston v3 0/5] Fast repaint loop start on DRM

On Tue, 7 Jul 2015 12:53:09 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > as promised in > http://lists.freedesktop.org/archives/wayland-devel/2015-July/023192.html here > are the patches. The above-mentioned email contains an analysis of the effects > of these patches. > >

RE: weston-desktop-shell

Hi pekka >>Btw. even the 3 seconds sounds awfully long. What platform is this and which >>backend/renderer? Fbdev backend, gl renderer >>Did you pass some --with-cairo= option to Weston's configure? --With-cairo=image >>Does the desktop fade in from black, or does it just jump out after 3 secon

Re: weston-desktop-shell

On Thu, 16 Jul 2015 12:18:03 +0300 Pekka Paalanen wrote: > On Thu, 16 Jul 2015 08:17:58 + > Nancy Zou wrote: > > > Dear all: > > > > When I set other Weston clients in the Weston.ini instead of > > Weston-deskto-shell, then start Weston is very slow. It cost about > > 16s. The Weston-desk-

Re: [PATCH weston] README: introduce libweston

On Wed, 15 Jul 2015 07:36:50 -0700 "Jon A. Cruz" wrote: > Factoring in the comments by Bryce, this looks good to me. > > Acked-by: Jon A. Cruz > > On 07/14/2015 03:07 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > What is libweston and where do we intend to go with it. > > > > C

Re: weston-desktop-shell

On Thu, 16 Jul 2015 08:17:58 + Nancy Zou wrote: > Dear all: > > When I set other Weston clients in the Weston.ini instead of > Weston-deskto-shell, then start Weston is very slow. It cost about > 16s. The Weston-desk-shell only cost 3s. Does there any big > difference between Weston-desktop-

Re: [PATCH weston 0/2] transform refactoring in ivi-shell

On Wed, 15 Jul 2015 14:03:01 +0900 Nobuhiko Tanibata wrote: > Hi, > > Current code in ivi-shell to transform a surface to global_matrix is not > readable very much. This patch set improves it. This consists of two > patches, > > - remove transform part once to add transform logic from scratch

weston-desktop-shell

Dear all: When I set other Weston clients in the Weston.ini instead of Weston-deskto-shell, then start Weston is very slow. It cost about 16s. The Weston-desk-shell only cost 3s. Does there any big difference between Weston-desktop-shell and other Weston client examples(for example, Weston-full

Re: [PATCH weston] README: introduce libweston

On Wed, 15 Jul 2015 09:52:38 -0700 Bryce Harrington wrote: > On Wed, Jul 15, 2015 at 01:03:24PM +0100, Daniel Stone wrote: > > Hi, > > > > On 14 July 2015 at 11:07, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > What is libweston and where do we intend to go with it. > > > > Sou

Re: [PATCH wayland] protocol: Add pointer gestures (swipe/pinch) protocol

On Wed, 15 Jul 2015 20:02:10 +0200 Carlos Garnacho wrote: > The lifetime and progress of gestures is maintained by the separate > wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces, > each of these has begin/update(optional)/end phases, as transmitted > by their events. > > The ges

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

Le 01/07/2015 12:52, Marek Chalupa a écrit : > > > On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > wrote: > > > > On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman > mailto:der...@osg.samsung.com>> wrote: > > There's no situation where a shm buffer w

Re: [PATCH wayland] shm: add getters for the fd and offset

Le 01/07/2015 10:25, Giulio Camuffo a écrit : > This allows to share the buffer data by mmapping the fd again. > --- > src/wayland-server-core.h | 6 ++ > src/wayland-shm.c | 16 +++- > 2 files changed, 21 insertions(+), 1 deletion(-) > Reviewed-by: David FORT > diff -

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

On Thu, Jul 16, 2015 at 03:23:20PM +0800, Jonas Ådahl wrote: > On Thu, Jul 16, 2015 at 03:37:30PM +0900, x414e54 wrote: > > On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer > > wrote: > > > On Wed, Jul 15, 2015 at 08:23:09AM +0900, x414e54 wrote: > > >> Hi, > > >> > > >> Just a quick questions: >

Re: [PATCH] wayland-server: Fix null pointer dereferencing

On 07/16/2015 09:27 AM, Marek Chalupa wrote: Nice catch (some static analysis tool? :). I'm not sure if this is the right way to fix it, though. If somebody calls wl_resource_post_error with NULL resource, it is his fault and program should crash to reveal this error. So the right fix in this

Re: [PATCH] wayland-server: Fix null pointer dereferencing

On 07/16/2015 09:22 AM, Giulio Camuffo wrote: 2015-07-16 9:27 GMT+03:00 Ashim : Initialising 'wl_client *client = NULL' and checking 'resource' for NULL and returning if found. This patch will avoid dereferencing of 'resource' if NULL I think in this case passing a NULL resource to wl_resou

Re: [PATCH] wayland-server: Fix null pointer dereferencing

Nice catch (some static analysis tool? :). I'm not sure if this is the right way to fix it, though. If somebody calls wl_resource_post_error with NULL resource, it is his fault and program should crash to reveal this error. So the right fix in this case would be to delete wl_client_post_no_mem

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

On Thu, Jul 16, 2015 at 03:37:30PM +0900, x414e54 wrote: > On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer > wrote: > > On Wed, Jul 15, 2015 at 08:23:09AM +0900, x414e54 wrote: > >> Hi, > >> > >> Just a quick questions: > >> > >> 1) Is there any way to un-normalize the values? > > > > not at this

Re: [PATCH] wayland-server: Fix null pointer dereferencing

2015-07-16 9:27 GMT+03:00 Ashim : > Initialising 'wl_client *client = NULL' and checking 'resource' for NULL and > returning if found. > This patch will avoid dereferencing of 'resource' if NULL I think in this case passing a NULL resource to wl_resource_post_error() is a programming mistake, and