Re: [PATCH weston 04/11] make the backends compositor-neutral

On Mon, 13 Jul 2015 14:19:17 -0700 "Jon A. Cruz" wrote: > On 07/10/2015 04:32 AM, Pekka Paalanen wrote: > > > > As I see it, the main reason the backends are .so files instead of > > built into libweston or the main executable is that we can restrict the > > dependencies. > > > > I can well ima

Re: [PATCH weston 3/3] zunitc: Fix minor typo

On Mon, 13 Jul 2015 12:23:01 -0700 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > tools/zunitc/inc/zunitc/zunitc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/zunitc/inc/zunitc/zunitc.h > b/tools/zunitc/inc/zunitc/zunitc.h > index fc6ee1c.

Re: [PATCH] Documentation for the prepare_lock_surface event description, is incorrect

On Mon, 13 Jul 2015 13:04:38 -0700 Bryce Harrington wrote: > On Mon, Jul 13, 2015 at 09:12:24AM +0300, Pekka Paalanen wrote: > > On Fri, 10 Jul 2015 15:31:03 -0700 > > Bryce Harrington wrote: > > > > > On Fri, Jul 10, 2015 at 09:33:46AM -0400, Christopher Michael wrote: > > > > Thanks for the r

Re: Wayland Relative Pointer API Progress

On Tue, Jun 30, 2015 at 4:22 AM, Bill Spitzak wrote: > > > On Sun, Jun 28, 2015 at 7:32 AM, x414e54 wrote: >> >> >> Clients do not draw the mouse cursor, either the GPU (using hardware >> overlays) or the WM does. > > > Yes, I want to allow clients to use this CPU/WM support. Currently the > clie

[PATCH libinput 2/2] touchpad: only edge-scroll while the finger is in the edge area

When the touch leaves the area for edge scrolling after starting to scroll, discard any movement. This signals to the user that they've left the area and forces them to lift the finger to switch back to motion. If the finger moves back into the area, scrolling continues. https://bugs.freedesktop.o

[PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

Rather than magic percentages of the touchpad axis ranges, make it a fixed size of 7mm. Except on synaptics touchpads, because they won't give us the actual axis range but rather the "typical bezel limits". Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 25 +++---

[PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

These touchpads have a terrible resolution when two fingers are down, causing scrolling to jump around a lot. That then turns into bug reports that we can't do much about, the data is simply garbage. For Alps: https://bugs.freedesktop.org/show_bug.cgi?id=91081 For Synaptics: https://bugs.freedeskt

Re: [PATCH weston 04/11] make the backends compositor-neutral

On 07/10/2015 04:32 AM, Pekka Paalanen wrote: > > As I see it, the main reason the backends are .so files instead of > built into libweston or the main executable is that we can restrict the > dependencies. > > I can well imagine a packager splitting Weston into several packages, > for example:

Re: [PATCH weston] configure.ac: add support for new versions of systemd

On Mon, Jul 13, 2015 at 8:21 PM, Quentin Glidic wrote: > On 2015-07-13 18:07, Frederico Cadete wrote: >> I thought of doing that, but can't think of a way to do it without >> breaking someone's build. >> >> Currently, weston enables sd-login if it finds the corresponding .pc, >> and disables it if

Re: [PATCH] Documentation for the prepare_lock_surface event description, is incorrect

On Mon, Jul 13, 2015 at 09:12:24AM +0300, Pekka Paalanen wrote: > On Fri, 10 Jul 2015 15:31:03 -0700 > Bryce Harrington wrote: > > > On Fri, Jul 10, 2015 at 09:33:46AM -0400, Christopher Michael wrote: > > > Thanks for the review. I've included an updated patch which fixes > > > the second 'shell

Re: [PATCH] screen-share: Use the correct list pointer when freeing shm buffers

On Mon, Jul 13, 2015 at 11:02:07AM -0500, Derek Foreman wrote: > looks correct to me. > > Reviewed-by: Derek Foreman Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/weston 2f2a70c..29f09fe master -> master > On 10/07/15 08:52 PM, Bryce Harrington wrote: > > The wl_list_for_each op

[PATCH weston 2/3] zunitc: Fix some minor grammatical errors in dox

Signed-off-by: Bryce Harrington --- tools/zunitc/doc/zunitc.dox | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/zunitc/doc/zunitc.dox b/tools/zunitc/doc/zunitc.dox index 0222690..cef6c34 100644 --- a/tools/zunitc/doc/zunitc.dox +++ b/tools/zunitc/doc/zunitc.dox @@ -1

[PATCH weston 1/3] zunitc: wrap dox to 80 columns

Signed-off-by: Bryce Harrington --- tools/zunitc/doc/zunitc.dox | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/tools/zunitc/doc/zunitc.dox b/tools/zunitc/doc/zunitc.dox index 24f20fa..0222690 100644 --- a/tools/zunitc/doc/zunitc.dox +++ b/tools

[PATCH weston 3/3] zunitc: Fix minor typo

Signed-off-by: Bryce Harrington --- tools/zunitc/inc/zunitc/zunitc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/zunitc/inc/zunitc/zunitc.h b/tools/zunitc/inc/zunitc/zunitc.h index fc6ee1c..d8c3cb0 100644 --- a/tools/zunitc/inc/zunitc/zunitc.h +++ b/tools/zunitc/inc/

Re: [PATCH weston] configure.ac: add support for new versions of systemd

On 2015-07-13 18:07, Frederico Cadete wrote: > I thought of doing that, but can't think of a way to do it without > breaking someone's build. > > Currently, weston enables sd-login if it finds the corresponding .pc, > and disables it if not. If I add a --enable-sd-login/--disable-sd-login, > I see

Re: [PATCH weston] configure.ac: add support for new versions of systemd

On Mon, Jul 13, 2015 at 12:14 PM, Quentin Glidic wrote: > On 2015-07-12 22:15, Frederico Cadete wrote: >> Starting from systemd version 209, a single libsystemd.pc is provided. >> For previous versions, fall back on libsystemd-login.pc. >> >> Signed-off-by: Frederico Cadete > > LGTM > Reviewed-by

Re: [PATCH] screen-share: Use the correct list pointer when freeing shm buffers

looks correct to me. Reviewed-by: Derek Foreman On 10/07/15 08:52 PM, Bryce Harrington wrote: > The wl_list_for_each operation on the free_buffers list should use > free_link not link, which is a different list. > > Signed-off-by: Bryce Harrington > --- > src/screen-share.c | 4 ++-- > 1 file

Re: [PATCH weston v3 06/11] build a libweston.so used by the weston binary

On Sat, 27 Jun 2015 14:07:46 +0300 Giulio Camuffo wrote: > The library is versioned, so a -N is appended to its name, e.g. > libweston-1.so. > The same is done for the pc file, the include and lib/weston dirs. > This allows multiple libweston versions to be installed together. > Additionally, a

Re: [PATCH weston v2] compositor: make sure to reset views' pointers to destroyed output

On Sun, 12 Jul 2015 10:52:32 +0300 Giulio Camuffo wrote: > When an output is being destroyed reassign the output of the views > that were in it, to be sure not to keep a dangling pointer which could > be used later on by calling weston_surface_assign_output() on the > view's surface. > Also make

Re: [PATCH weston] configure.ac: add support for new versions of systemd

On 2015-07-12 22:15, Frederico Cadete wrote: > Starting from systemd version 209, a single libsystemd.pc is provided. > For previous versions, fall back on libsystemd-login.pc. > > Signed-off-by: Frederico Cadete LGTM Reviewed-by: Quentin Glidic It is optional, but if you want to make a follow

Re: [PATCH weston v2] compositor: make sure to reset views' pointers to destroyed output

On Sun, Jul 12, 2015 at 10:52:32AM +0300, Giulio Camuffo wrote: > When an output is being destroyed reassign the output of the views > that were in it, to be sure not to keep a dangling pointer which could > be used later on by calling weston_surface_assign_output() on the > view's surface. > Also

Re: [PATCH v2 wayland] protocol: add wl_pointer.axis_frame events

On Mon, Jul 13, 2015 at 04:01:20PM +1000, Peter Hutterer wrote: > On Sun, Jul 12, 2015 at 03:58:47PM +0800, Jonas Ådahl wrote: > > On Thu, Jun 25, 2015 at 04:01:48PM +1000, Peter Hutterer wrote: > > > To group separate vertical/horizontal scroll events together. Likewise it > > > enables axis_stop