[PATCH weston v2] logind-util: Use %lu for unsigned int in snprintf

Addresses this warning found by Denis Denisov: [src/logind-util.c:702]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. Signed-off-by: Bryce Harrington --- src/logind-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

[PATCH] screen-share: Use the correct list pointer when freeing shm buffers

The wl_list_for_each operation on the free_buffers list should use free_link not link, which is a different list. Signed-off-by: Bryce Harrington --- src/screen-share.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/screen-share.c b/src/screen-share.c index 6b1b34c..

Re: [PATCH] xwayland: Allow dump_property when selection fails

On Fri, Jul 10, 2015 at 06:16:11PM -0700, Bryce Harrington wrote: > dump_property allows reply to be NULL. Calling it unconditionally will > ensure user knows where the selection failed. > > Also refactor code a bit. > > Suggested by Marek Chalupa > > Signed-off-by: Bryce Harrington I acciden

Re: [PATCH weston] compositor-wayland: Use the correct list pointer when freeing shm buffers

On Fri, May 29, 2015 at 04:32:52PM -0500, Derek Foreman wrote: > The wl_list_for_each operation on the free_buffers list should use > free_link not link, which is a different list. > > This fixes a crash when entering fullscreen mode when using the pixman > renderer on the wayland back-end. > > S

Re: [PATCH weston] compositor-wayland: Use the correct list pointer when freeing shm buffers

On Fri, May 29, 2015 at 04:32:52PM -0500, Derek Foreman wrote: > The wl_list_for_each operation on the free_buffers list should use > free_link not link, which is a different list. > > This fixes a crash when entering fullscreen mode when using the pixman > renderer on the wayland back-end. > > S

[PATCH] xwayland: Allow dump_property when selection fails

dump_property allows reply to be NULL. Calling it unconditionally will ensure user knows where the selection failed. Also refactor code a bit. Suggested by Marek Chalupa Signed-off-by: Bryce Harrington --- xwayland/selection.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH] xwayland: Check return of xcb_get_property_reply() before deref

On Fri, Jul 10, 2015 at 10:50:43AM +0200, Marek Chalupa wrote: > > > On 07/10/2015 06:30 AM, Bryce Harrington wrote: > > From the man pages it appears this routine can return NULL on certain > >error conditions. > > > >Suggested by Marek Chalupa > > > >Signed-off-by: Bryce Harrington > >--- > >

Re: [PATCH v2 weston 00/16] Atomic modesetting support

On Fri, Jun 26, 2015 at 02:16:55PM -0500, Derek Foreman wrote: > On 22/06/15 11:25 AM, Daniel Stone wrote: > > Hi, > > Thanks to everyone who reviewed the previous series. This new series > > cleans up the previous patches, introduces a few fixes (e.g. not relying > > on a repaint to pull us out of

Re: [PATCH v2 weston 04/16] compositor-drm: Record current DPMS level

On Mon, Jun 22, 2015 at 05:25:09PM +0100, Daniel Stone wrote: > Track the current DPMS level for any given output, and track failure (or > otherwise) of the DPMS-setting property call. > > Signed-off-by: Daniel Stone > --- > src/compositor-drm.c | 14 -- > 1 file changed, 12 insertio

Re: [PATCH v2 weston 02/16] compositor-drm: Refactor connector name into new function

On Mon, Jun 22, 2015 at 05:25:07PM +0100, Daniel Stone wrote: > From: Pekka Paalanen > > Refactor the code constructing the connector name into a new function. > This makes create_output_for_connector() slightly easier to read. > > Signed-off-by: Pekka Paalanen > Signed-off-by: Daniel Stone Re

Re: [PATCH v2 weston 01/16] compositor-drm: Refactor initial mode out of create_output

On Fri, Jun 26, 2015 at 01:57:22PM -0500, Derek Foreman wrote: > On 22/06/15 11:25 AM, Daniel Stone wrote: > > From: Pekka Paalanen > > > > Refactor the code for choosing the initial mode for an output from > > create_output_for_connector() to drm_output_choose_initial_mode(). > > > > This makes

Re: [PATCH] fixed-benchmark: remove unused arguments in main

On Fri, Jul 03, 2015 at 09:33:23AM +0200, Marek Chalupa wrote: > Fixed benchmark uses main(int argc, char *argv[]) > but does not use the arguments, so we can replace them with void > > Signed-off-by: Marek Chalupa Reviewed-by: Bryce Harrington Pushed: To ssh://git.freedesktop.org/git/wayland/

Re: [PATCH weston 03/19] desktop-shell: make client_initiated a bool

On Wed, Jul 01, 2015 at 04:51:24PM +0800, Jonas Ådahl wrote: > On Wed, Jun 03, 2015 at 03:53:22PM -0500, Derek Foreman wrote: > > Make it a bool in both surface_move() and struct weston_move_grab > > > > Signed-off-by: Derek Foreman > > Reviewed-by: Jonas Ådahl Thanks, pushed: To ssh://git.fr

Re: [PATCH weston 01/19] text-backend: Replace focus_listener_initialized with a bool

On Wed, Jul 01, 2015 at 04:50:39PM +0800, Jonas Ådahl wrote: > On Wed, Jun 03, 2015 at 03:53:20PM -0500, Derek Foreman wrote: > > Signed-off-by: Derek Foreman > > Reviewed-by: Jonas Ådahl Reviewed-by: Bryce Harrington No longer applies to trunk though; plz refresh. > > > --- > > src/text-ba

Re: [PATCH] Documentation for the prepare_lock_surface event description, is incorrect

On Fri, Jul 10, 2015 at 09:33:46AM -0400, Christopher Michael wrote: > Thanks for the review. I've included an updated patch which fixes > the second 'shell' mentioned in the descrption to be 'client'. > > > Documentation for the prepare_lock_surface event description is > incorrect. The summary

Re: [PATCH] Documentation for the prepare_lock_surface event description, is incorrect

Thanks for the review. I've included an updated patch which fixes the second 'shell' mentioned in the descrption to be 'client'. Documentation for the prepare_lock_surface event description is incorrect. The summary says "Tell the client..." however the full-text description says "tell the shel

Re: [PATCH weston v3 04/11] make the backends compositor-neutral

On Sat, 27 Jun 2015 14:07:44 +0300 Giulio Camuffo wrote: > The backends used to have lots of code dealing with weston specific configs. > To allow them to be used by other compositors with their own configurations > remove all the usage of weston_config from the backends code and move it > in wes

Re: [PATCH weston 04/11] make the backends compositor-neutral

On Sat, 27 Jun 2015 12:43:09 +0300 Giulio Camuffo wrote: > 2015-06-24 4:46 GMT+03:00 Jon A. Cruz : > > On 06/22/2015 10:51 PM, Giulio Camuffo wrote: > >> 2015-06-23 3:52 GMT+03:00 Bill Spitzak : > >>> It seems like prev > >>> > >>> On Mon, Jun 22, 2015 at 1:02 PM, Giulio Camuffo > >>> wrote: > >

Re: [PATCH weston v3 03/11] compositor: move the main() to a new main.c file

On Sat, 27 Jun 2015 14:07:43 +0300 Giulio Camuffo wrote: > This commits starts to separate the libweston code from the weston > specific code. As such, the main() is moved, together with signals > handling and configuration handling. > --- > Makefile.am | 1 + > src/compositor.c | 805 +--

Re: [PATCH weston v3 02/11] compositor: add API to manage compositor instances

On Sat, 27 Jun 2015 14:07:42 +0300 Giulio Camuffo wrote: > This commit adds three new exported functions: > - weston_compositor_create() returns a new weston_compositor instance, > initializing it as the now removed weston_compositor_init() did. Hi, I almost suggested that while weston_composit

Re: [PATCH] xwayland: Check return of xcb_get_property_reply() before deref

On 07/10/2015 06:30 AM, Bryce Harrington wrote: From the man pages it appears this routine can return NULL on certain error conditions. Suggested by Marek Chalupa Signed-off-by: Bryce Harrington --- xwayland/selection.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xwayland/s

Re: [PATCH] documentation: Update documentation for calling wl_display_sync

On Wed, 8 Jul 2015 11:32:02 -0400 Christopher Michael wrote: > The documentation for the wl_registry global object is partially > incorrect. It stated that clients can use wl_display_sync immediately > after calling wl_display.get_registry however this is misleading. If a > client calls wl_displa

Re: [PATCH] xwayland: Always free reply from xcb_get_property_reply()

On Wed, Jul 01, 2015 at 05:12:27PM -0700, Bryce Harrington wrote: > On Wed, Jul 01, 2015 at 11:19:09AM +0200, Marek Chalupa wrote: > > On Wed, Jul 1, 2015 at 6:35 AM, Bryce Harrington > > wrote: > > > > > Signed-off-by: Bryce Harrington > > > --- > > > xwayland/selection.c | 10 +++--- > > >

Re: [PATCH] documentation: Update documentation for calling wl_display_sync

On Wed, Jul 08, 2015 at 11:32:02AM -0400, Christopher Michael wrote: > The documentation for the wl_registry global object is partially > incorrect. It stated that clients can use wl_display_sync immediately > after calling wl_display.get_registry however this is misleading. If a > client calls wl_

Re: [PATCH] tests: Don't increment variables inside an assert()

On Fri, Jun 19, 2015 at 04:13:11PM -0700, Jon A. Cruz wrote: > On 06/19/2015 03:58 PM, Bryce Harrington wrote: > > Addresses this warning found by Denis Denisov: > > > > [tests/array-test.c:137]: (warning) Assert statement modifies 'i'. > > > > Signed-off-by: Bryce Harrington > > --- > > test

Re: [PATCH] weston-launch: Drop redundant exit()

On Wed, Jul 01, 2015 at 11:52:28AM +0200, Marek Chalupa wrote: > Reviewed-by: Marek Chalupa Thanks, pushed as commit 430aee1c23a641cf3227bcde08419458ef2ea252 > > On Sat, Jun 20, 2015 at 12:47 AM, Bryce Harrington > wrote: > > > error(1, ...) already will exit, per man page: "If status has a

Re: [PATCH weston] clients: Simplify memory allocation with xzalloc()

On Wed, Jul 01, 2015 at 12:18:26PM +0200, Marek Chalupa wrote: > Reviewed-by: Marek Chalupa Thanks, landed: remote: I: patch #52362 updated using rev da9d8fa3e46cc035f94be6441452a7738327ecf0 remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/wayland/weston 430a

Re: [PATCH 2/2] fbdev-compositor: enumerate framebuffer device using udev

On Tue, 2015-07-07 at 07:21 -0500, Derek Foreman wrote: > On 06/07/15 03:31 AM, Sjoerd Simons wrote: > > On startup enumerate the available framebuffer devices using udev > > and > > setup an output for each device, unless a specific device is passed > > with > > --device in which case just creat

Re: [PATCH] Documentation for the prepare_lock_surface event description, is incorrect

On Fri, Jul 10, 2015 at 09:36:45AM +0300, Pekka Paalanen wrote: > On Thu, 9 Jul 2015 13:46:46 -0400 > Christopher Michael wrote: > > > Here is an updated patch which changes the wording to match what Giulio > > offered. > > > > Documentation for the prepare_lock_surface event description is > >