[PATCH libinput 3/4] touchpad: work thumb detection into the tap state machine

2015-07-07 Thread Peter Hutterer
Most thumbs are detected a few events into the sequence. Work this into parts of the tapping state machine. Only the most common use-case is handled here - if the first finger ends up being marked as a thumb, we return to the idle state and ignore that touch sequence. At any other state, we handle

[PATCH libinput 1/4] test: allow for a default value on LITEST_AUTO_ASSIGNS

2015-07-07 Thread Peter Hutterer
The touchpads currently all send a default value of 30 for ABS_PRESSURE. For some tests we want to have a custom pressure but changing all tests isn't sensible. So hook each device up to send a default value of 30 if it isn't overridden in the test itself. Signed-off-by: Peter Hutterer --- test/

[PATCH libinput 2/4] touchpad: add pressure-based thumb-detection

2015-07-07 Thread Peter Hutterer
All touchpad recordings seen so far show that a value above 100 is definitely a thumb or a palm. Values below are harder to discern, and the same isn't true for touchpads supporting ABS_PRESSURE instead of ABS_MT_PRESSURE. The handling of a touch is as outlined in tp_thumb_detect: * thumbs are ign

[PATCH libinput 4/4] test: add touchpad thumb detection tests

2015-07-07 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/touchpad.c | 389 1 file changed, 389 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index a9e9e4e..1c75676 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -3664,6 +3664,384 @@ STA

Re: [PATCH libinput v5 5/5] libinput: add orientation and size of touch point and pressure to the API

2015-07-07 Thread Peter Hutterer
On Mon, Jul 06, 2015 at 05:15:01PM +0200, Andreas Pokorny wrote: > This change adds four new properties to touch events. > major: diameter of the touch ellipse along the major axis > minor: diameter perpendicular to major axis > pressure: a pressure value mapped into the range [0,1] > orientation:

Re: cross-client surface references

2015-07-07 Thread Bill Spitzak
On Mon, Jul 6, 2015 at 11:53 PM, Pekka Paalanen wrote: > Multiple "handles" to the same underlying server-side object from > completely asynchronous contexts (different processes). I can't see > that ending well at all, considering that *nothing* we have ever > designed for Wayland accounts for

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Bill Spitzak
On Tue, Jul 7, 2015 at 11:11 AM, Daniel Stone wrote: > > More correctly, they are never called (which would happen on receipt > of a server event) because it only ever binds wl_output v1, where the > done/scale events were added in v2, so the server will never send > those events. > How come the

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Daniel Stone
Hi, On 7 July 2015 at 18:27, Christopher Michael wrote: > This patch adds missing placeholders for the wl_output listener functions > 'done' and 'scale. The placeholders added here are no-op function > placeholders as the done and scale callbacks are not used in the screenshot > client. More cor

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Christopher Michael
This patch adds missing placeholders for the wl_output listener functions 'done' and 'scale. The placeholders added here are no-op function placeholders as the done and scale callbacks are not used in the screenshot client. Signed-off-by: Chris Michael --- clients/screenshot.c | 14 +

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Christopher Michael
No problem. I'll update the patch and add some no-op functions instead. Thanks for the review :) Chris On 07/07/2015 01:18 PM, Jasper St. Pierre wrote: Wacky. In any case, NULL is not a valid listener, which is sort of terrible, but it is how it is. You need to create an empty function that do

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Jasper St. Pierre
Wacky. In any case, NULL is not a valid listener, which is sort of terrible, but it is how it is. You need to create an empty function that does nothing. On Tue, Jul 7, 2015 at 10:17 AM, Christopher Michael wrote: > On 07/07/2015 01:15 PM, Jasper St. Pierre wrote: >> >> Shouldn't missing fields i

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Christopher Michael
On 07/07/2015 01:15 PM, Jasper St. Pierre wrote: Shouldn't missing fields in structs be auto-initialized to 0 / NULL? I thought that was part of the C specification. I thought so also however when compiling some other code which was also creating a wl_output_listener, I uncovered the warnings

Re: [PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Jasper St. Pierre
Shouldn't missing fields in structs be auto-initialized to 0 / NULL? I thought that was part of the C specification. On Tue, Jul 7, 2015 at 8:52 AM, Christopher Michael wrote: > This patch adds missing placeholders for the wl_output listener > functions 'done' and 'scale. Currently these placehol

[PATCH] screenshooter: Add missing field initializers for wl_output_listener

2015-07-07 Thread Christopher Michael
This patch adds missing placeholders for the wl_output listener functions 'done' and 'scale. Currently these placeholders are being set to NULL as the done and scale callbacks are not used in the screenshot client. Signed-off-by: Chris Michael --- clients/screenshot.c | 4 +++- 1 file changed,

Re: [PATCH weston v6 1/4] Added simple unit/integration test framework and corresponding test program.

2015-07-07 Thread Pekka Paalanen
On Thu, 2 Jul 2015 23:36:44 -0700 "Jon A. Cruz" wrote: > Added a simple C-based test framework and an example program > that uses it to run through some simple unit tests. > > This is new code inspired primarily by the approaches of Google > Test, Boost Test, JUnit and TestNG. Factors of others

Re: [PATCH weston v6 4/4] Adding doxygen setup and info for the testing framework.

2015-07-07 Thread Pekka Paalanen
On Thu, 2 Jul 2015 23:36:47 -0700 "Jon A. Cruz" wrote: > Signed-off-by: Jon A. Cruz > --- > .gitignore | 2 + > Makefile.am| 22 +++ > configure.ac | 20 ++ > doc/doxygen/devtools.dox | 51

Re: [PATCH 0/2] Add support for multiple framebuffer outputs

2015-07-07 Thread Derek Foreman
On 06/07/15 03:31 AM, Sjoerd Simons wrote: > This patchset add support for driving multiple framebuffers from weston. First > patch drops the intermediate shadow buffer in the fbdev compositor, which > turned out to be both unneeded and buggy with non-0x0 rooted outputs second > patch actually adds

Re: [PATCH 2/2] fbdev-compositor: enumerate framebuffer device using udev

2015-07-07 Thread Derek Foreman
On 06/07/15 03:31 AM, Sjoerd Simons wrote: > On startup enumerate the available framebuffer devices using udev and > setup an output for each device, unless a specific device is passed with > --device in which case just create one for that device. > > Signed-off-by: Sjoerd Simons > --- > src/com

Re: [PATCH weston v6 3/4] Converted the config parser test to the new framework.

2015-07-07 Thread Pekka Paalanen
On Thu, 2 Jul 2015 23:36:46 -0700 "Jon A. Cruz" wrote: > Signed-off-by: Jon A. Cruz > --- > Makefile.am| 10 +- > tests/config-parser-test.c | 371 > + > 2 files changed, 320 insertions(+), 61 deletions(-) > > diff --git a/Makefile

Re: [PATCH weston v6 2/4] Enables output in the JUnit XML format.

2015-07-07 Thread Pekka Paalanen
On Thu, 2 Jul 2015 23:36:45 -0700 "Jon A. Cruz" wrote: > Adds basic support for optionally outputting in the XML format > commonly used by JUnit compatible tools. > > This format is supported by default by many tools, including > the Jenkins build system. It also is more detailed and > captures

[PATCH] screenshooter: correct output ordering of screencast recording when Y-flip is off

2015-07-07 Thread Tomohito Esaki
The screenshooter encoder wrote the output from either top-to-bottom or bottom-to-top, depending on the Y-flip setting, but wcap-decode only decodes from bottom-to-top. Make the encoder always output from bottom-to-top, to match the decoder, and flip the input (source) according to the Y-flip setti

[PATCH weston v3 5/5] compositor: Respect repaint-window when restarting repaint loop.

2015-07-07 Thread Pekka Paalanen
From: Mario Kleiner If a stopped repaint loop gets restarted due to posting of new damage, and this restart of the repaint loop happens late in the video refresh cycle, ie. already inside the repaint-window and thereby after the composition deadline for the current frame, then defer the actual ou

[PATCH weston v3 1/5] presentation-shm: Allow setting of delay before surface.commit

2015-07-07 Thread Pekka Paalanen
From: Mario Kleiner A new optional parameter "-d msecs" allows to specify a delay before the surface attach/damage/commit to shift the point in time when a surface update is committed. This allows to test how different client timings interact with the compositors repaint timing. Suggested by Pe

[PATCH weston v3 4/5] compositor-drm: Allow instant start of repaint loop. (v3)

2015-07-07 Thread Pekka Paalanen
From: Mario Kleiner drm_output_start_repaint_loop() incurred a delay of one refresh cycle by using a no-op page-flip to get an accurate vblank timestamp as reference. This causes unwanted lag whenever Weston exited its repaint loop, e.g., whenever an application wants to repaint with less than fu

[PATCH weston v3 2/5] shared: introduce timespec-util.h

2015-07-07 Thread Pekka Paalanen
From: Pekka Paalanen Copyright is set according to the moved code from compositor.c. Signed-off-by: Pekka Paalanen --- Makefile.am| 1 + shared/timespec-util.h | 61 ++ src/compositor.c | 21 + 3 files changed,

[PATCH weston v3 3/5] compositor,shared: add millihz_to_nsec()

2015-07-07 Thread Pekka Paalanen
From: Pekka Paalanen A helper to improbe readability. Cc: Daniel Stone Cc: Mario Kleiner Signed-off-by: Pekka Paalanen --- shared/timespec-util.h | 14 ++ src/compositor.c | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/shared/timespec-util.h b/share

[PATCH weston v3 0/5] Fast repaint loop start on DRM

2015-07-07 Thread Pekka Paalanen
From: Pekka Paalanen Hi, as promised in http://lists.freedesktop.org/archives/wayland-devel/2015-July/023192.html here are the patches. The above-mentioned email contains an analysis of the effects of these patches. My modifications are mostly stylish and code re-use. millihz_to_nsec() was sugg

Re: [PATCH libinput 3/5] litest: add nexus4 style touch screen without orientation

2015-07-07 Thread Peter Hutterer
On Mon, Jul 06, 2015 at 05:05:03PM +0200, Andreas Pokorny wrote: > This device provides a circular touch point size and and hence lacks > orientation. It will be used to test default value handling. > > Signed-off-by: Andreas Pokorny thanks, I've merged 1-4 and pushed it to master, still working

Re: cross-client surface references

2015-07-07 Thread Alexander Larsson
On Fri, 2015-07-03 at 18:10 +0800, Jonas Ã…dahl wrote: > > With "see" I suppose you mean "be aware and map", because it wouldn't > see the content. Sure, there is no need for the other client to ever see (or change) the contents of the window (or get events or whatever). This is purely about bein