Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On Mon, 29 Jun 2015 13:49:21 +1000 Peter Hutterer wrote: > Don't require a list_init() on a node before we can call list_remove on it, it > clutters up the code for little benefit. > > Signed-off-by: Peter Hutterer > --- > src/libinput-util.c | 3 +++ > 1 file changed, 3 insertions(+) > > dif

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On 06/29/2015 04:32 PM, Peter Hutterer wrote: > On Mon, Jun 29, 2015 at 04:00:51PM -0700, Ping Cheng wrote: >> I guess Bill meant "||" should be used instead of "&&"? One of the == NULL >> would lead to a crash... > > that'd would hide potential memory corruption or other bugs and won't show > up

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On Mon, Jun 29, 2015 at 04:00:51PM -0700, Ping Cheng wrote: > On Mon, Jun 29, 2015 at 3:09 PM, Peter Hutterer > wrote: > > > On Mon, Jun 29, 2015 at 12:37:26PM -0700, Bill Spitzak wrote: > > > On Sun, Jun 28, 2015 at 8:49 PM, Peter Hutterer < > > peter.hutte...@who-t.net> > > > wrote: > > > > > >

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On Mon, Jun 29, 2015 at 3:09 PM, Peter Hutterer wrote: > On Mon, Jun 29, 2015 at 12:37:26PM -0700, Bill Spitzak wrote: > > On Sun, Jun 28, 2015 at 8:49 PM, Peter Hutterer < > peter.hutte...@who-t.net> > > wrote: > > > > > > > > + if (elm->next == NULL && elm->prev == NULL) > > > +

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On Mon, Jun 29, 2015 at 12:37:26PM -0700, Bill Spitzak wrote: > On Sun, Jun 28, 2015 at 8:49 PM, Peter Hutterer > wrote: > > > > > + if (elm->next == NULL && elm->prev == NULL) > > + return; > > + > > elm->prev->next = elm->next; > > elm->next->prev = elm->prev

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

On 06/29/2015 10:20 PM, Bill Spitzak wrote: On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman mailto:der...@osg.samsung.com>> wrote: > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > +{ > + if (output->pipe > 1) > + return (output->pipe <<

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

On 29/06/15 03:20 PM, Bill Spitzak wrote: > On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman > wrote: > > > > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > > +{ > > + if (output->pipe > 1) > > + return (output-

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

On Fri, Jun 26, 2015 at 11:34 AM, Derek Foreman wrote: > > > +static unsigned int drm_waitvblank_pipe(struct drm_output *output) > > +{ > > + if (output->pipe > 1) > > + return (output->pipe << DRM_VBLANK_HIGH_CRTC_SHIFT) & > > + DRM_VBLANK_HIGH_CRTC_MA

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

On Sun, Jun 28, 2015 at 8:49 PM, Peter Hutterer wrote: > > + if (elm->next == NULL && elm->prev == NULL) > + return; > + > elm->prev->next = elm->next; > elm->next->prev = elm->prev; > elm->next = NULL; > You probably don't need to check both pointers

Re: Wayland Relative Pointer API Progress

On Sun, Jun 28, 2015 at 7:32 AM, x414e54 wrote: > > Clients do not draw the mouse cursor, either the GPU (using hardware > overlays) or the WM does. > Yes, I want to allow clients to use this CPU/WM support. Currently the client *has* to draw the cursor (and hide the hardware one) to sync it's p

[PATCH weston] build: Add -lrt for programs that use clock_gettime()

glibc requires this prior to 2.17, and we already do it in a few other places. Signed-off-by: Derek Foreman --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f493d16..347c64a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -65,7

[PATCH weston] compositor/clients: Protect CLOCK_BOOTTIME with ifdefs

CLOCK_BOOTTIME is a relatively new* feature that may not actually be present everywhere (I'm looking at you wheezy). Since our use of it is actually only cosmetic, I've just ifdef'd if. * No it isn't. Signed-off-by: Derek Foreman --- Theoretically, this could bite us if a new clock type is add

Re: [PATCH v3 weston] input: Pass axis events through pointer grab interfaces

Reviewed-By: Derek Foreman On 25/06/15 11:37 PM, Jonas Ådahl wrote: > Don't only send motions and buttons but also axis events through the > pointer grab interface. > > Signed-off-by: Jonas Ådahl > --- > > Changes since v2: > > * Added WL_EXPORT (since it is called from plugins). > * Added do

Re: [PATCH 03/10] cms-helper/static: Add "identity" builtin cms profile (v2)

On 28/06/15 10:17 PM, Mario Kleiner wrote: > On 06/26/2015 08:29 PM, Derek Foreman wrote: >> On 21/06/15 02:25 PM, Mario Kleiner wrote: >>> Allows to force loading an identity gamma table if >>> option icc_profile=identity is given in weston.ini for >>> an output. >>> >>> Some special display outpu

Re: [RFC wayland 1/2] client: Introduce 'proxy wrapper' concept

2015-06-29 14:30 GMT+03:00 Jonas Ådahl : > Arnaud Vrac discovered an issue in the libwayland client API causing > race conditions when doing round trips using the wl_display object using > non-default proxy queues. > > The problem is that one thread can read and dispatch events after > another thre

Re: [PATCH weston v5 6/6] Adding doxygen setup and info for the testing framework.

On Sat, 20 Jun 2015 15:47:48 -0700 "Jon A. Cruz" wrote: > Signed-off-by: Jon A. Cruz > --- > .gitignore| 2 + > doc/doxygen/devtools.dox | 55 > doc/doxygen/tooldev.doxygen | 11 ++ > doc/doxygen/tools.dox | 32 +++

[RFC wayland 2/2] tests/queue-test: Add test for proxy wrappers

Test that doing wl_display.sync on a wrapped proxy with a special queue works as expected. Signed-off-by: Jonas Ådahl --- tests/queue-test.c | 164 + 1 file changed, 164 insertions(+) diff --git a/tests/queue-test.c b/tests/queue-test.c index

[RFC wayland 1/2] client: Introduce 'proxy wrapper' concept

Arnaud Vrac discovered an issue in the libwayland client API causing race conditions when doing round trips using the wl_display object using non-default proxy queues. The problem is that one thread can read and dispatch events after another thread creates the wl_callback object but before it sets

libinput / weston-terminal : missing the caret char in the terminal (^)

Hi list, hi Peter and Bill, I actually did not have the possibility to enter the caret (https://en.wikipedia.org/wiki/Caret) char within the weston-terminal. Does anybody have an idea why or what is missing?? Or does anybody else have this issue ?? ( I have not looked into bugzilla but no entry fo

Re: [PATCH v2 weston 00/16] Atomic modesetting support

Hi, On 29 June 2015 at 07:53, Pekka Paalanen wrote: > On Fri, 26 Jun 2015 14:27:48 +0100 > Daniel Stone wrote: >> On 24 June 2015 at 13:11, Pekka Paalanen wrote: >> > I think the best way to cache state is to let it stay in the kernel, >> > and avoid submitting a disable followed by the old sta

Re: Wayland Relative Pointer API Progress

On Tue, 23 Jun 2015 11:57:23 -0700 Bill Spitzak wrote: > On Sun, Jun 21, 2015 at 11:46 PM, x414e54 wrote: > > > So in your system the compositor would have to block mouse cursor > > movement until an application had dispatched and processed its events. > > Literally in this instance the user w