Re: [PATCH v2 weston 00/16] Atomic modesetting support

On 22/06/15 11:25 AM, Daniel Stone wrote: > Hi, > Thanks to everyone who reviewed the previous series. This new series > cleans up the previous patches, introduces a few fixes (e.g. not relying > on a repaint to pull us out of DPMS), and crucially adds support for the > libdrm TEST_ONLY interface (

Re: [PATCH v2 weston 08/16] compositor-drm: Refactor sprite create/destroy into helpers

On 22/06/15 11:25 AM, Daniel Stone wrote: > From: Pekka Paalanen > > This moves the single sprite creation code from create_sprites() into a > new function. The readability clean-up is small, but my intention is to > write an alternate version of create_sprites(), and sharing the single > sprite

Re: [PATCH v2 weston 01/16] compositor-drm: Refactor initial mode out of create_output

On 22/06/15 11:25 AM, Daniel Stone wrote: > From: Pekka Paalanen > > Refactor the code for choosing the initial mode for an output from > create_output_for_connector() to drm_output_choose_initial_mode(). > > This makes create_output_for_connector() slightly easier to read. > > v2: Document eve

Re: [PATCH 06/10] compositor-drm: Handle more than two output crtcs per card

On 21/06/15 02:25 PM, Mario Kleiner wrote: > Allow proper handling of output->pipe > 1 to support > triple-head graphics cards etc. by using the "high-crtc" > support introduced in Linux 2.6.39 and libdrm 2.4.25 > around May 2011. > > Signed-off-by: Mario Kleiner Looks good to me. Reviewed-By:

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

On Thu, Jun 25, 2015 at 8:52 PM, Peter Hutterer wrote: > I think you're underestimating the precision of modern touchpads. The T440s > have a resolution of 42 units/mm, the x220 from several years ago had > somewhere around 130. The lowest value I've seen so far was 10. > Ok then it sounds like

Re: [PATCH 03/10] cms-helper/static: Add "identity" builtin cms profile (v2)

On 21/06/15 02:25 PM, Mario Kleiner wrote: > Allows to force loading an identity gamma table if > option icc_profile=identity is given in weston.ini for > an output. > > Some special display output devices, e.g., for > neuro-science applications, and special display > testing hardware need a guara

Re: [PATCH v3 weston] Introduce pointer locking and confinement protocol

On Thu, Jun 25, 2015 at 9:38 PM, Jonas Ådahl wrote: > This version adds support for changing the lock/confine region after the > lock was created. > > For pending wl_confined_pointer lock, the effect is the same as for > wl_locked_pointer. But for an already activated confinement, it affects the

Re: [PATCH wayland 0/3] "enum" and "bitfield" attributes for protocol XML files

On 26 June 2015 at 19:25, Bill Spitzak wrote: > I am very much in favor of this, and posted earlier a further patch that > uses this information to produce better protocol documentation. > > The above design is exactly correct (in particular the bitfield indicator is > on the enumeration, not the

Re: [PATCH v3 weston] Introduce wl_relative_pointer interface

On Thu, Jun 25, 2015 at 9:38 PM, Jonas Ådahl wrote: > A wl_relative_pointer object is an extension to the wl_pointer interface > only used for emitting relative pointer events. It will only emit events > when the parent pointer has focus. > > To get a relative pointer object, use the get_relative

Re: [PATCH wayland 0/3] "enum" and "bitfield" attributes for protocol XML files

I am very much in favor of this, and posted earlier a further patch that uses this information to produce better protocol documentation. The above design is exactly correct (in particular the bitfield indicator is on the enumeration, not the argument). On Fri, Jun 26, 2015 at 8:04 AM, Auke Booij

Re: [PATCH wayland] shm: Deprecate wl_shm_buffer_create()

On 26/06/15 01:29 AM, Pekka Paalanen wrote: > On Thu, 25 Jun 2015 16:26:06 -0500 > Derek Foreman wrote: > >> From irc: >> it creates a wl_buffer object in a way that no client can ever >> access the storage. >> >> So, let's replace it with abort(); and mark it with attribute >> deprecated i

[PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

There's no situation where a shm buffer without a pool makes sense, so we enforce the pool's existence a little more rigidly. Signed-off-by: Derek Foreman --- src/wayland-shm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c in

[PATCH wayland 1/3 v2] shm: Deprecate wl_shm_buffer_create()

From irc: it creates a wl_buffer object in a way that no client can ever access the storage. So, let's replace it with abort(); and mark it with WL_DEPRECATED in the header. Signed-off-by: Derek Foreman --- This time using WL_DEPRECATED src/wayland-server-core.h | 2 +- src/wayland-shm

[PATCH wayland 2/3] shm: Move deprecated function to the bottom of the file

In wayland-server.c we group the deprecated functions and disable doxygen for them. Do that here too. Signed-off-by: Derek Foreman --- src/wayland-shm.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index a9a

Re: [PATCH wayland 0/3] "enum" and "bitfield" attributes for protocol XML files

On 26 June 2015 at 16:02, Auke Booij wrote: > Although arguments can only refer to enums in specific cases (see the > scanner.c changes), this new protocol data should not break the C bindings. > It is thinkable that other bindings *do* use the data in a way that breaks > the protocol; however suc

[PATCH wayland 1/3] protocol: introduce the enum argument type

This improvement to the protocol allows you to refer to the kind of enum you are expecting. It also introduces a distinction between enums that are bitfields, ie that can be OR'ed together. --- protocol/wayland.dtd | 2 ++ protocol/wayland.xml | 32 2 files chang

[PATCH wayland 2/3] scanner: enforce correct argument type for enums

The scanner now checks whether arguments that have an associated have the right type. An argument with an enum attribute must be of type int or uint, and if the with that name has the bitfield attribute set to true, then the argument must be of type uint. --- src/scanner.c | 68 +

[PATCH wayland 3/3] doc: document new enum attributes and use such data in generated docs

The newly introduced "enum" and "bitfield" protocol XML attributes give additional semantic information, which we can use when generating the documentation. --- doc/publican/protocol-to-docbook.xsl | 9 + doc/publican/sources/Protocol.xml| 23 +-- 2 files changed,

[PATCH wayland 0/3] "enum" and "bitfield" attributes for protocol XML files

As per last April/May's "enum" attribute discussion, these patches introduce two new attributes to the protocol XML files. The "enum" attribute is given to uments of type (u)int, and indicates which should be used for that argument. The "bitfield" attribute can be given to s, and, if set to "true"

Re: [PATCH v2 weston 00/16] Atomic modesetting support

Hi, On 24 June 2015 at 13:11, Pekka Paalanen wrote: > On Wed, 24 Jun 2015 12:22:15 +0100 > Daniel Stone wrote: >> On 23 June 2015 at 13:28, Pekka Paalanen wrote: >> > On Tue, 23 Jun 2015 11:48:56 +0100 >> > Daniel Stone wrote: >> >> > So, the DRM planes we have not assigned yet but were enable

Re: [PATCH libinput] touchpad: disable tap drag lock by default

Hi, On 26-06-15 08:49, Peter Hutterer wrote: Similar to tapping, it's a feature that is useful but confusing if a user doesn't know it exists. It makes the touchpad appear laggy and slow to react in the best case, or appear like a stuck button in the worst case. Signed-off-by: Peter Hutterer

Re: [PATCH libinput 3/5] filter: pass the DPI to the acceleration filter

Hi Peter, On 26-06-15 06:08, Peter Hutterer wrote: Currently unused, but store the ratio of DPI:default DPI for later use. Signed-off-by: Peter Hutterer --- src/evdev.c| 3 ++- src/evdev.h| 3 --- src/filter.c | 7 ++- src/filter.h | 3 ++-