[PATCH libinput] touchpad: disable tap drag lock by default

2015-06-25 Thread Peter Hutterer
Similar to tapping, it's a feature that is useful but confusing if a user doesn't know it exists. It makes the touchpad appear laggy and slow to react in the best case, or appear like a stuck button in the worst case. Signed-off-by: Peter Hutterer --- diff of the test is a bit confusing, but i re

Re: [PATCH weston] text_backend: make destructor call explicit

2015-06-25 Thread Pekka Paalanen
On Thu, 25 Jun 2015 09:06:52 -0500 Derek Foreman wrote: > Oops, I spoke too soon... > > On 25/06/15 09:01 AM, Derek Foreman wrote: > > On 24/06/15 08:28 AM, Pekka Paalanen wrote: > >> From: Pekka Paalanen > >> > >> We used to rely on the order in which the > >> weston_compositor::destroy_signal

Re: [PATCH wayland] shm: Deprecate wl_shm_buffer_create()

2015-06-25 Thread Pekka Paalanen
On Thu, 25 Jun 2015 16:26:06 -0500 Derek Foreman wrote: > From irc: > it creates a wl_buffer object in a way that no client can ever > access the storage. > > So, let's replace it with abort(); and mark it with attribute > deprecated in the header. > > Signed-off-by: Derek Foreman > ---

[PATCH v3 weston] desktop-shell: Track the black surface by its view

2015-06-25 Thread Jonas Ådahl
In preparation for further refactoring. Signed-off-by: Jonas Ådahl Signed-off-by: Arnaud Vrac --- Changes since v2: * Squashed in crash fix by Arnaud. desktop-shell/shell.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/desktop-shell

[PATCH v3 weston] clients: Add API for pointer locking and pointer confinement

2015-06-25 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- Changes since v2: * Automatically update the lock/confine region when window is resized. Makefile.am | 6 +- clients/window.c | 316 +++ clients/window.h | 62 +++ 3 files changed, 383 insertio

[PATCH weston] clients/clickdot: Toggle maximized state with 'm'

2015-06-25 Thread Jonas Ådahl
In order to test warping when pointer confinement region changes, add key binding to the maximized state without using the mouse. Signed-off-by: Jonas Ådahl --- This patch is an addition to the pointer lock series. Its purpose is to demonstrate the changing of the lock/confine regions without br

[PATCH v3 weston] desktop-shell: Make activate_binding take a view instead of surface

2015-06-25 Thread Jonas Ådahl
In preparation for further refactoring. This patch also removes a redundant NULL check. Since we pass views, and views will always have an associated surface, there is no point of checking if it has. Signed-off-by: Jonas Ådahl --- Changes since v2: * Removed redundant NULL check. desktop-she

[PATCH v3 weston] input: Pass axis events through pointer grab interfaces

2015-06-25 Thread Jonas Ådahl
Don't only send motions and buttons but also axis events through the pointer grab interface. Signed-off-by: Jonas Ådahl --- Changes since v2: * Added WL_EXPORT (since it is called from plugins). * Added doxygen (since its WL_EXPORT:ed) desktop-shell/exposay.c| 7 +++ desktop-shell/s

[PATCH v3 weston] input: Support non-rectangular pointer confine regions

2015-06-25 Thread Jonas Ådahl
This patch adds support for when the resulting pointer confinement region is not a rectangle. Support for this is implemented by converting the rectangles of the region into the regions outer border. Pointer motions are then clamped to these borders in order to not escape the confinement region.

[PATCH v3 weston] Introduce pointer locking and confinement protocol

2015-06-25 Thread Jonas Ådahl
This patch introduces a new protocol for locking and confining a pointer. It consists of a new global object with two requests; one for locking the surface to a position, one for confining the pointer to a given region. See pointer-lock.xml for details of the protocol. In this patch, only the loc

[PATCH v3 weston] window: Add API for manually set confine region

2015-06-25 Thread Jonas Ådahl
We can use this to test more complex confine regions. Signed-off-by: Jonas Ådahl --- Changes since v2: * Added support for updating the manually set confine region. clients/window.c | 69 clients/window.h | 11 + 2 files chang

[PATCH v3 weston] Introduce wl_relative_pointer interface

2015-06-25 Thread Jonas Ådahl
A wl_relative_pointer object is an extension to the wl_pointer interface only used for emitting relative pointer events. It will only emit events when the parent pointer has focus. To get a relative pointer object, use the get_relative_pointer request of the global wl_relative_pointer_manager obje

[PATCH libinput 4/5] tools: add --dpi= arg to ptraccel-debug

2015-06-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/ptraccel-debug.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/ptraccel-debug.c b/tools/ptraccel-debug.c index 0cfe2b7..b2dd1f9 100644 --- a/tools/ptraccel-debug.c +++ b/tools/ptraccel-debug.c @@ -168,6 +168,7 @@

[PATCH libinput 5/5] filter: add a custom low-dpi acceleration

2015-06-25 Thread Peter Hutterer
Motion normalization does not work well for devices below the default 1000dpi rate. A 400dpi mouse's minimum movement generates a 2.5 normalized motion, causing it to skip pixels at low speeds even when unaccelerated. Likewise, we don't want 1000dpi mice to be normalized to a 400dpi mouse, it feel

[PATCH libinput 3/5] filter: pass the DPI to the acceleration filter

2015-06-25 Thread Peter Hutterer
Currently unused, but store the ratio of DPI:default DPI for later use. Signed-off-by: Peter Hutterer --- src/evdev.c| 3 ++- src/evdev.h| 3 --- src/filter.c | 7 ++- src/filter.h | 3 ++- src/libinput-util.h| 3 +++ tools/ptraccel-debug.c | 3

[PATCH libinput 2/5] test: add a low-dpi mouse test device

2015-06-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/Makefile.am| 1 + test/litest-mouse-low-dpi.c | 75 + test/litest.c | 2 ++ test/litest.h | 1 + 4 files changed, 79 insertions(+) create mode 100644 test/litest-mouse-lo

[PATCH libinput 1/5] Drop motion normalization of unaccelerated deltas

2015-06-25 Thread Peter Hutterer
This simply doesn't work for low-dpi mice. Normalizing a 400dpi mouse to a 1000dpi mouse forces a minimum movement of 2.5 units and the resulting pixel jumps. It is impossible for the caller to detect whether the jump was caused by a single motion or multiple motion events. This is technically an

Re: [PATCH weston] shell: Switch middle and right mouse bindings

2015-06-25 Thread Peter Hutterer
On Thu, Jun 25, 2015 at 04:03:30PM -0500, Derek Foreman wrote: > Currently rotate is on the right mouse button and resize is on the middle. > > As fantastic as rotating windows is, it's probably nicer to have resize on > the right button, especially for anyone with only 2 buttons. > > Signed-off-

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread Peter Hutterer
On Thu, Jun 25, 2015 at 08:12:36AM -0700, Bill Spitzak wrote: > Actually it seems incorrect to store the number of device units per mm as an > integer, since I would guess this number is near 1. However I don't know how > touchpads work so maybe the resolution is much much finer than I would > gues

[PATCH wayland] shm: Deprecate wl_shm_buffer_create()

2015-06-25 Thread Derek Foreman
From irc: it creates a wl_buffer object in a way that no client can ever access the storage. So, let's replace it with abort(); and mark it with attribute deprecated in the header. Signed-off-by: Derek Foreman --- src/wayland-server-core.h | 3 ++- src/wayland-shm.c | 29 +---

[PATCH weston] shell: Switch middle and right mouse bindings

2015-06-25 Thread Derek Foreman
Currently rotate is on the right mouse button and resize is on the middle. As fantastic as rotating windows is, it's probably nicer to have resize on the right button, especially for anyone with only 2 buttons. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 4 ++-- 1 file changed, 2 i

[PATCH weston 1/3] text: Launch input method in text_backend_init

2015-06-25 Thread Derek Foreman
Previously we tried to launch the input method every time a seat was created, and the launch function would notice it was running and not bother to actually launch. Signed-off-by: Derek Foreman --- src/text-backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tex

[PATCH weston 0/3] Launch the virtual keyboard with weston_client_start()

2015-06-25 Thread Derek Foreman
This simplifies the launching of the virtual keyboard a little bit and removes a tricky race condition that can occur if the keyboard has just died and the compositor is shutting down. It's on top of pekka's http://patchwork.freedesktop.org/patch/52700/ and supersedes my http://patchwork.freedeskt

[PATCH weston 2/3] text: Don't track binding in struct text_backend

2015-06-25 Thread Derek Foreman
The binding is only used for preventing launch, and we've already got the pid for that. With multiple seats there are multiple bindings, so if the most recent binding unbinds it will clear the pointer, so using it like this is risky anyway. Signed-off-by: Derek Foreman --- src/text-backend.c |

[PATCH weston 3/3] text: Switch to weston_client_start instead of weston_client_launch

2015-06-25 Thread Derek Foreman
We really don't want to deal with sighups and pids. It's far easier to just deal with the client destroyed signal to respawn the input method. Inspiration taken from Pekka's commit 826dc14ec43b92d This fixes a potential crash on shutdown. If the input method client pointer is still set (sighup

Re: [PATCH weston v5 2/6] By default, stop test execution if unrecognized parameters are encountered.

2015-06-25 Thread Jon A. Cruz
On 06/25/2015 05:36 AM, Pekka Paalanen wrote: > On Sat, 20 Jun 2015 15:47:44 -0700 > "Jon A. Cruz" wrote: > >> Signed-off-by: Jon A. Cruz >> --- >> tools/zunitc/src/main.c | 11 ++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/tools/zunitc/src/main.c b/tools/zun

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread Bill Spitzak
Actually it seems incorrect to store the number of device units per mm as an integer, since I would guess this number is near 1. However I don't know how touchpads work so maybe the resolution is much much finer than I would guess? To avoid floating point it might work to store the size of the

[PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread spitzak
From: Bill Spitzak (changes from previous version: rounds the guess and changes 0 to 1, removed unused variables) Instead a default resolution is set if the device does not claim one. The selected value is a guess that the trackpad is 67 mm tall and that the device units are square. This estima

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-25 Thread Pekka Paalanen
On Tue, 23 Jun 2015 21:55:41 -0700 "Jon A. Cruz" wrote: > > On 06/22/2015 07:19 AM, Pekka Paalanen wrote: > > Hi Jon, > > > > this is just a quick casual look, so I'm only mentioning what cought my > > eye but mostly ignoring minor issues like style. > > > > I know you sent a v5 series, but it

Re: [PATCH weston v5 5/6] Converted the config parser test to the new framework.

2015-06-25 Thread Pekka Paalanen
On Sat, 20 Jun 2015 15:47:47 -0700 "Jon A. Cruz" wrote: > Signed-off-by: Jon A. Cruz > --- > Makefile.am| 9 +- > tests/config-parser-test.c | 368 > + > 2 files changed, 310 insertions(+), 67 deletions(-) Hi Jon, this is a nice e

Re: [PATCH weston] text_backend: make destructor call explicit

2015-06-25 Thread Derek Foreman
On 24/06/15 08:28 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > We used to rely on the order in which the > weston_compositor::destroy_signal callbacks happened, to not access > freed memory. Don't know when, but this broke at least with ivi-shell, > which caused crashes in random places o

Re: [PATCH weston] text_backend: make destructor call explicit

2015-06-25 Thread Derek Foreman
Oops, I spoke too soon... On 25/06/15 09:01 AM, Derek Foreman wrote: > On 24/06/15 08:28 AM, Pekka Paalanen wrote: >> From: Pekka Paalanen >> >> We used to rely on the order in which the >> weston_compositor::destroy_signal callbacks happened, to not access >> freed memory. Don't know when, but t

Re: [PATCH weston v5 4/6] Enables output in the JUnit XML format.

2015-06-25 Thread Pekka Paalanen
On Sat, 20 Jun 2015 15:47:46 -0700 "Jon A. Cruz" wrote: > Adds basic support fo optionally outputting in the XML format > commonly used by JUnit compatible tools. > > This format is supported by default by many tools, including > the Jenkins build system. It also is more detailed and > captures

Re: [PATCH weston v5 3/6] Enables output in the Test Anything Protocol (TAP) format.

2015-06-25 Thread Pekka Paalanen
On Sat, 20 Jun 2015 15:47:45 -0700 "Jon A. Cruz" wrote: > Adds basic support for optionally outputting in the Test Anything > Protocol (TAP) format. > > This format is a bit older and simplistic, but certain tools > handle it well. > > https://testanything.org/ > Hi Jon, ok, so we can produc

Re: [PATCH weston 0/3] Rework the launcher infrastructure

2015-06-25 Thread David Herrmann
Hi On Thu, Mar 19, 2015 at 4:04 AM, Jasper St. Pierre wrote: > Since the time that the logind launcher integration was written, it has > since gained a lot of features that mean that we don't have to touch > the TTY or VT ioctls ourselves. > > Refactor the launcher system so that we have three di

Re: [PATCH weston v5 2/6] By default, stop test execution if unrecognized parameters are encountered.

2015-06-25 Thread Pekka Paalanen
On Sat, 20 Jun 2015 15:47:44 -0700 "Jon A. Cruz" wrote: > Signed-off-by: Jon A. Cruz > --- > tools/zunitc/src/main.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c > index cc86185..8179807 100644 > --- a/to

Re: autostart of app(s) while weston starts

2015-06-25 Thread Pekka Paalanen
On Thu, 25 Jun 2015 11:08:30 +0200 Quentin Glidic wrote: > On 2015-06-25 08:45, Pekka Paalanen wrote: > > On Wed, 24 Jun 2015 09:25:36 -0700 > > Bill Spitzak wrote: > > > >> On Wed, Jun 24, 2015 at 2:05 AM, Pekka Paalanen > >> wrote: > >> > >>> On Wed, 24 Jun 2015 09:40:51 +0200 > >>> Christi

Re: autostart of app(s) while weston starts

2015-06-25 Thread Quentin Glidic
On 2015-06-25 08:45, Pekka Paalanen wrote: > On Wed, 24 Jun 2015 09:25:36 -0700 > Bill Spitzak wrote: > >> On Wed, Jun 24, 2015 at 2:05 AM, Pekka Paalanen wrote: >> >>> On Wed, 24 Jun 2015 09:40:51 +0200 >>> Christian Hartmann wrote: >>> Hi, is it possible to autostart of app(s)

Re: [PATCH 14/14] tests: test set for ivi-shell notification with bad condition in server side

2015-06-25 Thread Pekka Paalanen
On Wed, 24 Jun 2015 23:26:38 + "Tanibata, Nobuhiko (ADITJ/SWG)" wrote: > Hi Jon, > > Thank you for your effort to review them! > > Best regards, > Nobuhiko Tanibata > > > -Original Message- > > From: wayland-devel > > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf O

Re: [PATCH libinput] evdev: store the device dimensions

2015-06-25 Thread Hans de Goede
Hi, On 25-06-15 09:07, Peter Hutterer wrote: We use width/height often enough that storing it once is better than calculating it on each event. Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 18 ++

Re: [PATCH libinput] filter: reduce deceleration to minimal speeds only

2015-06-25 Thread Hans de Goede
Hi, On 25-06-15 08:08, Peter Hutterer wrote: Deceleration at low speeds is intended to enhance precision when moving the pointer slowly. However, the adaptive deceleration we used was badly calibrated, at slow-but-normal speeds the pointer became too slow to manouver. We don't want to drop dece

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-25 Thread Pekka Paalanen
On Thu, 25 Jun 2015 00:31:56 +0900 JoonCheol Park wrote: > Thanks pq and all, > > I didn't think this would be hot topic :-) All reply from all in this > thread was very very helpful to understand current weston project for me. > > > 2015-06-24 16:52 GMT+09:00 Pekka Paalanen : > > > Hi all >

[PATCH libinput] evdev: store the device dimensions

2015-06-25 Thread Peter Hutterer
We use width/height often enough that storing it once is better than calculating it on each event. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 18 -- src/evdev-mt-touchpad-edge-scroll.c | 4 ++-- src/evdev-mt-touchpad.c | 12