[PATCH libinput] touchpad: disable right-edge palm detection for edge scrolling

2015-06-15 Thread Peter Hutterer
Most scroll motions would be labelled a palm. https://bugs.freedesktop.org/show_bug.cgi?id=90980 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 2 +- src/evdev-mt-touchpad.c | 3 +++ src/evdev-mt-touchpad.h | 3 +++ test/touchpad.c

Re: [PATCH libinput] COYPING: Update boilerplate from MIT X11 to MIT Expat license

2015-06-15 Thread Peter Hutterer
On Thu, Jun 11, 2015 at 12:16:31PM +1000, Peter Hutterer wrote: > To quote Bryce Harrington from [1]: > "MIT has released software under several slightly different licenses, > including the old 'X11 License' or 'MIT License'. Some code under this > license was in fact included in X.org's Xserver i

[PATCH libinput] touchpad: mark ALPS touchpads for middle button emulation

2015-06-15 Thread Peter Hutterer
Alps devices don't know if there is a physical middle button on the touchpad, so they always report one. Since a large number of touchpads only have two buttons, enable middle button emulation by default. Those that really don't want it can play with configuration options, everyone else has it work

Re: [PATCH libinput 2/2] touchpad: set the finger pin distance to 5mm where possible

2015-06-15 Thread Peter Hutterer
On Mon, Jun 15, 2015 at 09:54:18AM +0200, Hans de Goede wrote: > Hi, > > On 15-06-15 06:40, Peter Hutterer wrote: > >On touchpads with resolutions, use a 5mm motion threshold before we unpin the > >finger (allow motion events while a clickpad button is down). This should > >remove any erroneous fi

Re: [PATCH] protocol/text: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-15 Thread Bryce Harrington
On Mon, Jun 15, 2015 at 03:27:51PM -0700, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington I just went ahead and landed this since at this point there's nothing controversial here. Bryce > --- > protocol/text.xml | 38 ++ > 1 file changed, 18 insert

Re: [PATCH weston 0/4] Extract common macros to single header.

2015-06-15 Thread Bryce Harrington
On Mon, Jun 15, 2015 at 01:48:27PM -0700, Bryce Harrington wrote: > On Mon, Jun 15, 2015 at 10:57:31AM +1000, Peter Hutterer wrote: > > On Fri, Jun 12, 2015 at 09:25:01PM -0700, Jon A. Cruz wrote: > > > As a follow-up to review feedback from Peter Hutterer this > > > set moves a few duplicated macr

Re: [PATCH v2 wayland] build: Allow disabling building of wayland libraries

2015-06-15 Thread Peter Hutterer
On Mon, Jun 15, 2015 at 11:07:35AM -0500, Derek Foreman wrote: > When cross-compiling it may be useful to build only the wayland-scanner > natively. This patch makes it possible to disable build of the libraries. > > This also allows us to relax some of the build requirements when compiling > jus

[PATCH weston v2 1/4] Remove redundant #include path component.

2015-06-15 Thread Jon A. Cruz
Using the parent '../' path component in #include statements makes the codebase more rigid and is redundant due to proper -I use. Signed-off-by: Jon A. Cruz --- clients/calibrator.c | 2 +- clients/desktop-shell.c| 4 ++-- clients/dnd.c | 2 +- clie

[PATCH weston v2 3/4] Moved the MIN() macro to the helper include.

2015-06-15 Thread Jon A. Cruz
Removed multiple definitions of the MIN() macro from existing locations and unified with a single definition. Updated sources to use the shared version. Signed-off-by: Jon A. Cruz --- clients/nested.c | 2 -- clients/weston-info.c | 2 -- clients/window.c | 2 -- desktop-shell/shell

[PATCH weston v2 4/4] Unified multiple definitions of container_of() macro.

2015-06-15 Thread Jon A. Cruz
Removed duplicate definitions of the container_of() macro and refactored sources to use the single implementation. Signed-off-by: Jon A. Cruz --- clients/clickdot.c | 1 + clients/desktop-shell.c | 1 + clients/window.h| 4 desktop-shell/e

[PATCH weston v2 2/4] Moved helper macro to a discrete include file.

2015-06-15 Thread Jon A. Cruz
To help reduce code duplication and also 'kitchen-sink' includes the ARRAY_LENGTH macro was moved to a stand-alone file and referenced from the sources consuming it. Other macros will be added in subsequent passes. Signed-off-by: Jon A. Cruz --- Makefile.am| 1 + clients

[PATCH weston 0/4] Extract common macros to single header.

2015-06-15 Thread Jon A. Cruz
As a follow-up to review feedback from Peter Hutterer this set moves a few duplicated macros into a common header, including ARRAY_LENGTH. Changes since v1: - Added example to container_of() doc comment. Jon A. Cruz (4): Remove redundant #include path component. Moved helper macro to a discre

[PATCH] protocol/text: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-15 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- protocol/text.xml | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/protocol/text.xml b/protocol/text.xml index 9cf78b3..0f824ea 100644 --- a/protocol/text.xml +++ b/protocol/text.xml @@ -4,26 +4,24 @@

Re: [PATCH libinput] touchpad: make the hysteresis dependent on physical distance

2015-06-15 Thread Peter Hutterer
On Mon, Jun 15, 2015 at 10:56:21AM -0700, Bill Spitzak wrote: > My idea is that there still would be an indication of "fake resolution", > but when that is turned on it also fills in the resolution values with this > value as a guess. Then anything that fails to test the fake resolution flag > woul

Re: [PATCH weston 0/4] Extract common macros to single header.

2015-06-15 Thread Bryce Harrington
On Mon, Jun 15, 2015 at 10:57:31AM +1000, Peter Hutterer wrote: > On Fri, Jun 12, 2015 at 09:25:01PM -0700, Jon A. Cruz wrote: > > As a follow-up to review feedback from Peter Hutterer this > > set moves a few duplicated macros into a common header, > > including ARRAY_LENGTH. > > > > Jon A. Cruz

[PATCH v3 wayland] build: Allow disabling building of wayland libraries

2015-06-15 Thread Derek Foreman
When cross-compiling it may be useful to build only the wayland-scanner natively. This patch makes it possible to disable build of the libraries. This also allows us to relax some of the build requirements when compiling just the scanner. Signed-off-by: Derek Foreman --- Changes from v1: Move n

Re: [PATCH libinput] touchpad: make the hysteresis dependent on physical distance

2015-06-15 Thread Bill Spitzak
My idea is that there still would be an indication of "fake resolution", but when that is turned on it also fills in the resolution values with this value as a guess. Then anything that fails to test the fake resolution flag would at least tend to produce stuff the same size as this does. It does s

Re: [PATCH weston 00/17] Update weston from MIT/X11 to MIT/Expat license

2015-06-15 Thread Bryce Harrington
On Mon, Jun 15, 2015 at 02:21:09PM +0300, Pekka Paalanen wrote: > Hi Bryce, > > well handled. > > On Fri, 12 Jun 2015 15:04:37 -0700 > Bryce Harrington wrote: > > > Following on from the wayland license switch, do the same for Weston, > > along with some minor cleanup. > > > > Several files we

[PATCH v2 wayland] build: Allow disabling building of wayland libraries

2015-06-15 Thread Derek Foreman
When cross-compiling it may be useful to build only the wayland-scanner natively. This patch makes it possible to disable build of the libraries. This also allows us to relax some of the build requirements when compiling just the scanner. Signed-off-by: Derek Foreman --- Move noinst_LTLIBRARIE

Re: [PATCH wayland] build: Allow disabling building of wayland libraries

2015-06-15 Thread Derek Foreman
On 14/06/15 07:48 PM, Peter Hutterer wrote: > On Fri, Jun 12, 2015 at 03:01:24PM -0500, Derek Foreman wrote: >> When cross-compiling it may be useful to build only the wayland-scanner >> natively. This patch makes it possible to disable build of the libraries. >> >> This also allows us to relax so

Re: [PATCH weston 00/17] Update weston from MIT/X11 to MIT/Expat license

2015-06-15 Thread Pekka Paalanen
Hi Bryce, well handled. On Fri, 12 Jun 2015 15:04:37 -0700 Bryce Harrington wrote: > Following on from the wayland license switch, do the same for Weston, > along with some minor cleanup. > > Several files were *not* updated: > > hash.* - These include a no-advertising clause appended to th

Re: [PATCH] Whitespace corrections

2015-06-15 Thread Pekka Paalanen
On Fri, 12 Jun 2015 15:04:39 -0700 Bryce Harrington wrote: > From: Murray Calavera > > Signed-off-by: Murray Calavera > Signed-off-by: Bryce Harrington > --- > clients/window.h | 4 ++-- > shared/cairo-util.h | 2 +- > src/compositor-x11.c | 2 +- > src/libbacklight.c

Re: [PATCH v2 2/2] cursor: Update printed license from MIT "X11" to MIT "Expat"

2015-06-15 Thread Pekka Paalanen
On Fri, 12 Jun 2015 16:44:16 -0700 Bryce Harrington wrote: > The code generates a cursor-data.h file, with licensing information. > Change this from the MIT "X11" license to MIT "Expat" license for > consistency with the rest of Wayland. > > Signed-off-by: Bryce Harrington > --- > > Update: Cl

Re: [PATCH v2 1/2] publican: Update docs license from MIT "X11" to MIT "Expat" style

2015-06-15 Thread Pekka Paalanen
On Fri, 12 Jun 2015 16:44:15 -0700 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > doc/publican/sources/Book_Info.xml | 46 > +++--- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/doc/publican/sources/Book_Info.xml > b/d

Re: [PATCH libinput 2/2] touchpad: set the finger pin distance to 5mm where possible

2015-06-15 Thread Hans de Goede
Hi, On 15-06-15 06:40, Peter Hutterer wrote: On touchpads with resolutions, use a 5mm motion threshold before we unpin the finger (allow motion events while a clickpad button is down). This should remove any erroneous finger movements while clicking, at the cost of having to move the finger a bi

Re: [PATCH libinput 1/2] touchpad: fix pinned finger drifting

2015-06-15 Thread Hans de Goede
Hi, On 15-06-15 06:40, Peter Hutterer wrote: This caused the finger to be unpinned on the first motion event after the click, effectively disabling this feature. Signed-off-by: Peter Hutterer Oops, my bad (IIRC), looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evd