Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Pekka Paalanen
On Wed, 10 Jun 2015 08:48:01 +1000 Peter Hutterer wrote: > On Tue, Jun 09, 2015 at 03:00:26PM -0700, Jon A. Cruz wrote: > > Instead of a full strcmp against an empty string, could we just check > > the first char? > > > > if (!text_backend->input_method.path[0]) > > does this really gain us

Re: [PATCH weston 2/2] Move text_backend initialization into the shell plugin

2015-06-09 Thread Pekka Paalanen
On Tue, 9 Jun 2015 20:24:55 + Murray Calavera wrote: > Whether a input method is used should be the responsibility > of the shell because some shells may not want to implement > an input method at all. > > Signed-off-by: Murray Calavera Hi, very good. > --- > desktop-shell/shell.c | 3

Re: [PATCH weston 1/2] text backend should handle existing seats on init.

2015-06-09 Thread Pekka Paalanen
On Tue, 9 Jun 2015 20:24:26 + Murray Calavera wrote: > Currently the text backend will crash the compositor if > seats have already been created. Hi, crash? I didn't realize I should've been looking for causes of crashes, I only thought the input method simply didn't work on the initial se

Re: libinput Acer c720 Observations

2015-06-09 Thread Peter Hutterer
On Fri, Jun 05, 2015 at 04:22:51PM -0600, Wade Berrier wrote: > Hello, > > I'm running libinput 0.17 on Fedora 22 (compiled and installed the > rawhide src.rpm) on an Acer c720 chromebook. The observations below > also apply to 0.15 that shipped with the distro, but I upgraded to see > if it chan

[PATCH libinput] touchpad: restart the motion filter on touch begin

2015-06-09 Thread Peter Hutterer
Our motion filter takes the last couple of vectors to calculate speed, provided the direction stays the same and it is within a certain timeout. It does not take into account lifting the finger, so the velocity on the first event is off. Real-world impact is mainly on scrolling. Before commit 289e

Re: [PATCH v2 weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-09 Thread Jon A. Cruz
On 06/09/2015 04:55 PM, Derek Foreman wrote: > On 09/06/15 06:24 PM, Jon A. Cruz wrote: >> On 06/08/2015 09:46 AM, Derek Foreman wrote: >>> We were loading modules out of the system dirs unconditionally, so >>> tests that loaded modules would use the system ones, or fail if >>> they weren't insta

Re: [PATCH v2 weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-09 Thread Derek Foreman
On 09/06/15 06:24 PM, Jon A. Cruz wrote: > On 06/08/2015 09:46 AM, Derek Foreman wrote: >> We were loading modules out of the system dirs unconditionally, so >> tests that loaded modules would use the system ones, or fail if >> they weren't installed. >> >> Reviewed-By: Pekka Paalanen >> Signed-of

Re: [PATCH v2 weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

2015-06-09 Thread Jon A. Cruz
On 06/08/2015 09:46 AM, Derek Foreman wrote: > We were loading modules out of the system dirs unconditionally, so > tests that loaded modules would use the system ones, or fail if > they weren't installed. > > Reviewed-By: Pekka Paalanen > Signed-off-by: Derek Foreman > --- > src/compositor.c |

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Peter Hutterer
On Tue, Jun 09, 2015 at 03:00:26PM -0700, Jon A. Cruz wrote: > Instead of a full strcmp against an empty string, could we just check > the first char? > > if (!text_backend->input_method.path[0]) does this really gain us anything worthwhile? Cheers, Peter > On 06/09/2015 01:28 PM, Murray

Re: [PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Jon A. Cruz
Instead of a full strcmp against an empty string, could we just check the first char? if (!text_backend->input_method.path[0]) On 06/09/2015 01:28 PM, Murray Calavera wrote: > This allows a user to explicitly disable the input > method by setting path to blank; > > Signed-off-by: Murray Cal

Re: [PATCH weston] Add config option to disable input method

2015-06-09 Thread Murray Calavera
Hello again. I tried again, thanks for being so patient with me. Here are the patches: http://patchwork.freedesktop.org/patch/51464/ http://patchwork.freedesktop.org/patch/51465/ And the optional one: http://patchwork.freedesktop.org/patch/51466/ > This is all just Weston-specifics anyway, right

[PATCH weston] cleanup text backend style

2015-06-09 Thread Murray Calavera
Signed-off-by: Murray Calavera --- src/text-backend.c | 157 + 1 file changed, 98 insertions(+), 59 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 01cb70a..64a3c1b 100644 --- a/src/text-backend.c +++ b/src/text-backend.

[PATCH weston] don't attempt to start input method if path is empty

2015-06-09 Thread Murray Calavera
This allows a user to explicitly disable the input method by setting path to blank; Signed-off-by: Murray Calavera --- src/text-backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/text-backend.c b/src/text-backend.c index 64a3c1b..3c349d4 100644 --- a/src/text-backend.c +++ b/sr

[PATCH weston 2/2] Move text_backend initialization into the shell plugin

2015-06-09 Thread Murray Calavera
Whether a input method is used should be the responsibility of the shell because some shells may not want to implement an input method at all. Signed-off-by: Murray Calavera --- desktop-shell/shell.c | 3 +++ ivi-shell/ivi-shell.c | 3 +++ src/compositor.c | 2 -- 3 files changed, 6 inserti

[PATCH weston 1/2] text backend should handle existing seats on init.

2015-06-09 Thread Murray Calavera
Currently the text backend will crash the compositor if seats have already been created. Signed-off-by: Murray Calavera --- src/text-backend.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index daae03c

Re: [PATCH wayland] protocol: define further the behavior of input on the presence of grabs

2015-06-09 Thread Jasper St. Pierre
What is the value of clients having this information? I think we've tried to hide grab semantics from the point of view of the client and simply say "we can revoke input at any time, including in response to a request you make", which gives us, the compositor, a lot more leeway with future possibil

[PATCH weston] xdg-shell: define further the behavior of input devices around xdg_popup

2015-06-09 Thread Carlos Garnacho
This consolidates the behavior that compositors must implement when xdg_popups cause input to be redirected into the popup surface. Signed-off-by: Carlos Garnacho --- protocol/xdg-shell.xml | 12 1 file changed, 12 insertions(+) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-sh

[PATCH wayland] protocol: define further the behavior of input on the presence of grabs

2015-06-09 Thread Carlos Garnacho
A good piece of this commit is actually defining as protocol documentation the de-facto behavior in weston and other compositors. Additionally, a wl_seat.release_input event is being added, and the cases where it should be emitted has been added in the relevant places. In short, the compositor sho

Re: Compositor grabs (was: Re: [PATCH] protocol: Add DnD actions)

2015-06-09 Thread Carlos Garnacho
Hey Jonas :), On jue, 2015-06-04 at 12:34 +0800, Jonas Ã…dahl wrote: > On Fri, Apr 17, 2015 at 02:16:41PM +0200, Carlos Garnacho wrote: > > Hey Jonas, > > > > This is drifting a bit off the topic of the original thread, better > > to > > spin this off. I'll reply to the DnD bits in another email.

[PATCH weston] data-device: Implement DnD actions

2015-06-09 Thread Carlos Garnacho
The policy in weston in order to determine the chosen DnD action is deliberately simple, and is probably the minimals that any compositor should be doing here. Besides honoring the notify_actions requests on both wl_data_source and wl_data_offer, weston now emits the newly added events notifying b

[PATCH wayland] protocol: Add DnD actions

2015-06-09 Thread Carlos Garnacho
These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req

Re: [PATCH weston] Add config option to disable input method

2015-06-09 Thread Pekka Paalanen
On Tue, 09 Jun 2015 10:16:40 +0200 Jan Arne Petersen wrote: > Hi, > > I think it is more a problem with weston-keyboard and not with input > methods in general. A compose input method does not need any support > from the shell plugin. Instead of falling back to weston-keyboard as a > default

Re: [PATCH weston] Add config option to disable input method

2015-06-09 Thread Jan Arne Petersen
Hi, I think it is more a problem with weston-keyboard and not with input methods in general. A compose input method does not need any support from the shell plugin. Instead of falling back to weston-keyboard as a default we should just use a compose input method by default. Regards Jan Arne