Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 17:06:49 -0700 Bryce Harrington wrote: > On Tue, May 26, 2015 at 03:52:59PM +0300, Pekka Paalanen wrote: > > On Tue, 26 May 2015 07:24:04 -0500 > > Derek Foreman wrote: > > > On 26/05/15 03:54 AM, Pekka Paalanen wrote: > > > > Now, when there is no black surface at all for "n

Re: [PATCH weston 2/2] internal-screenshot-test: Fix test so it doesn't expect shell surfaces

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 12:10:07 -0500 Derek Foreman wrote: > On 26/05/15 03:30 AM, Pekka Paalanen wrote: > > On Mon, 25 May 2015 15:19:38 -0500 > > Derek Foreman wrote: > > > >> We no longer have a race with shell startup because we create our own > >> colored surface and check that it's properly

Re: [PATCH weston] libinput-device: use the new merged scroll events

2015-05-26 Thread Pekka Paalanen
On Tue, 13 Jan 2015 10:29:06 +0800 Jonas Ådahl wrote: > Noted. It should be semi safe to push as long as it's on libinput > master. Weston master can depend libinput master, can't it, Pekka? Ahhah, sorry, this question had stuck in my long-time backlog. I think Weston master can well depend on

[ANNOUNCE] weston 1.7.93

2015-05-26 Thread Bryce Harrington
This is the second release candidate for the Weston 1.8 series. This requires Wayland 1.7.93. The main change since RC1 is the introduction of a new "headless rendering" test framework feature. This allows test cases to run weston synthetically, and instead of drawing to a physical monitor, to

[ANNOUNCE] wayland 1.7.93

2015-05-26 Thread Bryce Harrington
Wayland 1.8 RC2 brings one change since RC1, a unit test case to accompany the new core headers feature. This core header feature, added previously this release cycle, is a new scanner option --include-core-only, which creates new headers wayland-client-core.h and wayland-server-core.h to avoid de

Leftover 1.8 release warnings

2015-05-26 Thread Bryce Harrington
None of the following stuff looks important enough to block the release, but looks a little untidy. Would be nice to have this cleaned up for 1.9. == Wayland == * make distcheck flags tons of undocumented members in wayland-util.h, wayland.server.*, and wayland-shm.c. * publican maps: warn

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Bill Spitzak
On 05/26/2015 02:40 AM, Daniel Stone wrote: Probably to match X11's behaviour of using :0 in the absence of a $DISPLAY. I'm pretty certain X does not do that. I always have to set $DISPLAY. ___ wayland-devel mailing list wayland-devel@lists.freedes

[PATCH] gitignore: Bulk ignore all *-test files

2015-05-26 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- .gitignore | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/.gitignore b/.gitignore index 0f59395..a59564a 100644 --- a/.gitignore +++ b/.gitignore @@ -12,6 +12,7 @@ *.trs *.tar.xz *~ +*-test .libs .dirstamp cscope.ou

[PATCH] compositor-x11: More verbose logging

2015-05-26 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- Added some debugging statements in my (ultimately fruitless) effort to debug a black screenshot problem. Might be useful for other things... Signed-off-by: Bryce Harrington --- src/compositor-x11.c | 28 +--- 1 file changed, 21 inser

Re: [PATCH weston] internal-screenshot-test: Make distcheck pass

2015-05-26 Thread Bryce Harrington
On Tue, May 26, 2015 at 10:21:03AM -0500, Derek Foreman wrote: > Add the output screenshot to CLEANFILES so it's properly removed on > distclean, and add the reference files and ini to EXTRA_DIST so > distcheck can find them. Good catches. > Signed-off-by: Derek Foreman Tested-by: Bryce Harringt

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Bryce Harrington
On Tue, May 26, 2015 at 03:52:59PM +0300, Pekka Paalanen wrote: > On Tue, 26 May 2015 07:24:04 -0500 > Derek Foreman wrote: > > On 26/05/15 03:54 AM, Pekka Paalanen wrote: > > > Now, when there is no black surface at all for "none", the compositor > > > will show garbage until weston-desktop-shell

[PATCH weston v3 0/5] Refactored simple unit/integration test framework and corresponding test program.

2015-05-26 Thread Jon A. Cruz
Here is a re-worked version of the patch adding unit testing framework and corresponding separation. Aside from the higher-level waycheck program this also updates one of the existing unit test programs to the new framework. Jon A. Cruz (5): Expanded unit test framework to cover base requirement

[PATCH weston v3 5/5] Converted the config parser test to the new framework.

2015-05-26 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz --- Makefile.am| 9 +- tests/config-parser-test.c | 368 + 2 files changed, 310 insertions(+), 67 deletions(-) diff --git a/Makefile.am b/Makefile.am index b1b7c20..5cbd4a0 100644 --- a/Makefile.am +++ b/Mak

[PATCH weston v3 2/5] By default, stop test execution if unrecognized parameters are encountered.

2015-05-26 Thread Jon A. Cruz
Signed-off-by: Jon A. Cruz --- tools/zunitc/src/main.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c index 7049db0..0b4ce86 100644 --- a/tools/zunitc/src/main.c +++ b/tools/zunitc/src/main.c @@ -26,6 +26,7 @@

[PATCH weston v3 4/5] Enables output in the JUnit XML format.

2015-05-26 Thread Jon A. Cruz
Adds basic support fo optionally outputting in the XML format commonly used by JUnit compatible tools. Signed-off-by: Jon A. Cruz --- Makefile.am | 2 + tools/zunitc/inc/zunitc/zunitc.h | 7 + tools/zunitc/src/zuc_junit_reporter.c | 414

[PATCH weston v3 3/5] Enables output in the Test Anything Protocol (TAP) format.

2015-05-26 Thread Jon A. Cruz
Adds basic support for optionally outputting in the Test Anything Protocol (TAP) format. https://testanything.org/ Signed-off-by: Jon A. Cruz --- Makefile.am | 2 + tools/zunitc/inc/zunitc/zunitc.h | 8 ++ tools/zunitc/src/zuc_tap_logger.c | 230 ++

[PATCH weston] exposay: Fix use after free when a view is destroyed during animation

2015-05-26 Thread Derek Foreman
Moving the destroy listener setup allows the animation completion handler to be called before we free any structures it needs. Signed-off-by: Derek Foreman --- desktop-shell/exposay.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/desktop-shell/exposay.c b/deskt

Re: [PATCH] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-26 Thread Keith Packard
Daniel Stone writes: >> Signed-off-by: Rui Matos > > Thanks! > > Reviewed-by: Daniel Stone > > Keith, please pull. Looks like there have been some other updates in this area? Can I get one of you to build a patch on master? -- -keith signature.asc Description: PGP signature ___

Re: [PATCH libinput 04/11] touchpad: only check keyboards for disable-while-typing

2015-05-26 Thread Benjamin Tissoires
On Mon, May 25, 2015 at 6:52 PM, Peter Hutterer wrote: > The keyboard test is a simple one, if we have the first row of alphabetic > keys, we assume it's a full keyboard. > > Signed-off-by: Peter Hutterer > --- Yep. I was trying to understand why the Pixel was not able to get the disable while

Re: [PATCH weston 2/2] internal-screenshot-test: Fix test so it doesn't expect shell surfaces

2015-05-26 Thread Bryce Harrington
On Tue, May 26, 2015 at 12:10:07PM -0500, Derek Foreman wrote: > > > > Since we are procedurally generating these particular reference images, > > I would not save them as PNGs in git to avoid growing the size. PNGs which are procedurally generated potentially can have great compression ratios, s

[PATCH weston] desktop-shell: destroy shell client surfaces in handle_shell_client_destroy

2015-05-26 Thread Derek Foreman
This prevents a use after free when the surfaces are automatically cleaned up later, as shell_client's entry was still in the surface list. Signed-off-by: Derek Foreman --- I'm not really well versed in this, so would appreciate extra critical review here, as this trivial patch may be trivially

Re: [PATCH weston 2/2] internal-screenshot-test: Fix test so it doesn't expect shell surfaces

2015-05-26 Thread Derek Foreman
On 26/05/15 03:30 AM, Pekka Paalanen wrote: > On Mon, 25 May 2015 15:19:38 -0500 > Derek Foreman wrote: > >> We no longer have a race with shell startup because we create our own >> colored surface and check that it's properly drawn. >> >> Signed-off-by: Derek Foreman >> --- >> tests/internal-s

[PATCH weston] internal-screenshot-test: Fix endian problem

2015-05-26 Thread Derek Foreman
Use bit-shifts to properly generate pixel data. Signed-off-by: Derek Foreman --- tests/internal-screenshot-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/internal-screenshot-test.c b/tests/internal-screenshot-test.c index 991761f..7294a37 100644 -

Re: [PATCH] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-26 Thread Daniel Stone
Hi, On 26 May 2015 at 16:37, Rui Matos wrote: > In some extreme cases with animated cursors at a high frame rate we > could end up filling the wl_display outgoing buffer and end up with > wl_display_flush() failing. > > In any case, using the frame callback to throttle ourselves is the > right th

Re: Patch for Weston Running on a Secondary X Screen

2015-05-26 Thread Derek Foreman
On 26/05/15 04:42 AM, Pekka Paalanen wrote: > On Fri, 22 May 2015 11:33:59 +0200 > Marko wrote: > >> Hello! >> >> >> I had a problem with Weston failing to run when launched in a secondary >> screen (such as DISPLAY=:1.1) on a multi X screen configuration. >> Attached is the patch that should f

Re: [PATCH] protocol: Add DnD actions

2015-05-26 Thread Carlos Garnacho
Hey Jonas, Late reply, let's try to pick this up again... On mar, 2015-04-21 at 14:29 +0800, Jonas Ådahl wrote: > On Sat, Apr 18, 2015 at 04:53:46PM +0200, Carlos Garnacho wrote: > > Hey Jonas, > > Hi, > > Thanks for the explanations. I'll reply inline. > > > > > On vie, 2015-04-17 at 15:50 +

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Derek Foreman
On 26/05/15 05:03 AM, Pekka Paalanen wrote: > On Tue, 26 May 2015 12:06:39 +0300 > Pekka Paalanen wrote: > >> On Tue, 26 May 2015 11:54:52 +0300 >> Pekka Paalanen wrote: >> >>> From: Pekka Paalanen >>> >>> Do not use a black blanket surface when the startup animation is >>> specified to be "non

[PATCH] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-26 Thread Rui Matos
In some extreme cases with animated cursors at a high frame rate we could end up filling the wl_display outgoing buffer and end up with wl_display_flush() failing. In any case, using the frame callback to throttle ourselves is the right thing to do. Signed-off-by: Rui Matos --- v2: ensure that

[PATCH weston] internal-screenshot-test: Make distcheck pass

2015-05-26 Thread Derek Foreman
Add the output screenshot to CLEANFILES so it's properly removed on distclean, and add the reference files and ini to EXTRA_DIST so distcheck can find them. Signed-off-by: Derek Foreman --- Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makef

Re: [PATCH libinput] test: add an extra loop for slow udev initialization

2015-05-26 Thread Hans de Goede
Hi, On 05/26/2015 04:56 AM, Peter Hutterer wrote: On slower machines, e.g. VMs, udev isn't fast enough to get the properties set up by the time we're trying to get the device going. This fails when we try to add the device with libinput_path_add_device(). We know that all litest devices will ha

Re: [PATCH libinput 00/11] disable-while-typing refinement

2015-05-26 Thread Hans de Goede
Hi, On 05/26/2015 12:52 AM, Peter Hutterer wrote: A couple of patches to refine disable-while-typing which in its current incarnation works but its slightly annoying. The biggest change is 11/11 which adds a new approach: if a touch started after the last key press we release it once the timeou

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 07:24:04 -0500 Derek Foreman wrote: > On 26/05/15 03:54 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Do not use a black blanket surface when the startup animation is > > specified to be "none". This is the final fix needed to make the > > screenshot test determ

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Derek Foreman
On 26/05/15 03:54 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Do not use a black blanket surface when the startup animation is > specified to be "none". This is the final fix needed to make the > screenshot test deterministic and independent of weston-desktop-shell. > > Previously, the

Re: [PATCH weston] desktop-shell: destroy surfaces in an idle handler after fade out

2015-05-26 Thread Pekka Paalanen
On Tue, 14 Apr 2015 17:09:06 -0500 Derek Foreman wrote: > It's possible for more than one animation to be taking place on a view at > the same time. If one of those animations is the shell's fade out for > dying surfaces, its completion handler will trigger the surface destroy > signal, causing

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 12:06:39 +0300 Pekka Paalanen wrote: > On Tue, 26 May 2015 11:54:52 +0300 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Do not use a black blanket surface when the startup animation is > > specified to be "none". This is the final fix needed to make the > > sc

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 10:40:15 +0100 Daniel Stone wrote: > Hi, > > On 26 May 2015 at 10:26, Giulio Camuffo wrote: > > 2015-05-26 12:21 GMT+03:00 Pekka Paalanen : > >> I have a vague recollection this has been proposed before, but I can't > >> remember if there was any interest or discussion, nor

Re: [PATCH weston] exposay: Don't crash if no pointer is present

2015-05-26 Thread Pekka Paalanen
On Sat, 23 May 2015 07:12:50 +0100 Daniel Stone wrote: > Hi, > > On Friday, May 22, 2015, Derek Foreman wrote: > > > If the compositor has never seen a mouse, exposay will crash because > > the seat->pointer pointer is NULL. > > > > Signed-off-by: Derek Foreman > > > > > Reviewed-by: Daniel S

Re: Patch for Weston Running on a Secondary X Screen

2015-05-26 Thread Pekka Paalanen
On Fri, 22 May 2015 11:33:59 +0200 Marko wrote: > Hello! > > > I had a problem with Weston failing to run when launched in a secondary > screen (such as DISPLAY=:1.1) on a multi X screen configuration. > Attached is the patch that should fix the issue. I reported this as a bug in > > https:/

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Daniel Stone
Hi, On 26 May 2015 at 10:26, Giulio Camuffo wrote: > 2015-05-26 12:21 GMT+03:00 Pekka Paalanen : >> I have a vague recollection this has been proposed before, but I can't >> remember if there was any interest or discussion, nor what was the >> original intent behind defaulting to "wayland-0". Pr

Re: [PATCH] desktop-shell: provide an option, background-bpp , for specifing the bit depth of the wallpaper

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 09:19:39 -0400 nerdopolis wrote: > --- > clients/desktop-shell.c | 13 +++-- > man/weston.ini.man| 5 + > tests/internal-screenshot.ini | 1 + > 3 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/clients/desktop-shell.c b/clien

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Giulio Camuffo
2015-05-26 12:21 GMT+03:00 Pekka Paalanen : > On Mon, 25 May 2015 01:12:15 -0700 > Dima Ryazanov wrote: > >> Although defaulting to wayland-0 seems convenient, it has an undesirable >> side effect: clients may unintentionally connect to the wrong compositor. >> Generally, it's safer to fail instea

Re: [PATCH] desktop-shell: provide an option, background-bpp , for specifing the bit depth of the wallpaper

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 12:24:42 -0700 Bill Spitzak wrote: > On 05/25/2015 06:19 AM, nerdopolis wrote: >&background->bpp, 16); > > + /* TODO After Weston 1.8, change default to 32 bit bpp on the > > wallpaper*/ > > + if (background->low_bpp != 32) { > > +

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 01:12:15 -0700 Dima Ryazanov wrote: > Although defaulting to wayland-0 seems convenient, it has an undesirable > side effect: clients may unintentionally connect to the wrong compositor. > Generally, it's safer to fail instead. Here's a real example: > > In Fedora 22, Gtk+ pr

Re: [PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Pekka Paalanen
On Tue, 26 May 2015 11:54:52 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Do not use a black blanket surface when the startup animation is > specified to be "none". This is the final fix needed to make the > screenshot test deterministic and independent of weston-desktop-shell. > > P

[PATCH weston] desktop-shell: do not black out with startup "none"

2015-05-26 Thread Pekka Paalanen
From: Pekka Paalanen Do not use a black blanket surface when the startup animation is specified to be "none". This is the final fix needed to make the screenshot test deterministic and independent of weston-desktop-shell. Previously, the black surface would cover all outputs until weston-desktop

Re: [PATCH weston 2/2] internal-screenshot-test: Fix test so it doesn't expect shell surfaces

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 15:19:38 -0500 Derek Foreman wrote: > We no longer have a race with shell startup because we create our own > colored surface and check that it's properly drawn. > > Signed-off-by: Derek Foreman > --- > tests/internal-screenshot-test.c| 63 > ++

Re: [PATCH weston 1/2] desktop-shell: Add an option for shell startup timeout

2015-05-26 Thread Pekka Paalanen
On Mon, 25 May 2015 15:19:37 -0500 Derek Foreman wrote: > Make the time to wait for shell startup before removing the fade surface > configurable. > > Use this in internal-screenshot so we can screenshot without waiting for > the shell to start. > > Signed-off-by: Derek Foreman Hi, is this r