Hi,
On Friday, May 22, 2015, Derek Foreman wrote:
> If the compositor has never seen a mouse, exposay will crash because
> the seat->pointer pointer is NULL.
>
> Signed-off-by: Derek Foreman >
>
Reviewed-by: Daniel Stone
___
wayland-devel mailing lis
cms-colord used the weston_compositor destroy signal to
trigger its final colord_module_destroy cleanup, and the
wl_output destroy signal to trigger per output cleanup.
The problem is that the compositor destroy signal gets
emitted before the output destroy signals at compositor
shutdown, colord_m
On Fri, May 22, 2015 at 10:34:00AM +0300, Pekka Paalanen wrote:
>
> Another failure:
>
> $ make check TESTS=internal-screenshot.weston
> WESTON_TEST_REFERENCE_PATH=~/git/weston/tests/reference BACKEND=x11-backend.so
>
> FAIL: internal-screenshot.weston
> test-client: got seat 0x73a6e0 capabilit
On Fri, May 22, 2015 at 04:22:43PM -0700, Bryce Harrington wrote:
> On Fri, May 22, 2015 at 02:49:52PM -0500, Derek Foreman wrote:
> > make check failed for out of tree builds because we didn't set up
> > WESTON_TEST_REFERENCE_PATH in weston-tests-env
> >
> > Signed-off-by: Derek Foreman
>
> Ah,
On Fri, May 22, 2015 at 02:49:52PM -0500, Derek Foreman wrote:
> make check failed for out of tree builds because we didn't set up
> WESTON_TEST_REFERENCE_PATH in weston-tests-env
>
> Signed-off-by: Derek Foreman
Ah, right. Not sure how I could have missed that.
Reviewed-by: Bryce Harrington
On Fri, May 22, 2015 at 03:27:39PM -0500, Derek Foreman wrote:
> On 22/05/15 02:34 AM, Pekka Paalanen wrote:
> > Another failure:
> >
> > $ make check TESTS=internal-screenshot.weston
> > WESTON_TEST_REFERENCE_PATH=~/git/weston/tests/reference
> > BACKEND=x11-backend.so
> >
> > FAIL: internal-s
On 22/05/15 02:34 AM, Pekka Paalanen wrote:
> On Thu, 21 May 2015 15:43:18 -0700
> Bryce Harrington wrote:
>
>> On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote:
>>> With the tiny stride change mentioned on IRC, which, for those that
>>> weren't present, was basically little more tha
make check failed for out of tree builds because we didn't set up
WESTON_TEST_REFERENCE_PATH in weston-tests-env
Signed-off-by: Derek Foreman
---
tests/weston-tests-env | 4
1 file changed, 4 insertions(+)
diff --git a/tests/weston-tests-env b/tests/weston-tests-env
index 4da908a..0b9ff1e
Thanks for the very comprehensive review!
On 20/05/15 10:47 PM, Jonas Ådahl wrote:
> On Mon, May 04, 2015 at 10:59:10AM -0500, Derek Foreman wrote:
>> Keyboards and pointers aren't freed when devices are removed,
>> so we should really be testing keyboard_device_count and
>> pointer_device_count i
Although it sounds like the distributed header files will not be
generated with -c, I don't see why local header files such as
ivi-application-client-protocol.h, ivi-hmi-controller-client-protocol.h,
and weston-test-client-protocol.h can't be and this patch allows that.
On 05/22/2015 11:45 AM,
This seems like a good idea for consistency that the protocol header
is included for any protocols used by the code. This also means the
code will compile with headers generated by wayland-scanner -c.
Fixed to use angle brackets.
---
clients/ivi-shell-user-interface.c |1 +
tests/weston-test-
On 05/22/2015 12:40 AM, Pekka Paalanen wrote:
On Thu, 21 May 2015 19:20:57 -0700
Bill Spitzak wrote:
This seems like a good idea for consistency as the client and server
protocol should not be treated differently than others. This means the
code will compile even if the protocol headers are
litest_log is used in the else block as well, and we get errors like
test/litest.c:240: error: undefined reference to 'litest_log'
Signed-off-by: Khem Raj
---
test/litest.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/test/litest.c b/test/litest.c
index
If the compositor has never seen a mouse, exposay will crash because
the seat->pointer pointer is NULL.
Signed-off-by: Derek Foreman
---
desktop-shell/exposay.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/desktop-shell/exposay.c b/desktop-shell/exposay.c
i
On Thu, 21 May 2015 11:55:31 +0300
Pekka Paalanen wrote:
> On Thu, 21 May 2015 08:34:56 +0100
> Daniel Stone wrote:
>
> > Hi,
> >
> > On 21 May 2015 at 08:28, Daniel Stone wrote:
> > > This patchset is an experimental/RFC implementation of atomic modesetting
> > > for Weston, as a proof-of-co
On Thu, May 21, 2015 at 11:15:54PM -0400, nerdopolis wrote:
> On Thursday, May 21, 2015 05:23:30 PM you wrote:
> > On Thu, May 21, 2015 at 04:35:16PM -0400, nerdopolis wrote:
> > > ---
> > > clients/desktop-shell.c | 10 --
> > > man/weston.ini.man | 4
> > > 2 files changed, 12
On Thu, 21 May 2015 19:20:57 -0700
Bill Spitzak wrote:
> This seems like a good idea for consistency as the client and server
> protocol should not be treated differently than others. This means the
> code will compile even if the protocol headers are generated with the
> core only (-c) switch.
Hi,
On 22-05-15 04:03, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
The entire series looks good to me: Reviewed-by: Hans de Goede
Regards,
Hans
---
src/libinput.c | 60 ++
1 file changed, 60 insertions(+)
diff --git a/
On Thu, 21 May 2015 14:46:07 -0700
Bryce Harrington wrote:
> One more change requested by pq...
>
>
>
> tests: Check that the PNG file's stride matches our internal assumption
>
> Signed-off-by: Bryce Harrington
> ---
>
On Thu, 21 May 2015 15:43:18 -0700
Bryce Harrington wrote:
> On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote:
> > With the tiny stride change mentioned on IRC, which, for those that
> > weren't present, was basically little more than:
> > if (stride != bpp * reference->width) FAIL
>
20 matches
Mail list logo
