On Thu, 21 May 2015 23:15:54 -0400
nerdopolis wrote:
> On Thursday, May 21, 2015 05:23:30 PM you wrote:
> > On Thu, May 21, 2015 at 04:35:16PM -0400, nerdopolis wrote:
> > > ---
> > > clients/desktop-shell.c | 10 --
> > > man/weston.ini.man | 4
> > > 2 files changed, 12 inse
On Thu, 21 May 2015 12:29:28 -0700
Bryce Harrington wrote:
> On Thu, May 21, 2015 at 08:28:57AM +0100, Daniel Stone wrote:
> > Hi all,
> > This patchset is an experimental/RFC implementation of atomic modesetting
> > for Weston, as a proof-of-concept for the overall kernel API. It still
> > defin
On 04/13/2015 12:57 PM, Pekka Paalanen wrote:
On Sun, 12 Apr 2015 23:56:57 +0200
Mario Kleiner wrote:
...
Another issue separate from this patch is if/how we could provide some
kind of "unredirect fullscreen window" behaviour like on X11 compositors
when only 1 client is displaying on an out
On Thursday, May 21, 2015 05:23:30 PM you wrote:
> On Thu, May 21, 2015 at 04:35:16PM -0400, nerdopolis wrote:
> > ---
> > clients/desktop-shell.c | 10 --
> > man/weston.ini.man | 4
> > 2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/clients/desktop-she
This seems like a good idea for consistency as the client and server
protocol should not be treated differently than others. This means the
code will compile even if the protocol headers are generated with the
core only (-c) switch.
---
clients/ivi-shell-user-interface.c |1 +
tests/weston-tes
On Tue, May 05, 2015 at 03:35:17PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
>
> This patch changes the semantics (compared to the previous version of
> this patch) of maximizing/unmaximizing an already maximized/unmaximized
> surface to always result in a configure event. Doin
On Tue, May 05, 2015 at 03:35:16PM +0800, Jonas Ådahl wrote:
> Document that a compositor is free to ping in any way it wants, but a
> client must always respond to any xdg_shell object it created.
>
> Signed-off-by: Jonas Ådahl
> ---
>
> Changes since previous version:
>
> Moved the previous c
On Tue, May 05, 2015 at 03:35:15PM +0800, Jonas Ådahl wrote:
> Document that a wl_surface can only be assigned either a xdg_popup or
> xdg_surface once and that if the client still stries to do that an error
> is raised.
>
> Signed-off-by: Jonas Ådahl
Reviewed-by: Bryce Harrington
Looks good, p
Signed-off-by: Peter Hutterer
---
tools/event-gui.c | 69 ++-
1 file changed, 68 insertions(+), 1 deletion(-)
diff --git a/tools/event-gui.c b/tools/event-gui.c
index c28aaf2..adfb9f4 100644
--- a/tools/event-gui.c
+++ b/tools/event-gui.c
@@ -7
Signed-off-by: Peter Hutterer
---
src/libinput.c | 60 ++
1 file changed, 60 insertions(+)
diff --git a/src/libinput.c b/src/libinput.c
index 1c50284..0346578 100644
--- a/src/libinput.c
+++ b/src/libinput.c
@@ -665,30 +665,68 @@ libinput_e
The scale is an absolute value (relative to the gesture) rather than a delta
between events, so we should allow it to be queried for all events.
For START it's always 1.0, for END we can return whatever the most recent one
was.
Signed-off-by: Peter Hutterer
---
src/evdev-mt-touchpad-gestures.c |
Signed-off-by: Peter Hutterer
---
tools/event-gui.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/tools/event-gui.c b/tools/event-gui.c
index cb583af..c28aaf2 100644
--- a/tools/event-gui.c
+++ b/tools/event-gui.c
@@ -71,6 +71,12 @@ s
On Tue, May 05, 2015 at 03:35:14PM +0800, Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
>
> Hi,
>
> I updated the text as to what you suggested as it sounded less confusing.
Looks good now, pushed:
a7e1991..ca13f7e master -> master
> Jonas
>
> protocol/xdg-shell.xml | 9 +++
On Wed, May 20, 2015 at 02:57:58PM -0500, Derek Foreman wrote:
> Signed-off-by: Derek Foreman
LGTM, pushed:
0ccf8e2..a7e1991 master -> master
Bryce
> ---
> src/gl-renderer.c | 17 -
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/src/gl-renderer.c b/src
On Thu, May 21, 2015 at 04:35:16PM -0400, nerdopolis wrote:
> ---
> clients/desktop-shell.c | 10 --
> man/weston.ini.man | 4
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
> index e2f9f80..cc4a502 100644
On Thu, May 21, 2015 at 08:43:13PM +0300, Giulio Camuffo wrote:
> This test checks that the protocol and library headers include only what
> they are supposed to include. That is, that the core headers do not
> include the protocol headers and that the core protocol headers do not
> include the non
On Thu, May 21, 2015 at 04:44:41PM -0500, Derek Foreman wrote:
> With the tiny stride change mentioned on IRC, which, for those that
> weren't present, was basically little more than:
> if (stride != bpp * reference->width) FAIL
> in load_surface_from_png()
>
> for the series:
> Reviewed-By: Derek
With the tiny stride change mentioned on IRC, which, for those that
weren't present, was basically little more than:
if (stride != bpp * reference->width) FAIL
in load_surface_from_png()
for the series:
Reviewed-By: Derek Foreman
On 21/05/15 03:39 AM, Bryce Harrington wrote:
> Thought I'd try o
One more change requested by pq...
tests: Check that the PNG file's stride matches our internal assumption
Signed-off-by: Bryce Harrington
---
tests/internal-screenshot-test.c | 10 ++
1 file changed, 10 insertion
---
clients/desktop-shell.c | 10 --
man/weston.ini.man | 4
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
index e2f9f80..cc4a502 100644
--- a/clients/desktop-shell.c
+++ b/clients/desktop-shell.c
@@ -94,6 +94,7
On Thu, May 21, 2015 at 08:28:57AM +0100, Daniel Stone wrote:
> Hi all,
> This patchset is an experimental/RFC implementation of atomic modesetting
> for Weston, as a proof-of-concept for the overall kernel API. It still
> definitely has some rough edges, and safe to say it isn't 1.8 material,
> bu
On Thu, May 21, 2015 at 08:28:59AM +0100, Daniel Stone wrote:
> From: Pekka Paalanen
>
> Refactor the code for choosing the initial mode for an output from
> create_output_for_connector() to drm_output_choose_initial_mode().
>
> This makes create_output_for_connector() slightly easier to read.
>
On Thu, May 21, 2015 at 08:28:58AM +0100, Daniel Stone wrote:
> Signed-off-by: Daniel Stone
Since this one's trivial, I just pushed it:
ab3298a..f556ebe master -> master
> ---
> src/compositor-drm.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/compo
This test checks that the protocol and library headers include only what
they are supposed to include. That is, that the core headers do not
include the protocol headers and that the core protocol headers do not
include the non core library headers.
The build process now generates core protocol hea
This test checks that the protocol and library headers include only what
they are supposed to include. That is, that the core headers do not
include the protocol headers and that the core protocol headers do not
include the non core library headers.
The build process now generates core protocol hea
Expecting anything atomic from X11 in the first place is a wrong assumption.
On Thu, May 21, 2015 at 6:18 AM, Marek Chalupa wrote:
> Hi,
>
> On Sat, May 16, 2015 at 7:38 AM, Dima Ryazanov wrote:
>>
>> Add the output to the list when it's created rather than when its
>> properties
>> change (as p
On Thu, 21 May 2015 11:55:31 +0300
Pekka Paalanen wrote:
> On Thu, 21 May 2015 08:34:56 +0100
> Daniel Stone wrote:
>
> > Hi,
> >
> > On 21 May 2015 at 08:28, Daniel Stone wrote:
> > > This patchset is an experimental/RFC implementation of atomic modesetting
> > > for Weston, as a proof-of-co
On Thu, 21 May 2015 08:29:11 +0100
Daniel Stone wrote:
> Building on the drm_plane work from earlier, use the new atomic
> modesetting interface where available, including enabling overlay planes
> by default.
>
> It is still highly experimental, but manages to at least prove the
> overall atomi
On 05/20/2015 10:36 AM, Daniel Vetter wrote:
In
commit f02ad907cd9e7fe3a6405d2d005840912f1ed258
Author: Daniel Vetter
Date: Thu Jan 22 16:36:23 2015 +0100
drm/atomic-helpers: Recover full cursor plane behaviour
we've added a hack to atomic helpers to never to vblank waits for
cursor up
output.done event can be sent even on some property change, not only
when announcing the output. Therefore we must check if we already have it
otherwise we may corrupt the list by adding it multiple times.
This fixes bug when xwayland looped indefinitely in output.done handler
and that can be repr
Hi,
On Thu, May 14, 2015 at 6:37 PM, Dima Ryazanov wrote:
> Oh wow, I was playing around with outputs, and never realized
> output_handle_done
> was being called after any geometry change, not just after the output was
> created.
>
> On Thu, May 14, 2015 at 2:58 AM, Marek Chalupa
> wrote:
>
>>
Hi,
On Sat, May 16, 2015 at 7:38 AM, Dima Ryazanov wrote:
> Add the output to the list when it's created rather than when its
> properties
> change (as pointed out by Marek Chalupa).
> Remove the output from the list when it's destroyed.
>
> Signed-off-by: Dima Ryazanov
> ---
> hw/xwayland/xwa
On Thu, May 14, 2015 at 6:43 PM, Dima Ryazanov wrote:
> Actually, why not just move "xorg_list_append(&xwl_output->link,
> &xwl_screen->output_list);" to xwl_output_create?
>
I'm not an expert on output, but I think that it is in output.done on
purpose. output.done was added to allow "atomic" up
On Thu, 21 May 2015 08:29:05 +0100
Daniel Stone wrote:
> Add awareness of, rather than support for, universal planes. Activate
> the client cap when we start if possible, and if this is activated,
> studiously ignore non-overlay planes. For now.
>
> Signed-off-by: Daniel Stone
> ---
> src/comp
On Thu, 21 May 2015 08:29:09 +0100
Daniel Stone wrote:
> We already keep a GBM BO for the cursor plane, but also keep a DRM FB,
> so we can reuse it for atomic modesetting.
>
> Signed-off-by: Daniel Stone
> ---
> src/compositor-drm.c | 28 ++--
> 1 file changed, 26 inse
On Thu, 21 May 2015 08:29:05 +0100
Daniel Stone wrote:
> Add awareness of, rather than support for, universal planes. Activate
> the client cap when we start if possible, and if this is activated,
> studiously ignore non-overlay planes. For now.
>
> Signed-off-by: Daniel Stone
> ---
> src/comp
On Thu, 21 May 2015 08:29:04 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> This moves the single sprite creation code from create_sprites() into a
> new function. The readability clean-up is small, but my intention is to
> write an alternate version of create_sprites(), and sharing the s
Hi,
On 20-05-15 05:24, Peter Hutterer wrote:
This allows us to filter things based on argv before setting up tests, etc.
Signed-off-by: Peter Hutterer
The entire set LGTM: Reviewed-by: Hans de Goede
Regards,
Hans
---
test/device.c | 5 ++---
test/keyboard.c | 6 ++
test
On Thu, 21 May 2015 08:29:02 +0100
Daniel Stone wrote:
> From: Pekka Paalanen
>
> Cut a chunk of code out from drm_output_set_cursor() and form a new
> function for writing a cursor bo data from a weston_view with a wl_shm
> buffer.
>
> Add more asserts to verify the assumptions in there.
>
>
Hi,
On 20-05-15 00:52, Peter Hutterer wrote:
If a physical button is down but releasing said button doesn't actually
release it, we loop endlessly. Detect that and log a bug instead.
Reproducible: trigger a tap-n-drag on a touchpad device, then remove it.
Signed-off-by: Peter Hutterer
The e
On Thu, 21 May 2015 08:34:56 +0100
Daniel Stone wrote:
> Hi,
>
> On 21 May 2015 at 08:28, Daniel Stone wrote:
> > This patchset is an experimental/RFC implementation of atomic modesetting
> > for Weston, as a proof-of-concept for the overall kernel API. It still
> > definitely has some rough ed
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=83981
Signed-off-by: Bryce Harrington
---
tests/weston-test.c | 243
1 file changed, 243 insertions(+)
diff --git a/tests/weston-test.c b/tests/weston-test.c
index 9f1f49b..8f8781f 100644
---
Minor refactoring to simplify initial sanity checks of surfaces.
Conceivably useful for other basic checking.
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 40 ++-
tests/weston-test-client-helper.h | 3 +++
2 files changed, 30 insert
Introduce helper routines for testing surfaces against specific
conditions. These allow tests to validate screen captures as displaying
the correct rendering results.
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 87 +++
tests/weston
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/weston-test-client-helper.c
b/tests/weston-test-client-helper.c
index 1bfd43f..fda0ce7 100644
--- a/tests/weston-test-client-helper.c
+++ b
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 10 ++
tests/weston-test-client-helper.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/tests/weston-test-client-helper.c
b/tests/weston-test-client-helper.c
index e9ebc83..e6817bd 100644
--- a/tests/weston-
This also serves as a proof of concept of the screen capture
functionality and as a demo for snapshot-based rendering verification.
Implements screenshot saving clientside in the test itself.
This also demonstrates use of test-specific configuration files, in this
case to disable fadein animations
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 11 +++
tests/weston-test-client-helper.h | 16 ++--
2 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/tests/weston-test-client-helper.c
b/tests/weston-test-client-helper.c
index 00fdf8f..08
Thought I'd try one last run at the football...
This series adds support for implementing test cases that can check
rendering output without needing connection to a physical output. It
utilizes the pixman renderer in the headless backend to generate
screenshots at the request of the test client.
This adds a capture_screenshot request which returns an image of the
screen in the client-supplied wl_buffer for the given display output.
A 'done' event is used to indicate when screenshotting has finished and
the wl_buffer is ready to be read.
Signed-off-by: Bryce Harrington
---
protocol/west
And use the helper routine for generating the output filename.
Signed-off-by: Bryce Harrington
---
tests/internal-screenshot-test.c | 46
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/tests/internal-screenshot-test.c b/tests/internal-scr
Refactor out the screenshot shm buffer creation code.
Signed-off-by: Bryce Harrington
---
tests/internal-screenshot-test.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/tests/internal-screenshot-test.c b/tests/internal-screenshot-test
Implements a simple mechanism to allow tests to customize the
configuration. For a given -test.c just place a .ini file
at the same location as the test itself. Alternately, you can generate
a .ini in the same directory that the compiled test is placed
(i.e. the top builddir). If no configuratio
Signed-off-by: Bryce Harrington
---
tests/weston-tests-env | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/weston-tests-env b/tests/weston-tests-env
index ed8ff98..f945ac6 100755
--- a/tests/weston-tests-env
+++ b/tests/weston-tests-env
@@ -11,12 +11,12 @@ fi
WESTON
Signed-off-by: Bryce Harrington
---
tests/weston-test-client-helper.c | 38 ++
tests/weston-test-client-helper.h | 6 ++
2 files changed, 44 insertions(+)
diff --git a/tests/weston-test-client-helper.c
b/tests/weston-test-client-helper.c
index 41ed208..0
Loads an image from disk via cairo, and copies data into a weston test
surface for internal use.
Signed-off-by: Bryce Harrington
---
tests/internal-screenshot-test.c | 72 +++-
1 file changed, 56 insertions(+), 16 deletions(-)
diff --git a/tests/internal-scre
Provides a convenience function for JFDI grabbing of a single
screenshot. Tests that are doing multiple screenshots or other
fanciness probably will bypass this routine and do things more manually,
but this'll provide a reference implementation. And hopefully there'll
be enough simple cases that
Hi,
On 21 May 2015 at 08:28, Daniel Stone wrote:
> This patchset is an experimental/RFC implementation of atomic modesetting
> for Weston, as a proof-of-concept for the overall kernel API. It still
> definitely has some rough edges, and safe to say it isn't 1.8 material,
> but might be useful to
Hi all,
This patchset is an experimental/RFC implementation of atomic modesetting
for Weston, as a proof-of-concept for the overall kernel API. It still
definitely has some rough edges, and safe to say it isn't 1.8 material,
but might be useful to look at regardless, especially for those of you
int
From: Pekka Paalanen
Makes create_output_for_connector() slightly easier to read.
Signed-off-by: Pekka Paalanen
---
src/compositor-drm.c | 41 ++---
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/src/compositor-drm.c b/src/compositor-drm.c
i
Retain drm_plane tracking objects for all actual DRM planes when using
universal planes, not just overlay planes.
These are currently unused.
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --g
From: Pekka Paalanen
Refactor the code for choosing the initial mode for an output from
create_output_for_connector() to drm_output_choose_initial_mode().
This makes create_output_for_connector() slightly easier to read.
Signed-off-by: Pekka Paalanen
---
src/compositor-drm.c | 119 +++
We make the differentiation where planes are an abstract framebuffer
with a position within a CRTC/output, and sprites are special cases of
planes that are neither the primary (base/framebuffer) nor cursor plane.
drm_sprite, OTOH, contains nothing that's actually specific to sprites,
and we end up
From: Pekka Paalanen
Cut a chunk of code out from drm_output_set_cursor() and form a new
function for writing a cursor bo data from a weston_view with a wl_shm
buffer.
Add more asserts to verify the assumptions in there.
Signed-off-by: Pekka Paalanen
---
src/compositor-drm.c | 46
Add awareness of, rather than support for, universal planes. Activate
the client cap when we start if possible, and if this is activated,
studiously ignore non-overlay planes. For now.
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 384 ++-
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/compositor-drm.c b/src/compositor-drm.c
index 71ece6b..bf921be 100644
--- a/src/compositor-drm.c
+++ b/src/compositor-drm.c
@@ -1221,10 +1221,10 @@ choose_mode (str
Building on the drm_plane work from earlier, use the new atomic
modesetting interface where available, including enabling overlay planes
by default.
It is still highly experimental, but manages to at least prove the
overall atomic modesetting and blob property interfaces.
This patch was jointly a
Change the type of cursor_plane from a weston_plane (base tracking
structure) to a drm_plane (wrapper containing additional DRM-specific
details).
Except that we don't actually use any of drm_plane's members yet; this
is just a cosmetic rename.
Signed-off-by: Daniel Stone
---
src/compositor-drm
Use a real drm_plane to back the primary plane, displacing
output->current and output->next to their plane-tracked equivalents.
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 117 +++
1 file changed, 90 insertions(+), 27 deletions(-)
diff
Track the cursor plane through a real drm_plane, including pointing it
to the cursor plane we discover through universal planes, if applicable.
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 90 ++--
1 file changed, 74 insertions(+), 16 del
From: Pekka Paalanen
Refactor the code constructing the connector name into a new function.
This makes create_output_for_connector() slightly easier to read.
Signed-off-by: Pekka Paalanen
---
src/compositor-drm.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions
We already keep a GBM BO for the cursor plane, but also keep a DRM FB,
so we can reuse it for atomic modesetting.
Signed-off-by: Daniel Stone
---
src/compositor-drm.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/compositor-drm.c b/src/comp
From: Pekka Paalanen
This moves the single sprite creation code from create_sprites() into a
new function. The readability clean-up is small, but my intention is to
write an alternate version of create_sprites(), and sharing the single
sprite creation code is useful.
[daniels: Genericised from d
On Wed, 20 May 2015 15:47:00 -0700
Bill Spitzak wrote:
> Please don't duplicate the functions in multiple headers!
>
> You could achieve the same result this way so that there is only one
> copy of each function in the headers:
>
> wayland-client-protocol-core.h =
>(the same as you have it
Le 21/05/2015 09:02, Pekka Paalanen a écrit :
> On Tue, 19 May 2015 10:07:40 +0200
> David FORT wrote:
>
>> The RDP compositor is usable without certificates and key in a very limited
>> number of cases (local usage using xfreerdp), so let's force the presence of
>> keys and certificates.
[...]
On Wed, 20 May 2015 22:38:53 +0300
Giulio Camuffo wrote:
> This test checks that the protocol and library headers include only what
> they are supposed to include. That is, that the core headers do not
> include the protocol headers and that the core protocol headers do not
> include the non core
Le 21/05/2015 09:02, Pekka Paalanen a écrit :
> On Tue, 19 May 2015 10:07:40 +0200
> David FORT wrote:
>
>> The RDP compositor is usable without certificates and key in a very limited
>> number of cases (local usage using xfreerdp), so let's force the presence of
>> keys and certificates.
>> ---
On Tue, 19 May 2015 10:07:40 +0200
David FORT wrote:
> The RDP compositor is usable without certificates and key in a very limited
> number of cases (local usage using xfreerdp), so let's force the presence of
> keys and certificates.
> ---
> src/compositor-rdp.c | 6 ++
> 1 file changed, 6
On Wed, 20 May 2015 18:24:38 -0400
nerdopolis wrote:
> ---
> clients/desktop-shell.c | 13 +++--
> man/weston.ini.man | 4
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
> index e2f9f80..d4ba127 100644
>
79 matches
Mail list logo
