Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-19 Thread Pekka Paalanen
On Wed, 20 May 2015 08:34:32 +0200 Hardening wrote: > Le 20/05/2015 01:41, Bryce Harrington a écrit : > > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: > >> When a compositor window is closed, remove the output instead of just > >> exiting. > >> > >> (The "if (!input->output)" c

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-19 Thread Hardening
Le 20/05/2015 01:41, Bryce Harrington a écrit : > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: >> When a compositor window is closed, remove the output instead of just >> exiting. >> >> (The "if (!input->output)" checks are kind of ugly - but I couldn't find >> a better way to ha

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-19 Thread Pekka Paalanen
On Tue, 19 May 2015 16:41:19 -0700 Bryce Harrington wrote: > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: > > When a compositor window is closed, remove the output instead of just > > exiting. > > > > (The "if (!input->output)" checks are kind of ugly - but I couldn't find > >

[PATCH libinput 5/6] test: add --filter-group argument to match test groups (suites)

2015-05-19 Thread Peter Hutterer
Same as CK_RUN_SUITE, but supports fnmatch-like globs Signed-off-by: Peter Hutterer --- doc/test-suite.dox | 12 ++-- test/litest.c | 14 ++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/doc/test-suite.dox b/doc/test-suite.dox index 757dc86..83cae24 100

[PATCH libinput 3/6] test: add filtering to litest framework

2015-05-19 Thread Peter Hutterer
Complementary to CK_RUN_SUITE and CK_RUN_CASE, this filters on actual test function names with a simple fnmatch. ./test/test-touchpad --filter-test="*1fg_tap*" Most of this patch is renaming litest_add_* to _litest_add_* so we can use the macros to get at the function names. Signed-off-by: Peter

[PATCH libinput 2/6] test: move argument parsing into a separate function

2015-05-19 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/litest.c | 62 +-- 1 file changed, 35 insertions(+), 27 deletions(-) diff --git a/test/litest.c b/test/litest.c index c0b515b..d581018 100644 --- a/test/litest.c +++ b/test/litest.c @@ -456,12 +456,6 @

[PATCH libinput 6/6] doc: drop leftovers of Check's selective test running

2015-05-19 Thread Peter Hutterer
CK_RUN_CASE and CK_RUN_SUITE still work because we're still using check underneath, but it's better to use the arguments. Signed-off-by: Peter Hutterer --- doc/test-suite.dox | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/doc/test-suite.dox b/doc/test-sui

[PATCH libinput 1/6] test: move main() into litest

2015-05-19 Thread Peter Hutterer
This allows us to filter things based on argv before setting up tests, etc. Signed-off-by: Peter Hutterer --- test/device.c | 5 ++--- test/keyboard.c | 6 ++ test/litest.c | 10 +- test/litest.h | 2 +- test/log.c| 5 ++--- test/misc.c | 5 ++--- tes

[PATCH libinput 4/6] test: add --filter-device argument

2015-05-19 Thread Peter Hutterer
Similar to the CK_RUN_CASE environment variable, but it does support fnmatch()-style wildcards, e.g. ./test/test-touchpad --filter-device="synaptics*" Signed-off-by: Peter Hutterer --- doc/test-suite.dox | 11 +++ test/litest.c | 46 +

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-19 Thread Bryce Harrington
On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: > When a compositor window is closed, remove the output instead of just exiting. > > (The "if (!input->output)" checks are kind of ugly - but I couldn't find > a better way to handle the output going away.) > > Signed-off-by: Dima Rya

[PATCH libinput 5/7] evdev: sync the initial x/y position for touchscreens

2015-05-19 Thread Peter Hutterer
Unlikely, but there's the odd chance of the first touch coming in with the same X or Y coordinate the kernel already has internally. This would generate a x/0 or 0/y event in libinput. Sync the slot state on init, at least for Protocol B devices. For Protocol A devices and mtdev, don't bother. Si

[PATCH libinput 6/7] evdev: sync the initial state for absolute pointer devices

2015-05-19 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c| 2 ++ test/pointer.c | 59 ++ 2 files changed, 61 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 48c969d..f710d85 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1865,6 +1865,8

[PATCH libinput 4/7] evdev: add an interface hook to suspend a device

2015-05-19 Thread Peter Hutterer
The touchpad carries enough state around that calling release_all_keys() isn't enough to properly suspend it. e.g. a button down after tapping won't be released by trying to release the physical button for it. We need to clear the state properly, but that's interface-specific so add a new hook for

[PATCH libinput 2/7] touchpad: rename all interface functions for clarity

2015-05-19 Thread Peter Hutterer
Add "interface" to the name to make things a bit clearer. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 3ebb559..c8

[PATCH libinput 1/7] evdev: log a bug if releasing a key fails, but don't loop forever

2015-05-19 Thread Peter Hutterer
If a physical button is down but releasing said button doesn't actually release it, we loop endlessly. Detect that and log a bug instead. Reproducible: trigger a tap-n-drag on a touchpad device, then remove it. Signed-off-by: Peter Hutterer --- src/evdev.c | 47 -

[PATCH libinput 7/7] touchpad: sync the initial touch state

2015-05-19 Thread Peter Hutterer
Unlikely, but there's the odd chance of the first touch coming in with the same X or Y coordinate the kernel already has internally. This would generate a bogus delta on the second event when the touch coordinate jumps from 0/y or x/0 to the real coordinates. For touchpads with distance support th

[PATCH libinput 3/7] evdev: move release_pressed_keys() up

2015-05-19 Thread Peter Hutterer
Just a move to make the next diff easier Signed-off-by: Peter Hutterer --- src/evdev.c | 104 ++-- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 435bc52..87c59dc 100644 --- a/src/evdev.c +++

Re: EGL-X Applications on XWayland

2015-05-19 Thread Jasper St. Pierre
Currently, EGL-X applications will fall back to software rendering, assuming you're using a mesa-based GL, simply because mesa doesn't have support for DRI3 in its EGL layer, and Xwayland doesn't have support for DRI2. Either of those can be fixed, it's just that nobody has tried yet. On Tue, May

EGL-X Applications on XWayland

2015-05-19 Thread Prabhu S
Hi All, Wondering whether possible to run EGL-X on Xwayland? If my understanding correct EGL applications need be built natively with wayland-egl/EGL? Thanks Prabhu ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesk

Re: [PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-05-19 Thread Pekka Paalanen
On Tue, 19 May 2015 11:39:24 +0200 Hardening wrote: > Le 19/05/2015 11:20, Pekka Paalanen a écrit : > > On Tue, 19 May 2015 10:07:39 +0200 > > David FORT wrote: > > > >> This patch makes the seat dynamic and leak it on purpose during seat > >> removal to > >> prevent the ghost object case. > >

Re: [PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-05-19 Thread Hardening
Le 19/05/2015 11:20, Pekka Paalanen a écrit : > On Tue, 19 May 2015 10:07:39 +0200 > David FORT wrote: > >> This patch makes the seat dynamic and leak it on purpose during seat removal >> to >> prevent the ghost object case. >> --- >> src/compositor-rdp.c | 39 +++---

Re: [PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-05-19 Thread Pekka Paalanen
On Tue, 19 May 2015 10:07:39 +0200 David FORT wrote: > This patch makes the seat dynamic and leak it on purpose during seat removal > to > prevent the ghost object case. > --- > src/compositor-rdp.c | 39 +++ > 1 file changed, 27 insertions(+), 12 deletions(-

Re: [PATCH weston] compositor-drm: disable hardware cursors

2015-05-19 Thread Pekka Paalanen
On Tue, 19 May 2015 10:26:10 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > With the recent universal plane and atomic modeset / nuclear pageflip > development in the kernel, cursor content updates on Intel are currently > causing > an extra wait for vblank. This drops Weston's framera

Re: [PATCH weston] terminal: Fix segmentation fault when processing DCH ANSI escape code

2015-05-19 Thread aaron
> Since d is not used subsequently in this function, why not combine the > above two if statements into an and clause. Then the patch is just a > one-liner. It needs to short-circuit the else block, so I can't put the conditions together. > It looks like this also gets called for ICH codes, wher

Re: [PATCH weston] compositor-drm: disable hardware cursors

2015-05-19 Thread Pekka Paalanen
On Tue, 19 May 2015 10:17:49 +0200 Hardening wrote: > Le 19/05/2015 09:26, Pekka Paalanen a écrit : > > From: Pekka Paalanen > > > > src/compositor-drm.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c >

Re: libinput parallel test suite attempts and results

2015-05-19 Thread Peter Hutterer
On Mon, May 18, 2015 at 07:27:01PM -0700, Bryce Harrington wrote: > On Tue, May 19, 2015 at 12:04:34PM +1000, Peter Hutterer wrote: > > This is mostly just a comment on a failed attempt, in case someone is > > tempted to try it or has any feedback otherwise. > > > > The libinput tests suite has a

Re: [PATCH weston] compositor-drm: disable hardware cursors

2015-05-19 Thread Hardening
Le 19/05/2015 09:26, Pekka Paalanen a écrit : > From: Pekka Paalanen > > With the recent universal plane and atomic modeset / nuclear pageflip > development in the kernel, cursor content updates on Intel are currently > causing > an extra wait for vblank. This drops Weston's framerate to a fract

[PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-05-19 Thread David FORT
This patch makes the seat dynamic and leak it on purpose during seat removal to prevent the ghost object case. --- src/compositor-rdp.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 31

[PATCH 0/2] Misc fixes for the RDP compositor

2015-05-19 Thread David FORT
This serie contains a patch to force keys and certificates with the RDP compositor as it is almost unusable without them. It also makes dynamic the seat allocated per connection, so that we can free the RDP context and keep alive the seat (to workaround the fact that we can't safely free a seat).

[PATCH 2/2] RDP compositor: enforce certificate and key

2015-05-19 Thread David FORT
The RDP compositor is usable without certificates and key in a very limited number of cases (local usage using xfreerdp), so let's force the presence of keys and certificates. --- src/compositor-rdp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compositor-rdp.c b/src/compositor-r

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-05-19 Thread Christian Stroetmann
Am 19.05.2015 09:19, schrieb Christian Stroetmann: On the 19th of May 2015 08:33, Pekka Paalanen wrote: On Mon, 18 May 2015 19:23:20 -0700 Bryce Harrington wrote: On Sat, May 02, 2015 at 11:52:22PM +0200, Auke Booij wrote: On 19 April 2015 at 14:51, Jeroen Bollen wrote: Hello, It seems li

[PATCH weston] compositor-drm: disable hardware cursors

2015-05-19 Thread Pekka Paalanen
From: Pekka Paalanen With the recent universal plane and atomic modeset / nuclear pageflip development in the kernel, cursor content updates on Intel are currently causing an extra wait for vblank. This drops Weston's framerate to a fraction by 2 when cursor contents update. This combined with th

Re: [PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

2015-05-19 Thread Pekka Paalanen
On Mon, 18 May 2015 22:10:27 -0400 nerdopolis wrote: > Hardware cursors have been causing some problems with some drivers, mostly > i915 > > This will probably be changed once Atomic Mode Setting arrives, to probably > only force gl cursors > to always be on when Atomic Mode Setting isn't supp

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-05-19 Thread Christian Stroetmann
On the 19th of May 2015 08:33, Pekka Paalanen wrote: On Mon, 18 May 2015 19:23:20 -0700 Bryce Harrington wrote: On Sat, May 02, 2015 at 11:52:22PM +0200, Auke Booij wrote: On 19 April 2015 at 14:51, Jeroen Bollen wrote: Hello, It seems like this discussion died off. Currently there is no w