Re: [weston, v2, 17/17] configure: add an option to allow building only the libraries

2015-05-16 7:43 GMT+03:00 Bryce Harrington : > On Mon, May 11, 2015 at 09:27:38AM +0300, Pekka Paalanen wrote: >> On Sat, 9 May 2015 10:09:21 +0300 >> Giulio Camuffo wrote: >> >> > 2015-05-09 3:15 GMT+03:00 Bryce Harrington : >> > > On Thu, Dec 04, 2014 at 11:01:23PM +0200, Giulio Camuffo wrote: >

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

I just made that change in my set of patches, and I think it fixes the problem. On Thu, May 14, 2015 at 9:43 AM, Dima Ryazanov wrote: > Actually, why not just move "xorg_list_append(&xwl_output->link, > &xwl_screen->output_list);" to xwl_output_create? > > I can't tell if there's a reason it's i

[PATCH v2 3/3] xwayland: Destroy xwl_output when wl_output gets removed

This makes Xwayland correctly handle a monitor getting unplugged. Signed-off-by: Dima Ryazanov --- hw/xwayland/xwayland-output.c | 1 + hw/xwayland/xwayland.c| 10 +- hw/xwayland/xwayland.h| 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/xwayland

[PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

snprintf does not allocate memory, so we can never get an out-of-memory error. (Also, the error handler would free xwl_output after it was already registered as an event listener.) Signed-off-by: Dima Ryazanov --- hw/xwayland/xwayland-output.c | 6 +- 1 file changed, 1 insertion(+), 5 delet

[PATCH v2 1/3] xwayland: Fix the addition and removal of outputs

Add the output to the list when it's created rather than when its properties change (as pointed out by Marek Chalupa). Remove the output from the list when it's destroyed. Signed-off-by: Dima Ryazanov --- hw/xwayland/xwayland-output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

Re: [weston, v2, 17/17] configure: add an option to allow building only the libraries

On Mon, May 11, 2015 at 09:27:38AM +0300, Pekka Paalanen wrote: > On Sat, 9 May 2015 10:09:21 +0300 > Giulio Camuffo wrote: > > > 2015-05-09 3:15 GMT+03:00 Bryce Harrington : > > > On Thu, Dec 04, 2014 at 11:01:23PM +0200, Giulio Camuffo wrote: > > >> the --enable/disable-weston-binaries emable o

[ANNOUNCE] weston 1.7.92

Here is the Weston's RC1 release for the 1.8.0 cycle. This requires Wayland 1.7.92 (just for sake of keeping things in sync). Changes this release since the alpha include adding Cut/Copy/Paste support to the editor, and a handful of bugfixes to xwm, input, and compositors. Prior development this

[ANNOUNCE] wayland 1.7.92

Here's RC1 for Wayland as we head to 1.8. Changes this time are pretty modest, just some light code cleanup. The main change in 1.8 is the addition of a new scanner option --include-core-only, and adds new headers wayland-client-core.h and wayland-server-core.h, to avoid dependency on the generat

Re: [PATCH weston v2 04/14] tests: Add surface checks

On Fri, May 15, 2015 at 11:12:45AM +0100, Daniel Stone wrote: > Hi, > > On 15 May 2015 at 09:21, Bryce Harrington wrote: > > +/** > > + * check_surfaces_equal() - tests if two surfaces are pixel-identical > > + * > > + * Returns true if surface buffers have all the same byte values, > > + * false

Re: [PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

On Friday, May 15, 2015 12:30:30 PM David Herrmann wrote: > Hi > > On Fri, May 15, 2015 at 8:39 AM, Pekka Paalanen wrote: > > > > On Wed, 13 May 2015 21:43:39 -0400 > > nerdopolis wrote: > > > > > Resolving https://bugs.freedesktop.org/show_bug.cgi?id=73782 > > > udev might be configured to set

Re: [PATCH weston v2 14/21] Introduce pointer locking and confinement protocol

On 05/14/2015 07:53 PM, Jonas Ådahl wrote: but your notes were very misleading. What notes? The statement "Serials are dropped" that was in your header email is the one that really threw me. The primary problem I am having is all your description seems to be for setting up something li

Re: [PATCH] remove trailing whitespaces

On Fri, May 15, 2015 at 05:17:47PM +0200, Michael Vetter wrote: > Remove trailing whitespaces because they are not needed and jumping to > the end of al ine should do just that and not jump to the whitespace. > --- > clients/desktop-shell.c| 10 - > clients/dnd.c | 12

Re: [PATCH] remove trailing whitespaces

On Fri, May 15, 2015 at 05:12:41PM +0200, Michael Vetter wrote: > Remove trailing whitespaces because they are not needed and jumping to > the end of al ine should do just that and not jump to the whitespace. > --- > cursor/cursor-data.h | 1004 > +++---

Re: [PATCH weston v2 04/14] tests: Add surface checks

On Fri, May 15, 2015 at 04:55:48PM +0300, Pekka Paalanen wrote: > On Fri, 15 May 2015 01:21:49 -0700 > Bryce Harrington wrote: > > > Introduce helper routines for testing surfaces against specific > > conditions. These allow tests to validate screen captures as displaying > > the correct renderi

[PATCH weston v2 2/2] compositor-drm: pass ARGB fallback to gl create functions for XRGB formats

If the GL implementation doesn't provide an XRGB visual we may still be able to proceed with an ARGB one. Since we're not changing the scanout buffer format, and our current rendering loop always results in saturated alpha in the frame buffer, it should be Just Fine(tm) - and probably better than j

[PATCH weston v2 1/2] gl-renderer: Take a list of acceptable formats in create functions

Currently we pass either a single format or no formats to the gl renderer create and output_create functions. We extend this to any number of formats so we can allow fallback formats if we don't get our first pick. Reviewed-By: Bryce Harrington Reviewed-By: Pekka Paalanen Signed-off-by: Derek F

Re: [PATCH weston 1/2] gl-renderer: Take a list of acceptable formats in create functions

On 15/05/15 02:18 AM, Pekka Paalanen wrote: > On Thu, 14 May 2015 20:14:53 -0700 > Bryce Harrington wrote: > >> On Mon, May 11, 2015 at 02:19:02PM -0500, Derek Foreman wrote: >>> Currently we pass either a single format or no formats to the gl renderer >>> create and output_create functions. We

Re: [PATCH libinput] filter: add Simon's copyright

Hi Peter, that's fine, thanks! Sorry for being so formal, I was a bit upset and should have waited a little longer before hitting send. BTW it's great that you finally came to do that user study and all that jazz. If you like, just keep me in the loop for feedback. Cheers, Simon On 05/06

[PATCH] remove trailing whitespaces

Remove trailing whitespaces because they are not needed and jumping to the end of al ine should do just that and not jump to the whitespace. --- cursor/cursor-data.h | 1004 +++--- src/scanner.c|2 +- tests/connection-test.c |8 +- t

HiDPI problem with Gnome or Xwayland

I have a 4K display machine running Fedora 22. When I run a Wayland session it seems to me that applications which use X in some way get confused about the pixel size. The window manager (gnome-shell) will halve the size of the window whenever the window becomes active. Alt-tabbing can get pretty a

[PATCH] remove trailing whitespaces

Remove trailing whitespaces because they are not needed and jumping to the end of al ine should do just that and not jump to the whitespace. --- clients/desktop-shell.c| 10 - clients/dnd.c | 12 +- clients/editor.c | 2 +- clients/flower.c |

Re: [PATCH weston] launcher-util: Force all weston_launcher_open()s to use O_CLOEXEC

On Fri, 1 May 2015 11:46:36 -0500 Derek Foreman wrote: > Really, there's pretty much no time we'd ever want O_CLOEXEC unset, > as it will likely result in leaking fds to processes that aren't > interested in them or shouldn't have them. > > This also removes the (now unused) code from weston_lo

Re: [PATCH weston v2] logind: actually close fd in weston_logind_close()

On Thu, 30 Apr 2015 14:37:58 -0500 Derek Foreman wrote: > Sigh. > > s/weston_logind_close/weston_launcher_close/ Fixed that when applying. > On 30/04/15 02:37 PM, Derek Foreman wrote: > > You had one job... > > > > Signed-off-by: Derek Foreman > > --- > > Recommended change by David Herrmann

Re: [PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

Hi On Fri, May 15, 2015 at 4:44 PM, Derek Foreman wrote: > On 15/05/15 05:30 AM, David Herrmann wrote: >> systemd-logind listens to VT events via poll(2) on >> /sys/class/tty/tty0/active. On VT switches it changes ACL permissions >> on dev-nodes underneath /dev, if the 'uaccess' tag is set on a d

Re: [PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

On 15/05/15 05:30 AM, David Herrmann wrote: > Hi > > On Fri, May 15, 2015 at 8:39 AM, Pekka Paalanen wrote: >> >> On Wed, 13 May 2015 21:43:39 -0400 >> nerdopolis wrote: >> >>> Resolving https://bugs.freedesktop.org/show_bug.cgi?id=73782 >>> udev might be configured to set the permissions on fra

Re: [PATCH weston v2 04/14] tests: Add surface checks

On Fri, 15 May 2015 01:21:49 -0700 Bryce Harrington wrote: > Introduce helper routines for testing surfaces against specific > conditions. These allow tests to validate screen captures as displaying > the correct rendering results. > > Signed-off-by: Bryce Harrington > --- > tests/weston-test

Re: [PATCH libinput 0/3] touchpad: add disable-while-typing feature

Hi, On 07-05-15 08:53, Peter Hutterer wrote: This patchset adds the old feature "disable while typing" to libinput. We already have some palm detection but on some touchpads (or typing behaviours) it's not enough to analyse the edges alone. We have some plans to add general better detection of

Re: [PATCH libinput] filter: add Simon's copyright

Hi, On 06-05-15 05:20, Peter Hutterer wrote: This code was largely lifted from the X server in bb25b2ad297891430606c367bfabc but didn't take the copyright messages that applied to that code. Signed-off-by: Peter Hutterer LGTM: Reviewed-by: Hans de Goede Regards, Hans --- Simon: I think

Re: [PATCH libinput 1/3] test: add litest_add_ranged* functionality

Hi, On 06-05-15 02:17, Peter Hutterer wrote: litest_add_ranged* takes a range parameter that serves as the lower/upper boundary for a loop. This enables tests to be run multiple times, avoiding the timeouts we triggered by having the loops inside (e.g. see 2bf8d035c and 6dd02468). This just wra

Re: [PATCH libinput] timer: fix coverity warning about unused return value

Hi, On 06-05-15 02:01, Peter Hutterer wrote: "read(int, void *, size_t)" returns the number of bytes read, but it is ignored. We don't really care about the number of bytes, but let's complain if we get anything but EAGAIN. Signed-off-by: Peter Hutterer LGTM: Reviewed-by: Hans de Goede Re

Re: [PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

Hi On Fri, May 15, 2015 at 8:39 AM, Pekka Paalanen wrote: > > On Wed, 13 May 2015 21:43:39 -0400 > nerdopolis wrote: > > > Resolving https://bugs.freedesktop.org/show_bug.cgi?id=73782 > > udev might be configured to set the permissions on framebuffer devices with > > the UACCESS attribute. > >

Re: [PATCH weston v2 00/14] Implement screenshot-based testing with the headless renderer

Hi Bryce, On 15 May 2015 at 09:21, Bryce Harrington wrote: > This series adds support for implementing test cases that can check > rendering output without needing connection to a physical output. It > utilizes the pixman renderer in the headless backend to generate > screenshots at the request

Re: [PATCH weston v2 04/14] tests: Add surface checks

Hi, On 15 May 2015 at 09:21, Bryce Harrington wrote: > +/** > + * check_surfaces_equal() - tests if two surfaces are pixel-identical > + * > + * Returns true if surface buffers have all the same byte values, > + * false if the surfaces don't match or can't be compared due to > + * different dimen

[PATCH weston v2 10/14] tests: Add write_surface_as_png() helper

And use the helper routine for generating the output filename. Signed-off-by: Bryce Harrington --- tests/internal-screenshot-test.c | 42 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/tests/internal-screenshot-test.c b/tests/internal-scr

[PATCH weston v2 05/14] tests: Support --config to enable tests to override config defaults

Implements a simple mechanism to allow tests to customize the configuration. For a given -test.c just place a .ini file at the same location as the test itself. Alternately, you can generate a .ini in the same directory that the compiled test is placed (i.e. the top builddir). If no configuratio

[PATCH weston v2 04/14] tests: Add surface checks

Introduce helper routines for testing surfaces against specific conditions. These allow tests to validate screen captures as displaying the correct rendering results. Signed-off-by: Bryce Harrington --- tests/weston-test-client-helper.c | 116 ++ tests/weston

[PATCH weston v2 06/14] protocol: Add test screenshot capability

This adds a capture_screenshot request which returns an image of the screen in the client-supplied wl_buffer for the given display output. A 'done' event is used to indicate when screenshotting has finished and the wl_buffer is ready to be read. Signed-off-by: Bryce Harrington --- protocol/west

[PATCH weston v2 09/14] tests: Add internal test for the weston test screenshot capability

This also serves as a proof of concept of the screen capture functionality and as a demo for snapshot-based rendering verification. Implements screenshot saving clientside in the test itself. This also demonstrates use of test-specific configuration files, in this case to disable fadein animations

[PATCH weston v2 02/14] tests: Add client helper routines for output and reference filenames

Signed-off-by: Bryce Harrington --- tests/weston-test-client-helper.c | 38 ++ tests/weston-test-client-helper.h | 6 ++ 2 files changed, 44 insertions(+) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c index 41ed208..0

[PATCH weston v2 08/14] tests: Handle screenshot done event in weston-test

Signed-off-by: Bryce Harrington --- tests/weston-test-client-helper.c | 10 ++ tests/weston-test-client-helper.h | 1 + 2 files changed, 11 insertions(+) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c index 04b77d5..f9de7c8 100644 --- a/tests/weston-

[PATCH weston v2 07/14] tests: Add screenshot recording capability to weston-test

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=83981 Signed-off-by: Bryce Harrington --- tests/weston-test.c | 243 1 file changed, 243 insertions(+) diff --git a/tests/weston-test.c b/tests/weston-test.c index 9f1f49b..8f8781f 100644 ---

[PATCH weston v2 12/14] tests: Add load_surface_from_png()

Loads an image from disk via cairo, and copies data into a weston test surface for internal use. Signed-off-by: Bryce Harrington --- tests/internal-screenshot-test.c | 86 +--- 1 file changed, 62 insertions(+), 24 deletions(-) diff --git a/tests/internal-scre

[PATCH weston v2 11/14] tests: Add create_screenshot_surface()

Refactor out the screenshot shm buffer creation code. Signed-off-by: Bryce Harrington --- tests/internal-screenshot-test.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/tests/internal-screenshot-test.c b/tests/internal-screenshot-te

[PATCH weston v2 13/14] tests: Add check_surfaces_geometry()

Minor refactoring to simplify initial sanity checks of surfaces. Conceivably useful for other basic checking. Signed-off-by: Bryce Harrington --- tests/weston-test-client-helper.c | 41 ++- tests/weston-test-client-helper.h | 3 +++ 2 files changed, 30 insert

[PATCH weston v2 03/14] tests: Add an xmalloc helper function

Signed-off-by: Bryce Harrington --- tests/weston-test-client-helper.c | 11 +++ tests/weston-test-client-helper.h | 16 ++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c index 00fdf8f..08

[PATCH weston v2 01/14] tests: Add error handling for system calls

Signed-off-by: Bryce Harrington --- tests/weston-tests-env | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/weston-tests-env b/tests/weston-tests-env index ed8ff98..f945ac6 100755 --- a/tests/weston-tests-env +++ b/tests/weston-tests-env @@ -11,12 +11,12 @@ fi WESTON

[PATCH weston v2 14/14] tests: Add capture_screenshot_of_output()

Provides a convenience function for JFDI grabbing of a single screenshot. Tests that are doing multiple screenshots or other fanciness probably will bypass this routine and do things more manually, but this'll provide a reference implementation. And hopefully there'll be enough simple cases that

[PATCH weston v2 00/14] Implement screenshot-based testing with the headless renderer

This series adds support for implementing test cases that can check rendering output without needing connection to a physical output. It utilizes the pixman renderer in the headless backend to generate screenshots at the request of the test client. The test creates a shm buffer and passes it to t

Re: [PATCH weston 2/2] compositor-drm: pass ARGB fallback to gl create functions for XRGB formats

On Mon, 11 May 2015 14:19:03 -0500 Derek Foreman wrote: > If the GL implementation doesn't provide an XRGB visual we may still be > able to proceed with an ARGB one. Since we're not changing the scanout > buffer format, and our current rendering loop always results in saturated > alpha in the fra

Re: [PATCH weston 1/2] gl-renderer: Take a list of acceptable formats in create functions

On Thu, 14 May 2015 20:14:53 -0700 Bryce Harrington wrote: > On Mon, May 11, 2015 at 02:19:02PM -0500, Derek Foreman wrote: > > Currently we pass either a single format or no formats to the gl renderer > > create and output_create functions. We extend this to any number of > > formats so we can