Re: [PATCH weston v2 14/21] Introduce pointer locking and confinement protocol

2015-05-13 Thread Jonas Ådahl
On Wed, May 13, 2015 at 12:50:33PM -0700, Bill Spitzak wrote: > Again this seems excessively complicated, requires lots of communication > long before the lock happens, makes the methods used to trigger the lock > very limited and dependent on compositor features, and it does not look like > it is

RE: How to boot Weston as KMS

2015-05-13 Thread R .
Actually, I just found out how to do that on GNOME 3... No need for help with that.. Now, question ins, how do I do it for LXDE?? From: ren_zokuke...@hotmail.com To: wayland-devel@lists.freedesktop.org Subject: How to boot Weston as KMS Date: Wed, 13 May 2015 22:34:34 -0700 So Debian package

How to boot Weston as KMS

2015-05-13 Thread R .
So Debian packages for Weston and others have just been made available as of Debian 8. I've always wanted to use this new lighter display server, but I really don't know how to boot it at KMS. I've read the short instructions and used a minimal ~./config/weston.ini file, but all I can do is brin

[PATCH] compositor-drm: Add environment variable, WESTON_FORCE_SW_CURSORS to force software cursors

2015-05-13 Thread nerdopolis
For some video cards, hardware rendered cursors fail to change properly. Add a variable that users can use for these cards when starting Weston. Also document in the man page This time with all the closing parenthesis, and the correct commit message. --- man/weston.man | 4 src/compo

[PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

2015-05-13 Thread nerdopolis
Resolving https://bugs.freedesktop.org/show_bug.cgi?id=73782 udev might be configured to set the permissions on framebuffer devices with the UACCESS attribute. Weston currently attempts to reconnect to the framebuffer device before udev can set the permissions back. It waits 3 times in case if t

[PATCH] compositor-drm: Add environment variable, WESTON_FORCE_SW_CURSORS to force software cursors

2015-05-13 Thread nerdopolis
For some video cards, hardware rendered cursors fail to change properly. Add a variable that users can use for these cards when starting Weston. Also document in the man page --- man/weston.man | 4 src/compositor-drm.c | 5 - 2 files changed, 8 insertions(+), 1 deletion(-) diff

[PATCH] compositor-fbdev: Wait and retry before failing on reconnect to the framebuffer

2015-05-13 Thread nerdopolis
Resolving https://bugs.freedesktop.org/show_bug.cgi?id=73782 udev might be configured to set the permissions on framebuffer devices with the UACCESS attribute. Weston currently attempts to reconnect to the framebuffer device before udev can set the permissions back. It waits 3 times in case if t

Re: Landing priorities for 1.8

2015-05-13 Thread Derek Foreman
On 13/05/15 04:53 PM, Bryce Harrington wrote: > In patchwork, ideally I'd like to see all the patchsets marked 'Under > Review' dealt with, since those are all ones we postponed for 1.7. I > see there's been good progress at processing most of those, and there's > really just Guulio's libweston pa

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Bryce Harrington
On Wed, May 13, 2015 at 02:49:47PM +0100, Daniel Stone wrote: > Hi, > > On 13 May 2015 at 13:19, Bryce Harrington wrote: > > Thanks both of you for the reviews. I've implemented some of the > > changes you suggested: > > > > * Refactor cairo out of the test client backend code entirely > >b

Landing priorities for 1.8

2015-05-13 Thread Bryce Harrington
In patchwork, ideally I'd like to see all the patchsets marked 'Under Review' dealt with, since those are all ones we postponed for 1.7. I see there's been good progress at processing most of those, and there's really just Guulio's libweston patchset and Derek's zoom series that are left. As to l

Re: [PATCH weston v2 14/21] Introduce pointer locking and confinement protocol

2015-05-13 Thread Bill Spitzak
Again this seems excessively complicated, requires lots of communication long before the lock happens, makes the methods used to trigger the lock very limited and dependent on compositor features, and it does not look like it is possible to avoid an unwanted blink in the cursor. - Client must

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Daniel Stone
Hi, On 13 May 2015 at 13:19, Bryce Harrington wrote: > Thanks both of you for the reviews. I've implemented some of the > changes you suggested: > > * Refactor cairo out of the test client backend code entirely >by utilizing the weston test surface structure to carry the >specific data

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-13 Thread Bryce Harrington
On Mon, May 11, 2015 at 03:41:44PM +0300, Pekka Paalanen wrote: > On Sat, 9 May 2015 15:01:13 +0100 > Daniel Stone wrote: > > > Hi Bryce, > > > > On 7 May 2015 at 01:44, Bryce Harrington wrote: > > > This series adds support for implementing test cases that can check > > > rendering output with

Re: [PATCH weston v2 12/21] Introduce a 'double fixed' data type abstraction

2015-05-13 Thread Jonas Ådahl
On Wed, May 13, 2015 at 01:44:02PM +0300, Giulio Camuffo wrote: > 2015-05-13 13:26 GMT+03:00 Jonas Ådahl : > > The 'double fixed' value type is a fixed point data type implemented as > > two signed 32 bit integers. It is intended to be sent over the wire and > > used when wl_fixed_t is not detailed

Re: [PATCH weston v2 12/21] Introduce a 'double fixed' data type abstraction

2015-05-13 Thread Giulio Camuffo
2015-05-13 13:26 GMT+03:00 Jonas Ådahl : > The 'double fixed' value type is a fixed point data type implemented as > two signed 32 bit integers. It is intended to be sent over the wire and > used when wl_fixed_t is not detailed enough. > > Two helper functions are introduced: wl_double_fixed_to_dou

[PATCH weston v2 14/21] Introduce pointer locking and confinement protocol

2015-05-13 Thread Jonas Ådahl
This patch introduces a new protocol for locking and confining a pointer. It consists of a new global object with two requests; one for locking the surface to a position, one for confining the pointer to a given region. See pointer-lock.xml for details of the protocol. In this patch, only the loc

[PATCH weston v2 16/21] clients/resizor: Use pointer locking for resizing window

2015-05-13 Thread Jonas Ådahl
Resizes the window using pointer locking when holding the left pointer button down. The pointer lock cursor position hint is used to warp the pointer to the same position relative to the bottom right corner. Signed-off-by: Jonas Ådahl --- clients/resizor.c | 159 +

[PATCH weston v2 21/21] clients/clickdot: Add option for using a more complex confine region

2015-05-13 Thread Jonas Ådahl
By passing --complex-confine-region clickdot will draw an area looking like a strange H in half transparent gray. This region will act as the confine region when pointer confinement is activated (by right clicking). Signed-off-by: Jonas Ådahl --- clients/clickdot.c | 131

[PATCH weston v2 19/21] clients/clickdot: Reset motion lines on Backspace

2015-05-13 Thread Jonas Ådahl
Clear the white lines that is drawn by pointer motions. It makes it easier to debug pointer movements as one won't need to restart clickdot just to get a clean plate. Signed-off-by: Jonas Ådahl --- clients/clickdot.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/clients/clickdot.c b/

[PATCH weston v2 18/21] input: Support non-rectangular pointer confine regions

2015-05-13 Thread Jonas Ådahl
This patch adds support for when the resulting pointer confinement region is not a rectangle. Support for this is implemented by converting the rectangles of the region into the regions outer border. Pointer motions are then clamped to these borders in order to not escape the confinement region.

[PATCH weston v2 13/21] Introduce wl_relative_pointer interface

2015-05-13 Thread Jonas Ådahl
A wl_relative_pointer object is an extension to the wl_pointer interface only used for emitting relative pointer events. It will only emit events when the parent pointer has focus. To get a relative pointer object, use the get_relative_pointer request of the global wl_relative_pointer_manager obje

[PATCH weston v2 15/21] clients: Add API for pointer locking and pointer confinement

2015-05-13 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- Makefile.am | 6 +- clients/window.c | 294 +++ clients/window.h | 63 3 files changed, 362 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 201b780..9ddbbe9 100644 --

[PATCH weston v2 17/21] clients/clickdot: Use pointer confinement to confine drawed line

2015-05-13 Thread Jonas Ådahl
Use pointer confinement to make the line drawing not go outside the drawing area. It is toggled with the right pointer button. Signed-off-by: Jonas Ådahl --- clients/clickdot.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/clients/clickdot

[PATCH weston v2 12/21] Introduce a 'double fixed' data type abstraction

2015-05-13 Thread Jonas Ådahl
The 'double fixed' value type is a fixed point data type implemented as two signed 32 bit integers. It is intended to be sent over the wire and used when wl_fixed_t is not detailed enough. Two helper functions are introduced: wl_double_fixed_to_double and wl_double_fixed_from_double that can be us

[PATCH weston v2 20/21] window: Add API for manually set confine region

2015-05-13 Thread Jonas Ådahl
We can use this to test more complex confine regions. Signed-off-by: Jonas Ådahl --- clients/window.c | 40 +++- clients/window.h | 5 + 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/clients/window.c b/clients/window.c index 9f6816f..c1d

[PATCH weston v2 11/21] input: Don't send wl_pointer.motion if position didn't change

2015-05-13 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/input.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/input.c b/src/input.c index cd24067..059ab03 100644 --- a/src/input.c +++ b/src/input.c @@ -169,6 +169,8 @@ default_grab_pointer_motion(struct weston_pointer_grab *grab

[PATCH weston v2 04/21] desktop-shell: Make activate_binding take a view instead of surface

2015-05-13 Thread Jonas Ådahl
In preparation for further refactoring. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index ff17b04..1ac1340 100644 --- a/desktop-shell/shell.c +++ b/desktop-she

[PATCH weston v2 09/21] compositor: Keep track of what views were activated by clicking

2015-05-13 Thread Jonas Ådahl
Adds a weston_view_activate() that can be passed an additional active flag WESTON_ACTIVATE_CLICKED, that the shell passes when a view was activated by clicking. This allows shell independent components implement heuristics depending on how a view was activated. Signed-off-by: Jonas Ådahl --- de

[PATCH weston v2 06/21] desktop-shell: Change switcher to track views

2015-05-13 Thread Jonas Ådahl
Preparation for future refactorings. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index efa6ac4..8635d8f 100644 --- a/desktop-shell/shell.c +++ b/des

[PATCH weston v2 08/21] desktop-shell: Pass a flag bitmask instead of bool to activate()

2015-05-13 Thread Jonas Ådahl
Although it currently only has one available flag, but that'll change. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c | 9 ++--- desktop-shell/shell.c | 35 +++ desktop-shell/shell.h | 2 +- src/compositor.h| 5 + 4 files changed, 35

[PATCH weston v2 07/21] desktop-shell: Make activate() take a view instead of surface

2015-05-13 Thread Jonas Ådahl
In preparation for further refactorings. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c | 6 +++--- desktop-shell/shell.c | 20 +++- desktop-shell/shell.h | 2 +- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/desktop-shell/exposay.c b/desktop-shel

[PATCH weston v2 05/21] desktop-shell: Track the black surface by its view

2015-05-13 Thread Jonas Ådahl
In preparation for further refactoring. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 1ac1340..efa6ac4 100644 --- a/desktop-shell/shell.c +++ b

[PATCH weston v2 02/21] input: Make pointer grab motion callbacks take an event struct

2015-05-13 Thread Jonas Ådahl
Instead of only passing absolute pointer coordinates, effectively loosing motion event data, pass a struct that can potentially contain different types of motion events, currently being absolute and relative. A helper function to get resulting absolute coordinates was added for when previous callb

[PATCH weston v2 10/21] libinput: Expose unaccelerated motion deltas in motion event struct

2015-05-13 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/compositor.h | 3 +++ src/libinput-device.c | 9 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/compositor.h b/src/compositor.h index 79b232e..331b758 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -249,6 +249,7 @@ str

[PATCH weston v2 03/21] desktop-shell: Add surface_keyboard_focus_lost helper

2015-05-13 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index c66a976..ff17b04 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -

[PATCH weston v2 00/21] Relative pointer motions, locking and confinement

2015-05-13 Thread Jonas Ådahl
Hi again, This series is a follow up from the last series. It had received some review (on the list and on phabricator), and I had some issues of my own, so here is a new one. I'll briefly go through the differences from the previous version below. I'm sending it now, even though we are in the pr

[PATCH weston v2 01/21] input: Pass axis events through pointer grab interfaces

2015-05-13 Thread Jonas Ådahl
Don't only send motions and buttons but also axis events through the pointer grab interface. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c| 7 +++ desktop-shell/shell.c | 24 ivi-shell/hmi-controller.c | 9 + src/compositor.h |

Re: [PATCH weston 07/10] tests: Add screenshot recording capability to weston-test

2015-05-13 Thread Daniel Stone
Hi, On Monday, May 11, 2015, Bryce Harrington wrote: > On Sat, May 09, 2015 at 02:56:54PM +0100, Daniel Stone wrote: > > On 7 May 2015 at 01:44, Bryce Harrington > wrote: > > > +static void > > > +copy_bgra_yflip(uint8_t *dst, uint8_t *src, int height, int stride) > > > + > > > +static void > >