Re: [PATCH libinput 2/3] test: rename hover tests into semi_mt_hover

On Thu, Apr 30, 2015 at 04:30:24PM -0400, Benjamin Tissoires wrote: > From: Benjamin Tissoires > > The current hover tests are uniquely designed for some Synaptics > touchpad. Libinput can handle hovering through ABS_MT_DISTANCE, > so we need to reserve the "hover" name for real hovering devices.

Re: [PATCH libinput 3/3] touchpad: add support for per-finger hovering information

On Thu, Apr 30, 2015 at 04:30:25PM -0400, Benjamin Tissoires wrote: > From: Benjamin Tissoires > > When the device supports true hovering, it reports this > information through ABS_MT_DISTANCE. > When this axis is available, we should rely on it to > (un)hover the touches as BTN_TOUCH is most of

[PATCH libinput] filter: add Simon's copyright

This code was largely lifted from the X server in bb25b2ad297891430606c367bfabc but didn't take the copyright messages that applied to that code. Signed-off-by: Peter Hutterer --- Simon: I think that should cover it. Sorry about that, it was certainly not intentional. Let me know if that covers i

[PATCH libinput 2/3] test: switch the abs ranged tests over to real ranged tests

Signed-off-by: Peter Hutterer --- test/device.c | 57 + 1 file changed, 13 insertions(+), 44 deletions(-) diff --git a/test/device.c b/test/device.c index 1c277ba..b580e00 100644 --- a/test/device.c +++ b/test/device.c @@ -831,50 +831,22 @@

[PATCH libinput 3/3] test: switch the touchpad multitap tests over to ranged tests

Signed-off-by: Peter Hutterer --- test/touchpad.c | 396 +++- 1 file changed, 194 insertions(+), 202 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 576b2bd..96f1799 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -189,4

[PATCH libinput 1/3] test: add litest_add_ranged* functionality

litest_add_ranged* takes a range parameter that serves as the lower/upper boundary for a loop. This enables tests to be run multiple times, avoiding the timeouts we triggered by having the loops inside (e.g. see 2bf8d035c and 6dd02468). This just wraps the underlying check framework, the ranged va

[PATCH libinput] timer: fix coverity warning about unused return value

"read(int, void *, size_t)" returns the number of bytes read, but it is ignored. We don't really care about the number of bytes, but let's complain if we get anything but EAGAIN. Signed-off-by: Peter Hutterer --- src/timer.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --g

Re: [PATCH weston] Added simple unit/integration test framework and corresponding test program.

On 05/05/2015 09:40 AM, Jon A. Cruz wrote: > > > I'll move forward with merging things together. At the moment there is > some general testing work that others have outstanding, so I'll hold off > on modifying the existing files. Most likely some will just take > migrating appropriate functionali

[PATCH weston v2] Refactored simple unit/integration test framework and corresponding test program.

Refactored to a simple C-based test framework and an example program that uses it to run through some simple wayland client checks. Signed-off-by: Jon A. Cruz --- .gitignore| 3 + Makefile.am | 34 +++ tools/Doxyfile

[PATCH weston v2] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

Recent versions of Mesa have stopped exposing XRGB visuals for gl on some Intel GPUs. While this may be changed in Mesa eventually, it's not impossible that some other hardware in the future won't provide XRGB visuals either. Let's try again with an ARGB visual if XRGB is unavailable. Since we'r

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

It sure seems like it would be better to just provide the list of available keys to the client programs, and let them make up their own categories of device types. I'm not sure if requiring every Latin letter is a good test for a keyboard either. Aren't there some foreign layouts that omit som

Re: [PATCH weston 0/4] Recognize keyboards that can actually type

Failed to mention this is on top of my [PATCH weston v5] input: Don't test keyboard/pointer/touch pointers patch... On 05/05/15 03:01 PM, Derek Foreman wrote: > Right now weston doesn't differentiate between "real" keyboards and > keyboards that consist only of administrative controls (power butt

[PATCH weston 0/4] Recognize keyboards that can actually type

Right now weston doesn't differentiate between "real" keyboards and keyboards that consist only of administrative controls (power buttons, ACPI Video Bus thing for backlight controls...) This patch series adds additional capability bits to weston_keyboard to tell if the keyboard has_digits or has_

[PATCH weston 3/4] input: Move seat capability update sends out of init functions

This lets device_added() do additional processing before the update is sent, which will be useful later when recognizing keyboard capabilities. Signed-off-by: Derek Foreman --- src/compositor-headless.c | 2 ++ src/compositor-rdp.c | 1 + src/compositor-wayland.c | 2 ++ src/compositor-

[PATCH weston 4/4] input: Detect keyboard capabilities

Some devices (power buttons, acpi video bus driver) are considered keyboards but you can't type with them. As of libinput 0.15 we can query a keyboard to see which key events it can generate. We use this to detect if a keyboard can type letters or digits. The wayland protocol doesn't propagate t

[PATCH weston 2/4] input: make a function for device removal

Break device_removed() out into its own function like device_added(). Signed-off-by: Derek Foreman --- src/libinput-seat.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/libinput-seat.c b/src/libinput-seat.c index 19116ec..410df0e 100644 --- a/src/libinput-s

[PATCH weston 1/4] input: Split get_udev_seat() into its own function

We're going to need this on device removal in the future, so pull it out into a separate function now. Signed-off-by: Derek Foreman --- src/libinput-seat.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/libinput-seat.c b/src/libinput-seat.c index 3ac01

Re: [PATCH weston] Added simple unit/integration test framework and corresponding test program.

On 05/04/2015 12:22 PM, Pekka Paalanen wrote: > On Wed, 29 Apr 2015 15:31:45 -0700 > "Jon A. Cruz" wrote: > >> Added a simple C-based test framework and an example program >> that uses it to run through some simple wayland client checks. >> > > Hi Jon, > > I said I didn't have time to look at thi

Re: [PATCH weston] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

Hi, On 5 May 2015 at 14:52, Derek Foreman wrote: > +static bool > +fallback_format(EGLint *format) > +{ > + char *fourcc = (char *)format; > + > + if (fourcc[0] != 'X') > + return false; > + > + fourcc[0] = 'A'; > + return true; > +} Took me a moment to work

[PATCH weston] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

Recent versions of Mesa have stopped exposing XRGB visuals for gl on some Intel GPUs. While this may be changed in Mesa eventually, it's not impossible that some other hardware in the future won't provide XRGB visuals either. Let's try again with an ARGB visual if XRGB is unavailable. Since we'r

Re: why wi_surface_frame callback delay two frames

On Tue, 5 May 2015 09:14:42 + Nancy Zou wrote: > Hi Pekka > > >>how do you differ from the main loops and event handlers in Weston's > >>simple-shm.c or simple-egl.c? > >>Are you using EGL? Which implementation of EGL? > > I try to do a implementation for the wayland-egl flip driver becaus

RE: why wi_surface_frame callback delay two frames

Hi Pekka >>how do you differ from the main loops and event handlers in Weston's >>simple-shm.c or simple-egl.c? >>Are you using EGL? Which implementation of EGL? I try to do a implementation for the wayland-egl flip driver because my linux sgx driver don't support wayland now. When I do it, I r

Re: why wi_surface_frame callback delay two frames

On Tue, 5 May 2015 06:53:44 + Nancy Zou wrote: > Hi all > > My wayland/Weston version is 1.5.0. > > I use wl_surface_frame to listen the frame done callback info. I get the > frame 0 callback when the frame 2 is drawing. If I wait for frame 0 callback > when drawing frame 1, the program i

Re: [PATCH weston 02/17] xdg-shell: Require proper object tree destruction

On Thu, Apr 30, 2015 at 04:54:07PM +0300, Pekka Paalanen wrote: > On Tue, 7 Apr 2015 17:01:17 +0800 > Jonas Ådahl wrote: > > > Require all child objects to be destroyed before the parent. In other > > words, all popups and surfaces created by one xdg_shell instance needs > > to be destroyed befo

[PATCH] xdg-shell: Document error conditions when popup and surface getters

Document that a wl_surface can only be assigned either a xdg_popup or xdg_surface once and that if the client still stries to do that an error is raised. Signed-off-by: Jonas Ådahl --- Changes since the previous versions: Explicitly allow to create a new xdg_surfce/popup from a previously used

[PATCH 2/2] xdg-shell: Further clarify xdg_surface.resize semantics

Signed-off-by: Jonas Ådahl --- protocol/xdg-shell.xml | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index fbd0093..9318bea 100644 --- a/protocol/xdg-shell.xml +++ b/protocol/xdg-shell.xml @@ -269,

[PATCH 1/2] xdg-shell: Further clarify xdg_surface.move semantics

Signed-off-by: Jonas Ådahl --- Except for typos etc, this (and the following) patch, compared to the previous versions, changes the wording regarding the visual indications when moving and resizing. Jonas protocol/xdg-shell.xml | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions

[PATCH] xdg-shell: Document responsibilities regarding ping events

Document that a compositor is free to ping in any way it wants, but a client must always respond to any xdg_shell object it created. Signed-off-by: Jonas Ådahl --- Changes since previous version: Moved the previous commit message into the .xml as it, to Bryce, was better. Jonas protocol/xd

[PATCH] xdg-shell: Document the set_maximized and unsetmaximized requests

Signed-off-by: Jonas Ådahl --- This patch changes the semantics (compared to the previous version of this patch) of maximizing/unmaximizing an already maximized/unmaximized surface to always result in a configure event. Doing it this way would be more consistent with how the compositor works rega

[PATCH] xdg-shell: Clarify the meaning of app ID and give example

Signed-off-by: Jonas Ådahl --- Hi, I updated the text as to what you suggested as it sounded less confusing. Jonas protocol/xdg-shell.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index ab86922..7257036 100644 --- a/protocol/x

why wi_surface_frame callback delay two frames

Hi all My wayland/Weston version is 1.5.0. I use wl_surface_frame to listen the frame done callback info. I get the frame 0 callback when the frame 2 is drawing. If I wait for frame 0 callback when drawing frame 1, the program is in dead loop. Does this result is right? Is there any problem in

[ANNOUNCE] libinput 0.15.0

A new release of libinput, 0.15.0, is now available. One new API was added: libinput_device_keyboard_has_key() which does what it says on the box. A new tool is now available: libinput-debug-events This tool allows debugging libinput events directly, it works as something like an evtest to libin