Re: [PATCH libinput 1/7] test: litest_is_button_event should take an unsigned int

Hi, On 05-05-15 07:43, Peter Hutterer wrote: Signed-off-by: Peter Hutterer The entire series looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans --- test/litest.c | 2 +- test/litest.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/litest.

[PATCH weston] compositor: send the output_created signal after inserting it in the list

The compositor's output_created signal used to be sent in weston_output_init() which the backend call before putting the output in the output_list. This caused problems when creating a new view in a listener to that signal, because weston_view_assign_output() doesn't yet know the new output exists.

[PATCH libinput 1/7] test: litest_is_button_event should take an unsigned int

Signed-off-by: Peter Hutterer --- test/litest.c | 2 +- test/litest.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/litest.c b/test/litest.c index 91f2747..c79cca6 100644 --- a/test/litest.c +++ b/test/litest.c @@ -1329,7 +1329,7 @@ litest_create_uinput_device(const

[PATCH libinput 6/7] test: add litest_is_keyboard_event() helper function

Signed-off-by: Peter Hutterer --- test/keyboard.c | 45 ++--- test/litest.c | 20 test/litest.h | 4 3 files changed, 38 insertions(+), 31 deletions(-) diff --git a/test/keyboard.c b/test/keyboard.c index 508362b..03d62dd 100

[PATCH libinput 5/7] test: add litest_is_touch_event() helper function

Signed-off-by: Peter Hutterer --- test/litest.c | 27 +++ test/litest.h | 3 +++ test/touch.c | 14 -- 3 files changed, 34 insertions(+), 10 deletions(-) diff --git a/test/litest.c b/test/litest.c index e7cf477..9677670 100644 --- a/test/litest.c +++ b/test/

[PATCH libinput 4/7] test: add litest_is_motion_event() helper

Signed-off-by: Peter Hutterer --- test/litest.c | 23 +++ test/litest.h | 2 ++ test/pointer.c | 14 ++ 3 files changed, 27 insertions(+), 12 deletions(-) diff --git a/test/litest.c b/test/litest.c index 563ee39..e7cf477 100644 --- a/test/litest.c +++ b/test/li

[PATCH libinput 2/7] test: re-order the tests to have the likely ones to fail first

Run the touchpad tests first, it's the most likely to fail. It also takes the longest, so it's annoying to have it fail when you spent a minute watching the other tests succeed. Signed-off-by: Peter Hutterer --- test/Makefile.am | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH libinput 7/7] test: use litest_is_button_event() helper

Signed-off-by: Peter Hutterer --- test/touchpad.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 576b2bd..15230e7 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -3842,20 +3842,12 @@ assert_btnevent_from_device(struct li

[PATCH libinput 3/7] test: add litest_is_axis_event() helper

Signed-off-by: Peter Hutterer --- test/litest.c | 25 + test/litest.h | 4 test/pointer.c | 14 -- 3 files changed, 29 insertions(+), 14 deletions(-) diff --git a/test/litest.c b/test/litest.c index c79cca6..563ee39 100644 --- a/test/litest.c +++ b/tes

Re: [PATCH libinput] touchpad: enable clickfinger by default on some System76 laptops

On Mon, May 04, 2015 at 03:57:56PM +0200, Hans de Goede wrote: > Hi, > > On 05/04/2015 11:36 AM, Peter Hutterer wrote: > >Bonobo, Clevo, Galago and Kudu have clickpads and no markings -> > >enable clickfinger by default. > > > >Lemur and Gazelle have physical buttons, no need for extra configurati

Re: [PATCH weston] Added simple unit/integration test framework and corresponding test program.

On Wed, 29 Apr 2015 15:31:45 -0700 "Jon A. Cruz" wrote: > Added a simple C-based test framework and an example program > that uses it to run through some simple wayland client checks. > > Signed-off-by: Jon A. Cruz > --- > .gitignore| 3 + > Makefile.am

[PATCH weston v5] input: Don't test keyboard/pointer/touch pointers

Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers. Otherwise we end up with different behaviour after removing a device than we had before it was inserted. This commit r

Re: [PATCH weston] compositor-drm: Open drm device with CLOEXEC

Le 01/05/2015 16:59, Derek Foreman a écrit : > Signed-off-by: Derek Foreman > --- > src/compositor-drm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index 43197a8..6a2dbd9 100644 > --- a/src/compositor-drm.c > +++ b/src

Re: [PATCH v2 libinput 1/2] touchpad: drop the tap finger count

Hi, On 05/04/2015 12:37 PM, Peter Hutterer wrote: Use tp->nfingers_down as trigger when we have no fingers left on the touchpad and when we should return to idle. If all touchpoints end in the same frame tp->nfingers is 0. Thus when we handle the first tap release we transition to IDLE which now

Re: [PATCH libinput] touchpad: enable clickfinger by default on some System76 laptops

Hi, On 05/04/2015 11:36 AM, Peter Hutterer wrote: Bonobo, Clevo, Galago and Kudu have clickpads and no markings -> enable clickfinger by default. Lemur and Gazelle have physical buttons, no need for extra configuration. https://bugs.freedesktop.org/show_bug.cgi?id=90170 Signed-off-by: Peter H

[PATCH v2 libinput 1/2] touchpad: drop the tap finger count

Use tp->nfingers_down as trigger when we have no fingers left on the touchpad and when we should return to idle. If all touchpoints end in the same frame tp->nfingers is 0. Thus when we handle the first tap release we transition to IDLE which now needs to handle (and discard) any touch release even

Re: [PATCH 2/2] touchpad: don't apply tap config until all fingers are up

On Mon, May 04, 2015 at 09:11:46AM +0200, Hans de Goede wrote: > Hi, > > On 04-05-15 08:41, Peter Hutterer wrote: > >On Fri, May 01, 2015 at 10:19:59AM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 01-05-15 04:48, Peter Hutterer wrote: > >>>On Thu, Apr 30, 2015 at 10:01:55AM +0200, Hans de Goede

[PATCH v2 libinput 2/2] touchpad: when clearing the touchpad state, release fake touches too

Causes an error message in the device_disable_release_tap_n_drag test. When the touchpad is suspended, all touches are ended in tp_clear_state. Since the hovering support was added, this returns the touches to TOUCH_HOVERING, a subsequent tp_handle_state() will turn them back into TOUCH_BEGIN based

[PATCH libinput] touchpad: enable clickfinger by default on some System76 laptops

Bonobo, Clevo, Galago and Kudu have clickpads and no markings -> enable clickfinger by default. Lemur and Gazelle have physical buttons, no need for extra configuration. https://bugs.freedesktop.org/show_bug.cgi?id=90170 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c| 18

Re: [PATCH libinput] touchpad: enable clickfinger by default on chromebooks

Hi, On 04-05-15 04:11, Peter Hutterer wrote: This matches the vendor default. Board IDs pulled from modinfo chromeos_laptop, touchpad names from a bit of googling around. Signed-off-by: Peter Hutterer Tested-by: Benjamin Tissoires LGTM: Reviewed-by: Hans de Goede Regards, Hans --- s

Re: [PATCH 2/2] touchpad: don't apply tap config until all fingers are up

Hi, On 04-05-15 08:41, Peter Hutterer wrote: On Fri, May 01, 2015 at 10:19:59AM +0200, Hans de Goede wrote: Hi, On 01-05-15 04:48, Peter Hutterer wrote: On Thu, Apr 30, 2015 at 10:01:55AM +0200, Hans de Goede wrote: Hi, On 30-04-15 08:00, Peter Hutterer wrote: If tapping is enabled while a