The current doubletap timeout was incorrect, it gave the user only 180ms to
touch, release, touch, release to recognise a doubletap. But it would also set
a timeout on the second release, delaying the button events by 180ms.
Instead, re-arm the timer on the second touch down. This gives the user 1
On Thu, Apr 30, 2015 at 09:49:30AM +0200, Hans de Goede wrote:
> Hi,
>
> On 30-04-15 07:59, Peter Hutterer wrote:
> >Causes an error message in the device_disable_release_tap_n_drag test. When
> >the touchpad is suspended, all touches are ended in tp_clear_state. Since the
> >hovering support was
On Thu, Apr 30, 2015 at 10:01:55AM +0200, Hans de Goede wrote:
> Hi,
>
> On 30-04-15 08:00, Peter Hutterer wrote:
> >If tapping is enabled while at least one finger is down, we underrun
> >tp->tap.tap_finger_count on touch release. Avoid this by only switching
> >tap config whenever there are no f
On Thu, Apr 30, 2015 at 09:24:41AM -0500, Derek Foreman wrote:
> On 29/04/15 08:33 PM, Peter Hutterer wrote:
> > Signed-off-by: Peter Hutterer
> > ---
> > I admit, I'm not sure of the effect it has leaving the data sitting there.
> > timerfd_create states that only the value read changes, not the
On Thu, Apr 30, 2015 at 11:43:28AM -0500, Derek Foreman wrote:
> We'd rather keep these out of the hands of children.
>
> Signed-off-by: Derek Foreman
> ---
merged, thanks.
Cheers,
Peter
> src/evdev.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/evdev
The other set_focus() functions take the relevant type instead of a seat
already, so this is consistent.
Signed-off-by: Derek Foreman
---
In addition to being more consistent with the other similar functions,
this also makes my patch to hide the seat->touch pointer behind a
helper function that
---
src/clipboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/clipboard.c b/src/clipboard.c
index c1091a9..994c301 100644
--- a/src/clipboard.c
+++ b/src/clipboard.c
@@ -254,7 +254,7 @@ clipboard_set_selection(struct wl_listener *listener, void
*data)
mime_
From: Benjamin Tissoires
Signed-off-by: Benjamin Tissoires
---
test/litest-bcm5974.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/litest-bcm5974.c b/test/litest-bcm5974.c
index 035bed2..ddff038 100644
--- a/test/litest-bcm5974.c
+++ b/test/litest-bcm5974.c
@@ -
From: Benjamin Tissoires
The current hover tests are uniquely designed for some Synaptics
touchpad. Libinput can handle hovering through ABS_MT_DISTANCE,
so we need to reserve the "hover" name for real hovering devices.
Signed-off-by: Benjamin Tissoires
---
test/touchpad.c | 26 +
Hi,
The Chromebook Pixel 2015 presents a true per finger hovering transmitted
by the ABS_MT_DISTANCE event. This is to my knowledge the first touchpad
presenting such information and libinput fails to handle it properly.
This patch series aims at supporting a per-finger hovering and making the
to
From: Benjamin Tissoires
When the device supports true hovering, it reports this
information through ABS_MT_DISTANCE.
When this axis is available, we should rely on it to
(un)hover the touches as BTN_TOUCH is most of the time
unreliable (generated by the mouse emulation in the kernel).
Signed-of
Sigh.
s/weston_logind_close/weston_launcher_close/
On 30/04/15 02:37 PM, Derek Foreman wrote:
> You had one job...
>
> Signed-off-by: Derek Foreman
> ---
> Recommended change by David Herrmann.
>
> src/launcher-util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s
You had one job...
Signed-off-by: Derek Foreman
---
Recommended change by David Herrmann.
src/launcher-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/launcher-util.c b/src/launcher-util.c
index e89710b..00cb935 100644
--- a/src/launcher-util.c
+++ b/src/launcher-
On 30/04/15 11:27 AM, David Herrmann wrote:
> Hi
>
> On Thu, Apr 30, 2015 at 6:20 PM, Derek Foreman wrote:
>> You had one job...
>>
>> Signed-off-by: Derek Foreman
>> ---
>> src/logind-util.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/logind-util.c b/src/logind-util.c
>>
On 04/30/2015 11:08 AM, Giulio Camuffo wrote:
I think you're just not getting the goal of the patches here. The goal
is basically to be able to *not include* indirectly
wayland-client-protocol.h, not to clean up the circular includes or
whatever. Whoever includes directly wayland-client-protocol
2015-04-30 21:18 GMT+03:00 Bill Spitzak :
> On 04/30/2015 11:03 AM, Giulio Camuffo wrote:
>
>> Functionally the initial patch and the latest ones are exactly the
>> same, so not sure what you're talking about
>
>
> No they are not. The original patch and my proposal has *-client-protocol.h
> fi
On 04/30/2015 11:03 AM, Giulio Camuffo wrote:
Functionally the initial patch and the latest ones are exactly the
same, so not sure what you're talking about
No they are not. The original patch and my proposal has
*-client-protocol.h file including wayland-client-core.h. The latest one
ha
2015-04-30 21:00 GMT+03:00 Bill Spitzak :
> On 04/30/2015 04:49 AM, Pekka Paalanen wrote:
>
>> But we have no reason to push people away from the old headers. Those
>> who need the new headers know already that the old ones are awkward.
>> Those who don't need the new headers are welcome to keep us
2015-04-30 20:41 GMT+03:00 Bill Spitzak :
> On 04/30/2015 03:34 AM, Pekka Paalanen wrote:
>
>>> Just to be clear, my proposal is:
>>>
>>> wayland-client.h : hand-written, includes:
>>> wayland-client-core.h
>>> wayland-client-protocol.h
>>> deprecated api
>>>
>>> way
On 04/30/2015 04:49 AM, Pekka Paalanen wrote:
But we have no reason to push people away from the old headers. Those
who need the new headers know already that the old ones are awkward.
Those who don't need the new headers are welcome to keep using the old
ones. That's why we're not adding a #war
On 04/30/2015 03:33 AM, Pekka Paalanen wrote:
On Wed, 29 Apr 2015 09:17:33 -0700
Bill Spitzak wrote:
On 04/29/2015 03:10 AM, Pekka Paalanen wrote:
Weston had a good reason to not use getopt() I believe: each module
parses its own arguments in turn, so command line options are parsed in
sev
On 04/30/2015 03:34 AM, Pekka Paalanen wrote:
Just to be clear, my proposal is:
wayland-client.h : hand-written, includes:
wayland-client-core.h
wayland-client-protocol.h
deprecated api
wayland-client-core.h : hand-written, includes
wl_event_queue, wl_pr
Hi
On Thu, Apr 30, 2015 at 6:43 PM, Derek Foreman wrote:
> We'd rather keep these out of the hands of children.
>
> Signed-off-by: Derek Foreman
> ---
> src/evdev.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: David Herrmann
Thanks
David
> diff --git a/src/evde
We'd rather keep these out of the hands of children.
Signed-off-by: Derek Foreman
---
src/evdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c b/src/evdev.c
index d997d24..af36127 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1953,7 +1953,8 @@ evdev_devi
If there's an application that wants a move indicator, we could
provide a "moving" state, but since the application doesn't get any
feedback about the move, ever, I'm not sure this is useful.
On Thu, Apr 30, 2015 at 7:36 AM, Pekka Paalanen wrote:
> On Tue, 7 Apr 2015 18:40:03 -0700
> Bryce Harrin
Hi
On Thu, Apr 30, 2015 at 6:20 PM, Derek Foreman wrote:
> We'd rather not have these fds available in all child processes, even
> if using old versions of libinput that don't bother to set CLOEXEC
>
> Signed-off-by: Derek Foreman
Reviewed-by: David Herrmann
Thanks
David
> ---
> src/libinpu
Hi
On Thu, Apr 30, 2015 at 6:20 PM, Derek Foreman wrote:
> You had one job...
>
> Signed-off-by: Derek Foreman
> ---
> src/logind-util.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/logind-util.c b/src/logind-util.c
> index e4e20eb..1327b48 100644
> --- a/src/logind-util.c
> +
Oh, nice catch, that's a typo. The expected behavior here is that you
cannot change from xdg_surface to xdg_popup or cursor surface or
anything.
You should be able to destroy and recreate the xdg_surface without
destroying the wl_surface.
On Thu, Apr 30, 2015 at 7:08 AM, Giulio Camuffo wrote:
>
You had one job...
Signed-off-by: Derek Foreman
---
src/logind-util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/logind-util.c b/src/logind-util.c
index e4e20eb..1327b48 100644
--- a/src/logind-util.c
+++ b/src/logind-util.c
@@ -248,6 +248,8 @@ weston_logind_close(struct weston_lo
We'd rather not have these fds available in all child processes, even
if using old versions of libinput that don't bother to set CLOEXEC
Signed-off-by: Derek Foreman
---
src/libinput-seat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libinput-seat.c b/src/libinput-sea
On Tue, 7 Apr 2015 17:01:32 +0800
Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> clients/simple-damage.c | 2 +-
> clients/simple-egl.c| 2 +-
> clients/simple-shm.c| 2 +-
> clients/window.c| 2 +-
> desktop-shell/shell.c | 2 +-
> protocol/xdg-shell.xml | 2 +-
>
On Wed, 08 Apr 2015 12:44:20 -0700
Bill Spitzak wrote:
> I think the compositor is allowed to choose a color other than black, right?
>
> On 04/07/2015 07:52 PM, Bryce Harrington wrote:
>
> >> +If the surface doesn't cover the whole output, the compositor will
> >> +position the
On Tue, 7 Apr 2015 19:43:44 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:30PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
>
> Couple typos, but nothing major. LGTM:
>
> Reviewed-by: Bryce Harrington
>
> > ---
> > protocol/xdg-shell.xml | 41 +++
On Tue, 7 Apr 2015 19:40:46 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:29PM +0800, Jonas Ådahl wrote:
> > Some times the compositor needs to send a configure request but without
> > having any clue about what size the surface should have. Examples
> > include unmaximizing a sur
On Tue, 7 Apr 2015 19:40:12 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:28PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
>
> Reviewed-by: Bryce Harrington
>
> > ---
> > protocol/xdg-shell.xml | 13 -
> > 1 file changed, 8 insertions(+), 5 deletions(
On Tue, 7 Apr 2015 19:39:29 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:27PM +0800, Jonas Ådahl wrote:
> > Mention set_window_geometry in configure documentation.
> >
> > Add a strategic "For instance" to clarify what is just an example.
> >
> > Clarify that the arguments of s
On Tue, 7 Apr 2015 19:27:00 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:26PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
> > ---
> > protocol/xdg-shell.xml | 24 +---
> > 1 file changed, 21 insertions(+), 3 deletions(-)
> >
> > diff --git a/pr
On Tue, 7 Apr 2015 19:38:49 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 07:12:48PM -0700, Jasper St. Pierre wrote:
> > It's described as murky because it is super murky.
> >
> > In the brave new world, apps are supposed to be D-Bus Activatable.
> > That means setting DBusActivatable=
On Tue, 7 Apr 2015 18:43:17 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:24PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
> Reviewed-by: Bryce Harrington
Trivially ok.
Thanks,
pq
> > ---
> > protocol/xdg-shell.xml | 5 ++---
> > 1 file changed, 2 insertions(+
On Tue, 7 Apr 2015 18:40:03 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:23PM +0800, Jonas Ådahl wrote:
> > Signed-off-by: Jonas Ådahl
> > ---
> > protocol/xdg-shell.xml | 13 +++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/protocol/xdg-
On Tue, 7 Apr 2015 17:01:22 +0800
Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index d316e06..d013803 100644
> --- a/protocol/xdg-shell.xml
> +++ b/p
On 29/04/15 08:33 PM, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
> ---
> I admit, I'm not sure of the effect it has leaving the data sitting there.
> timerfd_create states that only the value read changes, not the actual size
> of the data (which I couldn't reproduce in a quick test, it
On Tue, 7 Apr 2015 23:12:31 -0700
Bryce Harrington wrote:
> On Wed, Apr 08, 2015 at 11:32:20AM +0800, Jonas Ådahl wrote:
> > On Tue, Apr 07, 2015 at 06:36:56PM -0700, Jasper St. Pierre wrote:
> > > On Tue, Apr 7, 2015 at 6:03 PM, Bryce Harrington
> > > wrote:
> > > > On Tue, Apr 07, 2015 at 05:
On Tue, 7 Apr 2015 17:01:19 +0800
Jonas Ådahl wrote:
> They are errors that may be as a result of calling get_xdg_popup on an
> xdg_shell, not a result of calling a request on xdg_popup.
>
> Signed-off-by: Jonas Ådahl
Yes, this is alright, and also not a reason to bump the experimental
versio
On Tue, 7 Apr 2015 17:47:56 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:20PM +0800, Jonas Ådahl wrote:
> > Document that a compositor is free to ping in any way it wants, but a
> > client must always respond to any xdg_shell object it created.
> >
> > Signed-off-by: Jonas Ådahl
2015-04-07 12:01 GMT+03:00 Jonas Ådahl :
> Document that a wl_surface can only be assigned either a xdg_popup or
> xdg_surface once and that if the client still stries to do that an error
> is raised.
>
> Signed-off-by: Jonas Ådahl
> ---
> protocol/xdg-shell.xml | 14 --
> 1 file chan
On Tue, 7 Apr 2015 17:26:46 -0700
Bryce Harrington wrote:
> On Tue, Apr 07, 2015 at 05:01:18PM +0800, Jonas Ådahl wrote:
> > Document that a wl_surface can only be assigned either a xdg_popup or
> > xdg_surface once and that if the client still stries to do that an error
> > is raised.
> >
> > S
On Tue, 7 Apr 2015 17:01:17 +0800
Jonas Ådahl wrote:
> Require all child objects to be destroyed before the parent. In other
> words, all popups and surfaces created by one xdg_shell instance needs
> to be destroyed before the xdg_shell object, otherwise a protocol error
> is raised.
>
> Signed
On Fri, 10 Apr 2015 08:01:39 +0200
Mario Kleiner wrote:
> On 04/07/2015 11:01 AM, wayland-devel-requ...@lists.freedesktop.org wrote:
> > Date: Tue, 7 Apr 2015 17:01:15 +0800
> > From: Jonas Ådahl
> > To: wayland-devel@lists.freedesktop.org
> > Cc: Jonas Ådahl
> > Subject: [PATCH weston 00/17]
From: Pekka Paalanen
Use the same retvals for both short and long options.
Whitespace fixes.
Signed-off-by: Pekka Paalanen
---
src/scanner.c | 44 ++--
1 file changed, 14 insertions(+), 30 deletions(-)
diff --git a/src/scanner.c b/src/scanner.c
index 7
On Wed, 29 Apr 2015 16:46:51 +0300
Giulio Camuffo wrote:
> When using this new option the generated code will include the new
> core headers instead of the old ones. The default needs to remain
> unchanged for backward compatibility with old code.
> With this change the generated headers will now
On Fri, 17 Apr 2015 16:47:49 +0300
Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Pass 'this' weston_surface as the data argument to
> weston_surface::destroy_signal listeners. The old &surface->resource was
> really just an offsetted pointer to the weston_surface anyway. And,
> because 'reso
On Wed, 29 Apr 2015 11:11:48 -0700
Bill Spitzak wrote:
> Forcing --include-core-only on in wayland-scanner, the attached patch
> makes Weston compile. This involved adding two wayland-client-protocol.h
> includes.
Thanks for testing.
> IMHO it is better to require this small bit of editing th
On Mon, 27 Apr 2015 17:02:54 +0900
Nobuhiko Tanibata wrote:
> Especially, the size of destination rectagle is set to (1,1).
> This is because the size will be used for caluculating scale and not to
> be 0 to avoid 0 dividing.
>
> I also remark this as FIXME. This shall be fixed at ivi-layout-tan
On Wed, 29 Apr 2015 13:18:22 +0300
Pekka Paalanen wrote:
> On Tue, 28 Apr 2015 22:57:18 +0300
> Giulio Camuffo wrote:
>
> > The new core header doesn't include any other header, since it really
> > is not needed.
> > ---
> > Makefile.am| 1 +
> > src/wayland-egl-core.h | 56
> > +
On Wed, 29 Apr 2015 16:34:47 +0300
Giulio Camuffo wrote:
> wayland-client.h and wayland-server.h include the protocol headers generated
> at build time. This means that a libwayland user cannot generate and use
> protocol code created from a wayland.xml newer than the installed libwayand,
> becau
On Wed, 29 Apr 2015 09:06:13 -0700
Bill Spitzak wrote:
> On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
> > Just to be clear, are you suggesting the scanner should generate two
> > headers for an xml, one including the old headers and one including
> > the core ones? I'm not sure i see the advanta
On Wed, 29 Apr 2015 09:17:33 -0700
Bill Spitzak wrote:
> On 04/29/2015 03:10 AM, Pekka Paalanen wrote:
>
> > Weston had a good reason to not use getopt() I believe: each module
> > parses its own arguments in turn, so command line options are parsed in
> > several passes, and an unknown option i
Hi,
On 30-04-15 10:28, Peter Hutterer wrote:
Rebuild the same binary but without the special LDFLAG. The event-debug tool
is left as-is to allow for easy debugging with gdb, the new tool is now
libtool-enabled and can't be run directly in gdb without installing it first.
Signed-off-by: Peter Hu
Rebuild the same binary but without the special LDFLAG. The event-debug tool
is left as-is to allow for easy debugging with gdb, the new tool is now
libtool-enabled and can't be run directly in gdb without installing it first.
Signed-off-by: Peter Hutterer
---
I find myself asking more bugreporte
Hi,
On 30-04-15 08:00, Peter Hutterer wrote:
If tapping is enabled while at least one finger is down, we underrun
tp->tap.tap_finger_count on touch release. Avoid this by only switching
tap config whenever there are no fingers down.
The immediate applying of tapping enabled changes is delibera
On Wed, Apr 29, 2015 at 10:39:18PM -0700, Dima Ryazanov wrote:
> We don't even need to simulate button clicks; it's done automatically.
> This also fixes scrolling in Qt5 apps.
>
> Signed-off-by: Dima Ryazanov
Reviewed-by: Peter Hutterer
Cheers,
Peter
> ---
> hw/xwayland/xwayland-input.c |
Hi,
On 30-04-15 07:59, Peter Hutterer wrote:
Causes an error message in the device_disable_release_tap_n_drag test. When
the touchpad is suspended, all touches are ended in tp_clear_state. Since the
hovering support was added, this returns the touches to TOUCH_HOVERING, a
subsequent tp_handle_st
Hi,
On 30-04-15 03:33, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
It seems this is the right thing todo:
Reviewed-by: Hans de Goede
Regards,
Hans
---
I admit, I'm not sure of the effect it has leaving the data sitting there.
timerfd_create states that only the value read chan
Hi,
On 30-04-15 06:14, Peter Hutterer wrote:
Introduced in 6b6f8151a41147eb44d08f33de143b43eb004563, libinput-version.h is
in the builddir.
Signed-off-by: Peter Hutterer
Looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
tools/Makefile.am | 4 ++--
1 file changed, 2 inse
65 matches
Mail list logo
