If tapping is enabled while at least one finger is down, we underrun
tp->tap.tap_finger_count on touch release. Avoid this by only switching
tap config whenever there are no fingers down.
Reported-by: Rui Matos
Signed-off-by: Peter Hutterer
---
src/evdev-mt-touchpad-tap.c | 47 +
Causes an error message in the device_disable_release_tap_n_drag test. When
the touchpad is suspended, all touches are ended in tp_clear_state. Since the
hovering support was added, this returns the touches to TOUCH_HOVERING, a
subsequent tp_handle_state() will turn them back into TOUCH_BEGIN based
On Wed, Apr 29, 2015 at 07:18:55PM +0200, Rui Matos wrote:
> If a touch begins before tap gets enabled we underflow
> tap_finger_count when the touch ends.
>
> This happens in practice when enabling tapping on a GUI with a
> touchpad click.
>
> Signed-off-by: Rui Matos
> ---
>
> This patch seem
We don't even need to simulate button clicks; it's done automatically.
This also fixes scrolling in Qt5 apps.
Signed-off-by: Dima Ryazanov
---
hw/xwayland/xwayland-input.c | 53 +---
hw/xwayland/xwayland.h | 4
2 files changed, 16 insertions(+)
Introduced in 6b6f8151a41147eb44d08f33de143b43eb004563, libinput-version.h is
in the builddir.
Signed-off-by: Peter Hutterer
---
tools/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index ae3a27f..792f310 100644
--- a/too
Signed-off-by: Peter Hutterer
---
I admit, I'm not sure of the effect it has leaving the data sitting there.
timerfd_create states that only the value read changes, not the actual size
of the data (which I couldn't reproduce in a quick test, it's always 1)
epoll sounds like it should keep triggeri
Added a simple C-based test framework and an example program
that uses it to run through some simple wayland client checks.
Signed-off-by: Jon A. Cruz
---
.gitignore| 3 +
Makefile.am | 34 +++
tools/Doxyfile| 318 +
Attached is the patch done to wayland. Note that no other code had to be
changed.
This is not the correct patch, the correct patch would either remove or
invert the switch.
diff --git a/src/scanner.c b/src/scanner.c
index 75322f7..168d9b5 100644
--- a/src/scanner.c
+++ b/src/scanner.c
@@ -1038,
Forcing --include-core-only on in wayland-scanner, the attached patch
makes Weston compile. This involved adding two wayland-client-protocol.h
includes.
IMHO it is better to require this small bit of editing than to continue
to include a header with the comment "Use of this header file is
dis
If a touch begins before tap gets enabled we underflow
tap_finger_count when the touch ends.
This happens in practice when enabling tapping on a GUI with a
touchpad click.
Signed-off-by: Rui Matos
---
This patch seems enough to fix the issue in my testing but I'm not
familiar with the state mac
On 04/29/2015 09:18 AM, Giulio Camuffo wrote:
You commented it out from the wrong file. Comment it in iirc
desktop-shell-client-protocol.h instead, or some other file generated
from a protocol in weston.
Okay I did this in weston:
make clean
make protocol/desktop-shell-client-
2015-04-29 19:06 GMT+03:00 Bill Spitzak :
> On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
>>
>> 2015-04-29 2:17 GMT+03:00 Bill Spitzak :
The problem is when you have an extension.xml, and generate
extension-client-protocol.h. Then you have some preexisting code
i
On 04/29/2015 03:10 AM, Pekka Paalanen wrote:
Weston had a good reason to not use getopt() I believe: each module
parses its own arguments in turn, so command line options are parsed in
several passes, and an unknown option is an error only when all modules
have had a go.
The client programs a
On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
2015-04-29 2:17 GMT+03:00 Bill Spitzak :
The problem is when you have an extension.xml, and generate
extension-client-protocol.h. Then you have some preexisting code
including that and relying on it including wayland-client.h and then
wayland-client-
Skype's popup notifications use this type.
---
xwayland/window-manager.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
index 336b018..16544e2 100644
--- a/xwayland/window-manager.c
+++ b/xwayland/window-manager.c
@@ -242
On Apr 29, 2015 3:30 AM, "Pekka Paalanen" wrote:
>
> On Wed, 29 Apr 2015 12:50:48 +0300
> Giulio Camuffo wrote:
>
> > 2015-04-29 12:13 GMT+03:00 Pekka Paalanen :
> > > On Tue, 28 Apr 2015 22:57:16 +0300
> > > Giulio Camuffo wrote:
> > >
> > >> wayland-client.h and wayland-server.h include the pr
Seems completely reasonable to me.
Reviewed-By: Derek Foreman
On 28/04/15 04:55 PM, Peter Hutterer wrote:
> Makes debugging a bit easier when you can just ask users to do that instead of
> digging around in whatever packaging system they have.
>
> Signed-off-by: Peter Hutterer
> ---
> tools/l
When using this new option the generated code will include the new
core headers instead of the old ones. The default needs to remain
unchanged for backward compatibility with old code.
With this change the generated headers will now forward declare all
types and interfaces it uses; that is needed w
When using this new option the generated code will include the new
core headers instead of the old ones. The default needs to remain
unchanged for backward compatibility with old code.
With this change the generated headers will now forward declare all
types and interfaces it uses; that is needed w
wayland-client.h and wayland-server.h include the protocol headers generated
at build time. This means that a libwayland user cannot generate and use
protocol code created from a wayland.xml newer than the installed libwayand,
because it is not possible to only include the API header.
Another use c
Signed-off-by: Hans de Goede
---
src/evdev-mt-touchpad-gestures.c | 20
src/evdev-mt-touchpad.c | 4 ++--
src/evdev-mt-touchpad.h | 2 +-
src/libinput-private.h | 11 +++
src/libinput.c | 37 +
Implement touchpad pinch (and rotate) gesture support.
Note that two two-finger scrolling tests are slightly tweaked to assure that
there is enough touch movement to allow the scroll-or-pinch detect code to do
its work.
Signed-off-by: Hans de Goede
Acked-by: Jason Gerecke
---
src/evdev-mt-touc
Extend the touchpad gesture API with pinch gestures. Note that this
new API offers a single event stream for both pinch and rotate data, this
is deliberate as some applications may be interested in getting both at
the same time. Applications which are only interested in one or the other
can simply
Add support for swipe gestures.
Signed-off-by: Hans de Goede
Reviewed-by: Peter Hutterer
Acked-by: Jason Gerecke
---
src/evdev-mt-touchpad-gestures.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-tou
For touchscreens we always send raw touch events to the compositor, and the
compositor or application toolkits do gesture recognition. This makes sense
because on a touchscreen which window / widget the touches are over is
important context to know to interpret gestures.
On touchpads however we ne
Hi All,
Here is v3 of my touchpad gestures support patch series.
Changes since v2:
- For pinch gestures instead of reporting finger distance deltas report a scale
value which is relative to the initial finger distance
- Added a new patch to provide cancellation information when a gesture ends
On Wed, 29 Apr 2015 12:50:48 +0300
Giulio Camuffo wrote:
> 2015-04-29 12:13 GMT+03:00 Pekka Paalanen :
> > On Tue, 28 Apr 2015 22:57:16 +0300
> > Giulio Camuffo wrote:
> >
> >> wayland-client.h and wayland-server.h include the protocol headers
> >> generated
> >> at build time. This means that
On Tue, 28 Apr 2015 22:57:18 +0300
Giulio Camuffo wrote:
> The new core header doesn't include any other header, since it really
> is not needed.
> ---
> Makefile.am| 1 +
> src/wayland-egl-core.h | 56
> ++
> src/wayland-egl.h |
On Tue, 28 Apr 2015 22:57:17 +0300
Giulio Camuffo wrote:
> When using this new option the generated code will include the new
> core headers instead of the old ones. The default needs to remain
> unchanged for backward compatibility with old code.
> The option handling logic code in comes directl
2015-04-29 12:13 GMT+03:00 Pekka Paalanen :
> On Tue, 28 Apr 2015 22:57:16 +0300
> Giulio Camuffo wrote:
>
>> wayland-client.h and wayland-server.h include the protocol headers generated
>> at build time. This means that a libwayland user cannot generate and use
>> protocol code created from a way
On Tue, 28 Apr 2015 22:57:16 +0300
Giulio Camuffo wrote:
> wayland-client.h and wayland-server.h include the protocol headers generated
> at build time. This means that a libwayland user cannot generate and use
> protocol code created from a wayland.xml newer than the installed libwayand,
> becau
2015-04-29 2:17 GMT+03:00 Bill Spitzak :
>> The problem is when you have an extension.xml, and generate
>> extension-client-protocol.h. Then you have some preexisting code
>> including that and relying on it including wayland-client.h and then
>> wayland-client-protocol.h, and if yo
32 matches
Mail list logo
