[PATCH libinput 3/8] test: drop REP_DELAY from the ms surface cover event codes

litest doesn't know how to set this up and we don't need it anyway. Signed-off-by: Peter Hutterer --- test/litest-ms-surface-cover.c | 1 - 1 file changed, 1 deletion(-) diff --git a/test/litest-ms-surface-cover.c b/test/litest-ms-surface-cover.c index 5b9ec23..3e026e0 100644 --- a/test/litest-

[PATCH libinput 6/8] evdev: reject devices with either REL_X or REL_Y

Not sure if any exists, if they do let's see if a user files a bug report first so we know what to do with those (they're most likely buttonsets). Signed-off-by: Peter Hutterer --- src/evdev.c | 4 1 file changed, 4 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 6a9df49..db19ac

[PATCH libinput 5/8] test: add the MS Surface Type Cover to the list of devices

Added in d2842893a828407e3c4d2459a382f8c7179b2f51 but never added to the list of devices so none of the tests ran against it. Signed-off-by: Peter Hutterer --- test/litest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/litest.c b/test/litest.c index 235ccb9..6d17a37 100644 --- a/te

[PATCH libinput 1/8] test: fix a memory leak in the touch test

Signed-off-by: Peter Hutterer --- test/touch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/touch.c b/test/touch.c index ac97c52..5c363f9 100644 --- a/test/touch.c +++ b/test/touch.c @@ -439,6 +439,8 @@ START_TEST(fake_mt_exists) * have different capabilities */ ck_

[PATCH libinput 2/8] test: check for event as not null before dereferencing it

Signed-off-by: Peter Hutterer --- test/pointer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/pointer.c b/test/pointer.c index 0d49310..01ea2fd 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -136,6 +136,7 @@ test_absolute_event(struct litest_device *dev, double x, double y)

[PATCH libinput 4/8] test: fix features for the MS Surface Cover

LITEST_KEYBOARD is the type, LITEST_KEYS is the feature. And this device has buttons, so mark it as such. Signed-off-by: Peter Hutterer --- test/litest-ms-surface-cover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/litest-ms-surface-cover.c b/test/litest-ms-surface-c

[PATCH libinput 7/8] evdev: init pointer accel filters when we have rel x/y axes

Some devices provide abs x/y and rel x/y. We can't know which event the device will send. The Microsoft Surface Type Cover sends relative devices, which then crashes libinput when we don't have an accel filter set up. So instead of checking that the device doesn't have ABS_X/Y, check for the devic

[PATCH libinput 8/8] test: upgrade to the Microsoft Surface Type Cover

Almost identical to the one we already had but this one also has ABS_X/Y to mess things up. Update the existing one, no need to add a separate device here. The fake MT touch test needs to be updated now though. A fake MT device may be an absolute device too, so if we use the touch_down() handlers

Re: [PATCH libinput v2 0/4] touchpad gestures support

On Fri, Apr 24, 2015 at 02:39:07PM +0200, Carlos Garnacho wrote: > On Fri, Apr 24, 2015 at 1:49 PM, Hans de Goede wrote: > > Hi, > > > > On 24-04-15 13:39, Carlos Garnacho wrote: > >> > >> Hey Hans :), > >> > >> On jue, 2015-03-26 at 10:04 +0100, Hans de Goede wrote: > >>> > >>> Hi All, > >>> > >>

Re: Patch: some refactoring in evdev-mt-touchpad-tap.c

Hi Lucas, On Fri, Apr 24, 2015 at 11:50:58PM +0200, Lucas Baudin wrote: > Here is a patch that factorizes some code from edev-mt-touchpad-tap.c, that > uses more the structures that are already updated by libinput. > > This patch is a first step towards multi-touch touchpad event, such as three >

Re: [PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt touchpads

On Fri, Apr 24, 2015 at 04:49:36PM +0200, Hans de Goede wrote: > Some semi-mt model touchpads have a better accuracy for slot 0 then for > slot 1 (they only have 2), so on semi-mt models only use the movement of > the touch in slot 0 for 2fg scrolling, rather then the average movement of > the 2 to

Re: [PATCH libinput v5] evdev: use a different filter for low resolution touchpad on the Lenovo X230

On Thu, Apr 23, 2015 at 02:32:40PM -0400, Benjamin Tissoires wrote: > Those touchpads presents an actual lower resolution that what is > advertised. > > We see some jumps from the cursor due to the big steps in X and Y > when we are receiving data. > > For instance, we receive: > > E: 13.471932

Re: [PATCH libinput v2] tests: Add negative test for libinput_device_keyboard_has_key()

On Fri, Apr 24, 2015 at 05:21:18PM -0500, Derek Foreman wrote: > Ensure we get a -1 return for non-keyboard devices. > > Signed-off-by: Derek Foreman merged, thanks, though I did a minor change to it to make the line wrapping nicer: + for (code = 0; code < KEY_CNT; code++) { +

Re: [PATCH libinput] test: add LITEST_KEYS to roccat mouse features

On Fri, Apr 24, 2015 at 05:23:13PM -0500, Derek Foreman wrote: > The mouse can generate key events, so it should be carry that feature bit. > > Signed-off-by: Derek Foreman pushed, thanks. Cheers, Peter > --- > test/litest-mouse-roccat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH libinput] touchpad: allow BTN_LEFT in clickfinger mode without touches

On Fri, Apr 24, 2015 at 08:30:28AM +0200, Hans de Goede wrote: > Hi, > > On 24-04-15 06:20, Peter Hutterer wrote: > >On the Logitech T650 it's quite easy to trigger a click without touching the > >surface. For software buttons we discard those clicks because we can't tell > >where the finger is to

Re: [PATCH libinput v5] evdev: use a different filter for low resolution touchpad on the Lenovo X230

Hi Benjamin, This one works well on my x230. Have my: Tested-by: Vasily Khoruzhick Regards, Vasily On Thu, Apr 23, 2015 at 9:32 PM, Benjamin Tissoires wrote: > Those touchpads presents an actual lower resolution that what is > advertised. > > We see some jumps from the cursor due to the big