Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-22 Thread Pekka Paalanen
On Wed, 22 Apr 2015 08:38:22 -0700 Bill Spitzak wrote: > On 04/21/2015 11:34 PM, Pekka Paalanen wrote: > > > I also think this discussion is going off-topic. You wanted to add > > annotations to the XML, so you could find out about enum and bitfield > > arguments, so let's keep to that. There is

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-22 Thread Pekka Paalanen
On Wed, 22 Apr 2015 11:47:51 +0200 Auke Booij wrote: > On 22 April 2015 at 08:34, Pekka Paalanen wrote: > > I also think this discussion is going off-topic. You wanted to add > > annotations to the XML, so you could find out about enum and bitfield > > arguments, so let's keep to that. There is

Re: Wayland Relative Pointer API Progress

2015-04-22 Thread x414e54
On Thu, Apr 23, 2015 at 1:51 PM, x414e54 wrote: > On Wed, Apr 22, 2015 at 1:52 PM, Peter Hutterer > wrote: >> The real problem regarding the mouse position is that you now rely on the >> client and the compositor to calculate the cursor position exactly the same >> way. If not, you may end up lea

Re: Wayland Relative Pointer API Progress

2015-04-22 Thread x414e54
On Wed, Apr 22, 2015 at 1:52 PM, Peter Hutterer wrote: > The real problem regarding the mouse position is that you now rely on the > client and the compositor to calculate the cursor position exactly the same > way. If not, you may end up leaving the window when the cursor as drawn by > the client

Re: [PATCH libinput v4 2/2] udev: add a custom udev rule for X230 touchpads

2015-04-22 Thread Peter Hutterer
On Mon, Apr 20, 2015 at 02:29:45PM -0400, Benjamin Tissoires wrote: > X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to > apply a different acceleration profile. > > Signed-off-by: Benjamin Tissoires > Reviewed-by: Peter Hutterer > --- > changes in v4: > - renamed the file

[PATCH] doc: use enum information to make documentation links

2015-04-22 Thread Bill Spitzak
This is based on (and includes unchanged) Auke Booij's patch to protocol.xml to add enum type information. This ignores whether an enumeration is a bitmap, but that seems to be clear from the summary text. ___ wayland-devel mailing list wayland-devel@lis

[PATCH 2/2] doc: Use enum argument type to make links in protocol documentation

2015-04-22 Thread Bill Spitzak
--- doc/publican/protocol-to-docbook.xsl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/publican/protocol-to-docbook.xsl b/doc/publican/protocol-to-docbook.xsl index 7b45969..3c4e140 100644 --- a/doc/publican/protocol-to-docbook.xsl +++ b/doc/public

[PATCH 1/2] Clarify the enum argument type

2015-04-22 Thread Bill Spitzak
This improvement to the protocol allows you to refer to the kind of enum you are expecting. It also introduces a distinction between enums that are bitfields, ie that can be OR'ed together. --- protocol/wayland.dtd |2 ++ protocol/wayland.xml | 32 2 files c

[PATCH libinput] evdev: add support for LIBINPUT_MODEL_* udev tags

2015-04-22 Thread Peter Hutterer
Some devices need specific configuration or different defaults. Push that into udev rules and a hwdb file, that's where detection is the easiest. The LIBINPUT_MODEL_ prefix is used to determine some type of device model. Note that this property is a private API and subject to change at any time wit

Re: [PATCH] test-touchpad: Adjust touchpad_edge_scroll_no_2fg test for gesture support

2015-04-22 Thread Peter Hutterer
On Wed, Apr 22, 2015 at 10:32:38AM +0200, Hans de Goede wrote: > Unlike all the other 2fg scroll tests the touchpad_edge_scroll_no_2fg test > puts the 2 fingers down quite far apart, this makes the pinch vs scroll > gesture detection code in the gestures branch detect a pinch causing the > test to

Re: [PATCH libinput] Add libinput_device_keyboard_has_key()

2015-04-22 Thread Peter Hutterer
On Wed, Apr 22, 2015 at 08:45:21AM -0500, Derek Foreman wrote: > On 21/04/15 11:44 PM, Peter Hutterer wrote: > > Similar to libinput_device_pointer_has_button(), this function returns > > whether > > a given device has a specific keycode. > > > > This enables a caller to determine if the device i

[PATCH v2 weston] window: Use wl_cursor_frame_and_duration() for mouse cursor updates

2015-04-22 Thread Derek Foreman
Some animated cursor sets use very long delays, but until now we'd use the frame callback and update the cursor at the display framerate anyway. Now we use a timerfd to drive cursor animation if the delay is longer than 100ms, or the old method for short delays. Signed-off-by: Derek Foreman ---

Re: [PATCH 5/6] compositor-drm: Fix refresh rate selection in drm_output_switch_mode

2015-04-22 Thread Derek Foreman
On 22/04/15 12:42 AM, Mario Kleiner wrote: > On 04/16/2015 07:14 PM, Derek Foreman wrote: >> On 02/04/15 12:10 AM, Mario Kleiner wrote: >>> The matching logic in choose_mode() compared refresh rate >>> of a drm_mode candidate mode expressed in Hz against the >>> requested refresh rate of the target

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-22 Thread Bill Spitzak
I think this looks like the correct patch. Only correction is that I would put the enum right after the type="int" consistently. Some of your cases you put the summary between them. On 04/19/2015 01:30 PM, Auke Booij wrote: On 19 April 2015 at 14:51, Jeroen Bollen wrote: Hello, It seems li

Re: [PATCH libinput v4 0/2] Fix Lenovo X230 series touchpad

2015-04-22 Thread Giulio Camuffo
Hi, sorry to bikeshed but imho the v1, while maybe too slow, was better than this one. Imho the acceleration curve is too abrupt, i find that sometimes i'm trying to move the pointer some tens of pixels away so i move the finger slowly, only it's too slow so i accelerate a bit and i end up swoopin

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-22 Thread Bill Spitzak
On 04/21/2015 11:34 PM, Pekka Paalanen wrote: I also think this discussion is going off-topic. You wanted to add annotations to the XML, so you could find out about enum and bitfield arguments, so let's keep to that. There is value in simplicity. Absolutely agree How about this: Auke's ori

Re: [PATCH libinput] Add libinput_device_keyboard_has_key()

2015-04-22 Thread Derek Foreman
On 21/04/15 11:44 PM, Peter Hutterer wrote: > Similar to libinput_device_pointer_has_button(), this function returns whether > a given device has a specific keycode. > > This enables a caller to determine if the device is really a keyboard (check > for KEY_A-KEY_Z) or just a media key device (chec

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-22 Thread Auke Booij
On 22 April 2015 at 08:34, Pekka Paalanen wrote: > I also think this discussion is going off-topic. You wanted to add > annotations to the XML, so you could find out about enum and bitfield > arguments, so let's keep to that. There is value in simplicity. > > > How about this: > > Add three new, m

Re: [PATCH libinput] Add libinput_device_keyboard_has_key()

2015-04-22 Thread Hans de Goede
Hi, On 22-04-15 06:44, Peter Hutterer wrote: Similar to libinput_device_pointer_has_button(), this function returns whether a given device has a specific keycode. This enables a caller to determine if the device is really a keyboard (check for KEY_A-KEY_Z) or just a media key device (check for

[PATCH] test-touchpad: Adjust touchpad_edge_scroll_no_2fg test for gesture support

2015-04-22 Thread Hans de Goede
Unlike all the other 2fg scroll tests the touchpad_edge_scroll_no_2fg test puts the 2 fingers down quite far apart, this makes the pinch vs scroll gesture detection code in the gestures branch detect a pinch causing the test to fail. This commit brings the finger placement in line with the other 2

Re: Wayland Relative Pointer API Progress

2015-04-22 Thread Peter Hutterer
On Tue, Apr 21, 2015 at 06:05:02PM -0700, Bill Spitzak wrote: > Interesting. It does seem like a good idea to do remote by providing > identical device api's. This probably applies to sound output too. There > will have to be simple and obvious methods to figure out the remote machine > so that all

[PATCH libinput] Add libinput_device_keyboard_has_key()

2015-04-22 Thread Peter Hutterer
Similar to libinput_device_pointer_has_button(), this function returns whether a given device has a specific keycode. This enables a caller to determine if the device is really a keyboard (check for KEY_A-KEY_Z) or just a media key device (check for KEY_PLAY or somesuch), depending on the context