[PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Manuel Bachmann
From: Manuel Bachmann Some DRI drivers, including VMware vmwgfx, do not support calling eglQueryString() with a EGL_NO_DISPLAY parameter. Just as we do in gl_renderer_supports(), which returns 0 but does not fail in this case, do not fail in gl_renderer_setup_egl_extensions(). With some versions

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Manuel Bachmann
Agreed ! I am going send the patch again, same name ("gl-renderer: fix EGL initialization steps") but modified in this sense and with another commit message, Regards, Manuel 2015-04-02 11:51 GMT+02:00 Pekka Paalanen : > On Mon, 30 Mar 2015 21:48:32 +0200 > Manuel Bachmann wrote: > > > OK. Foun

Re: [PATCH] config: use simpler regexp syntax to get dot version

2015-04-02 Thread Bryce Harrington
On Thu, Apr 02, 2015 at 07:20:00PM -0700, Bill Spitzak wrote: > I wasted a lot of time before I figured out that I needed to add those > square brackets to get this to work. Sigh... Lots clearer too. Reviewed-by: Bryce Harrington > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+

Re: [PATCH 5/5] tests: Refactor weston launching syntax

2015-04-02 Thread Bryce Harrington
On Thu, Apr 02, 2015 at 02:13:36PM +0300, Pekka Paalanen wrote: > On Wed, 1 Apr 2015 19:17:07 -0700 > Bryce Harrington wrote: > > > There are only minor differences in the syntax for how weston is invoked > > for .so/.la tests vs. other tests, but it's hard to spot them. Refactor > > the comman

[PATCH] config: use simpler regexp syntax to get dot version

2015-04-02 Thread Bill Spitzak
I wasted a lot of time before I figured out that I needed to add those square brackets to get this to work. Sigh... --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6bbec59..271eec3 100644 --- a/configure.ac +++ b/configure.

[PATCH 7/9] tests: Prefer bracket form of test command for consistency

2015-04-02 Thread Bryce Harrington
Also use variable default assignment to eliminate an if clause Signed-off-by: Bryce Harrington --- tests/weston-tests-env | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/weston-tests-env b/tests/weston-tests-env index 09fc3a3..53bf8d6 100755 --- a/tests/weston-tes

[PATCH 5/9] tests: Refactor weston launching syntax

2015-04-02 Thread Bryce Harrington
There are only minor differences in the syntax for how weston is invoked for .so/.la tests vs. other tests, but it's hard to spot them. Refactor the command itself out, so it becomes clearer what the difference is. Signed-off-by: Bryce Harrington --- tests/weston-tests-env | 35

[PATCH 9/9] tests: Add test to verify tests' ini files get loaded

2015-04-02 Thread Bryce Harrington
config-malformed uses an invalid configuration file to verify that the test harness is indeed attempting to load the test's requested config file. Signed-off-by: Bryce Harrington --- Makefile.am | 12 +++- tests/config-malformed-test.c | 33 +

[PATCH 4/9] tests: Cleanup test log filenames

2015-04-02 Thread Bryce Harrington
The log files were being named like: surface-global-test.la-log.txt surface-global-test.la-serverlog.txt surface-test.la-log.txt surface-test.la-serverlog.txt text.weston-log.txt text.weston-serverlog.txt For consistency, omit the test filename's ex

[PATCH 6/9] tests: Simplify the .la/.so logic

2015-04-02 Thread Bryce Harrington
Once we convert *.la to *.so, we only care about *.so files Signed-off-by: Bryce Harrington --- tests/weston-tests-env | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/tests/weston-tests-env b/tests/weston-tests-env index f7ee27a..09fc3a3 100755 --- a/tes

[PATCH 3/9] tests: Keep track of basename

2015-04-02 Thread Bryce Harrington
basename returns the filename without path information (but with the file extension). We can get this more efficiently via shell variables. Also, for the socket name, use the test's name without the file extension. Reviewed-by: Pekka Paalanen Signed-off-by: Bryce Harrington --- tests/weston-t

[PATCH 1/9] compositor: Help text for --config

2015-04-02 Thread Bryce Harrington
Reviewed-by: Pekka Paalanen Signed-off-by: Bryce Harrington --- src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor.c b/src/compositor.c index 4de8fbf..e6a60bd 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -5032,6 +5032,7 @@ usage(int error_code)

[PATCH 2/9] tests: Support --config to enable tests to override config defaults

2015-04-02 Thread Bryce Harrington
Implements a simple mechanism to allow tests to customize the configuration. Just place a .ini file at the same location as the test itself. If no configuration file is found, then no configuration will be used (i.e. --no-config is specified.) Signed-off-by: Bryce Harrington --- Makefile.am

[PATCH 8/9] tests: Add a couple minor error checks

2015-04-02 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- tests/weston-tests-env | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/weston-tests-env b/tests/weston-tests-env index 53bf8d6..c0a211e 100755 --- a/tests/weston-tests-env +++ b/tests/weston-tests-env @@ -10,19 +10,15 @@ f

[PATCH weston v2 0/9] Enable test configuration

2015-04-02 Thread Bryce Harrington
This enables tests to provide their own .ini files for configuring weston, via the recently added --config option. Also included in this set is some related cleanup in weston-tests-env. [Update v2] Implemented review comments from pekka: * Dropped ~/.config as default location of weston.ini in h

Re: [PATCH weston] compositor-wayland: ignore frame callback's time

2015-04-02 Thread Bill Spitzak
Oops never mind, that is a listener function so it needs the argument even if it ignores it On 04/02/2015 07:14 AM, Derek Foreman wrote: Makes sense, fixes the problem for me. Reviewed-by: Derek Foreman On 02/04/15 08:54 AM, Pekka Paalanen wrote: From: Pekka Paalanen Weston running the Wa

Re: [PATCH weston] compositor-wayland: ignore frame callback's time

2015-04-02 Thread Bill Spitzak
Should you remove the unused "time" argument? On 04/02/2015 07:14 AM, Derek Foreman wrote: Makes sense, fixes the problem for me. Reviewed-by: Derek Foreman On 02/04/15 08:54 AM, Pekka Paalanen wrote: From: Pekka Paalanen Weston running the Wayland backend is nested. The parent compositor

[PATCH weston] xwm: Don't remove the frame's window id from hash until the frame is destroyed

2015-04-02 Thread Derek Foreman
Previously when a client window was destroyed we destroyed its frame and removed the frame's id from the window hash table. If a window is created then destroyed very quickly a race exists - the frame may receive a configure notify after its client window is already gone. This results in the wind

Re: [PATCH weston 0/6] Add client driven repaint and clock for testing

2015-04-02 Thread Derek Foreman
On 27/03/15 07:54 AM, Pekka Paalanen wrote: > On Fri, 19 Dec 2014 12:45:44 -0600 > Derek Foreman wrote: > >> This series allows test clients to put the compositor into a new "test mode" >> where the presentation clock is controlled by the client, and the client >> can request a repaint. >> >> Onl

Re: [PATCH weston 6/6] compositor-headless: Add test mode

2015-04-02 Thread Derek Foreman
On 27/03/15 07:50 AM, Pekka Paalanen wrote: > On Tue, 27 Jan 2015 12:38:46 + > Daniel Stone wrote: > >> Hi, >> >> On 19 December 2014 at 18:45, Derek Foreman wrote: >>> static int >>> headless_output_repaint(struct weston_output *output_base, >>>pixman_region32_t *d

Re: [PATCH weston v2 3/6] test: Add clock_settime()

2015-04-02 Thread Derek Foreman
On 27/03/15 07:38 AM, Pekka Paalanen wrote: > On Mon, 22 Dec 2014 16:09:58 -0600 > Derek Foreman wrote: > >> Add a way to set the presentation clock to an arbitrary value, but only >> when in test mode. >> >> Signed-off-by: Derek Foreman >> --- >> protocol/wayland-test.xml | 9 + >> sr

Re: [PATCH weston 5/6] test: Add client driven repaint

2015-04-02 Thread Derek Foreman
On 27/03/15 07:44 AM, Pekka Paalanen wrote: > On Fri, 19 Dec 2014 12:45:49 -0600 > Derek Foreman wrote: > >> Allow a test client to call for a repaint. >> >> Signed-off-by: Derek Foreman >> --- >> protocol/wayland-test.xml | 1 + >> tests/weston-test.c | 9 + >> 2 files changed, 1

Re: egl streams, trying to gain some knowledge

2015-04-02 Thread Daniel Stone
Hi, My two cents, which largely parallels Jason's ... On 2 April 2015 at 08:35, Dave Airlie wrote: > So nvidia have indicated they would like to use an EGLstreams based > solution to enable wayland on their binary driver stack at some point. No real surprise, I guess. NVIDIA have long pushed EGL

Re: egl streams, trying to gain some knowledge

2015-04-02 Thread Jason Ekstrand
On Thu, Apr 2, 2015 at 12:35 AM, Dave Airlie wrote: > So nvidia have indicated they would like to use an EGLstreams based > solution to enable wayland on their binary driver stack at some point. As per their recent XDC talk, they sounded like they had given up on eglstreams for implementing the W

Re: [PATCH weston] compositor-wayland: ignore frame callback's time

2015-04-02 Thread Derek Foreman
Makes sense, fixes the problem for me. Reviewed-by: Derek Foreman On 02/04/15 08:54 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Weston running the Wayland backend is nested. The parent compositor uses > an unknown clock for the frame callback timestamps. This is quite likely > a diffe

Re: [PATCH weston 2/2] compositor: Skip repaint delay for nested compositors

2015-04-02 Thread Pekka Paalanen
On Thu, 2 Apr 2015 13:29:53 +0300 Pekka Paalanen wrote: > On Wed, 1 Apr 2015 12:37:34 -0500 > Derek Foreman wrote: > > > The repaint delay becomes cumulative if it's used in both a parent > > compositor and a nested compositor. This can lead to dropped frames > > and visible latency. > > > >

[PATCH weston] compositor-wayland: ignore frame callback's time

2015-04-02 Thread Pekka Paalanen
From: Pekka Paalanen Weston running the Wayland backend is nested. The parent compositor uses an unknown clock for the frame callback timestamps. This is quite likely a different clock from what the nested Weston chose as its presentation clock. This means we cannot reasonably read the presentat

Xfig menus don't appear - bug?

2015-04-02 Thread Felix E. Klee
When I click on a menu in [Xfig][1] running in xwayland, then it doesn’t appear. The same Xfig installation in X.org runs fine. I start Wayland directly from the console, i.e. with DRI/KMS: $ weston-launch `weston.ini`: [core] modules=xwayland.so System: * VMware Player guest

Re: [PATCH weston 4/9] ivi-layout: abort without controller_module_init

2015-04-02 Thread Pekka Paalanen
On Thu, 2 Apr 2015 01:04:12 + "Tanibata, Nobuhiko (ADITJ/SWG)" wrote: > > > > -Original Message- > > From: wayland-devel > > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka > > Paalanen > > Sent: Monday, March 30, 2015 6:21 PM > > To: wayland-devel@lists.free

Re: [PATCH 2/6] compositor-drm: Allow instant start of repaint loop.

2015-04-02 Thread Pekka Paalanen
On Thu, 2 Apr 2015 07:10:50 +0200 Mario Kleiner wrote: > drm_output_start_repaint_loop() incurred a delay of > one refresh cycle by using a no-op page-flip to get > an accurate vblank timestamp as reference. This causes > unwanted lag whenever Weston exited its repaint loop, e.g., > whenever an

Re: [PATCH 5/5] tests: Refactor weston launching syntax

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 19:17:07 -0700 Bryce Harrington wrote: > There are only minor differences in the syntax for how weston is invoked > for .so/.la tests vs. other tests, but it's hard to spot them. Refactor > the command itself out, so it becomes clearer what the difference is. > > Signed-off-

Re: [PATCH 1/5] compositor: Help text for --config

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 19:17:03 -0700 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/compositor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compositor.c b/src/compositor.c > index 4de8fbf..f969018 100644 > --- a/src/compositor.c > +++ b/src/compositor.c >

Re: [PATCH 2/5] tests: Support --config to enable tests to override config defaults

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 19:17:04 -0700 Bryce Harrington wrote: > Implements a simple mechanism to allow tests to customize the > configuration. Just place a .ini file at the same location as the > test itself. If no configuration file is found, then no configuration > will be used (i.e. --no-config

Re: [PATCH 4/5] tests: Cleanup test log filenames

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 19:17:06 -0700 Bryce Harrington wrote: > The log files were being named like: > > surface-global-test.la-log.txt > surface-global-test.la-serverlog.txt > surface-test.la-log.txt > surface-test.la-serverlog.txt > text.weston-log.txt > text.w

Re: [PATCH 3/5] tests: Keep track of basename

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 19:17:05 -0700 Bryce Harrington wrote: > basename returns the filename without path information (but with > the file extension). We can get this more efficiently via shell > variables. > > Also, for the socket name, use the test's name without the file > extension. > > Sign

Re: [PATCH weston 2/2] compositor: Skip repaint delay for nested compositors

2015-04-02 Thread Pekka Paalanen
On Wed, 1 Apr 2015 12:37:34 -0500 Derek Foreman wrote: > The repaint delay becomes cumulative if it's used in both a parent > compositor and a nested compositor. This can lead to dropped frames > and visible latency. > > Signed-off-by: Derek Foreman > --- > src/compositor.c | 8 > 1

Re: use compatible check for dot version

2015-04-02 Thread Pekka Paalanen
On Tue, 31 Mar 2015 20:52:48 +0200 Hector Oron wrote: > Hello, > > 2015-03-31 20:49 GMT+02:00 Bill Spitzak : > > I can't get either of those to work, but how about this: > > > > dot_version=`$DOT -V 2>&1 | $GREP -o '[0-9]*\.[0-9]*\.[0-9]*'` > > That one also works for me. Ok, so will someone

Re: [PATCH weston 2/9] tests: rename client_create to create_client_and_test_surface

2015-04-02 Thread Pekka Paalanen
On Tue, 31 Mar 2015 13:18:28 +0200 Marek Chalupa wrote: > Hi, > > yep, I can confirm R-b for the two patches. The two patches pushed. 5fd8140..4ac06ff master -> master Thanks, pq > On Tue, Mar 31, 2015 at 11:26 AM, Pekka Paalanen > wrote: > > > On Mon, 30 Mar 2015 06:52:37 -0400 > > Ma

Re: [PATCH] evdev: Add support for TRACKPOINT_CONST_ACCEL udev property

2015-04-02 Thread Hans de Goede
Hi, Note this is a libinput patch, I forgot to set subjectprefix when sending this. Regards, Hans On 02-04-15 11:50, Hans de Goede wrote: There is quite a wide spread in the delta events generated by trackpoints, some generate deltas of 1-2 under normal use, while others generate deltas from

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-04-02 Thread Pekka Paalanen
On Mon, 30 Mar 2015 21:48:32 +0200 Manuel Bachmann wrote: > OK. Found it, thanks to your hint, Daniel. > > This version of Mesa (10.1.3) does not feature these extensions. > > They were added here : > http://cgit.freedesktop.org/mesa/mesa/commit/src/egl/main/eglglobals.c?id=468cc866b4b308cee404

[PATCH] evdev: Add support for TRACKPOINT_CONST_ACCEL udev property

2015-04-02 Thread Hans de Goede
There is quite a wide spread in the delta events generated by trackpoints, some generate deltas of 1-2 under normal use, while others generate deltas from 1-20. It is desirable to normalize trackpoint deltas just like we are normalizing mouse deltas to 1000 dpi, so as to give different model lapto

egl streams, trying to gain some knowledge

2015-04-02 Thread Dave Airlie
So nvidia have indicated they would like to use an EGLstreams based solution to enable wayland on their binary driver stack at some point. I'm just trying to gauge how people in mesa/wayland feel about this as a solution, is it a solution looking for a problem, when you have EGLstreams everything

Re: [PATCH weston 2/2] compositor: Skip repaint delay for nested compositors

2015-04-02 Thread Bryce Harrington
On Wed, Apr 01, 2015 at 12:37:34PM -0500, Derek Foreman wrote: > The repaint delay becomes cumulative if it's used in both a parent > compositor and a nested compositor. This can lead to dropped frames > and visible latency. > > Signed-off-by: Derek Foreman > --- > src/compositor.c | 8

Re: [PATCH libinput v2 0/4] touchpad gestures support

2015-04-02 Thread Hans de Goede
Hi, On 01-04-15 23:42, Jason Gerecke wrote: On 3/26/2015 2:04 AM, Hans de Goede wrote: Hi All, Here is v2 of my touchpad gestures support patch series, changes since v1: - Merge the gesture capability flag and event-debug patched into the "touchpad: Add an API for touchpad gesture events" -