Re: [PATCH weston 0/4] Some transform fixes

On Tue, Mar 24, 2015 at 11:36:12AM -0500, Derek Foreman wrote: > Zoom broke in 87535e24 "zoom: use pixels instead of gl co-ordinates" > was fixed for some transforms in 0f67941c "compositor: use > weston_matrix_transform for weston_output_transform_coordinate" > but that commit broke multiple outp

Re: [RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

On Mar 24, 2015 6:14 PM, "Jonas Ådahl" wrote: > > On Wed, Mar 25, 2015 at 10:27:10AM +1000, Peter Hutterer wrote: > > The axis_source event determines how an axis event was generated. This enables > > clients to judge when to use kinetic scrolling. > > > > The axis_stop event notifies a client abo

Re: [RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

On Wed, Mar 25, 2015 at 10:27:10AM +1000, Peter Hutterer wrote: > The axis_source event determines how an axis event was generated. This enables > clients to judge when to use kinetic scrolling. > > The axis_stop event notifies a client about the termination of a scroll > sequence, likewise needed

Re: [RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

On Tue, Mar 24, 2015 at 5:27 PM, Peter Hutterer wrote: > The axis_source event determines how an axis event was generated. This enables > clients to judge when to use kinetic scrolling. > > The axis_stop event notifies a client about the termination of a scroll > sequence, likewise needed to calcu

[RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

The axis_source event determines how an axis event was generated. This enables clients to judge when to use kinetic scrolling. The axis_stop event notifies a client about the termination of a scroll sequence, likewise needed to calculate kinetic scrolling parameters. The axis_discrete event provi

Re: [PATCH wayland] protocol: add a note about the version bumps on wl_seat

On Wed, Mar 25, 2015 at 09:37:21AM +1000, Peter Hutterer wrote: > See the explanation by Jonas here: > http://lists.freedesktop.org/archives/wayland-devel/2015-March/020814.html > > --- > One thought while writing this: would it make sense to add a > wl_seat.get_pointer_versioned request to reques

[PATCH wayland] protocol: add a note about the version bumps on wl_seat

See the explanation by Jonas here: http://lists.freedesktop.org/archives/wayland-devel/2015-March/020814.html --- One thought while writing this: would it make sense to add a wl_seat.get_pointer_versioned request to request a specific wl_pointer version from the seat? or is that a solution waiting

Re: [PATCH libinput 3/3] Add a normalized_length helper function and use this where applicable

On Tue, Mar 24, 2015 at 01:14:19PM +0100, Hans de Goede wrote: > Add a normalized_length helper function and use this where applicable, > just a minor cleanup. > > Signed-off-by: Hans de Goede thanks, all three merged, with a couple of minor whitespace changes as detailed below. > --- > src/ev

Re: [PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

On Tue, Mar 24, 2015 at 04:51:35PM +0100, Hans de Goede wrote: > Change tp_filter_motion to use normalized_coords, rather then having it take > separate x and y values. > > Signed-off-by: Hans de Goede weird. I remember writing this patch but apparently it went down the wrong dark branch and got

[PATCH weston 1/4] compositor: Create the inverse of the output matrix

Signed-off-by: Derek Foreman --- src/compositor.c | 2 ++ src/compositor.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 47da818..623dff3 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4003,6 +4003,8 @@ weston_output_update_matrix(struc

[PATCH weston 4/4] pixman-renderer: use pre-computed inverse output matrix

We've already computer the inverse of the ouput matrix, so we don't need to calculate it again here. Signed-off-by: Derek Foreman --- src/pixman-renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index a479684..c650d55 100

[PATCH weston 3/4] zoom: fix zoom

Right now zoom only works on the output at 0, 0 because it's adding the output corner co-ordinates to global co-ordinates that already include the output offset. Signed-off-by: Derek Foreman --- src/zoom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zoom.c b/src/z

[PATCH weston 2/4] compositor: fix weston_output_transform_coordinate

weston_output_transform_coordinate() was supposed to convert from device co-ordinates to global co-ordinates. Commit 0f67941c broke that by converting from global to device instead, which just magically works ok for single untransformed outputs (where the transformation is identity) Signed-off-by

[PATCH weston 0/4] Some transform fixes

Zoom broke in 87535e24 "zoom: use pixels instead of gl co-ordinates" was fixed for some transforms in 0f67941c "compositor: use weston_matrix_transform for weston_output_transform_coordinate" but that commit broke multiple output nested compositors (x11, wayland) because it did the inverse transfo

[PATCH libinput 2/2] Change tp_filter_motion to normalized_coords

Change tp_filter_motion to use normalized_coords, rather then having it take separate x and y values. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-edge-scroll.c | 3 +-- src/evdev-mt-touchpad-gestures.c| 8 src/evdev-mt-touchpad.c | 29 ++-

[PATCH libinput 1/2] Add a normalized_is_zero helper function

Add a normalized_is_zero helper function, and use it where applicable. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 5 ++--- src/evdev-mt-touchpad.c | 2 +- src/evdev.c | 6 ++ src/libinput-private.h | 6 ++ 4 files changed,

Re: [PATCH weston 5/6] Pass config file from compositor to everything

Hi, On 24 March 2015 at 13:56, Pekka Paalanen wrote: > We have the Weston command line option '--no-config' which is meant to > prevent loading weston.ini at all. It works for Weston itself, but it > does not work for any clients that also want to read weston.ini. > > To fix that, introduce a new

Re: [PATCH weston] compositor-x11: Fix pointer warping with multiple outputs

On 20/03/15 05:17 PM, Ondřej Majerech wrote: > When using the X11 backend with multiple outputs, moving the mouse from > one output to another would cause it to warp back to the edge of the > first output. > > This was caused by the backend reporting motion events relative to each > respective out

[PATCH weston 3/6] shared: fail reading a directory as a config file

From: Pekka Paalanen open() will happily open directories and other non-normal files. Attempting to parse them as config files makes no sense, so check that the opened file is indeed a regular file. Signed-off-by: Pekka Paalanen --- shared/config-parser.c | 8 1 file changed, 8 insert

[PATCH weston 1/6] compositor: postpone unhandled option check

From: Pekka Paalanen Move the code that checks for unhandled command line options only after all the module loading. We pass argc, argv to all module loaders, so modules might want to have command line options, but you cannot use them if the check is too early. Signed-off-by: Pekka Paalanen ---

[PATCH weston 4/6] compositor: move code into load_configuration()

From: Pekka Paalanen Move the config file loading code from main() to its own function. No functional changes. Signed-off-by: Pekka Paalanen --- src/compositor.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/compositor.c b/src/composit

[PATCH weston 0/6] Configuration file control

From: Pekka Paalanen Hi, I'm writing some testing foundations for ivi-shell, and for that I need to specify a special weston.ini from the tests. This series starts with some clean-up and sanity checks. The main point are the last two patches, which ensure all pieces of Weston use the same confi

[PATCH weston 6/6] compositor: add option to specify a weston.ini

From: Pekka Paalanen Add a command line option to specify a file to be read instead of weston.ini. IVI-shell testing will at least temporarily need to specify a config file, because it cannot run without. That is why this is being added, but should be convenient for everybody, too. Signed-off-b

[PATCH weston 2/6] tests: use MODDIR in weston-tests-env

From: Pekka Paalanen Make a little short-hand for the module directory. This also cleans up the redefinition of BACKEND in the script. Signed-off-by: Pekka Paalanen --- tests/weston-tests-env | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/weston-test

[PATCH weston 5/6] Pass config file from compositor to everything

From: Pekka Paalanen We have the Weston command line option '--no-config' which is meant to prevent loading weston.ini at all. It works for Weston itself, but it does not work for any clients that also want to read weston.ini. To fix that, introduce a new environment variable WESTON_CONFIG_FILE.

Re: [PATCH weston 00/10] platform_base cleanups and review reply

On Tue, 24 Mar 2015 13:11:59 +0100 Jonny Lamb wrote: > In reply to Pekka's late review, I've written some more patches to > address his comments: > > Jonny Lamb (10): > compositor-{drm,x11,wayland}: stop including EGL headers here > gl-renderer: fix build with --disable-egl > gl-renderer:

[PATCH libinput 1/3] Fix scroll-threshold check for edge-scrolling to use normalized coordinates

The DEFAULT_SCROLL_THRESHOLD value is a TP_MM_TO_DPI_NORMALIZED value and as such should be compared to a normalized value. But since commit 8101e43774 ("touchpad: switch delta handling to typesafe coordinates"), the initial_dx / initial_dy values initial_delta points to are no longer in normalized

[PATCH libinput 3/3] Add a normalized_length helper function and use this where applicable

Add a normalized_length helper function and use this where applicable, just a minor cleanup. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-tap.c | 10 +++--- src/filter.c| 4 +--- src/libinput-private.h | 7 +++ 3 files changed, 11 insertions(+), 10 deleti

[PATCH libinput 2/3] Add a delta_coords type and use it were applicable

tp_normalize_coords is one of the last functions taking separate x, y values rather a coordinate pair, this commit cleans this up. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-edge-scroll.c | 9 ++--- src/evdev-mt-touchpad-tap.c | 6 ++ src/evdev-mt-touchpad.c

[PATCH weston 09/10] platform: remove global variables

Reviewed-by: Pekka Paalanen --- shared/platform.h | 55 +-- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/shared/platform.h b/shared/platform.h index ea5980e..be6d8e6 100644 --- a/shared/platform.h +++ b/shared/platform.h @@ -4

[PATCH weston 05/10] gl-renderer: call supports() automatically in create()

This means compositors don't need to call supports() manually and create() will just return -1 in the failure case as before. This also means we can deal with the case of eglGetProcAddress returning non-NULL but not actually being available at runtime. Reviewed-by: Pekka Paalanen --- src/composi

[PATCH weston 07/10] nested-client: include platform.h

Missed because buliding nested clients requires cairo-glesv2. Reviewed-by: Pekka Paalanen --- clients/nested-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/nested-client.c b/clients/nested-client.c index 5195831..200543c 100644 --- a/clients/nested-client.c +++ b/clients/

[PATCH weston 08/10] platform: provide platform_base fallbacks and remove ifdefs

Reviewed-by: Pekka Paalanen --- shared/platform.h | 47 +-- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/shared/platform.h b/shared/platform.h index fd06046..ea5980e 100644 --- a/shared/platform.h +++ b/shared/platform.h @@ -25,26 +25

[PATCH weston 10/10] platform: rename create_egl_window to create_egl_surface

Reviewed-by: Pekka Paalanen --- clients/nested-client.c | 4 ++-- clients/simple-egl.c | 6 +++--- clients/subsurfaces.c | 6 +++--- clients/window.c | 6 +++--- shared/platform.h | 12 ++-- tests/buffer-count-test.c | 6 +++--- 6 files changed, 20 inserti

[PATCH weston 03/10] gl-renderer: move all EGL_PLATFORM_* defines here

Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 4 src/compositor-wayland.c | 4 src/compositor-x11.c | 4 src/gl-renderer.h| 12 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c inde

[PATCH weston 02/10] gl-renderer: fix build with --disable-egl

Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 3 ++- src/gl-renderer.h| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index c0d0c84..8471a35 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1626,7 +1626,

[PATCH weston 04/10] compositor-{drm, wayland, x11}: remove useless tests for ->supports

Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 3 +-- src/compositor-wayland.c | 3 +-- src/compositor-x11.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 158929f..9e42a8b 100644 --- a/src/compositor-drm.c

[PATCH weston 00/10] platform_base cleanups and review reply

In reply to Pekka's late review, I've written some more patches to address his comments: Jonny Lamb (10): compositor-{drm,x11,wayland}: stop including EGL headers here gl-renderer: fix build with --disable-egl gl-renderer: move all EGL_PLATFORM_* defines here compositor-{drm,wayland,x11}:

[PATCH weston 06/10] gl-renderer: provide platform_base fallbacks and remove ifdefs

Reviewed-by: Pekka Paalanen --- src/gl-renderer.c | 16 +++- src/gl-renderer.h | 6 ++ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 2c36a8d..b3b2364 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -37,7 +37,

[PATCH weston 01/10] compositor-{drm, x11, wayland}: stop including EGL headers here

Reviewed-by: Pekka Paalanen --- src/compositor-drm.c | 2 -- src/compositor-wayland.c | 2 -- src/compositor-x11.c | 2 -- src/gl-renderer.h| 1 + 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 450920e..c0d0c84 10064

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

On Mon, 23 Mar 2015 10:13:41 +0100 Jonny Lamb wrote: > Il 23/03/2015 09:12, Pekka Paalanen ha scritto: > > IMO no space, please. Without a space it looks more like the actual > > operator precedence in C... doesn't it? I hope I remember the > > precedence rules right here. > > fwiw with a space

Re: [RFC wayland 1/2] server: implement intact resources

Le 19/03/2015 09:11, Marek Chalupa a écrit : > When server looses some capability (like pointer or keyboard), > it takes some time to get this information to clients. > When client sends request with new_id argument to the object > that has been just destroyed on server-side (client > does not know