[PATCH weston] compositor-x11: Fix pointer warping with multiple outputs

2015-03-20 Thread Ondřej Majerech
When using the X11 backend with multiple outputs, moving the mouse from one output to another would cause it to warp back to the edge of the first output. This was caused by the backend reporting motion events relative to each respective output, without taking the output's offset into account. Si

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Daniel Stone
On Friday, March 20, 2015, Bill Spitzak wrote: > > The void* cast has to read "xid ? (void*)&xid : (void*)0" to handle the > NULL correctly that other calls use. Well, and the minor matter that it breaks all other platforms. Again, see the patch - the Wayland backend passes in a struct wl_surfac

[PATCH weston] input: Don't recreate the cursor sprite when only the hotspot changes

2015-03-20 Thread Derek Foreman
Currently we unmap and re-map the cursor when the hotspot changes which causes spurious enter/leave events. This changes the pointer_set_cursor() logic to avoid this. Signed-off-by: Derek Foreman --- src/input.c | 45 + 1 file changed, 29 insertions(+

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Bill Spitzak
static int gl_renderer_output_create(struct weston_output *output, Window xid, const EGLint *attribs, const EGLint *visual_id) { ... if (gr->create_platform_window) { go->egl_surface

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Bill Spitzak
On 03/20/2015 06:33 AM, Daniel Stone wrote: On Thursday, March 19, 2015, Bill Spitzak mailto:spit...@gmail.com>> wrote: On 03/19/2015 07:07 AM, Jonny Lamb wrote: - if (gl_renderer->output_create(&__output->base, output->surface, + if (gl_renderer->outpu

Re: [PATCH weston] man: update weston's shells

2015-03-20 Thread Bryce Harrington
On Fri, Mar 20, 2015 at 07:23:31AM -0700, Jason Ekstrand wrote: > LGTM Reviewed-by: Bryce Harrington Thanks, applied: 4bdcb57..41d2ccc master -> master > On Mar 20, 2015 6:59 AM, "Pekka Paalanen" wrote: > > > From: Pekka Paalanen > > > > Tablet shell is long gone. Might as well list what

Re: [PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-20 Thread Bryce Harrington
On Fri, Mar 20, 2015 at 03:26:53PM +0100, Jonny Lamb wrote: > Reviewed-by: Derek Foreman > Reviewed-by: Bryce Harrington Thanks, applied: 111c6f9..4bdcb57 master -> master > --- > clients/nested-client.c | 7 +++ > clients/simple-egl.c | 7 --- > clients/subsurfaces.c

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- clients/nested-client.c | 7 +++ clients/simple-egl.c | 7 --- clients/subsurfaces.c | 6 +++--- clients/window.c | 8 shared/platform.h | 23 +++ tests/buffer-count-

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- src/compositor-drm.c | 13 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 20 +-- src/compositor-x11.c | 11 +- src/gl-renderer.c| 90 ++-- s

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 39 ++- src/gl-renderer.h

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-03-20 Thread Jonny Lamb
Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington --- Makefile.am | 4 ++- clients/nested-client.c | 4 ++- clients/simple-egl.c | 6 +++- clients/subsurfaces.c | 5 ++- clients/window.c | 5 ++- clients/window.h | 1 + shared/platform.h

Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Pekka Paalanen
On Fri, 20 Mar 2015 15:13:43 +0100 Thilo Cestonaro wrote: > Am 20.03.2015 12:54, schrieb Thilo Cestonaro: > > Am 20.03.2015 11:32, schrieb Thilo Cestonaro: > >> Further debuggin. > >> > >> I added some debug output to weston-launch. > >> When the parent part (of the forks) recieves the SIGCHILD

Re: [PATCH weston] man: update weston's shells

2015-03-20 Thread Jason Ekstrand
LGTM On Mar 20, 2015 6:59 AM, "Pekka Paalanen" wrote: > From: Pekka Paalanen > > Tablet shell is long gone. Might as well list what we have now. > > Signed-off-by: Pekka Paalanen > --- > man/weston.man | 27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > > di

Re: Fwd: Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Thilo Cestonaro
Am 20.03.2015 12:54, schrieb Thilo Cestonaro: Am 20.03.2015 11:32, schrieb Thilo Cestonaro: Further debuggin. I added some debug output to weston-launch. When the parent part (of the forks) recieves the SIGCHILD it calls the quit function. And in there I added the debug output and the ioctl to

[PATCH weston] man: update weston's shells

2015-03-20 Thread Pekka Paalanen
From: Pekka Paalanen Tablet shell is long gone. Might as well list what we have now. Signed-off-by: Pekka Paalanen --- man/weston.man | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/man/weston.man b/man/weston.man index 735235f..d8d924e 100644

Re: [PATCH weston] compositor: fix return code from main()

2015-03-20 Thread Pekka Paalanen
On Fri, 20 Mar 2015 14:27:18 +0100 Emilio Pozuelo Monfort wrote: > On 20/03/15 13:40, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > There were a few cases of 'goto out' in main() that did not set ret to > > EXIT_FAILURE. Shell failing to init is the one I hit when writing tests > > for

Re: [PATCH weston] compositor-drm: Allow ARGB8888 as a GBM format

2015-03-20 Thread Giulio Camuffo
2015-03-20 15:41 GMT+02:00 Daniel Stone : > Hi, > > On Thursday, March 19, 2015, Derek Foreman wrote: >> >> As of mesa commit 65c8965d on some systems all formats that used to >> be called XRGB are now ARGB and we can't launch weston. > > > Which platforms? Seems pretty odd, to say the lea

Re: [PATCH weston] compositor-drm: Allow ARGB8888 as a GBM format

2015-03-20 Thread Daniel Stone
Hi, On Thursday, March 19, 2015, Derek Foreman wrote: > As of mesa commit 65c8965d on some systems all formats that used to > be called XRGB are now ARGB and we can't launch weston. > Which platforms? Seems pretty odd, to say the least. We could handle this internally by accepting ARGB

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-20 Thread Daniel Stone
On Thursday, March 19, 2015, Bill Spitzak wrote: > On 03/19/2015 07:07 AM, Jonny Lamb wrote: > >> - if (gl_renderer->output_create(&output->base, output->surface, >> + if (gl_renderer->output_create(&output->base, >> + output->surface, output->surf

Re: [PATCH weston] compositor: fix return code from main()

2015-03-20 Thread Emilio Pozuelo Monfort
On 20/03/15 13:40, Pekka Paalanen wrote: From: Pekka Paalanen There were a few cases of 'goto out' in main() that did not set ret to EXIT_FAILURE. Shell failing to init is the one I hit when writing tests for ivi-shell. Rather than adding a few more 'ret = EXIT_FAILURE', make that the default

[PATCH weston] compositor: fix return code from main()

2015-03-20 Thread Pekka Paalanen
From: Pekka Paalanen There were a few cases of 'goto out' in main() that did not set ret to EXIT_FAILURE. Shell failing to init is the one I hit when writing tests for ivi-shell. Rather than adding a few more 'ret = EXIT_FAILURE', make that the default and remove the redundant assignments. When

Re: Fwd: Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Thilo Cestonaro
Am 20.03.2015 11:32, schrieb Thilo Cestonaro: Further debuggin. I added some debug output to weston-launch. When the parent part (of the forks) recieves the SIGCHILD it calls the quit function. And in there I added the debug output and the ioctl to set the text mode, never returns. So it hangs

Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Pekka Paalanen
On Fri, 20 Mar 2015 09:47:54 +0100 Thilo Cestonaro wrote: > > >> Further debugging. > >> > >> I managed to start weston-launch from tty1 without --tty, --user and > >> openvt as a normal user. > >> > >> While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. > >> When I stop west

Re: [PATCH weston] compositor-drm: Allow ARGB8888 as a GBM format

2015-03-20 Thread Pekka Paalanen
On Thu, 19 Mar 2015 15:16:14 -0500 Derek Foreman wrote: > As of mesa commit 65c8965d on some systems all formats that used to > be called XRGB are now ARGB and we can't launch weston. > > This allows setting ARGB as a format in weston.ini (but does not > change the default) > > Sign

Re: Fwd: Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Thilo Cestonaro
Further debuggin. I added some debug output to weston-launch. When the parent part (of the forks) recieves the SIGCHILD it calls the quit function. And in there I added the debug output and the ioctl to set the text mode, never returns. So it hangs in the kernel, right? cheers Thilo Am 20.0

Re: [PATCH weston] compositor: warn about insane repaint delay

2015-03-20 Thread Pekka Paalanen
On Thu, 19 Mar 2015 11:16:33 -0700 Bryce Harrington wrote: > On Thu, Mar 19, 2015 at 08:13:42AM -0500, Derek Foreman wrote: > > Reviewed-By: Derek Foreman > > > > On 19/03/15 05:33 AM, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > Make the sanity check more explicit and log a w

Re: [PATCH weston v2 1/2] compositor, backends: weston_compositor_read_presentation_clock

2015-03-20 Thread Pekka Paalanen
On Thu, 19 Mar 2015 11:29:52 -0700 Bryce Harrington wrote: > On Thu, Mar 19, 2015 at 11:55:06AM +0200, Pekka Paalanen wrote: > > On Wed, 18 Mar 2015 10:58:37 -0700 > > Bryce Harrington wrote: > > > > > On Wed, Mar 18, 2015 at 03:27:21PM +0200, Pekka Paalanen wrote: > > > > From: Pekka Paalanen

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-20 Thread Pekka Paalanen
On Fri, 20 Mar 2015 18:09:07 +0800 Jonas Ådahl wrote: > On Fri, Mar 20, 2015 at 11:53:24AM +0200, Pekka Paalanen wrote: > > Btw. how can you ever get enter or leave on a *cursor* surface? > > Is that another Weston bug? > > Why wouldn't you want enter or leave on a cursor surface? They need to

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-20 Thread Jonas Ådahl
On Fri, Mar 20, 2015 at 11:53:24AM +0200, Pekka Paalanen wrote: > On Fri, 20 Mar 2015 17:03:14 +0800 > Jonas Ådahl wrote: > > > On Fri, Mar 20, 2015 at 10:53:42AM +0200, Pekka Paalanen wrote: > > > On Thu, 19 Mar 2015 23:45:00 -0400 > > > Lyude wrote: > > > > > > > On Fri, 2015-03-20 at 11:37 +

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-20 Thread Pekka Paalanen
On Fri, 20 Mar 2015 17:03:14 +0800 Jonas Ådahl wrote: > On Fri, Mar 20, 2015 at 10:53:42AM +0200, Pekka Paalanen wrote: > > On Thu, 19 Mar 2015 23:45:00 -0400 > > Lyude wrote: > > > > > On Fri, 2015-03-20 at 11:37 +0800, Jonas Ådahl wrote: > > > > > > > > Try to apply this patch http://patchwo

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-20 Thread Jonas Ådahl
On Fri, Mar 20, 2015 at 10:53:42AM +0200, Pekka Paalanen wrote: > On Thu, 19 Mar 2015 23:45:00 -0400 > Lyude wrote: > > > On Fri, 2015-03-20 at 11:37 +0800, Jonas Ådahl wrote: > > > > > > Try to apply this patch http://patchwork.freedesktop.org/patch/44994/ . > > > > > > > > > Jonas > > > > I

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-20 Thread Hans de Goede
Hi, On 20-03-15 01:38, Peter Hutterer wrote: On Fri, Mar 20, 2015 at 10:19:06AM +1000, Peter Hutterer wrote: [...] 5) If a device has multiple axes of the same type, is the order supposed to be ABI? Example: gamepads tend to have two analog-sticks. How do applications reliably find the left and

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-20 Thread Pekka Paalanen
On Thu, 19 Mar 2015 23:45:00 -0400 Lyude wrote: > On Fri, 2015-03-20 at 11:37 +0800, Jonas Ådahl wrote: > > > > Try to apply this patch http://patchwork.freedesktop.org/patch/44994/ . > > > > > > Jonas > > I just tried the patch and it fixed the issue. Thanks a ton for the > quick reply to my

Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Thilo Cestonaro
Further debugging. I managed to start weston-launch from tty1 without --tty, --user and openvt as a normal user. While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. When I stop weston (Ctrl+Alt+Backspace), the display gets black and switching the consoles isn't possible anymo

Re: [PATCH wayland] scanner: Fail on empty enumerations

2015-03-20 Thread Hardening
Le 19/03/2015 09:58, Jonas Ådahl a écrit : > Without this patch, the scanner would generate invalid C which wouldn't > compile anyway, so lets be nice and fail earlier and point out where the > error is. > > Signed-off-by: Jonas Ådahl +1 Reviewed-By: David FORT > --- > src/scanner.c | 4

Re: Fwd: Re: After exiting weston all consoles not working anymore

2015-03-20 Thread Thilo Cestonaro
Am 19.03.2015 17:24, schrieb Derek Foreman: On 19/03/15 09:58 AM, Thilo Cestonaro wrote: Further debugging. I managed to start weston-launch from tty1 without --tty, --user and openvt as a normal user. While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. When I stop weston (Ct