Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Beomho Seo
On 03/20/2015 06:15 AM, Peter Hutterer wrote: > On Thu, Mar 19, 2015 at 09:44:39PM +0900, Beomho Seo wrote: >> On 03/19/2015 07:25 PM, Peter Hutterer wrote: >>> On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: On 03/12/2015 06:28 AM, Peter Hutterer wrote: > On Wed, Mar 11, 2015

Re: [PATCH weston v2] input: Make setting the same pointer cursor state again a no-op

2015-03-19 Thread Jonas Ådahl
On Thu, Mar 19, 2015 at 08:31:04PM -0500, Derek Foreman wrote: > On 19/03/15 08:06 PM, Jonas Ådahl wrote: > > On Thu, Mar 19, 2015 at 12:37:02PM -0500, Derek Foreman wrote: > >> On 18/03/15 09:23 PM, Jonas Ådahl wrote: > >>> If the client calls wl_pointer.set_cursor with the same surface and hot >

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-19 Thread Lyude
On Fri, 2015-03-20 at 11:37 +0800, Jonas Ådahl wrote: > > Try to apply this patch http://patchwork.freedesktop.org/patch/44994/ . > > > Jonas I just tried the patch and it fixed the issue. Thanks a ton for the quick reply to my e-mail and the patch :). Now I can finally get back to work. Cheer

Re: gtk3-demo dies with EAGAIN when running under Weston

2015-03-19 Thread Jonas Ådahl
On Thu, Mar 19, 2015 at 11:10:31PM -0400, Lyude wrote: > Hi! So, I'm stuck on an issue here that's unfortunately making it > impossible for me to test any of the changes I make to GTK+ under > Wayland. For whatever reason, all of a sudden gtk3-demo is crashing > under Weston whenever a pointer move

gtk3-demo dies with EAGAIN when running under Weston

2015-03-19 Thread Lyude
Hi! So, I'm stuck on an issue here that's unfortunately making it impossible for me to test any of the changes I make to GTK+ under Wayland. For whatever reason, all of a sudden gtk3-demo is crashing under Weston whenever a pointer moves over any of it's wl_surfaces. The error message that GDK retu

Re: [PATCH weston v2] input: Make setting the same pointer cursor state again a no-op

2015-03-19 Thread Derek Foreman
On 19/03/15 08:06 PM, Jonas Ådahl wrote: > On Thu, Mar 19, 2015 at 12:37:02PM -0500, Derek Foreman wrote: >> On 18/03/15 09:23 PM, Jonas Ådahl wrote: >>> If the client calls wl_pointer.set_cursor with the same surface and hot >>> spot coordinate that is already set, don't do anything as no state wa

libinput - force-push to master

2015-03-19 Thread Peter Hutterer
I had a release script test gone bad and it pushed a fake 0.13.0 release. The commit was only sitting on master for a couple of minutes, I've force-pushed the previous HEAD (1ed07fedce45d817f70f56439aba6e13be7a) Just in case you see something odd, sorry about that. The false commit was 274251b693

Re: [PATCH weston v2] input: Make setting the same pointer cursor state again a no-op

2015-03-19 Thread Jonas Ådahl
On Thu, Mar 19, 2015 at 12:37:02PM -0500, Derek Foreman wrote: > On 18/03/15 09:23 PM, Jonas Ådahl wrote: > > If the client calls wl_pointer.set_cursor with the same surface and hot > > spot coordinate that is already set, don't do anything as no state was > > changed. > > > > This avoids an issue

Re: [RFC v2 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 02:01:29PM -0700, Jason Gerecke wrote: > David's already asked the API questions that popped in my head, so I'll just > wait for feedback on his thread. As far as this patch goes, things look > pretty good though there are two comments: > > On 3/17/2015 11:58 PM, Peter Hutt

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-19 Thread Peter Hutterer
On Fri, Mar 20, 2015 at 10:19:06AM +1000, Peter Hutterer wrote: [...] > > 5) If a device has multiple axes of the same type, is the order > > supposed to be ABI? Example: gamepads tend to have two analog-sticks. > > How do applications reliably find the left and right stick? > > well, our promise

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 01:15:01PM +0100, David Herrmann wrote: > Hi > > On Wed, Mar 18, 2015 at 7:58 AM, Peter Hutterer > wrote: > > > > This is a re-vamped version of the buttonset interface. Still WIP but I'd > > like to get some comments on the API. > > > > Changes to the last version: > > Th

Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 09:44:39PM +0900, Beomho Seo wrote: > On 03/19/2015 07:25 PM, Peter Hutterer wrote: > > On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: > >> On 03/12/2015 06:28 AM, Peter Hutterer wrote: > >>> On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: > Hi

Re: [RFC v2 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

2015-03-19 Thread Jason Gerecke
David's already asked the API questions that popped in my head, so I'll just wait for feedback on his thread. As far as this patch goes, things look pretty good though there are two comments: On 3/17/2015 11:58 PM, Peter Hutterer wrote: From: Benjamin Tissoires Same approach as evdev-tablet

[PATCH weston] compositor-drm: Allow ARGB8888 as a GBM format

2015-03-19 Thread Derek Foreman
As of mesa commit 65c8965d on some systems all formats that used to be called XRGB are now ARGB and we can't launch weston. This allows setting ARGB as a format in weston.ini (but does not change the default) Signed-off-by: Derek Foreman --- man/weston.ini.man | 1 + src/composito

Re: [PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Bryce Harrington
On Thu, Mar 19, 2015 at 03:07:14PM +0100, Jonny Lamb wrote: > Reviewed-by: Derek Foreman > --- > clients/nested-client.c | 7 +++ > clients/simple-egl.c | 7 --- > clients/subsurfaces.c | 6 +++--- > clients/window.c | 8 > shared/platform.h | 23 +

Re: [PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Bryce Harrington
On Thu, Mar 19, 2015 at 02:34:06PM +0100, Jonny Lamb wrote: > Il 16/03/2015 21:44, Bryce Harrington ha scritto: > >Since this pattern of code is repeating several places, perhaps having > >it in a helper function or macro might be more maintainable longer term? > > OK I've done that in my next pat

Re: [RFC wayland 1/2] server: implement intact resources

2015-03-19 Thread Bill Spitzak
I think the name "intact" is really confusing. Can it be instead called "destroyed"? On 03/19/2015 01:11 AM, Marek Chalupa wrote: When server looses some capability (like pointer or keyboard), it takes some time to get this information to clients. When client sends request with new_id argument

Re: [PATCH wayland] server: give more precise error message

2015-03-19 Thread Bill Spitzak
On 03/19/2015 12:42 AM, Marek Chalupa wrote: message = &object->interface->methods[opcode]; + since = wl_message_get_since(message); if (!(resource_flags & WL_MAP_ENTRY_LEGACY) && - resource->version > 0 && - res

Re: [PATCH weston v2 1/2] compositor, backends: weston_compositor_read_presentation_clock

2015-03-19 Thread Bryce Harrington
On Thu, Mar 19, 2015 at 11:55:06AM +0200, Pekka Paalanen wrote: > On Wed, 18 Mar 2015 10:58:37 -0700 > Bryce Harrington wrote: > > > On Wed, Mar 18, 2015 at 03:27:21PM +0200, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > If 0 time is returned, are we certain that's not going to scr

Re: [PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-19 Thread Bill Spitzak
On 03/19/2015 07:07 AM, Jonny Lamb wrote: - if (gl_renderer->output_create(&output->base, output->surface, + if (gl_renderer->output_create(&output->base, + output->surface, output->surface, gl_renderer->opaq

Re: [PATCH weston] compositor: warn about insane repaint delay

2015-03-19 Thread Bryce Harrington
On Thu, Mar 19, 2015 at 08:13:42AM -0500, Derek Foreman wrote: > Reviewed-By: Derek Foreman > > On 19/03/15 05:33 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Make the sanity check more explicit and log a warning if it happens. > > > > Small negative values are ok because it just

Re: [PATCH weston v2] input: Make setting the same pointer cursor state again a no-op

2015-03-19 Thread Derek Foreman
On 18/03/15 09:23 PM, Jonas Ådahl wrote: > If the client calls wl_pointer.set_cursor with the same surface and hot > spot coordinate that is already set, don't do anything as no state was > changed. > > This avoids an issue where a client setting the same cursor surface > multiple times would rece

Re: [PATCH wayland] scanner: Fail on empty enumerations

2015-03-19 Thread Derek Foreman
This looks good to me. Reviewed-By: Derek Foreman On 19/03/15 03:58 AM, Jonas Ådahl wrote: > Without this patch, the scanner would generate invalid C which wouldn't > compile anyway, so lets be nice and fail earlier and point out where the > error is. > > Signed-off-by: Jonas Ådahl > --- > sr

Re: Fwd: Re: After exiting weston all consoles not working anymore

2015-03-19 Thread Derek Foreman
On 19/03/15 09:58 AM, Thilo Cestonaro wrote: > Further debugging. > > I managed to start weston-launch from tty1 without --tty, --user and > openvt as a normal user. > > While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. > When I stop weston (Ctrl+Alt+Backspace), the display ge

Re: After exiting weston all consoles not working anymore

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 15:58:59 +0100 Thilo Cestonaro wrote: > Further debugging. > > I managed to start weston-launch from tty1 without --tty, --user and > openvt as a normal user. > > While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. > When I stop weston (Ctrl+Alt+Backspace)

Re: [PATCH] Spellcheck fixes

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 18:42:00 -0700 Bryce Harrington wrote: > ./ivi-shell/README:19: protocal ==> protocol > ./src/compositor.h:596: seperate ==> separate > ./src/version.h.in:33: actualy ==> actually > ./src/cms-helper.h:44: embeded ==> embedded > ./protocol/fullscreen-shell.xml:65: seperate

Re: [WESTON patch 1/2] weston-test: add device_{release/add} into protocol

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 03:38:51 -0400 Marek Chalupa wrote: > This request simulates device creation/destruction from evdev (libinput) > > Signed-off-by: Marek Chalupa > --- > protocol/weston-test.xml | 6 ++ > tests/weston-test.c | 37 + > 2 files cha

Re: [PATCH] Spelling fixes (cosmetic)

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 19:42:21 -0700 Bill Spitzak wrote: > Looks good to me. Those are my spelling errors btw, > > On 03/18/2015 06:32 PM, Bryce Harrington wrote: > > A few typos in comments and protocol docs, no code changes. > > > > ./src/wayland-util.h:281: recieved ==> received > > ./src/wayl

Fwd: Re: After exiting weston all consoles not working anymore

2015-03-19 Thread Thilo Cestonaro
Further debugging. I managed to start weston-launch from tty1 without --tty, --user and openvt as a normal user. While weston is running I can switch between tty1-6 with Ctrl+Alt+FX. When I stop weston (Ctrl+Alt+Backspace), the display gets black and switching the consoles isn't possible anym

Re: [PATCH weston] tests: use two roundtrips for global events

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 03:35:40 -0400 Marek Chalupa wrote: > first is for getting and binding to globals and the other one is for > getting wl_shm.formats that are emitted after binding > to wl_shm > > Signed-off-by: Marek Chalupa > --- > tests/weston-test-client-helper.c | 6 -- > 1 file cha

Re: [WESTON patch 2/2] tests: add tests for devices handling

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 03:38:52 -0400 Marek Chalupa wrote: > Test misc races when adding/releasing devices. One of the > tests reveals a race that is not currently handled by Weston. > > Signed-off-by: Marek Chalupa > --- > Makefile.am | 7 ++- > tests/devices-test.c | 160 > +

Re: [PATCH wayland] server: give more precise error message

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 10:54:05 + Daniel Stone wrote: > Hi Marek, > > On Thursday, March 19, 2015, Marek Chalupa wrote: > > > There are two same error messages with different cause. > > Let user know what is the cause of the error. > > > > For this, the double-client-roundtrip patch, and the

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- src/compositor-drm.c | 13 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 20 +-- src/compositor-x11.c | 11 +- src/gl-renderer.c| 90 ++-- src/gl-renderer.h| 6 ++

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- clients/nested-client.c | 7 +++ clients/simple-egl.c | 7 --- clients/subsurfaces.c | 6 +++--- clients/window.c | 8 shared/platform.h | 23 +++ tests/buffer-count-test.c | 7 +++ 6 files ch

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 39 ++- src/gl-renderer.h| 3 ++- 6 files changed, 45 i

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

2015-03-19 Thread Jonny Lamb
Reviewed-by: Derek Foreman --- Makefile.am | 4 ++- clients/nested-client.c | 4 ++- clients/simple-egl.c | 6 +++- clients/subsurfaces.c | 5 ++- clients/window.c | 5 ++- clients/window.h | 1 + shared/platform.h | 79

Re: [PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

2015-03-19 Thread Jonny Lamb
Il 16/03/2015 21:44, Bryce Harrington ha scritto: Since this pattern of code is repeating several places, perhaps having it in a helper function or macro might be more maintainable longer term? OK I've done that in my next patch set revision but only in clients & tests. I decided not to use th

Re: [PATCH weston] compositor: warn about insane repaint delay

2015-03-19 Thread Derek Foreman
Reviewed-By: Derek Foreman On 19/03/15 05:33 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Make the sanity check more explicit and log a warning if it happens. > > Small negative values are ok because it just means the compositor is > lagging behind, or more likely the user specified a

Re: After exiting weston all consoles not working anymore

2015-03-19 Thread Thilo Cestonaro
> Is anything actually switching to vt7? I'm not sure what weston-launch > does there, usually it takes the current VT and you don't seem to be > telling openvt to switch. Nothing is switching to tty7 as I'm connected via UART so different output. Anyway weston starts properly on tty7 and is dis

Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Beomho Seo
On 03/19/2015 07:25 PM, Peter Hutterer wrote: > On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: >> On 03/12/2015 06:28 AM, Peter Hutterer wrote: >>> On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: Hi everyone, I have a question about libinput. I will

Re: [PATCH libinput 1/4] filter: switch to normalized_coords

2015-03-19 Thread Hans de Goede
Hi, On 19-03-15 04:11, Peter Hutterer wrote: Signed-off-by: Peter Hutterer The entire set looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-touchpad.c | 26 +++-- src/evdev.c | 7 +-- src/filter-private.h| 7

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-19 Thread David Herrmann
Hi On Wed, Mar 18, 2015 at 7:58 AM, Peter Hutterer wrote: > > This is a re-vamped version of the buttonset interface. Still WIP but I'd > like to get some comments on the API. > > Changes to the last version: > This version now uses numbered axes instead of typed axes. Previously the > interface

Re: [PATCH wayland] server: give more precise error message

2015-03-19 Thread Daniel Stone
Hi Marek, On Thursday, March 19, 2015, Marek Chalupa wrote: > There are two same error messages with different cause. > Let user know what is the cause of the error. > For this, the double-client-roundtrip patch, and the test-device-hotplug patches: Reviewed-by: Daniel Stone Cheers, Daniel __

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 11:42:24 +0100 Thilo Cestonaro wrote: > > > > I haven't looked at the Weston code, but Thilo says it's broken. Thilo, > > could you file a bug with all this information against Weston? If there > > isn't one open already, that is. > > > > Ok like this? https://bugs.freedesk

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-19 Thread Thilo Cestonaro
I haven't looked at the Weston code, but Thilo says it's broken. Thilo, could you file a bug with all this information against Weston? If there isn't one open already, that is. Ok like this? https://bugs.freedesktop.org/show_bug.cgi?id=89674 Cheers, Thilo

[PATCH weston] compositor: warn about insane repaint delay

2015-03-19 Thread Pekka Paalanen
From: Pekka Paalanen Make the sanity check more explicit and log a warning if it happens. Small negative values are ok because it just means the compositor is lagging behind, or more likely the user specified a too long repaint window. Signed-off-by: Pekka Paalanen --- src/compositor.c | 14 +

Re: [Wayland, libinput] Question about libinput

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 02:29:05PM +0900, Beomho Seo wrote: > On 03/12/2015 06:28 AM, Peter Hutterer wrote: > > On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: > >> Hi everyone, > >> > >> I have a question about libinput. > >> > >> I will handle a rotary input device. It is able to prov

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 15:53:33 -0500 Derek Foreman wrote: > On 18/03/15 08:27 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > This timer delays the output_repaint towards the end of the refresh > > period, reducing the time from repaint to present. > > > > The length of the repaint wi

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 14:44:52 -0700 Bill Spitzak wrote: > Would it be possible to compute this repaint window as how long it took > to paint the previous frame, plus some small user-adjustable constant? > Or a more complex weighted average of recent frames? > > I'm not sure if perhaps the neces

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-19 Thread Peter Hutterer
On Thu, Mar 19, 2015 at 11:45:16AM +0200, Pekka Paalanen wrote: > On Thu, 19 Mar 2015 07:13:18 +1000 > Peter Hutterer wrote: > > > On Wed, Mar 18, 2015 at 01:14:52PM +0200, Pekka Paalanen wrote: > > > On Wed, 18 Mar 2015 11:45:01 +0100 > > > Thilo Cestonaro wrote: > > > > > > > Hey! > > > > >

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 14:45:34 -0700 Bryce Harrington wrote: > On Wed, Mar 18, 2015 at 03:27:22PM +0200, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > This timer delays the output_repaint towards the end of the refresh > > period, reducing the time from repaint to present. > > > > The l

Re: [PATCH weston v2 1/2] compositor, backends: weston_compositor_read_presentation_clock

2015-03-19 Thread Pekka Paalanen
On Wed, 18 Mar 2015 10:58:37 -0700 Bryce Harrington wrote: > On Wed, Mar 18, 2015 at 03:27:21PM +0200, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Create a new function weston_compositor_read_presentation_clock() to > > wrap the clock_gettime() call for the Presentation clock. > > >

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-19 Thread Pekka Paalanen
On Thu, 19 Mar 2015 07:13:18 +1000 Peter Hutterer wrote: > On Wed, Mar 18, 2015 at 01:14:52PM +0200, Pekka Paalanen wrote: > > On Wed, 18 Mar 2015 11:45:01 +0100 > > Thilo Cestonaro wrote: > > > > > Hey! > > > > > > > > > > Is it broken only on fbdev or DRM also? > > > > > > DRM is the same

[PATCH wayland] scanner: Fail on empty enumerations

2015-03-19 Thread Jonas Ådahl
Without this patch, the scanner would generate invalid C which wouldn't compile anyway, so lets be nice and fail earlier and point out where the error is. Signed-off-by: Jonas Ådahl --- src/scanner.c | 4 1 file changed, 4 insertions(+) diff --git a/src/scanner.c b/src/scanner.c index 1f1e

[RFC wayland 1/2] server: implement intact resources

2015-03-19 Thread Marek Chalupa
When server looses some capability (like pointer or keyboard), it takes some time to get this information to clients. When client sends request with new_id argument to the object that has been just destroyed on server-side (client does not know about it yet), we still have to create the resource. I

[RFC wayland 2/2] tests: add test for intact objects

2015-03-19 Thread Marek Chalupa
Test if the requests of intact objects are ignored, except for destructors. Signed-off-by: Marek Chalupa --- tests/resources-test.c | 123 + 1 file changed, 123 insertions(+) diff --git a/tests/resources-test.c b/tests/resources-test.c index a6ce3

[PATCH wayland] server: give more precise error message

2015-03-19 Thread Marek Chalupa
There are two same error messages with different cause. Let user know what is the cause of the error. Signed-off-by: Marek Chalupa --- src/wayland-server.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index ac4db65..7

[WESTON patch 1/2] weston-test: add device_{release/add} into protocol

2015-03-19 Thread Marek Chalupa
This request simulates device creation/destruction from evdev (libinput) Signed-off-by: Marek Chalupa --- protocol/weston-test.xml | 6 ++ tests/weston-test.c | 37 + 2 files changed, 43 insertions(+) diff --git a/protocol/weston-test.xml b/protocol

[WESTON patch 2/2] tests: add tests for devices handling

2015-03-19 Thread Marek Chalupa
Test misc races when adding/releasing devices. One of the tests reveals a race that is not currently handled by Weston. Signed-off-by: Marek Chalupa --- Makefile.am | 7 ++- tests/devices-test.c | 160 +++ 2 files changed, 166 insertions

[PATCH weston] tests: use two roundtrips for global events

2015-03-19 Thread Marek Chalupa
first is for getting and binding to globals and the other one is for getting wl_shm.formats that are emitted after binding to wl_shm Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/weston-test-clie

Re: [PATCH weston] data-device: Implement DnD actions

2015-03-19 Thread Marek Chalupa
Just a cosmetic: there are mixed coding styles like 'function(...)' and 'function (...)' (space between name function and the parenthesis). It should be unified, preferably to weston (wayland) coding style (no space) Cheers, Marek On Wed, Mar 18, 2015 at 8:20 PM, Bryce Harrington wrote: > On Mo