Re: [Wayland, libinput] Question about libinput

2015-03-18 Thread Beomho Seo
On 03/12/2015 06:28 AM, Peter Hutterer wrote: > On Wed, Mar 11, 2015 at 05:01:32PM +0900, Beomho Seo wrote: >> Hi everyone, >> >> I have a question about libinput. >> >> I will handle a rotary input device. It is able to provide angular >> information >> (increase, decrease), elocity and push/rela

[PATCH libinput 1/4] filter: switch to normalized_coords

2015-03-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 26 +++-- src/evdev.c | 7 +-- src/filter-private.h| 7 --- src/filter.c| 50 +++-- src/filter.h| 8 +++- 5 files chan

[PATCH libinput 4/4] test: add accel test for direction change

2015-03-18 Thread Peter Hutterer
Make sure that if we go in one direction, then change flip over to the other direction we actually stop going into that direction, and the delta is lower than whatever the previous delta was (i.e. acceleration resets). Signed-off-by: Peter Hutterer --- test/pointer.c | 43 +++

[PATCH libinput 2/4] Switch vector_get_direction to use doubles

2015-03-18 Thread Peter Hutterer
Delta movements on most slower movements are less than 1.0 per event, so we'd end up with an undefined direction for all of them. This led to the velocity being calculated across opposite movements rather than (as intended) across movements within a shared octant. Signed-off-by: Peter Hutterer --

[PATCH libinput 3/4] filter: calculate the time delta correctly

2015-03-18 Thread Peter Hutterer
If the delta is 0, the distance is the number of units (within this ms). Delta 1 means velocity across 2 ms, etc. Bonus: this doesn't return infinite speed anymore if we get more than one event per ms. This can happen on any device approaching 1000Hz poll rate, but definitely got triggered by the

[PATCH weston 3/3] launcher-logind: Remove old VT switching code, move to SwitchTo/Activate

2015-03-18 Thread Jasper St. Pierre
In the time since this code was written, logind has gained new APIs to handle VT switching automatically and activate sessions. Switch to that. --- src/launcher-logind.c | 219 +- 1 file changed, 40 insertions(+), 179 deletions(-) diff --git a/src/l

[PATCH weston 1/3] launcher: Rename logind-util to launcher-logind

2015-03-18 Thread Jasper St. Pierre
We're refactoring this to have multiple launcher "implementations". --- Makefile.am | 4 +- src/launcher-logind.c | 953 ++ src/launcher-logind.h | 120 +++ src/launcher-util.c | 2 +- src/logind-util.c | 953 -

[PATCH weston 0/3] Rework the launcher infrastructure

2015-03-18 Thread Jasper St. Pierre
Since the time that the logind launcher integration was written, it has since gained a lot of features that mean that we don't have to touch the TTY or VT ioctls ourselves. Refactor the launcher system so that we have three different implementations of the launcher system, tried in this order:

[PATCH weston 2/3] launcher: Split out launcher implementations into three distinct ones

2015-03-18 Thread Jasper St. Pierre
We now have a launcher interface and distinct implementations for logind, weston-launch, and direct DRM, each in their own files. This helps up clean up the spaghetti code into something that's hopefully a bit more understood. There should be no functional changes here. --- Makefile.am

Re: [PATCH] Spelling fixes (cosmetic)

2015-03-18 Thread Bill Spitzak
Looks good to me. Those are my spelling errors btw, On 03/18/2015 06:32 PM, Bryce Harrington wrote: A few typos in comments and protocol docs, no code changes. ./src/wayland-util.h:281: recieved ==> received ./src/wayland-client.c:115: occured ==> occurred ./src/wayland-client.c:156: occured

Re: [PATCH] protocol: Add DnD actions

2015-03-18 Thread Bill Spitzak
This is still bothering me as being much too complicated. I think a list of actions can be sent from the DnD source to the target, and the target selects one. There is no need for the compositor to do any intersection of the sets and there is no need to communicate the set of target actions to

[PATCH weston v2] input: Make setting the same pointer cursor state again a no-op

2015-03-18 Thread Jonas Ådahl
If the client calls wl_pointer.set_cursor with the same surface and hot spot coordinate that is already set, don't do anything as no state was changed. This avoids an issue where a client setting the same cursor surface multiple times would receive wl_surface.leave/enter on that surface every time

[PATCH] Spellcheck fixes

2015-03-18 Thread Bryce Harrington
./ivi-shell/README:19: protocal ==> protocol ./src/compositor.h:596: seperate ==> separate ./src/version.h.in:33: actualy ==> actually ./src/cms-helper.h:44: embeded ==> embedded ./protocol/fullscreen-shell.xml:65: seperate ==> separate ./protocol/xdg-shell.xml:150: auxilliary ==> auxiliary .

[PATCH] Spelling fixes (cosmetic)

2015-03-18 Thread Bryce Harrington
A few typos in comments and protocol docs, no code changes. ./src/wayland-util.h:281: recieved ==> received ./src/wayland-client.c:115: occured ==> occurred ./src/wayland-client.c:156: occured ==> occurred ./tests/test-compositor.c:76: parallely ==> parallelly ./tests/test-compositor.c:474: re

Re: [PATCH weston] data-device: Implement DnD actions

2015-03-18 Thread Bryce Harrington
On Mon, Feb 16, 2015 at 04:37:35PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the notify_actions requests on both wl_data_so

Re: [PATCH] protocol: Add DnD actions

2015-03-18 Thread Bryce Harrington
On Mon, Feb 16, 2015 at 04:37:34PM +0100, Carlos Garnacho wrote: > These 2 requests have been added: > > - wl_data_source.notify_actions request: Notifies the compositor of the > available actions on the data source. > - wl_data_offer.notify_actions request: Notifies the compositor of the > av

Re: [PATCH] cursor: free the array from which images are linked

2015-03-18 Thread Bryce Harrington
On Wed, Mar 18, 2015 at 12:49:06PM +0100, Emilio Pozuelo Monfort wrote: > On 18/03/15 01:53, Emmanuel Gil Peyrot wrote: > >--- > > cursor/wayland-cursor.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c > >index 1a5393a..410a0d4 10064

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-18 Thread Bryce Harrington
On Wed, Mar 18, 2015 at 03:27:22PM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > This timer delays the output_repaint towards the end of the refresh > period, reducing the time from repaint to present. > > The length of the repaint window can be set in weston.ini. > > The call to west

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-18 Thread Bill Spitzak
Would it be possible to compute this repaint window as how long it took to paint the previous frame, plus some small user-adjustable constant? Or a more complex weighted average of recent frames? I'm not sure if perhaps the necessary clock information is not available, or that this idea would

Re: [PATCH weston] input: Make setting the same pointer cursor surface again a no-op

2015-03-18 Thread Derek Foreman
On 18/03/15 02:16 AM, Jonas Ådahl wrote: > If the client calls wl_pointer.set_cursor with the same surface that is > already set, don't do anything as no state was changed. > > This avoids an issue where a client setting the same cursor surface > multiple times would receive wl_surface.leave/enter

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Peter Hutterer
On Wed, Mar 18, 2015 at 01:14:52PM +0200, Pekka Paalanen wrote: > On Wed, 18 Mar 2015 11:45:01 +0100 > Thilo Cestonaro wrote: > > > Hey! > > > > > > > Is it broken only on fbdev or DRM also? > > > > DRM is the same as Fbdev. The touch doesn't have the correct > > orientation, but I can use we

Re: [PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-18 Thread Derek Foreman
On 18/03/15 08:27 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > This timer delays the output_repaint towards the end of the refresh > period, reducing the time from repaint to present. > > The length of the repaint window can be set in weston.ini. > > The call to weston_output_schedule_r

Re: [PATCH weston v2 2/6] compositors: Wrap clock_gettime() usage

2015-03-18 Thread Derek Foreman
On 18/03/15 03:14 AM, Pekka Paalanen wrote: > On Mon, 22 Dec 2014 16:09:15 -0600 > Derek Foreman wrote: > >> In preparation for a future patch which allows test clients to control >> the presentation clock, we wrap any clock_gettime() of the presentation >> clock in weston_compositor_presentation

Re: [PATCH weston v2 1/2] compositor, backends: weston_compositor_read_presentation_clock

2015-03-18 Thread Bryce Harrington
On Wed, Mar 18, 2015 at 03:27:21PM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > Create a new function weston_compositor_read_presentation_clock() to > wrap the clock_gettime() call for the Presentation clock. > > Reading the presentation clock is never supposed to fail, but if it > do

Re: [PATCH weston] desktop-shell: don't allow negative values in drag resize

2015-03-18 Thread Bryce Harrington
On Wed, Mar 18, 2015 at 10:21:59AM -0700, Jasper St. Pierre wrote: > Yeah, this is obviously correct. > > Reviewed-by: Jasper St. Pierre Thanks, applied: 561662b..70ac0ed master -> master > On Wed, Mar 18, 2015 at 9:16 AM, Derek Foreman > wrote: > > > Now clamping width and height to a

Re: [PATCH weston] desktop-shell: don't allow negative values in drag resize

2015-03-18 Thread Jasper St. Pierre
Yeah, this is obviously correct. Reviewed-by: Jasper St. Pierre On Wed, Mar 18, 2015 at 9:16 AM, Derek Foreman wrote: > Now clamping width and height to a minimum of 1, 1 when drag resizing. > > Signed-off-by: Derek Foreman > --- > desktop-shell/shell.c | 4 > 1 file changed, 4 insertio

[PATCH weston] desktop-shell: don't allow negative values in drag resize

2015-03-18 Thread Derek Foreman
Now clamping width and height to a minimum of 1, 1 when drag resizing. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 4 1 file changed, 4 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 826692f..aca91eb 100644 --- a/desktop-shell/shell.c +++ b/desk

Re: After exiting weston all consoles not working anymore

2015-03-18 Thread Pekka Paalanen
On Wed, 18 Mar 2015 14:42:39 +0100 Thilo Cestonaro wrote: > > > Is anything actually switching to vt7? I'm not sure what weston-launch > > does there, usually it takes the current VT and you don't seem to be > > telling openvt to switch. > > Nothing is switching to tty7 as I'm connected via UAR

Re: [PATCH] client: Fix typo

2015-03-18 Thread Pekka Paalanen
On Tue, 17 Mar 2015 15:09:30 -0700 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/wayland-client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/wayland-client.c b/src/wayland-client.c > index 0f1405c..9adde38 100644 > --- a/src/wayland-cli

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Pekka Paalanen
On Wed, 18 Mar 2015 10:29:51 +0100 Thilo Cestonaro wrote: > Hey Derek! > > Wow that was fast! :) and the rotation is working now with fbdev! > Thank you! I take that as a Tested-by then. ;-) > Am 17.03.2015 19:22, schrieb Derek Foreman: > > fbdev transforms are currently broken, and can

Re: After exiting weston all consoles not working anymore

2015-03-18 Thread Thilo Cestonaro
Is anything actually switching to vt7? I'm not sure what weston-launch does there, usually it takes the current VT and you don't seem to be telling openvt to switch. Nothing is switching to tty7 as I'm connected via UART so different output. Anyway weston starts properly on tty7 and is displa

[PATCH weston v2 2/2] compositor: add repaint delay timer

2015-03-18 Thread Pekka Paalanen
From: Pekka Paalanen This timer delays the output_repaint towards the end of the refresh period, reducing the time from repaint to present. The length of the repaint window can be set in weston.ini. The call to weston_output_schedule_repaint_reset() is delayed by one more period. If we exit th

[PATCH weston v2 1/2] compositor, backends: weston_compositor_read_presentation_clock

2015-03-18 Thread Pekka Paalanen
From: Pekka Paalanen Create a new function weston_compositor_read_presentation_clock() to wrap the clock_gettime() call for the Presentation clock. Reading the presentation clock is never supposed to fail, but if it does, this will notify about it. I have not seen it fail yet, though. This prep

[PATCH weston v2 0/2] New repaint scheduling algorithm

2015-03-18 Thread Pekka Paalanen
From: Pekka Paalanen Hi, this is the v2 of http://lists.freedesktop.org/archives/wayland-devel/2015-February/019924.html Please see http://ppaalanen.blogspot.fi/2015/02/weston-repaint-scheduling.html for the details. From the v1 series, the first 3 patches landed, and the remaining two needed

Re: [PATCH] cursor: free the array from which images are linked

2015-03-18 Thread Emilio Pozuelo Monfort
On 18/03/15 01:53, Emmanuel Gil Peyrot wrote: --- cursor/wayland-cursor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index 1a5393a..410a0d4 100644 --- a/cursor/wayland-cursor.c +++ b/cursor/wayland-cursor.c @@ -190,6 +190,7 @@ wl_curso

Re: After exiting weston all consoles not working anymore

2015-03-18 Thread Pekka Paalanen
On Wed, 18 Mar 2015 12:19:46 +0100 Thilo Cestonaro wrote: > AFAI can see, it is the weston-launch which does the bad thing. > > If i, being root, start weston directly, it does work fine. > If i, being root, start weston indirect via weston-launch, the process > never returns to console and I c

Re: After exiting weston all consoles not working anymore

2015-03-18 Thread Thilo Cestonaro
AFAI can see, it is the weston-launch which does the bad thing. If i, being root, start weston directly, it does work fine. If i, being root, start weston indirect via weston-launch, the process never returns to console and I can't login from via other shells. This behave is the same with 1.7.

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Pekka Paalanen
On Wed, 18 Mar 2015 11:45:01 +0100 Thilo Cestonaro wrote: > Hey! > > > > Is it broken only on fbdev or DRM also? > > DRM is the same as Fbdev. The touch doesn't have the correct > orientation, but I can use weston-simple-touch to have a windows paint > simulation with just one brush and colo

After exiting weston all consoles not working anymore

2015-03-18 Thread Thilo Cestonaro
Hey! with the master HEAD + Dereks patches for FBDev transformation fix and mine for the right pixman type, I can't use the machine after hitting Ctrl+Alt+Backspace in weston. Doesn't matter what I want to do, open a new ssh session, editing a file with vi, or doing a local login. It all jus

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Thilo Cestonaro
Hey! Is it broken only on fbdev or DRM also? DRM is the same as Fbdev. The touch doesn't have the correct orientation, but I can use weston-simple-touch to have a windows paint simulation with just one brush and color :) Can you try to use weston-simple-touch to see if the touch input i

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Pekka Paalanen
On Wed, 18 Mar 2015 10:56:55 +0100 Thilo Cestonaro wrote: > hey! > > rewind to 1.7.0 and added Dereks patches and mine, to have fbdev > compositor recognize my pixman type, and FBDev (transform) with touch is > working awesome. > > I'm not sure what breaks touchscreen when I forward to master

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Thilo Cestonaro
hey! rewind to 1.7.0 and added Dereks patches and mine, to have fbdev compositor recognize my pixman type, and FBDev (transform) with touch is working awesome. I'm not sure what breaks touchscreen when I forward to master HEAD + Dereks and mine patches. Thilo. Am 18.03.2015 10:29, schrie

Re: [PATCH weston 0/5] fix fbdev transforms

2015-03-18 Thread Thilo Cestonaro
Hey Derek! Wow that was fast! :) and the rotation is working now with fbdev! Thank you! But at least here, the touch isn't working anymore, altough the touch was recognized as input device (Touchscreen) - Date: 2015-03-18 CET [10:25:45.253] weston 1.7.90

Re: [RFC v2 libinput 0/2] Buttonset interface - numbered axes

2015-03-18 Thread Hans de Goede
Hi, On 18-03-15 07:58, Peter Hutterer wrote: This is a re-vamped version of the buttonset interface. Still WIP but I'd like to get some comments on the API. Changes to the last version: This version now uses numbered axes instead of typed axes. Previously the interface used a unique axis type t

Re: [PATCH libinput] tools: don't use deprecated gdk_cursor_new()

2015-03-18 Thread Hans de Goede
Hi, On 18-03-15 00:44, Peter Hutterer wrote: Replaced by gdk_cursor_new_from_display() which means we need to tickle the event until it spits out a GdkDisplay. Deprecated in gdk 3.16 Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede --- If anyone can do a quick

Re: [PATCH weston v2 2/6] compositors: Wrap clock_gettime() usage

2015-03-18 Thread Pekka Paalanen
On Mon, 22 Dec 2014 16:09:15 -0600 Derek Foreman wrote: > In preparation for a future patch which allows test clients to control > the presentation clock, we wrap any clock_gettime() of the presentation > clock in weston_compositor_presentation_clock_gettime(). > > Signed-off-by: Derek Foreman

[PATCH weston] input: Make setting the same pointer cursor surface again a no-op

2015-03-18 Thread Jonas Ådahl
If the client calls wl_pointer.set_cursor with the same surface that is already set, don't do anything as no state was changed. This avoids an issue where a client setting the same cursor surface multiple times would receive wl_surface.leave/enter on that surface every time. Signed-off-by: Jonas