Re: [RFC libinput 1/3] litest: Make touchpad_2fg_scroll_slow_distance take resolution into account

On Thu, Mar 12, 2015 at 08:05:24PM +0100, Hans de Goede wrote: > Currently touchpad_2fg_scroll_slow_distance always moves the touches 10% of > the touchpad height during the test. > > On the wacom-intuos-finger test device this is a much larger distance then on > the synaptics test device, trigger

[weston v2] configure.ac: Add support for new versions of systemd

... that only provide a unique libsystemd.pc file --- configure.ac | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index d9d8d8f..5f2cbc1 100644 --- a/configure.ac +++ b/configure.ac @@ -341,14 +341,21 @@ AC_ARG_ENABLE(resize-optimiz

Re: [weston] configure.ac: Add support for new versions of systemd

> Hi, Hi Pekka, > let's get a bit more context, the whole systemd-login thing in > configure.ac is: > > PKG_CHECK_MODULES(SYSTEMD_LOGIN, [libsystemd-login >= 198], > [have_systemd_login=yes], [have_systemd_login=no]) > AS_IF([test "x$have_systemd_login" = "xyes"], > [AC_DE

[PATCH libinput 5/6] Replace event type check switch statements with a helper macro/function

The helper function now prints an error message if the event type passed is not allowed. Signed-off-by: Peter Hutterer --- src/libinput.c | 142 ++--- test/litest.c | 12 + test/litest.h | 2 + test/misc.c| 10 4 files change

[PATCH libinput 1/6] Calling has_axis on a non-axis pointer event is a bug, note this

Signed-off-by: Peter Hutterer --- src/libinput.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index ca08c3e..9a7829e 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -668,6 +668,12 @@ libinput_event_pointer_get_seat_button_count( * libinput_event_

[PATCH libinput 3/6] Expand documentation on touch events, listing what is permitted when

Signed-off-by: Peter Hutterer --- src/libinput.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index f978b37..356c1bf 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -839,8 +839,11 @@ libinput_event_touch_get_

[PATCH libinput 6/6] Add event type checking to the various libinput_event_ functions

Signed-off-by: Peter Hutterer --- src/libinput.c | 191 +++-- 1 file changed, 185 insertions(+), 6 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 4d88c46..1231783 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -253,18 +253

[PATCH libinput 4/6] test: abort() for invalid logging priorities

Signed-off-by: Peter Hutterer --- test/litest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/litest.c b/test/litest.c index 3646446..ad0aff2 100644 --- a/test/litest.c +++ b/test/litest.c @@ -372,6 +372,8 @@ litest_log_handler(struct libinput *libinput, case LIBINPUT_LOG_PRI

[PATCH libinput 2/6] Correct documentation on get_slot and get_seat_slot()

We don't actually use TOUCH_CANCEL in libinput, but either way calling the slot on a cancel should be valid. Calling it on a FRAME event is not. Signed-off-by: Peter Hutterer --- src/libinput.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/libinput.h

Re: [RFC libinput 1/2] touchpad: Extend the touchpad gesture API with pinch gestures

On Wed, Mar 11, 2015 at 03:20:54PM +0100, Hans de Goede wrote: > Extend the touchpad gesture API with pinch gestures. Note that this > new API offers a single event stream for both pinch and rotate data, this > is deliberate as some applications may be interested in getting both at > the same time.

Re: [PATCH wayland] extend WAYLAND_DISPLAY semantic and make server socket path configurable using environment

On 03/11/2015 07:05 PM, Bryce Harrington wrote: In any case, may as well check for error return from snprintf (i.e. name_size < 0). snprintf returns the number of bytes that would be needed, so truncation is indicated by returning a value greater than the size of the buffer. (yes a whole lo

[RFC libinput 2/3] litest: Add a litest_touch_move_two_touches helper function

Currently all the touchpad 2fg tests move the 2 fingers 1 at a time, causing a finger motion which looks more like a pinch zoom in followed by a zoom outthen an actual 2fg scroll gesture. Add a helper function which can move 2 fingers at the same time (more or less), and use this were relevant. Si

[RFC libinput 1/3] litest: Make touchpad_2fg_scroll_slow_distance take resolution into account

Currently touchpad_2fg_scroll_slow_distance always moves the touches 10% of the touchpad height during the test. On the wacom-intuos-finger test device this is a much larger distance then on the synaptics test device, triggering ck_assert(axisval < 5.0) errors with further patches in this set, thi

[RFC libinput 3/3] litest: Put fingers down closer together for 2fg scroll tests

The current default start location for the 2fg scroll tests: 47%, 50% and 53%, 50% are further then 3cm apart on the wacom-intuos-finger test device, causing test failures when pinch gesture support gets added. This fixes this, and also switches the fingers in the touchpad_2fg_scroll_slow_distance

Re: [wayland HiDPI support, posible regression?]

Hi-DPI displays and resolution independence are two completely different problems. You don't get resolution independence by scaling, it needs separate design and a responsive layout. The scale is simply for displays where the pixel density is double or triple other displays. On Thu, Mar 12, 2015 a

Re: [wayland HiDPI support, posible regression?]

on Monday 09 March 2015 08:59:35，Jasper St. Pierre wrote： > You misunderstood what pq said. > > You work in "logical pixels". On a hi-DPI display, with twice the pixel > density, each "logical pixel" is backed by 4 device pixels. Your actual > backing surface containing the pixels is in "device pi

wayland - weston - and framebuffer

Hey! I'm totaly new to wayland and weston, so please forgive me if I ask silly questions! I want to run the wayland compositor "weston" on a TI AM335x with no graphic acceleration. So framebuffer only, no opengl or something like that. I succeeded in compiling libwayland and weston with FBD

Re: [PATCH 2/3] Modify wayland-scanner to generate inert objects

I wonder if the same effect could be achieved by few smaller changes. What I'm thinking about is something like: wl_resource_set_intact() So far I've got three ways how to achieve that: 1) change scanner so that it saves opcode of destructor events in wl_interface, so when we invoke a closure, we

Re: [PATCH wayland] extend WAYLAND_DISPLAY semantic and make server socket path configurable using environment

On Wed, Mar 11, 2015 at 10:05 PM, Bryce Harrington wrote: > On Tue, Feb 24, 2015 at 03:08:36PM +0100, Davide Bettio wrote: > > commit e8b37de8e084d4e50a12bd2911657d54c0ebd9ed > > Author: Davide Bettio > > Date: Tue Feb 24 12:40:49 2015 +0100 > > > > * Extend WAYLAND_DISPLAY and name parame

Re: [PATCH weston v2 15/16] pixman-renderer: implement source clipping

On 03/11/2015 03:13 AM, Pekka Paalanen wrote: On Tue, 10 Mar 2015 12:39:58 -0700 Bill Spitzak wrote: Using the new pixman_image_t may be equivalent (I should check) but if there is some speed problem it should be possible to get an arbitrary subrectangle by making a new pixman_image_t direct

Re: [RFC] Implementing Wayland Security Module

How would a game change the mode in the first place? There is no request to do so. Anyway, I'm still going to push for a complete solution that isn't tied to Wayland and also works for DBus, but I can't convince you this is a bad idea. So, best of luck to you, and I'll shut up now :) On Mar 11, 20

[PATCH libinput 11/12] Add another data type for discrete coordinates

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 8 +--- src/evdev.c | 27 --- src/libinput-private.h | 8 ++-- src/libinput.c | 12 +--- 4 files changed, 32 insertions(+), 2

[PATCH libinput 10/12] Split deltas/absolute coords in pointer events to separate fields

Signed-off-by: Peter Hutterer --- src/libinput.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 3b1d482..1a68069 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -57,8 +57,8 @@ struct libinput_event_keyb

[PATCH libinput 04/12] touchpad: change motion history to typesafe coords

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 2 +- src/evdev-mt-touchpad.h | 7 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 8808850..ebe611f 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-to

[PATCH libinput 12/12] Store unaccelerated delta as normalized_coords

Signed-off-by: Peter Hutterer --- src/libinput.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 8db6997..96df44a 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -58,10 +58,9 @@ struct libinput_event_pointer { struct

[PATCH libinput 09/12] Use typesafe coordinates in touch events

Signed-off-by: Peter Hutterer --- src/evdev.c| 13 + src/libinput-private.h | 6 ++ src/libinput.c | 23 +-- 3 files changed, 16 insertions(+), 26 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d1b0504..cab7e85 100644 --- a/src/

[PATCH libinput 06/12] touchpad: switch delta handling to typesafe coordinates

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 26 src/evdev-mt-touchpad-gestures.c| 60 +++-- src/evdev-mt-touchpad-tap.c | 6 ++-- src/evdev-mt-touchpad.c | 34 +++-- src/evdev-mt-

[PATCH libinput 00/12] typesafe coordinate wrappers

libinput has two types of coordinates - device coordinates and coordinates normalized into the 1000 dpi default. we generally use int/double for those two, but it's not always clear or obvious which type of coordinates we're dealing with. So there's a risk of mixing them up and we may not notice f

[PATCH libinput 01/12] cosmetic: rename touch to t for consistency

Everywhere else in the touchpad code we use "t" for the struct tp_touch. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt-touchpad-edge-scroll.c inde

[PATCH libinput 03/12] evdev: start introducing some type-safety for device/normalized coordinates

Make it clear where we're dealing with device coordinates and where we're dealing with DPI-normalized coordinates. Signed-off-by: Peter Hutterer --- src/evdev.c| 88 +- src/evdev.h| 8 ++--- src/libinput-private.h | 10

[PATCH libinput 07/12] Use typesafe coordinates for scrolling events

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 8 ++-- src/evdev-mt-touchpad-gestures.c| 2 +- src/evdev.c | 81 + src/evdev.h | 6 +-- src/libinput-private.h | 3 +-

[PATCH libinput 02/12] evdev: add helper function to normalize delta coordinates

No functional changes. Signed-off-by: Peter Hutterer --- src/evdev.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 70c60ee..645a36b 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -224,6 +224,13 @@ evdev_device_transform_y(struc

[PATCH libinput 08/12] Use typesafe coords in motion events

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-gestures.c | 10 -- src/evdev.c | 6 ++ src/libinput-private.h | 9 +++-- src/libinput.c | 21 + 4 files changed, 18 insertions(+), 28 deletions(-) diff

[PATCH libinput 05/12] touchpad: switch touch point, hysteresis, initial coords to typesafe coords

Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 14 - src/evdev-mt-touchpad-edge-scroll.c | 11 +++ src/evdev-mt-touchpad-tap.c | 7 ++--- src/evdev-mt-touchpad.c | 62 + src/evdev-mt-touchpad.h

Re: [RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

On Wed, Mar 11, 2015 at 03:20:55PM +0100, Hans de Goede wrote: > Implement touchpad pinch (and rotate) gesture support. > > WIP: TODO: fix testsuite. > > Signed-off-by: Hans de Goede looks good, almost all comments are just related to coding style/shuffling things around. fwiw, it'd be good ad

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

On Wed, 2015-03-11 at 16:05 +0200, Pekka Paalanen wrote: > On Tue, 10 Mar 2015 11:34:45 +0900 > Ryo Munakata wrote: > > > This was a TODO: > > "Ideally, available frame buffers should be enumerated > > using udev, rather than passing a device node in as a > > parameter." > > Hi, > > I'm CC'ing

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

2015/03/12 0:40 "Ryo Munakata" : > > On Wed, 11 Mar 2015 16:05:55 +0200 > Pekka Paalanen wrote: > > > On Tue, 10 Mar 2015 11:34:45 +0900 > > Ryo Munakata wrote: > > > + > > > struct fbdev_compositor { > > > struct weston_compositor base; > > > uint32_t prev_state; > > > @@ -690,6 +692,9

[RFC libinput 2/2] touchpad: Implement pinch gesture support (wip)

Implement touchpad pinch (and rotate) gesture support. WIP: TODO: fix testsuite. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 242 --- src/evdev-mt-touchpad.h | 18 +++ test/touchpad.c | 10 +- 3 files change

Re: [PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

On Tue, 10 Mar 2015 11:34:45 +0900 Ryo Munakata wrote: > This was a TODO: > "Ideally, available frame buffers should be enumerated > using udev, rather than passing a device node in as a > parameter." Hi, I'm CC'ing the person responsible for the TODO-comment. > > Signed-off-by: Ryo Munakata

Re: [PATCH weston] xwayland: wm: fix an invalid read

On Wed, 11 Mar 2015 10:49:18 +0200 Giulio Camuffo wrote: > Oops, that looks broken indeed. > > Reviewwed-by: Giulio Camuffo > > 2015-03-11 10:36 GMT+02:00 Ryo Munakata : > > This `for` statement needs corresponding braces. > > > > Signed-off-by: Ryo Munakata > > --- > > xwayland/window-manag