Re: [PATCH] implement weston local texture using weston_buffer without wl_resourse

2015-03-09 Thread Jasper St. Pierre
The X11 xwm also draws decorations for client windows inside the compositor. On Mon, Mar 9, 2015 at 11:34 PM, Pekka Paalanen wrote: > On Mon, 09 Mar 2015 10:56:23 -0700 > Bill Spitzak wrote: > > > On 03/09/2015 01:20 AM, Pekka Paalanen wrote: > > > > > However, we already also have an exception

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Pekka Paalanen
On Mon, 09 Mar 2015 11:13:20 -0700 Bill Spitzak wrote: > On 03/09/2015 06:34 AM, Pekka Paalanen wrote: > > > What performance concerns do you have? > > I suspect the worry was about allocating and freeing a temporary array, > but your idea of the caller passing the array avoids it. > > I feel

Re: [PATCH] implement weston local texture using weston_buffer without wl_resourse

2015-03-09 Thread Pekka Paalanen
On Mon, 09 Mar 2015 10:56:23 -0700 Bill Spitzak wrote: > On 03/09/2015 01:20 AM, Pekka Paalanen wrote: > > > However, we already also have an exception to this in upstream: the > > Wayland backend needs to draw the output window decorations. > > Sorry can you explain that in more detail? An ap

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread Jasper St. Pierre
Mouse input is reported in a 24.8 fixed-point format. Subpixel mouse locations are entirely possible. On Mon, Mar 9, 2015 at 10:33 PM, microcai wrote: > 在 2015年3月9日 Monday 08:59:35,您写道: > > You misunderstood what pq said. > > > > You work in "logical pixels". On a hi-DPI display, with twice the

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread microcai
在 2015年3月9日 Monday 08:59:35,您写道: > You misunderstood what pq said. > > You work in "logical pixels". On a hi-DPI display, with twice the pixel > density, each "logical pixel" is backed by 4 device pixels. Your actual > backing surface containing the pixels is in "device pixels". > > So, if you ha

[PATCH libinput 1/2] tablet: rely on libwacom for the list of axis capabilities

2015-03-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac | 2 +- src/evdev-tablet.c | 56 +- 2 files changed, 27 insertions(+), 31 deletions(-) diff --git a/configure.ac b/configure.ac index 85db1fd..038022e 100644 --- a/configure.ac +++ b/configu

[PATCH libinput 2/2] tablet: use libwacom_new_from_path() to handle more tablets

2015-03-09 Thread Peter Hutterer
Some tablets cannot be differentiated by pid/vid alone, use the device path instead - that gives libwacom the ability to extract the information required to handle the device (libwacom doesn't open the path, it just reads through the sysfs entry of the device). Signed-off-by: Peter Hutterer ---

[PATCH weston] compositor-fbdev: enumerate available fbdevs using udev

2015-03-09 Thread Ryo Munakata
This was a TODO: "Ideally, available frame buffers should be enumerated using udev, rather than passing a device node in as a parameter." Signed-off-by: Ryo Munakata --- src/compositor-fbdev.c | 55 +++--- 1 file changed, 52 insertions(+), 3 deletions(

Re: [PATCH weston 6/8] pixman-renderer: move code to draw_view_translated()

2015-03-09 Thread Derek Foreman
On 09/03/15 05:52 AM, Pekka Paalanen wrote: > On Fri, 06 Mar 2015 13:46:26 -0600 > Derek Foreman wrote: > >> On 06/03/15 05:04 AM, Pekka Paalanen wrote: >>> From: Pekka Paalanen >>> >>> Move code from draw_view() into a new function draw_view_translated(). >>> This new function is correct only i

Re: [PATCH libinput] touchpad: Remove unnecessary edge scroll threshold variable

2015-03-09 Thread Peter Hutterer
On Mon, Mar 09, 2015 at 02:22:56PM +0100, Hans de Goede wrote: > Now that we've separate handling of the EDGE_NEW vs EDGE states in > tp_edge_scroll_post_events() we can drop the threshold variable, in EDGE_NEW > we always want to check against DEFAULT_SCROLL_THRESHOLD and in the EDGE > state we on

Re: [RFC] Implementing Wayland Security Module

2015-03-09 Thread Jasper St. Pierre
On Mon, Mar 9, 2015 at 12:52 PM, Manuel Bachmann < manuel.bachm...@open.eurogiciel.org> wrote: > Hi Matthias, > > "I don't think it makes sense to develop a specific solution just for > the portion of application sandboxing that happens to overlap with > wayland protocol requests. The same questio

Re: [RFC] Implementing Wayland Security Module

2015-03-09 Thread Bill Spitzak
Fullscreen is not any more of a problem than resizing, except for the fact that a bunch of people think "fullscreen" == "always on top". Due to child windows this is not going to be true, compositors have to support floating windows atop the fullscreen one. People are being confused by the pan

Re: [RFC] Implementing Wayland Security Module

2015-03-09 Thread Manuel Bachmann
Hi Matthias, "I don't think it makes sense to develop a specific solution just for the portion of application sandboxing that happens to overlap with wayland protocol requests. The same questions need to be answered when a third-party application e.g. wants to open a file or send an email." While

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread Bill Spitzak
I think he did not explain the problem exactly. Pixels in the buffers themselves can be hi-dpi. The problem is that the wayland api still has several integers that are in "low-DPI" pixels. The buffer size, the xy offsets when the buffer is set, the position in the subsurface api, the destinati

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Bill Spitzak
On 03/09/2015 06:34 AM, Pekka Paalanen wrote: What performance concerns do you have? I suspect the worry was about allocating and freeing a temporary array, but your idea of the caller passing the array avoids it. I feel like it would be better to reduce the number of arguments to only a s

Re: [PATCH] implement weston local texture using weston_buffer without wl_resourse

2015-03-09 Thread Bill Spitzak
On 03/09/2015 01:20 AM, Pekka Paalanen wrote: However, we already also have an exception to this in upstream: the Wayland backend needs to draw the output window decorations. Sorry can you explain that in more detail? ___ wayland-devel mailing list w

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread Jasper St. Pierre
You misunderstood what pq said. You work in "logical pixels". On a hi-DPI display, with twice the pixel density, each "logical pixel" is backed by 4 device pixels. Your actual backing surface containing the pixels is in "device pixels". So, if you have an window that is 800x600 logical pixels, wh

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Daniel Stone
Hi, On 9 March 2015 at 07:49, Pekka Paalanen wrote: > On Mon, 23 Feb 2015 17:20:37 -0800 > Bryce Harrington wrote: >> However, I suspect this API would be better named as >> wl_global_find_first(). >> >> A more general wl_global_find() I would expect to be returning a list of >> results. >> >> O

Re: [RFC] Implementing Wayland Security Module

2015-03-09 Thread Jari Vetoniemi
2015-03-09 15:30 GMT+02:00 Matthias Clasen : > I don't think it makes sense to develop a specific solution just for > the portion of application sandboxing that happens to overlap with > wayland protocol requests. The same questions need to be answered when > a third-party application e.g. wants t

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Pekka Paalanen
On Mon, 9 Mar 2015 01:51:27 -0700 Bryce Harrington wrote: > On Mon, Mar 09, 2015 at 09:49:19AM +0200, Pekka Paalanen wrote: > > On Mon, 23 Feb 2015 17:20:37 -0800 > > Bryce Harrington wrote: > > > > > On Mon, Feb 23, 2015 at 11:30:57AM -0800, Bill Spitzak wrote: > > > > Which of the 4 arguments

Re: [RFC] Implementing Wayland Security Module

2015-03-09 Thread Matthias Clasen
On Mon, Mar 9, 2015 at 1:38 AM, Manuel Bachmann wrote: > Any comments on this ? > I don't think it makes sense to develop a specific solution just for the portion of application sandboxing that happens to overlap with wayland protocol requests. The same questions need to be answered when a third

[PATCH libinput] touchpad: Remove unnecessary edge scroll threshold variable

2015-03-09 Thread Hans de Goede
Now that we've separate handling of the EDGE_NEW vs EDGE states in tp_edge_scroll_post_events() we can drop the threshold variable, in EDGE_NEW we always want to check against DEFAULT_SCROLL_THRESHOLD and in the EDGE state we only want to make sure that the delta != 0.0 which is already checked lat

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread microcai
在 2015年3月9日 Monday 10:39:20,您写道: > Hi, > > On Monday, March 9, 2015, microcai wrote: > > so we are forcing two code pathes in APP? or just support non-integer > > scale? > > Scaling is a specific fallback for legacy/non-DPI-aware clients, to get > them to show anything at all. Other clients will

Re: [PATCH v2 libinput 5/3] touchpad: accumulate the initial scroll edge delta

2015-03-09 Thread Hans de Goede
Hi, On 09-03-15 01:54, Peter Hutterer wrote: The previous setting of 10 wasn't 10 mm, it was used against the deltas normalized to a 1000DPI mouse, i.e. closer to 4mm. It was also also per-event, so a slow movement or a high-frequency touchpad can struggle to meet the threshold. Change the trig

Re: [PATCH weston v2 02/20] gl-renderer: Call glViewport after the context is made current

2015-03-09 Thread Pekka Paalanen
On Thu, 16 Oct 2014 10:55:20 -0500 Derek Foreman wrote: > From: Jason Ekstrand > > --- > src/gl-renderer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gl-renderer.c b/src/gl-renderer.c > index 076c242..d54928b 100644 > --- a/src/gl-renderer.c > +++ b/src

Re: [PATCH weston 0/8] Fix pixman-renderer cropping

2015-03-09 Thread Pekka Paalanen
On Fri, 06 Mar 2015 14:08:50 -0600 Derek Foreman wrote: > On 06/03/15 05:03 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Hi, > > > > this is a series of relatively small changes to the Pixman-renderer, with > > the > > major goals of a) clean up the draw_view/repaint_region mach

Re: [PATCH weston 7/8] pixman-renderer: implement source clipping

2015-03-09 Thread Pekka Paalanen
On Fri, 06 Mar 2015 13:53:46 -0600 Derek Foreman wrote: > On 06/03/15 05:04 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Implement a way to do composition clipping with a region32 given in > > source image space. > > > > Pixman does not directly support this kind of operation at

Re: [PATCH weston 6/8] pixman-renderer: move code to draw_view_translated()

2015-03-09 Thread Pekka Paalanen
On Fri, 06 Mar 2015 13:46:26 -0600 Derek Foreman wrote: > On 06/03/15 05:04 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Move code from draw_view() into a new function draw_view_translated(). > > This new function is correct only if > > view_transformation_is_translation(). > > >

Re: [PATCH weston 5/8] pixman-renderer: change repaint_region() arguments

2015-03-09 Thread Pekka Paalanen
On Fri, 06 Mar 2015 13:42:20 -0600 Derek Foreman wrote: > On 06/03/15 05:04 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Change the region argument types in repaint_region(), moving the > > final_region computation to the caller. The caller is in a better > > position deciding if

Re: [wayland HiDPI support, posible regression?]

2015-03-09 Thread Daniel Stone
Hi, On Monday, March 9, 2015, microcai wrote: > > so we are forcing two code pathes in APP? or just support non-integer > scale? > Scaling is a specific fallback for legacy/non-DPI-aware clients, to get them to show anything at all. Other clients will render at the appropriate resolution already

[wayland HiDPI support, posible regression?]

2015-03-09 Thread microcai
As some one in the IRC channel told me, we should totally ignore DPIs when design UI. so, in wayland word, we design UIs in pixels -- no, in device independent pixels -- and scales at pixel level. so instead of using 9pit font, we using 8x16 font. CAN you imagnaging how stupid this would be i

Re: [PATCH weston 2/8] pixman-renderer: put transformation computation into function

2015-03-09 Thread Pekka Paalanen
On Fri, 06 Mar 2015 13:31:28 -0600 Derek Foreman wrote: > On 06/03/15 05:03 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Move the long piece of code computing the end-to-end transformation from > > repaint_region() into a new function > > pixman_renderer_compute_transform(). > >

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Bryce Harrington
On Mon, Mar 09, 2015 at 09:49:19AM +0200, Pekka Paalanen wrote: > On Mon, 23 Feb 2015 17:20:37 -0800 > Bryce Harrington wrote: > > > On Mon, Feb 23, 2015 at 11:30:57AM -0800, Bill Spitzak wrote: > > > Which of the 4 arguments do you use for your use case? > > > > > > Because this can only return

Re: [PATCH] implement weston local texture using weston_buffer without wl_resourse

2015-03-09 Thread Pekka Paalanen
On Sun, 8 Mar 2015 10:33:25 +0100 Benoit Gschwind wrote: > This patch allow desktop-shell and other components of weston to create > local texture as surface and show them. This patch support only the > gl-renderer. > --- > Makefile.am| 2 ++ > src/compositor-drm.c | 3 +

Re: [PATCH wayland] server: add helper functions for wl_global

2015-03-09 Thread Pekka Paalanen
On Mon, 23 Feb 2015 17:20:37 -0800 Bryce Harrington wrote: > On Mon, Feb 23, 2015 at 11:30:57AM -0800, Bill Spitzak wrote: > > Which of the 4 arguments do you use for your use case? > > > > Because this can only return the first match I suspect some of the > > NULL tests are pretty useless, beca

Re: [PATCH weston v2] Fix trivial memory leaks

2015-03-09 Thread Pekka Paalanen
On Sun, 8 Mar 2015 19:17:06 +0900 Ryo Munakata wrote: > Signed-off-by: Ryo Munakata > --- > desktop-shell/shell.c | 2 ++ > src/compositor-x11.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index aae304d..826692f 100644 > --- a/d

Re: [PATCH 2/2] Fix trivial memory leaks

2015-03-09 Thread Pekka Paalanen
On Sun, 8 Mar 2015 19:18:33 +0900 Ryo Munakata wrote: > On Tue, 3 Mar 2015 12:04:23 +0200 > Pekka Paalanen wrote: > > > > > > > static void > > > diff --git a/xwayland/launcher.c b/xwayland/launcher.c > > > index df2efd2..63a1dea 100644 > > > --- a/xwayland/launcher.c > > > +++ b/xwayland/la